Uh oh!
There was an error while loading. Please reload this page.
GH-51140: [C++] Require simdjson 4.3.0 for fractured_json APIs - #51142
Conversation
tadeja
commented
Sep 2, 2026
@github-actions crossbow submit test-build-vcpkg-win test-ubuntu-22.04-cpp-bundled |
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped, matches the documented minimum simdjson API requirement, and reduces the risk of configuration-time acceptance of incompatible system versions.
Pull request overview
Updates the C++ third-party dependency configuration to require simdjson >= 4.3.0, matching the minimum version needed for the fractured_json APIs used in Arrow and preventing misconfigured builds with older system simdjson installs.
Changes:
- Bump
ARROW_SIMDJSON_REQUIRED_VERSIONfrom 4.0.0 to 4.3.0 in the CMake toolchain dependency resolution.
File summaries
| File | Description |
|---|---|
| cpp/cmake_modules/ThirdpartyToolchain.cmake | Raises the minimum accepted simdjson version to avoid build failures when system simdjson is < 4.3.0. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Revision: f3018b3 Submitted crossbow builds: ursacomputing/crossbow @ actions-0a31401513
|
Uh oh!
There was an error while loading. Please reload this page.
rok
commented
Sep 3, 2026
Regarding simdjson version - we had a version discussion here already - #50568 (comment). TLDR: ubuntu lags, only 26.0.10 has 4.6.8, while 26.0.4 has 4.2.4. |
Rationale for this change
Fix#51140, CMake configuration should not accept simdjson earlier than v4.3.0.
What changes are included in this PR?
Set ARROW_SIMDJSON_REQUIRED_VERSION to "4.3.0"
Are these changes tested?
Yes. Locally, CMake configuration rejects system simdjson 4.2.3 now
CMake Error at cmake_modules/ThirdpartyToolchain.cmake:316 (message):Couldn't find simdjson >= 4.3.0Are there any user-facing changes?
No.