Skip to content

GH-28497: [C++][Compute] Add quotient and modulo kernels - #11116

Draft
edponce wants to merge 4 commits into
apache:mainfrom
edponce:ARROW-12755-Compute-Add-quotient-and-modulo-kernels
Draft

GH-28497: [C++][Compute] Add quotient and modulo kernels#11116
edponce wants to merge 4 commits into
apache:mainfrom
edponce:ARROW-12755-Compute-Add-quotient-and-modulo-kernels

Conversation

@edponce

@edponceedponce commented Sep 9, 2021

Copy link
Copy Markdown
Contributor

This PR adds compute functions "floor_divide" and "remainder".

@github-actions

Copy link
Copy Markdown

@pitrou

Copy link
Copy Markdown
Member

@edponce Are you willing to pursue this?

@edponce

edponce commented Nov 10, 2021

Copy link
Copy Markdown
ContributorAuthor

@pitrou I will complete this PR in the next couple of days. Basically, plan on finishing divmod PR first and then make these individual kernels call divmod.

I got a stuck when needed to output a struct for div and mod pairs, but I think I can solve it now.

@ianmcook

Copy link
Copy Markdown
Member

@edponce could you please make it a priority to complete this PR, or see if someone else can take it over? Thanks.

@edponce
edponceforce-pushed the ARROW-12755-Compute-Add-quotient-and-modulo-kernels branch from 853bfca to fab398bCompareSeptember 5, 2022 20:14
@jgehrcke

jgehrcke commented Dec 15, 2022

Copy link
Copy Markdown
Contributor

Modulo (to me) seems like a rather important operator to be implemented. I'd love to help, if I can!

@edponce
edponceforce-pushed the ARROW-12755-Compute-Add-quotient-and-modulo-kernels branch from e5b9b0b to 44d4445CompareDecember 15, 2022 13:55
@jgehrcke

Copy link
Copy Markdown
Contributor

Update: priorities shifted. I'd love to get back to this, but reality is that I won't be able to in the coming 1 month, at least.

@koukou changed the title ARROW-12755: [C++][Compute] Add quotient and modulo kernelsGH-28497: [C++][Compute] Add quotient and modulo kernelsMay 10, 2023
@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #28497has been automatically assigned in GitHub to PR creator.

@mike-jn

Copy link
Copy Markdown

would be great to have this implemented. what is the reason the PR stalled?

@github-actions

Copy link
Copy Markdown

Thank you for your contribution. Unfortunately, this pull request has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this PR will be closed in 14 days. Feel free to re-open this if it has been closed in error. If you do not have repository permissions to reopen the PR, please tag a maintainer.

@github-actionsgithub-actionsBot added the Status: stale-warning Issues and PRs flagged as stale which are due to be closed if no indication otherwise label Dec 3, 2025
@rokrok reopened this Aug 6, 2026
@github-actionsgithub-actionsBot removed the Status: stale-warning Issues and PRs flagged as stale which are due to be closed if no indication otherwise label Aug 7, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C++][Compute] Add quotient and modulo kernels

6 participants

@edponce@pitrou@ianmcook@jgehrcke@mike-jn@rok