Skip to content

ARROW-12084: [C++][Compute] Add remainder and quotient compute::Function - #11115

Closed
edponce wants to merge 10 commits into
apache:mainfrom
edponce:ARROW-12084-Compute-Add-remainder-and-quotient-compu
Closed

ARROW-12084: [C++][Compute] Add remainder and quotient compute::Function#11115
edponce wants to merge 10 commits into
apache:mainfrom
edponce:ARROW-12084-Compute-Add-remainder-and-quotient-compu

Conversation

@edponce

@edponceedponce commented Sep 9, 2021

Copy link
Copy Markdown
Contributor

This PR adds compute functions "divmod" and "divmod_checked" to calculate the quotient and remainder as a single operation.

@github-actions

github-actionsBot commented Sep 9, 2021

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-12084

@edponce
edponceforce-pushed the ARROW-12084-Compute-Add-remainder-and-quotient-compu branch 2 times, most recently from 2117a9f to e42547cCompareSeptember 21, 2021 21:39
@edponce

edponce commented Sep 21, 2021

Copy link
Copy Markdown
ContributorAuthor

@lidavidm Please review :)

FYI, PR is still missing tests.

lidavidm
lidavidm reviewed Sep 22, 2021
View reviewed changes
Comment threadcpp/src/arrow/compute/kernels/codegen_internal.h Outdated
@edponceedponce mentioned this pull request Nov 10, 2021
Draft
@kszucs

kszucs commented Apr 21, 2022

Copy link
Copy Markdown
Member

@edponce shall we close this as stale?

@edponce

edponce commented Apr 21, 2022

Copy link
Copy Markdown
ContributorAuthor

@kszucs Do not mark this PR as stale. I had stopped working on it bc I had trouble figuring out how to output a StructArray from compute kernel, but I have a pretty good understanding now. I will take some time on Monday to finish this.

@ianmcook

ianmcook commented Jun 2, 2022

Copy link
Copy Markdown
Member

@edponce could you please make it a priority to complete this PR, or see if someone else can take it over? Thanks.

@edponce
edponceforce-pushed the ARROW-12084-Compute-Add-remainder-and-quotient-compu branch from b38aae3 to 843f68eCompareJuly 18, 2022 18:50
lidavidm
lidavidm reviewed Jul 19, 2022
View reviewed changes
Comment threadcpp/src/arrow/compute/kernels/scalar_arithmetic.cc Outdated
@edponce
edponceforce-pushed the ARROW-12084-Compute-Add-remainder-and-quotient-compu branch from 17bf054 to d38f80dCompareSeptember 5, 2022 21:03
@asfimportasfimport mentioned this pull request Oct 17, 2022
Closed
@github-actions

github-actionsBot commented Nov 18, 2025

Copy link
Copy Markdown

Thank you for your contribution. Unfortunately, this pull request has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this PR will be closed in 14 days. Feel free to re-open this if it has been closed in error. If you do not have repository permissions to reopen the PR, please tag a maintainer.

@github-actionsgithub-actionsBot added the Status: stale-warning Issues and PRs flagged as stale which are due to be closed if no indication otherwise label Nov 18, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidmlidavidmlidavidm left review comments
@pitroupitroupitrou left review comments

Assignees

No one assigned

Labels

Component: C++Status: stale-warningIssues and PRs flagged as stale which are due to be closed if no indication otherwise

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@edponce@kszucs@ianmcook@lidavidm@pitrou