ARROW-14897: [CI][C++] Upgrade Clang Tools to 12 from 8 - #11786

Closed
kou wants to merge 6 commits into
apache:masterfrom
kou:cpp-clang-tools-12
Closed

ARROW-14897: [CI][C++] Upgrade Clang Tools to 12 from 8#11786
kou wants to merge 6 commits into
apache:masterfrom
kou:cpp-clang-tools-12

Conversation

@kou

@koukou commented Nov 28, 2021

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actionsBot commented Nov 28, 2021

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14897

@github-actions

github-actionsBot commented Nov 28, 2021

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@kou
kouforce-pushed the cpp-clang-tools-12 branch from ef93600 to e881881CompareNovember 28, 2021 21:21
@kou

kou commented Nov 28, 2021

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g nightly

@github-actions

github-actionsBot commented Nov 28, 2021

Copy link
Copy Markdown

Revision: e881881a488339daf3d461ee06eb35845ebfcee5

Submitted crossbow builds: ursacomputing/crossbow @ actions-1210

TaskStatus
almalinux-8-amd64Github Actions
almalinux-8-arm64TravisCI
amazon-linux-2-amd64Github Actions
centos-7-amd64Github Actions
centos-8-amd64Github Actions
centos-8-arm64TravisCI
conda-cleanAzure
conda-linux-gcc-py36-cpu-r40Azure
conda-linux-gcc-py36-cudaAzure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py36-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2017-py36-r40Azure
debian-bookworm-amd64Github Actions
debian-bookworm-arm64TravisCI
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
debian-buster-amd64Github Actions
debian-buster-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
test-build-cpp-fuzzGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.10Github Actions
test-conda-python-3.6Github Actions
test-conda-python-3.6-pandas-0.23Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-v3.1.2Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-v3.2.0Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-dask-latestGithub Actions
test-conda-python-3.9-dask-masterGithub Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-conda-python-3.9-spark-masterGithub Actions
test-debian-10-cppGithub Actions
test-debian-11-cppGithub Actions
test-debian-11-go-1.15Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-33-cppGithub Actions
test-fedora-33-python-3Azure
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-autoAzure
test-r-depsource-systemGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.1-centos8Azure
test-r-rstudio-r-base-4.1-focalAzure
test-r-rstudio-r-base-4.1-opensuse15Azure
test-r-rstudio-r-base-4.1-opensuse42Azure
test-r-ubuntu-21.04Github Actions
test-r-versionsGithub Actions
test-skyhook-integrationGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-python-3Azure
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-14Github Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-bundledGithub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.10-docsAzure
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-hirsute-amd64Github Actions
ubuntu-hirsute-arm64TravisCI
ubuntu-impish-amd64Github Actions
ubuntu-impish-arm64TravisCI
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-high-sierra-cp310-amd64Github Actions
wheel-macos-high-sierra-cp36-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-macos-mavericks-cp310-amd64Github Actions
wheel-macos-mavericks-cp36-amd64Github Actions
wheel-macos-mavericks-cp37-amd64Github Actions
wheel-macos-mavericks-cp38-amd64Github Actions
wheel-macos-mavericks-cp39-amd64Github Actions
wheel-manylinux2010-cp310-amd64Github Actions
wheel-manylinux2010-cp36-amd64Github Actions
wheel-manylinux2010-cp37-amd64Github Actions
wheel-manylinux2010-cp38-amd64Github Actions
wheel-manylinux2010-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp36-amd64Github Actions
wheel-manylinux2014-cp36-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp36-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions

@kou

kou commented Nov 29, 2021

Copy link
Copy Markdown
MemberAuthor

@pitrou@lidavidm@cyb70289@bkietz@westonpace You may be interested in this.

cyb70289
cyb70289 approved these changes Nov 29, 2021
View reviewed changes

@cyb70289cyb70289 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mbrobbel

mbrobbel commented Nov 29, 2021

Copy link
Copy Markdown
Member

There are some mentions in dev docs about the clang version:

lidavidm
lidavidm approved these changes Nov 29, 2021
View reviewed changes

@lidavidmlidavidm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be worth giving a heads-up on dev@, even though the diffs here are small/it seems we shouldn't have many conflicts.

westonpace
westonpace approved these changes Nov 30, 2021
View reviewed changes

@westonpacewestonpace left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be rather helpful for me. I had to disable clang on clion because it kept reordering the headers and I think IncludeBlocks: Preserve is probably what I was missing so thanks for that 👍

It looks like the TravisCI failures are related. Googling suggests that maybe the TravisCI build host has out-of-date SSL root certificates and you might need to update libgnutls-openssl27 libgnutls30 in addition to ca-certificates but that is kind of a shot in the dark based on this

@kou

kou commented Nov 30, 2021•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@mbrobbel Good catch! I've updated documentations and they don't include the pinned version now.

@lidavidm It makes sense. I've sent an e-mail: https://lists.apache.org/thread/bd3rkllwgsrnqmmsn9zn5wo3cmjdn2b4

@westonpace Thanks for the hint. I've fixed it. You may be interested in R related changes after the first push:

@thisisnicthisisnic mentioned this pull request Nov 30, 2021
Closed
@jonkeane

jonkeane commented Dec 1, 2021

Copy link
Copy Markdown
Member

This is fantastic, thank you!

There are a few places in dev/tasks/tasks.yml that had bespoke versions of CLANG_TOOLS to get them working that I don't think are needed anymore. I'm happy to push a commit to this branch (I would suggest changes, but GH doesn't let me do that on a file that's not near the diffs)

arrow/dev/tasks/tasks.yml

Line 1205 in 736a69e

CLANG_TOOLS: 9# can remove this when >=9 is the default

arrow/dev/tasks/tasks.yml

Line 1193 in 736a69e

CLANG_TOOLS: 9# can remove this when >=9 is the default

@kou
kouforce-pushed the cpp-clang-tools-12 branch from 26b67c7 to 8ab6937CompareDecember 1, 2021 21:02
@kou

kou commented Dec 1, 2021

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-ubuntu-21.04 test-r-gcc-11

@kou

kou commented Dec 1, 2021

Copy link
Copy Markdown
MemberAuthor

@jonkeane Good catch! I've removed them.

@github-actions

github-actionsBot commented Dec 1, 2021

Copy link
Copy Markdown

Revision: 8ab693734997f4085b50a56318d2ac07dfb8f554

Submitted crossbow builds: ursacomputing/crossbow @ actions-1227

TaskStatus
test-r-gcc-11Github Actions
test-r-ubuntu-21.04Github Actions

@kou
kouforce-pushed the cpp-clang-tools-12 branch from 8ab6937 to 84aa717CompareDecember 1, 2021 23:45
@kou
kouforce-pushed the cpp-clang-tools-12 branch from 84aa717 to 4665516CompareDecember 2, 2021 01:23
@kou
kouforce-pushed the cpp-clang-tools-12 branch from 4665516 to 3ee8213CompareDecember 2, 2021 02:44
@kou

kou commented Dec 2, 2021

Copy link
Copy Markdown
MemberAuthor

CI failures are unrelated. This is caused by https://packagemanager.rstudio.com/ . It returns 500.

I'll merge this.

@koukou closed this in f36451fDec 2, 2021
@kou
kou deleted the cpp-clang-tools-12 branch December 2, 2021 05:08
@ursabot

ursabot commented Dec 2, 2021•
edited
Loading

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 9ec01da and contender = f36451f. f36451f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.45% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.13% ⬆️0.09%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidmlidavidmlidavidm approved these changes
@westonpacewestonpacewestonpace approved these changes
@pitroupitroupitrou approved these changes
@cyb70289cyb70289cyb70289 approved these changes

Assignees

No one assigned

Labels

Component: C++Component: FlightRPCComponent: GandivaComponent: ParquetComponent: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@kou@mbrobbel@jonkeane@ursabot@lidavidm@westonpace@pitrou@cyb70289
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ARROW-14897: [CI][C++] Upgrade Clang Tools to 12 from 8 - #11786
Closed
kou wants to merge 6 commits into
apache:masterfrom 
kou:cpp-clang-tools-12
Closed
ARROW-14897: [CI][C++] Upgrade Clang Tools to 12 from 8#11786
kou wants to merge 6 commits into
apache:masterfrom 
kou:cpp-clang-tools-12
Conversation
@kou
@koukou
commented
Nov 28, 2021

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Nov 28, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14897
@github-actions
github-actionsBot
commented
Nov 28, 2021

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
ef93600 to
e881881CompareNovember 28, 2021 21:21
@kou
kou
commented
Nov 28, 2021

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g nightly
@github-actions
github-actionsBot
commented
Nov 28, 2021

Copy link


Copy Markdown

Revision: e881881a488339daf3d461ee06eb35845ebfcee5
Submitted crossbow builds: ursacomputing/crossbow @ actions-1210
TaskStatus
almalinux-8-amd64Github Actions
almalinux-8-arm64TravisCI
amazon-linux-2-amd64Github Actions
centos-7-amd64Github Actions
centos-8-amd64Github Actions
centos-8-arm64TravisCI
conda-cleanAzure
conda-linux-gcc-py36-cpu-r40Azure
conda-linux-gcc-py36-cudaAzure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py36-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2017-py36-r40Azure
debian-bookworm-amd64Github Actions
debian-bookworm-arm64TravisCI
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
debian-buster-amd64Github Actions
debian-buster-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
test-build-cpp-fuzzGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.10Github Actions
test-conda-python-3.6Github Actions
test-conda-python-3.6-pandas-0.23Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-v3.1.2Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-v3.2.0Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-dask-latestGithub Actions
test-conda-python-3.9-dask-masterGithub Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-conda-python-3.9-spark-masterGithub Actions
test-debian-10-cppGithub Actions
test-debian-11-cppGithub Actions
test-debian-11-go-1.15Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-33-cppGithub Actions
test-fedora-33-python-3Azure
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-autoAzure
test-r-depsource-systemGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.1-centos8Azure
test-r-rstudio-r-base-4.1-focalAzure
test-r-rstudio-r-base-4.1-opensuse15Azure
test-r-rstudio-r-base-4.1-opensuse42Azure
test-r-ubuntu-21.04Github Actions
test-r-versionsGithub Actions
test-skyhook-integrationGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-python-3Azure
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-14Github Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-bundledGithub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.10-docsAzure
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-hirsute-amd64Github Actions
ubuntu-hirsute-arm64TravisCI
ubuntu-impish-amd64Github Actions
ubuntu-impish-arm64TravisCI
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-high-sierra-cp310-amd64Github Actions
wheel-macos-high-sierra-cp36-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-macos-mavericks-cp310-amd64Github Actions
wheel-macos-mavericks-cp36-amd64Github Actions
wheel-macos-mavericks-cp37-amd64Github Actions
wheel-macos-mavericks-cp38-amd64Github Actions
wheel-macos-mavericks-cp39-amd64Github Actions
wheel-manylinux2010-cp310-amd64Github Actions
wheel-manylinux2010-cp36-amd64Github Actions
wheel-manylinux2010-cp37-amd64Github Actions
wheel-manylinux2010-cp38-amd64Github Actions
wheel-manylinux2010-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp36-amd64Github Actions
wheel-manylinux2014-cp36-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp36-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions
@kou
kou
commented
Nov 29, 2021

Copy link


Copy Markdown

MemberAuthor
@pitrou@lidavidm@cyb70289@bkietz@westonpace You may be interested in this.
cyb70289
cyb70289
approved these changes
Nov 29, 2021
View reviewed changes
@cyb70289cyb70289
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@mbrobbel
mbrobbel
commented
Nov 29, 2021

Copy link


Copy Markdown

Member
There are some mentions in dev docs about the clang version:
lidavidm
lidavidm
approved these changes
Nov 29, 2021
View reviewed changes
@lidavidmlidavidm
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be worth giving a heads-up on dev@, even though the diffs here are small/it seems we shouldn't have many conflicts.
westonpace
westonpace
approved these changes
Nov 30, 2021
View reviewed changes
@westonpacewestonpace
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be rather helpful for me. I had to disable clang on clion because it kept reordering the headers and I think IncludeBlocks: Preserve is probably what I was missing so thanks for that 👍
It looks like the TravisCI failures are related. Googling suggests that maybe the TravisCI build host has out-of-date SSL root certificates and you might need to update libgnutls-openssl27 libgnutls30 in addition to ca-certificates but that is kind of a shot in the dark based on this
@kou
kou
commented
Nov 30, 2021•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
@mbrobbel Good catch! I've updated documentations and they don't include the pinned version now.
@lidavidm It makes sense. I've sent an e-mail: https://lists.apache.org/thread/bd3rkllwgsrnqmmsn9zn5wo3cmjdn2b4
@westonpace Thanks for the hint. I've fixed it. You may be interested in R related changes after the first push:
@thisisnicthisisnic
mentioned this pull request
Nov 30, 2021
 Closed

@jonkeane
jonkeane
commented
Dec 1, 2021

Copy link


Copy Markdown

Member
This is fantastic, thank you!
There are a few places in dev/tasks/tasks.yml that had bespoke versions of CLANG_TOOLS to get them working that I don't think are needed anymore. I'm happy to push a commit to this branch (I would suggest changes, but GH doesn't let me do that on a file that's not near the diffs)
arrow/dev/tasks/tasks.yml

Line 1205
in
736a69e
CLANG_TOOLS: 9# can remove this when >=9 is the default

arrow/dev/tasks/tasks.yml

Line 1193
in
736a69e
CLANG_TOOLS: 9# can remove this when >=9 is the default
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
26b67c7 to
8ab6937CompareDecember 1, 2021 21:02
@kou
kou
commented
Dec 1, 2021

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-ubuntu-21.04 test-r-gcc-11
@kou
kou
commented
Dec 1, 2021

Copy link


Copy Markdown

MemberAuthor
@jonkeane Good catch! I've removed them.
@github-actions
github-actionsBot
commented
Dec 1, 2021

Copy link


Copy Markdown

Revision: 8ab693734997f4085b50a56318d2ac07dfb8f554
Submitted crossbow builds: ursacomputing/crossbow @ actions-1227
TaskStatus
test-r-gcc-11Github Actions
test-r-ubuntu-21.04Github Actions
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
8ab6937 to
84aa717CompareDecember 1, 2021 23:45
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
84aa717 to
4665516CompareDecember 2, 2021 01:23
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
4665516 to
3ee8213CompareDecember 2, 2021 02:44
@kou
kou
commented
Dec 2, 2021

Copy link


Copy Markdown

MemberAuthor
CI failures are unrelated. This is caused by https://packagemanager.rstudio.com/ . It returns 500.
I'll merge this.
@koukou
closed this
in
f36451fDec 2, 2021
@kou
kou
deleted the

cpp-clang-tools-12

branch
December 2, 2021 05:08
@ursabot
ursabot
commented
Dec 2, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 9ec01da and contender = f36451f. f36451f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.45% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.13% ⬆️0.09%] ursa-thinkcentre-m75q

Supported benchmarks:

ursa-i9-9960x: langs = Python, R, JavaScript

ursa-thinkcentre-m75q: langs = C++, Java

ec2-t3-xlarge-us-east-2: cloud = True
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lidavidmlidavidmlidavidm approved these changes
@westonpacewestonpacewestonpace approved these changes
@pitroupitroupitrou approved these changes
@cyb70289cyb70289cyb70289 approved these changes

Assignees


No one assigned


Labels

Component: C++Component: FlightRPCComponent: GandivaComponent: ParquetComponent: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@kou@mbrobbel@jonkeane@ursabot@lidavidm@westonpace@pitrou@cyb70289

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-14897: [CI][C++] Upgrade Clang Tools to 12 from 8 - #11786
Closed
kou wants to merge 6 commits into
apache:masterfrom 
kou:cpp-clang-tools-12
Closed
ARROW-14897: [CI][C++] Upgrade Clang Tools to 12 from 8#11786
kou wants to merge 6 commits into
apache:masterfrom 
kou:cpp-clang-tools-12
Conversation
@kou
@koukou
commented
Nov 28, 2021

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Nov 28, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14897
@github-actions
github-actionsBot
commented
Nov 28, 2021

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
ef93600 to
e881881CompareNovember 28, 2021 21:21
@kou
kou
commented
Nov 28, 2021

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g nightly
@github-actions
github-actionsBot
commented
Nov 28, 2021

Copy link


Copy Markdown

Revision: e881881a488339daf3d461ee06eb35845ebfcee5
Submitted crossbow builds: ursacomputing/crossbow @ actions-1210
TaskStatus
almalinux-8-amd64Github Actions
almalinux-8-arm64TravisCI
amazon-linux-2-amd64Github Actions
centos-7-amd64Github Actions
centos-8-amd64Github Actions
centos-8-arm64TravisCI
conda-cleanAzure
conda-linux-gcc-py36-cpu-r40Azure
conda-linux-gcc-py36-cudaAzure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py36-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2017-py36-r40Azure
debian-bookworm-amd64Github Actions
debian-bookworm-arm64TravisCI
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
debian-buster-amd64Github Actions
debian-buster-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
test-build-cpp-fuzzGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.10Github Actions
test-conda-python-3.6Github Actions
test-conda-python-3.6-pandas-0.23Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-v3.1.2Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-v3.2.0Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-dask-latestGithub Actions
test-conda-python-3.9-dask-masterGithub Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-conda-python-3.9-spark-masterGithub Actions
test-debian-10-cppGithub Actions
test-debian-11-cppGithub Actions
test-debian-11-go-1.15Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-33-cppGithub Actions
test-fedora-33-python-3Azure
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-autoAzure
test-r-depsource-systemGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.1-centos8Azure
test-r-rstudio-r-base-4.1-focalAzure
test-r-rstudio-r-base-4.1-opensuse15Azure
test-r-rstudio-r-base-4.1-opensuse42Azure
test-r-ubuntu-21.04Github Actions
test-r-versionsGithub Actions
test-skyhook-integrationGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-python-3Azure
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-14Github Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-bundledGithub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.10-docsAzure
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-hirsute-amd64Github Actions
ubuntu-hirsute-arm64TravisCI
ubuntu-impish-amd64Github Actions
ubuntu-impish-arm64TravisCI
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-high-sierra-cp310-amd64Github Actions
wheel-macos-high-sierra-cp36-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-macos-mavericks-cp310-amd64Github Actions
wheel-macos-mavericks-cp36-amd64Github Actions
wheel-macos-mavericks-cp37-amd64Github Actions
wheel-macos-mavericks-cp38-amd64Github Actions
wheel-macos-mavericks-cp39-amd64Github Actions
wheel-manylinux2010-cp310-amd64Github Actions
wheel-manylinux2010-cp36-amd64Github Actions
wheel-manylinux2010-cp37-amd64Github Actions
wheel-manylinux2010-cp38-amd64Github Actions
wheel-manylinux2010-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp36-amd64Github Actions
wheel-manylinux2014-cp36-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp36-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions
@kou
kou
commented
Nov 29, 2021

Copy link


Copy Markdown

MemberAuthor
@pitrou@lidavidm@cyb70289@bkietz@westonpace You may be interested in this.
cyb70289
cyb70289
approved these changes
Nov 29, 2021
View reviewed changes
@cyb70289cyb70289
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@mbrobbel
mbrobbel
commented
Nov 29, 2021

Copy link


Copy Markdown

Member
There are some mentions in dev docs about the clang version:
lidavidm
lidavidm
approved these changes
Nov 29, 2021
View reviewed changes
@lidavidmlidavidm
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be worth giving a heads-up on dev@, even though the diffs here are small/it seems we shouldn't have many conflicts.
westonpace
westonpace
approved these changes
Nov 30, 2021
View reviewed changes
@westonpacewestonpace
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be rather helpful for me. I had to disable clang on clion because it kept reordering the headers and I think IncludeBlocks: Preserve is probably what I was missing so thanks for that 👍
It looks like the TravisCI failures are related. Googling suggests that maybe the TravisCI build host has out-of-date SSL root certificates and you might need to update libgnutls-openssl27 libgnutls30 in addition to ca-certificates but that is kind of a shot in the dark based on this
@kou
kou
commented
Nov 30, 2021•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
@mbrobbel Good catch! I've updated documentations and they don't include the pinned version now.
@lidavidm It makes sense. I've sent an e-mail: https://lists.apache.org/thread/bd3rkllwgsrnqmmsn9zn5wo3cmjdn2b4
@westonpace Thanks for the hint. I've fixed it. You may be interested in R related changes after the first push:
@thisisnicthisisnic
mentioned this pull request
Nov 30, 2021
 Closed

@jonkeane
jonkeane
commented
Dec 1, 2021

Copy link


Copy Markdown

Member
This is fantastic, thank you!
There are a few places in dev/tasks/tasks.yml that had bespoke versions of CLANG_TOOLS to get them working that I don't think are needed anymore. I'm happy to push a commit to this branch (I would suggest changes, but GH doesn't let me do that on a file that's not near the diffs)
arrow/dev/tasks/tasks.yml

Line 1205
in
736a69e
CLANG_TOOLS: 9# can remove this when >=9 is the default

arrow/dev/tasks/tasks.yml

Line 1193
in
736a69e
CLANG_TOOLS: 9# can remove this when >=9 is the default
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
26b67c7 to
8ab6937CompareDecember 1, 2021 21:02
@kou
kou
commented
Dec 1, 2021

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-ubuntu-21.04 test-r-gcc-11
@kou
kou
commented
Dec 1, 2021

Copy link


Copy Markdown

MemberAuthor
@jonkeane Good catch! I've removed them.
@github-actions
github-actionsBot
commented
Dec 1, 2021

Copy link


Copy Markdown

Revision: 8ab693734997f4085b50a56318d2ac07dfb8f554
Submitted crossbow builds: ursacomputing/crossbow @ actions-1227
TaskStatus
test-r-gcc-11Github Actions
test-r-ubuntu-21.04Github Actions
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
8ab6937 to
84aa717CompareDecember 1, 2021 23:45
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
84aa717 to
4665516CompareDecember 2, 2021 01:23
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
4665516 to
3ee8213CompareDecember 2, 2021 02:44
@kou
kou
commented
Dec 2, 2021

Copy link


Copy Markdown

MemberAuthor
CI failures are unrelated. This is caused by https://packagemanager.rstudio.com/ . It returns 500.
I'll merge this.
@koukou
closed this
in
f36451fDec 2, 2021
@kou
kou
deleted the

cpp-clang-tools-12

branch
December 2, 2021 05:08
@ursabot
ursabot
commented
Dec 2, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 9ec01da and contender = f36451f. f36451f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.45% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.13% ⬆️0.09%] ursa-thinkcentre-m75q

Supported benchmarks:

ursa-i9-9960x: langs = Python, R, JavaScript

ursa-thinkcentre-m75q: langs = C++, Java

ec2-t3-xlarge-us-east-2: cloud = True
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lidavidmlidavidmlidavidm approved these changes
@westonpacewestonpacewestonpace approved these changes
@pitroupitroupitrou approved these changes
@cyb70289cyb70289cyb70289 approved these changes

Assignees


No one assigned


Labels

Component: C++Component: FlightRPCComponent: GandivaComponent: ParquetComponent: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@kou@mbrobbel@jonkeane@ursabot@lidavidm@westonpace@pitrou@cyb70289

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-14897: [CI][C++] Upgrade Clang Tools to 12 from 8 - #11786
Closed
kou wants to merge 6 commits into
apache:masterfrom 
kou:cpp-clang-tools-12
Closed
ARROW-14897: [CI][C++] Upgrade Clang Tools to 12 from 8#11786
kou wants to merge 6 commits into
apache:masterfrom 
kou:cpp-clang-tools-12
Conversation
@kou
@koukou
commented
Nov 28, 2021

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Nov 28, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14897
@github-actions
github-actionsBot
commented
Nov 28, 2021

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
ef93600 to
e881881CompareNovember 28, 2021 21:21
@kou
kou
commented
Nov 28, 2021

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g nightly
@github-actions
github-actionsBot
commented
Nov 28, 2021

Copy link


Copy Markdown

Revision: e881881a488339daf3d461ee06eb35845ebfcee5
Submitted crossbow builds: ursacomputing/crossbow @ actions-1210
TaskStatus
almalinux-8-amd64Github Actions
almalinux-8-arm64TravisCI
amazon-linux-2-amd64Github Actions
centos-7-amd64Github Actions
centos-8-amd64Github Actions
centos-8-arm64TravisCI
conda-cleanAzure
conda-linux-gcc-py36-cpu-r40Azure
conda-linux-gcc-py36-cudaAzure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py36-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2017-py36-r40Azure
debian-bookworm-amd64Github Actions
debian-bookworm-arm64TravisCI
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
debian-buster-amd64Github Actions
debian-buster-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
test-build-cpp-fuzzGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.10Github Actions
test-conda-python-3.6Github Actions
test-conda-python-3.6-pandas-0.23Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-v3.1.2Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-v3.2.0Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-dask-latestGithub Actions
test-conda-python-3.9-dask-masterGithub Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-conda-python-3.9-spark-masterGithub Actions
test-debian-10-cppGithub Actions
test-debian-11-cppGithub Actions
test-debian-11-go-1.15Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-33-cppGithub Actions
test-fedora-33-python-3Azure
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-autoAzure
test-r-depsource-systemGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.1-centos8Azure
test-r-rstudio-r-base-4.1-focalAzure
test-r-rstudio-r-base-4.1-opensuse15Azure
test-r-rstudio-r-base-4.1-opensuse42Azure
test-r-ubuntu-21.04Github Actions
test-r-versionsGithub Actions
test-skyhook-integrationGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-python-3Azure
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-14Github Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-bundledGithub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.10-docsAzure
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-hirsute-amd64Github Actions
ubuntu-hirsute-arm64TravisCI
ubuntu-impish-amd64Github Actions
ubuntu-impish-arm64TravisCI
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-high-sierra-cp310-amd64Github Actions
wheel-macos-high-sierra-cp36-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-macos-mavericks-cp310-amd64Github Actions
wheel-macos-mavericks-cp36-amd64Github Actions
wheel-macos-mavericks-cp37-amd64Github Actions
wheel-macos-mavericks-cp38-amd64Github Actions
wheel-macos-mavericks-cp39-amd64Github Actions
wheel-manylinux2010-cp310-amd64Github Actions
wheel-manylinux2010-cp36-amd64Github Actions
wheel-manylinux2010-cp37-amd64Github Actions
wheel-manylinux2010-cp38-amd64Github Actions
wheel-manylinux2010-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp36-amd64Github Actions
wheel-manylinux2014-cp36-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp36-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions
@kou
kou
commented
Nov 29, 2021

Copy link


Copy Markdown

MemberAuthor
@pitrou@lidavidm@cyb70289@bkietz@westonpace You may be interested in this.
cyb70289
cyb70289
approved these changes
Nov 29, 2021
View reviewed changes
@cyb70289cyb70289
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@mbrobbel
mbrobbel
commented
Nov 29, 2021

Copy link


Copy Markdown

Member
There are some mentions in dev docs about the clang version:
lidavidm
lidavidm
approved these changes
Nov 29, 2021
View reviewed changes
@lidavidmlidavidm
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be worth giving a heads-up on dev@, even though the diffs here are small/it seems we shouldn't have many conflicts.
westonpace
westonpace
approved these changes
Nov 30, 2021
View reviewed changes
@westonpacewestonpace
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be rather helpful for me. I had to disable clang on clion because it kept reordering the headers and I think IncludeBlocks: Preserve is probably what I was missing so thanks for that 👍
It looks like the TravisCI failures are related. Googling suggests that maybe the TravisCI build host has out-of-date SSL root certificates and you might need to update libgnutls-openssl27 libgnutls30 in addition to ca-certificates but that is kind of a shot in the dark based on this
@kou
kou
commented
Nov 30, 2021•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
@mbrobbel Good catch! I've updated documentations and they don't include the pinned version now.
@lidavidm It makes sense. I've sent an e-mail: https://lists.apache.org/thread/bd3rkllwgsrnqmmsn9zn5wo3cmjdn2b4
@westonpace Thanks for the hint. I've fixed it. You may be interested in R related changes after the first push:
@thisisnicthisisnic
mentioned this pull request
Nov 30, 2021
 Closed

@jonkeane
jonkeane
commented
Dec 1, 2021

Copy link


Copy Markdown

Member
This is fantastic, thank you!
There are a few places in dev/tasks/tasks.yml that had bespoke versions of CLANG_TOOLS to get them working that I don't think are needed anymore. I'm happy to push a commit to this branch (I would suggest changes, but GH doesn't let me do that on a file that's not near the diffs)
arrow/dev/tasks/tasks.yml

Line 1205
in
736a69e
CLANG_TOOLS: 9# can remove this when >=9 is the default

arrow/dev/tasks/tasks.yml

Line 1193
in
736a69e
CLANG_TOOLS: 9# can remove this when >=9 is the default
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
26b67c7 to
8ab6937CompareDecember 1, 2021 21:02
@kou
kou
commented
Dec 1, 2021

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-ubuntu-21.04 test-r-gcc-11
@kou
kou
commented
Dec 1, 2021

Copy link


Copy Markdown

MemberAuthor
@jonkeane Good catch! I've removed them.
@github-actions
github-actionsBot
commented
Dec 1, 2021

Copy link


Copy Markdown

Revision: 8ab693734997f4085b50a56318d2ac07dfb8f554
Submitted crossbow builds: ursacomputing/crossbow @ actions-1227
TaskStatus
test-r-gcc-11Github Actions
test-r-ubuntu-21.04Github Actions
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
8ab6937 to
84aa717CompareDecember 1, 2021 23:45
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
84aa717 to
4665516CompareDecember 2, 2021 01:23
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
4665516 to
3ee8213CompareDecember 2, 2021 02:44
@kou
kou
commented
Dec 2, 2021

Copy link


Copy Markdown

MemberAuthor
CI failures are unrelated. This is caused by https://packagemanager.rstudio.com/ . It returns 500.
I'll merge this.
@koukou
closed this
in
f36451fDec 2, 2021
@kou
kou
deleted the

cpp-clang-tools-12

branch
December 2, 2021 05:08
@ursabot
ursabot
commented
Dec 2, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 9ec01da and contender = f36451f. f36451f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.45% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.13% ⬆️0.09%] ursa-thinkcentre-m75q

Supported benchmarks:

ursa-i9-9960x: langs = Python, R, JavaScript

ursa-thinkcentre-m75q: langs = C++, Java

ec2-t3-xlarge-us-east-2: cloud = True
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lidavidmlidavidmlidavidm approved these changes
@westonpacewestonpacewestonpace approved these changes
@pitroupitroupitrou approved these changes
@cyb70289cyb70289cyb70289 approved these changes

Assignees


No one assigned


Labels

Component: C++Component: FlightRPCComponent: GandivaComponent: ParquetComponent: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@kou@mbrobbel@jonkeane@ursabot@lidavidm@westonpace@pitrou@cyb70289

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ARROW-14897: [CI][C++] Upgrade Clang Tools to 12 from 8 - #11786
Closed
kou wants to merge 6 commits into
apache:masterfrom 
kou:cpp-clang-tools-12
Closed
ARROW-14897: [CI][C++] Upgrade Clang Tools to 12 from 8#11786
kou wants to merge 6 commits into
apache:masterfrom 
kou:cpp-clang-tools-12
Conversation
@kou
@koukou
commented
Nov 28, 2021

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Nov 28, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14897
@github-actions
github-actionsBot
commented
Nov 28, 2021

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
ef93600 to
e881881CompareNovember 28, 2021 21:21
@kou
kou
commented
Nov 28, 2021

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g nightly
@github-actions
github-actionsBot
commented
Nov 28, 2021

Copy link


Copy Markdown

Revision: e881881a488339daf3d461ee06eb35845ebfcee5
Submitted crossbow builds: ursacomputing/crossbow @ actions-1210
TaskStatus
almalinux-8-amd64Github Actions
almalinux-8-arm64TravisCI
amazon-linux-2-amd64Github Actions
centos-7-amd64Github Actions
centos-8-amd64Github Actions
centos-8-arm64TravisCI
conda-cleanAzure
conda-linux-gcc-py36-cpu-r40Azure
conda-linux-gcc-py36-cudaAzure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py36-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2017-py36-r40Azure
debian-bookworm-amd64Github Actions
debian-bookworm-arm64TravisCI
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
debian-buster-amd64Github Actions
debian-buster-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
test-build-cpp-fuzzGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.10Github Actions
test-conda-python-3.6Github Actions
test-conda-python-3.6-pandas-0.23Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-v3.1.2Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-v3.2.0Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-dask-latestGithub Actions
test-conda-python-3.9-dask-masterGithub Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-conda-python-3.9-spark-masterGithub Actions
test-debian-10-cppGithub Actions
test-debian-11-cppGithub Actions
test-debian-11-go-1.15Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-33-cppGithub Actions
test-fedora-33-python-3Azure
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-autoAzure
test-r-depsource-systemGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.1-centos8Azure
test-r-rstudio-r-base-4.1-focalAzure
test-r-rstudio-r-base-4.1-opensuse15Azure
test-r-rstudio-r-base-4.1-opensuse42Azure
test-r-ubuntu-21.04Github Actions
test-r-versionsGithub Actions
test-skyhook-integrationGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-python-3Azure
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-14Github Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-bundledGithub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.10-docsAzure
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-hirsute-amd64Github Actions
ubuntu-hirsute-arm64TravisCI
ubuntu-impish-amd64Github Actions
ubuntu-impish-arm64TravisCI
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-high-sierra-cp310-amd64Github Actions
wheel-macos-high-sierra-cp36-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-macos-mavericks-cp310-amd64Github Actions
wheel-macos-mavericks-cp36-amd64Github Actions
wheel-macos-mavericks-cp37-amd64Github Actions
wheel-macos-mavericks-cp38-amd64Github Actions
wheel-macos-mavericks-cp39-amd64Github Actions
wheel-manylinux2010-cp310-amd64Github Actions
wheel-manylinux2010-cp36-amd64Github Actions
wheel-manylinux2010-cp37-amd64Github Actions
wheel-manylinux2010-cp38-amd64Github Actions
wheel-manylinux2010-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp36-amd64Github Actions
wheel-manylinux2014-cp36-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp36-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions
@kou
kou
commented
Nov 29, 2021

Copy link


Copy Markdown

MemberAuthor
@pitrou@lidavidm@cyb70289@bkietz@westonpace You may be interested in this.
cyb70289
cyb70289
approved these changes
Nov 29, 2021
View reviewed changes
@cyb70289cyb70289
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@mbrobbel
mbrobbel
commented
Nov 29, 2021

Copy link


Copy Markdown

Member
There are some mentions in dev docs about the clang version:
lidavidm
lidavidm
approved these changes
Nov 29, 2021
View reviewed changes
@lidavidmlidavidm
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be worth giving a heads-up on dev@, even though the diffs here are small/it seems we shouldn't have many conflicts.
westonpace
westonpace
approved these changes
Nov 30, 2021
View reviewed changes
@westonpacewestonpace
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be rather helpful for me. I had to disable clang on clion because it kept reordering the headers and I think IncludeBlocks: Preserve is probably what I was missing so thanks for that 👍
It looks like the TravisCI failures are related. Googling suggests that maybe the TravisCI build host has out-of-date SSL root certificates and you might need to update libgnutls-openssl27 libgnutls30 in addition to ca-certificates but that is kind of a shot in the dark based on this
@kou
kou
commented
Nov 30, 2021•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
@mbrobbel Good catch! I've updated documentations and they don't include the pinned version now.
@lidavidm It makes sense. I've sent an e-mail: https://lists.apache.org/thread/bd3rkllwgsrnqmmsn9zn5wo3cmjdn2b4
@westonpace Thanks for the hint. I've fixed it. You may be interested in R related changes after the first push:
@thisisnicthisisnic
mentioned this pull request
Nov 30, 2021
 Closed

@jonkeane
jonkeane
commented
Dec 1, 2021

Copy link


Copy Markdown

Member
This is fantastic, thank you!
There are a few places in dev/tasks/tasks.yml that had bespoke versions of CLANG_TOOLS to get them working that I don't think are needed anymore. I'm happy to push a commit to this branch (I would suggest changes, but GH doesn't let me do that on a file that's not near the diffs)
arrow/dev/tasks/tasks.yml

Line 1205
in
736a69e
CLANG_TOOLS: 9# can remove this when >=9 is the default

arrow/dev/tasks/tasks.yml

Line 1193
in
736a69e
CLANG_TOOLS: 9# can remove this when >=9 is the default
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
26b67c7 to
8ab6937CompareDecember 1, 2021 21:02
@kou
kou
commented
Dec 1, 2021

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-ubuntu-21.04 test-r-gcc-11
@kou
kou
commented
Dec 1, 2021

Copy link


Copy Markdown

MemberAuthor
@jonkeane Good catch! I've removed them.
@github-actions
github-actionsBot
commented
Dec 1, 2021

Copy link


Copy Markdown

Revision: 8ab693734997f4085b50a56318d2ac07dfb8f554
Submitted crossbow builds: ursacomputing/crossbow @ actions-1227
TaskStatus
test-r-gcc-11Github Actions
test-r-ubuntu-21.04Github Actions
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
8ab6937 to
84aa717CompareDecember 1, 2021 23:45
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
84aa717 to
4665516CompareDecember 2, 2021 01:23
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
4665516 to
3ee8213CompareDecember 2, 2021 02:44
@kou
kou
commented
Dec 2, 2021

Copy link


Copy Markdown

MemberAuthor
CI failures are unrelated. This is caused by https://packagemanager.rstudio.com/ . It returns 500.
I'll merge this.
@koukou
closed this
in
f36451fDec 2, 2021
@kou
kou
deleted the

cpp-clang-tools-12

branch
December 2, 2021 05:08
@ursabot
ursabot
commented
Dec 2, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 9ec01da and contender = f36451f. f36451f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.45% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.13% ⬆️0.09%] ursa-thinkcentre-m75q

Supported benchmarks:

ursa-i9-9960x: langs = Python, R, JavaScript

ursa-thinkcentre-m75q: langs = C++, Java

ec2-t3-xlarge-us-east-2: cloud = True
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lidavidmlidavidmlidavidm approved these changes
@westonpacewestonpacewestonpace approved these changes
@pitroupitroupitrou approved these changes
@cyb70289cyb70289cyb70289 approved these changes

Assignees


No one assigned


Labels

Component: C++Component: FlightRPCComponent: GandivaComponent: ParquetComponent: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@kou@mbrobbel@jonkeane@ursabot@lidavidm@westonpace@pitrou@cyb70289

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-14897: [CI][C++] Upgrade Clang Tools to 12 from 8 - #11786
Closed
kou wants to merge 6 commits into
apache:masterfrom 
kou:cpp-clang-tools-12
Closed
ARROW-14897: [CI][C++] Upgrade Clang Tools to 12 from 8#11786
kou wants to merge 6 commits into
apache:masterfrom 
kou:cpp-clang-tools-12
Conversation
@kou
@koukou
commented
Nov 28, 2021

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Nov 28, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14897
@github-actions
github-actionsBot
commented
Nov 28, 2021

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
ef93600 to
e881881CompareNovember 28, 2021 21:21
@kou
kou
commented
Nov 28, 2021

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g nightly
@github-actions
github-actionsBot
commented
Nov 28, 2021

Copy link


Copy Markdown

Revision: e881881a488339daf3d461ee06eb35845ebfcee5
Submitted crossbow builds: ursacomputing/crossbow @ actions-1210
TaskStatus
almalinux-8-amd64Github Actions
almalinux-8-arm64TravisCI
amazon-linux-2-amd64Github Actions
centos-7-amd64Github Actions
centos-8-amd64Github Actions
centos-8-arm64TravisCI
conda-cleanAzure
conda-linux-gcc-py36-cpu-r40Azure
conda-linux-gcc-py36-cudaAzure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py36-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2017-py36-r40Azure
debian-bookworm-amd64Github Actions
debian-bookworm-arm64TravisCI
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
debian-buster-amd64Github Actions
debian-buster-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
test-build-cpp-fuzzGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.10Github Actions
test-conda-python-3.6Github Actions
test-conda-python-3.6-pandas-0.23Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-v3.1.2Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-v3.2.0Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-dask-latestGithub Actions
test-conda-python-3.9-dask-masterGithub Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-conda-python-3.9-spark-masterGithub Actions
test-debian-10-cppGithub Actions
test-debian-11-cppGithub Actions
test-debian-11-go-1.15Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-33-cppGithub Actions
test-fedora-33-python-3Azure
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-autoAzure
test-r-depsource-systemGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.1-centos8Azure
test-r-rstudio-r-base-4.1-focalAzure
test-r-rstudio-r-base-4.1-opensuse15Azure
test-r-rstudio-r-base-4.1-opensuse42Azure
test-r-ubuntu-21.04Github Actions
test-r-versionsGithub Actions
test-skyhook-integrationGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-python-3Azure
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-14Github Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-bundledGithub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.10-docsAzure
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-hirsute-amd64Github Actions
ubuntu-hirsute-arm64TravisCI
ubuntu-impish-amd64Github Actions
ubuntu-impish-arm64TravisCI
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-high-sierra-cp310-amd64Github Actions
wheel-macos-high-sierra-cp36-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-macos-mavericks-cp310-amd64Github Actions
wheel-macos-mavericks-cp36-amd64Github Actions
wheel-macos-mavericks-cp37-amd64Github Actions
wheel-macos-mavericks-cp38-amd64Github Actions
wheel-macos-mavericks-cp39-amd64Github Actions
wheel-manylinux2010-cp310-amd64Github Actions
wheel-manylinux2010-cp36-amd64Github Actions
wheel-manylinux2010-cp37-amd64Github Actions
wheel-manylinux2010-cp38-amd64Github Actions
wheel-manylinux2010-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp36-amd64Github Actions
wheel-manylinux2014-cp36-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp36-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions
@kou
kou
commented
Nov 29, 2021

Copy link


Copy Markdown

MemberAuthor
@pitrou@lidavidm@cyb70289@bkietz@westonpace You may be interested in this.
cyb70289
cyb70289
approved these changes
Nov 29, 2021
View reviewed changes
@cyb70289cyb70289
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@mbrobbel
mbrobbel
commented
Nov 29, 2021

Copy link


Copy Markdown

Member
There are some mentions in dev docs about the clang version:
lidavidm
lidavidm
approved these changes
Nov 29, 2021
View reviewed changes
@lidavidmlidavidm
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be worth giving a heads-up on dev@, even though the diffs here are small/it seems we shouldn't have many conflicts.
westonpace
westonpace
approved these changes
Nov 30, 2021
View reviewed changes
@westonpacewestonpace
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be rather helpful for me. I had to disable clang on clion because it kept reordering the headers and I think IncludeBlocks: Preserve is probably what I was missing so thanks for that 👍
It looks like the TravisCI failures are related. Googling suggests that maybe the TravisCI build host has out-of-date SSL root certificates and you might need to update libgnutls-openssl27 libgnutls30 in addition to ca-certificates but that is kind of a shot in the dark based on this
@kou
kou
commented
Nov 30, 2021•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
@mbrobbel Good catch! I've updated documentations and they don't include the pinned version now.
@lidavidm It makes sense. I've sent an e-mail: https://lists.apache.org/thread/bd3rkllwgsrnqmmsn9zn5wo3cmjdn2b4
@westonpace Thanks for the hint. I've fixed it. You may be interested in R related changes after the first push:
@thisisnicthisisnic
mentioned this pull request
Nov 30, 2021
 Closed

@jonkeane
jonkeane
commented
Dec 1, 2021

Copy link


Copy Markdown

Member
This is fantastic, thank you!
There are a few places in dev/tasks/tasks.yml that had bespoke versions of CLANG_TOOLS to get them working that I don't think are needed anymore. I'm happy to push a commit to this branch (I would suggest changes, but GH doesn't let me do that on a file that's not near the diffs)
arrow/dev/tasks/tasks.yml

Line 1205
in
736a69e
CLANG_TOOLS: 9# can remove this when >=9 is the default

arrow/dev/tasks/tasks.yml

Line 1193
in
736a69e
CLANG_TOOLS: 9# can remove this when >=9 is the default
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
26b67c7 to
8ab6937CompareDecember 1, 2021 21:02
@kou
kou
commented
Dec 1, 2021

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-ubuntu-21.04 test-r-gcc-11
@kou
kou
commented
Dec 1, 2021

Copy link


Copy Markdown

MemberAuthor
@jonkeane Good catch! I've removed them.
@github-actions
github-actionsBot
commented
Dec 1, 2021

Copy link


Copy Markdown

Revision: 8ab693734997f4085b50a56318d2ac07dfb8f554
Submitted crossbow builds: ursacomputing/crossbow @ actions-1227
TaskStatus
test-r-gcc-11Github Actions
test-r-ubuntu-21.04Github Actions
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
8ab6937 to
84aa717CompareDecember 1, 2021 23:45
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
84aa717 to
4665516CompareDecember 2, 2021 01:23
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
4665516 to
3ee8213CompareDecember 2, 2021 02:44
@kou
kou
commented
Dec 2, 2021

Copy link


Copy Markdown

MemberAuthor
CI failures are unrelated. This is caused by https://packagemanager.rstudio.com/ . It returns 500.
I'll merge this.
@koukou
closed this
in
f36451fDec 2, 2021
@kou
kou
deleted the

cpp-clang-tools-12

branch
December 2, 2021 05:08
@ursabot
ursabot
commented
Dec 2, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 9ec01da and contender = f36451f. f36451f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.45% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.13% ⬆️0.09%] ursa-thinkcentre-m75q

Supported benchmarks:

ursa-i9-9960x: langs = Python, R, JavaScript

ursa-thinkcentre-m75q: langs = C++, Java

ec2-t3-xlarge-us-east-2: cloud = True
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lidavidmlidavidmlidavidm approved these changes
@westonpacewestonpacewestonpace approved these changes
@pitroupitroupitrou approved these changes
@cyb70289cyb70289cyb70289 approved these changes

Assignees


No one assigned


Labels

Component: C++Component: FlightRPCComponent: GandivaComponent: ParquetComponent: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@kou@mbrobbel@jonkeane@ursabot@lidavidm@westonpace@pitrou@cyb70289

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-14897: [CI][C++] Upgrade Clang Tools to 12 from 8 - #11786
Closed
kou wants to merge 6 commits into
apache:masterfrom 
kou:cpp-clang-tools-12
Closed
ARROW-14897: [CI][C++] Upgrade Clang Tools to 12 from 8#11786
kou wants to merge 6 commits into
apache:masterfrom 
kou:cpp-clang-tools-12
Conversation
@kou
@koukou
commented
Nov 28, 2021

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Nov 28, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14897
@github-actions
github-actionsBot
commented
Nov 28, 2021

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
ef93600 to
e881881CompareNovember 28, 2021 21:21
@kou
kou
commented
Nov 28, 2021

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g nightly
@github-actions
github-actionsBot
commented
Nov 28, 2021

Copy link


Copy Markdown

Revision: e881881a488339daf3d461ee06eb35845ebfcee5
Submitted crossbow builds: ursacomputing/crossbow @ actions-1210
TaskStatus
almalinux-8-amd64Github Actions
almalinux-8-arm64TravisCI
amazon-linux-2-amd64Github Actions
centos-7-amd64Github Actions
centos-8-amd64Github Actions
centos-8-arm64TravisCI
conda-cleanAzure
conda-linux-gcc-py36-cpu-r40Azure
conda-linux-gcc-py36-cudaAzure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py36-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2017-py36-r40Azure
debian-bookworm-amd64Github Actions
debian-bookworm-arm64TravisCI
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
debian-buster-amd64Github Actions
debian-buster-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
test-build-cpp-fuzzGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.10Github Actions
test-conda-python-3.6Github Actions
test-conda-python-3.6-pandas-0.23Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-v3.1.2Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-v3.2.0Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-dask-latestGithub Actions
test-conda-python-3.9-dask-masterGithub Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-conda-python-3.9-spark-masterGithub Actions
test-debian-10-cppGithub Actions
test-debian-11-cppGithub Actions
test-debian-11-go-1.15Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-33-cppGithub Actions
test-fedora-33-python-3Azure
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-autoAzure
test-r-depsource-systemGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.1-centos8Azure
test-r-rstudio-r-base-4.1-focalAzure
test-r-rstudio-r-base-4.1-opensuse15Azure
test-r-rstudio-r-base-4.1-opensuse42Azure
test-r-ubuntu-21.04Github Actions
test-r-versionsGithub Actions
test-skyhook-integrationGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-python-3Azure
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-14Github Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-bundledGithub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.10-docsAzure
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-hirsute-amd64Github Actions
ubuntu-hirsute-arm64TravisCI
ubuntu-impish-amd64Github Actions
ubuntu-impish-arm64TravisCI
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-high-sierra-cp310-amd64Github Actions
wheel-macos-high-sierra-cp36-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-macos-mavericks-cp310-amd64Github Actions
wheel-macos-mavericks-cp36-amd64Github Actions
wheel-macos-mavericks-cp37-amd64Github Actions
wheel-macos-mavericks-cp38-amd64Github Actions
wheel-macos-mavericks-cp39-amd64Github Actions
wheel-manylinux2010-cp310-amd64Github Actions
wheel-manylinux2010-cp36-amd64Github Actions
wheel-manylinux2010-cp37-amd64Github Actions
wheel-manylinux2010-cp38-amd64Github Actions
wheel-manylinux2010-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp36-amd64Github Actions
wheel-manylinux2014-cp36-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp36-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions
@kou
kou
commented
Nov 29, 2021

Copy link


Copy Markdown

MemberAuthor
@pitrou@lidavidm@cyb70289@bkietz@westonpace You may be interested in this.
cyb70289
cyb70289
approved these changes
Nov 29, 2021
View reviewed changes
@cyb70289cyb70289
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@mbrobbel
mbrobbel
commented
Nov 29, 2021

Copy link


Copy Markdown

Member
There are some mentions in dev docs about the clang version:
lidavidm
lidavidm
approved these changes
Nov 29, 2021
View reviewed changes
@lidavidmlidavidm
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be worth giving a heads-up on dev@, even though the diffs here are small/it seems we shouldn't have many conflicts.
westonpace
westonpace
approved these changes
Nov 30, 2021
View reviewed changes
@westonpacewestonpace
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be rather helpful for me. I had to disable clang on clion because it kept reordering the headers and I think IncludeBlocks: Preserve is probably what I was missing so thanks for that 👍
It looks like the TravisCI failures are related. Googling suggests that maybe the TravisCI build host has out-of-date SSL root certificates and you might need to update libgnutls-openssl27 libgnutls30 in addition to ca-certificates but that is kind of a shot in the dark based on this
@kou
kou
commented
Nov 30, 2021•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
@mbrobbel Good catch! I've updated documentations and they don't include the pinned version now.
@lidavidm It makes sense. I've sent an e-mail: https://lists.apache.org/thread/bd3rkllwgsrnqmmsn9zn5wo3cmjdn2b4
@westonpace Thanks for the hint. I've fixed it. You may be interested in R related changes after the first push:
@thisisnicthisisnic
mentioned this pull request
Nov 30, 2021
 Closed

@jonkeane
jonkeane
commented
Dec 1, 2021

Copy link


Copy Markdown

Member
This is fantastic, thank you!
There are a few places in dev/tasks/tasks.yml that had bespoke versions of CLANG_TOOLS to get them working that I don't think are needed anymore. I'm happy to push a commit to this branch (I would suggest changes, but GH doesn't let me do that on a file that's not near the diffs)
arrow/dev/tasks/tasks.yml

Line 1205
in
736a69e
CLANG_TOOLS: 9# can remove this when >=9 is the default

arrow/dev/tasks/tasks.yml

Line 1193
in
736a69e
CLANG_TOOLS: 9# can remove this when >=9 is the default
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
26b67c7 to
8ab6937CompareDecember 1, 2021 21:02
@kou
kou
commented
Dec 1, 2021

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-ubuntu-21.04 test-r-gcc-11
@kou
kou
commented
Dec 1, 2021

Copy link


Copy Markdown

MemberAuthor
@jonkeane Good catch! I've removed them.
@github-actions
github-actionsBot
commented
Dec 1, 2021

Copy link


Copy Markdown

Revision: 8ab693734997f4085b50a56318d2ac07dfb8f554
Submitted crossbow builds: ursacomputing/crossbow @ actions-1227
TaskStatus
test-r-gcc-11Github Actions
test-r-ubuntu-21.04Github Actions
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
8ab6937 to
84aa717CompareDecember 1, 2021 23:45
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
84aa717 to
4665516CompareDecember 2, 2021 01:23
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
4665516 to
3ee8213CompareDecember 2, 2021 02:44
@kou
kou
commented
Dec 2, 2021

Copy link


Copy Markdown

MemberAuthor
CI failures are unrelated. This is caused by https://packagemanager.rstudio.com/ . It returns 500.
I'll merge this.
@koukou
closed this
in
f36451fDec 2, 2021
@kou
kou
deleted the

cpp-clang-tools-12

branch
December 2, 2021 05:08
@ursabot
ursabot
commented
Dec 2, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 9ec01da and contender = f36451f. f36451f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.45% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.13% ⬆️0.09%] ursa-thinkcentre-m75q

Supported benchmarks:

ursa-i9-9960x: langs = Python, R, JavaScript

ursa-thinkcentre-m75q: langs = C++, Java

ec2-t3-xlarge-us-east-2: cloud = True
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lidavidmlidavidmlidavidm approved these changes
@westonpacewestonpacewestonpace approved these changes
@pitroupitroupitrou approved these changes
@cyb70289cyb70289cyb70289 approved these changes

Assignees


No one assigned


Labels

Component: C++Component: FlightRPCComponent: GandivaComponent: ParquetComponent: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@kou@mbrobbel@jonkeane@ursabot@lidavidm@westonpace@pitrou@cyb70289

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ARROW-14897: [CI][C++] Upgrade Clang Tools to 12 from 8 - #11786
Closed
kou wants to merge 6 commits into
apache:masterfrom 
kou:cpp-clang-tools-12
Closed
ARROW-14897: [CI][C++] Upgrade Clang Tools to 12 from 8#11786
kou wants to merge 6 commits into
apache:masterfrom 
kou:cpp-clang-tools-12
Conversation
@kou
@koukou
commented
Nov 28, 2021

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Nov 28, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14897
@github-actions
github-actionsBot
commented
Nov 28, 2021

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
ef93600 to
e881881CompareNovember 28, 2021 21:21
@kou
kou
commented
Nov 28, 2021

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g nightly
@github-actions
github-actionsBot
commented
Nov 28, 2021

Copy link


Copy Markdown

Revision: e881881a488339daf3d461ee06eb35845ebfcee5
Submitted crossbow builds: ursacomputing/crossbow @ actions-1210
TaskStatus
almalinux-8-amd64Github Actions
almalinux-8-arm64TravisCI
amazon-linux-2-amd64Github Actions
centos-7-amd64Github Actions
centos-8-amd64Github Actions
centos-8-arm64TravisCI
conda-cleanAzure
conda-linux-gcc-py36-cpu-r40Azure
conda-linux-gcc-py36-cudaAzure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py36-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2017-py36-r40Azure
debian-bookworm-amd64Github Actions
debian-bookworm-arm64TravisCI
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
debian-buster-amd64Github Actions
debian-buster-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
test-build-cpp-fuzzGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.10Github Actions
test-conda-python-3.6Github Actions
test-conda-python-3.6-pandas-0.23Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-v3.1.2Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-v3.2.0Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-dask-latestGithub Actions
test-conda-python-3.9-dask-masterGithub Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-conda-python-3.9-spark-masterGithub Actions
test-debian-10-cppGithub Actions
test-debian-11-cppGithub Actions
test-debian-11-go-1.15Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-33-cppGithub Actions
test-fedora-33-python-3Azure
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-autoAzure
test-r-depsource-systemGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.1-centos8Azure
test-r-rstudio-r-base-4.1-focalAzure
test-r-rstudio-r-base-4.1-opensuse15Azure
test-r-rstudio-r-base-4.1-opensuse42Azure
test-r-ubuntu-21.04Github Actions
test-r-versionsGithub Actions
test-skyhook-integrationGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-python-3Azure
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-14Github Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-bundledGithub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.10-docsAzure
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-hirsute-amd64Github Actions
ubuntu-hirsute-arm64TravisCI
ubuntu-impish-amd64Github Actions
ubuntu-impish-arm64TravisCI
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-high-sierra-cp310-amd64Github Actions
wheel-macos-high-sierra-cp36-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-macos-mavericks-cp310-amd64Github Actions
wheel-macos-mavericks-cp36-amd64Github Actions
wheel-macos-mavericks-cp37-amd64Github Actions
wheel-macos-mavericks-cp38-amd64Github Actions
wheel-macos-mavericks-cp39-amd64Github Actions
wheel-manylinux2010-cp310-amd64Github Actions
wheel-manylinux2010-cp36-amd64Github Actions
wheel-manylinux2010-cp37-amd64Github Actions
wheel-manylinux2010-cp38-amd64Github Actions
wheel-manylinux2010-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp36-amd64Github Actions
wheel-manylinux2014-cp36-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp36-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions
@kou
kou
commented
Nov 29, 2021

Copy link


Copy Markdown

MemberAuthor
@pitrou@lidavidm@cyb70289@bkietz@westonpace You may be interested in this.
cyb70289
cyb70289
approved these changes
Nov 29, 2021
View reviewed changes
@cyb70289cyb70289
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@mbrobbel
mbrobbel
commented
Nov 29, 2021

Copy link


Copy Markdown

Member
There are some mentions in dev docs about the clang version:
lidavidm
lidavidm
approved these changes
Nov 29, 2021
View reviewed changes
@lidavidmlidavidm
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be worth giving a heads-up on dev@, even though the diffs here are small/it seems we shouldn't have many conflicts.
westonpace
westonpace
approved these changes
Nov 30, 2021
View reviewed changes
@westonpacewestonpace
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be rather helpful for me. I had to disable clang on clion because it kept reordering the headers and I think IncludeBlocks: Preserve is probably what I was missing so thanks for that 👍
It looks like the TravisCI failures are related. Googling suggests that maybe the TravisCI build host has out-of-date SSL root certificates and you might need to update libgnutls-openssl27 libgnutls30 in addition to ca-certificates but that is kind of a shot in the dark based on this
@kou
kou
commented
Nov 30, 2021•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
@mbrobbel Good catch! I've updated documentations and they don't include the pinned version now.
@lidavidm It makes sense. I've sent an e-mail: https://lists.apache.org/thread/bd3rkllwgsrnqmmsn9zn5wo3cmjdn2b4
@westonpace Thanks for the hint. I've fixed it. You may be interested in R related changes after the first push:
@thisisnicthisisnic
mentioned this pull request
Nov 30, 2021
 Closed

@jonkeane
jonkeane
commented
Dec 1, 2021

Copy link


Copy Markdown

Member
This is fantastic, thank you!
There are a few places in dev/tasks/tasks.yml that had bespoke versions of CLANG_TOOLS to get them working that I don't think are needed anymore. I'm happy to push a commit to this branch (I would suggest changes, but GH doesn't let me do that on a file that's not near the diffs)
arrow/dev/tasks/tasks.yml

Line 1205
in
736a69e
CLANG_TOOLS: 9# can remove this when >=9 is the default

arrow/dev/tasks/tasks.yml

Line 1193
in
736a69e
CLANG_TOOLS: 9# can remove this when >=9 is the default
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
26b67c7 to
8ab6937CompareDecember 1, 2021 21:02
@kou
kou
commented
Dec 1, 2021

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-ubuntu-21.04 test-r-gcc-11
@kou
kou
commented
Dec 1, 2021

Copy link


Copy Markdown

MemberAuthor
@jonkeane Good catch! I've removed them.
@github-actions
github-actionsBot
commented
Dec 1, 2021

Copy link


Copy Markdown

Revision: 8ab693734997f4085b50a56318d2ac07dfb8f554
Submitted crossbow builds: ursacomputing/crossbow @ actions-1227
TaskStatus
test-r-gcc-11Github Actions
test-r-ubuntu-21.04Github Actions
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
8ab6937 to
84aa717CompareDecember 1, 2021 23:45
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
84aa717 to
4665516CompareDecember 2, 2021 01:23
@kou
kouforce-pushed
the
cpp-clang-tools-12
branch
from
4665516 to
3ee8213CompareDecember 2, 2021 02:44
@kou
kou
commented
Dec 2, 2021

Copy link


Copy Markdown

MemberAuthor
CI failures are unrelated. This is caused by https://packagemanager.rstudio.com/ . It returns 500.
I'll merge this.
@koukou
closed this
in
f36451fDec 2, 2021
@kou
kou
deleted the

cpp-clang-tools-12

branch
December 2, 2021 05:08
@ursabot
ursabot
commented
Dec 2, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 9ec01da and contender = f36451f. f36451f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.45% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.13% ⬆️0.09%] ursa-thinkcentre-m75q

Supported benchmarks:

ursa-i9-9960x: langs = Python, R, JavaScript

ursa-thinkcentre-m75q: langs = C++, Java

ec2-t3-xlarge-us-east-2: cloud = True
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lidavidmlidavidmlidavidm approved these changes
@westonpacewestonpacewestonpace approved these changes
@pitroupitroupitrou approved these changes
@cyb70289cyb70289cyb70289 approved these changes

Assignees


No one assigned


Labels

Component: C++Component: FlightRPCComponent: GandivaComponent: ParquetComponent: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@kou@mbrobbel@jonkeane@ursabot@lidavidm@westonpace@pitrou@cyb70289