ARROW-14840: [R][CI] test-ubuntu-20.10-docs nightly build failing due to R install issue - #11815

Closed
thisisnic wants to merge 9 commits into
apache:masterfrom
thisisnic:ARROW-14840
Closed

ARROW-14840: [R][CI] test-ubuntu-20.10-docs nightly build failing due to R install issue#11815
thisisnic wants to merge 9 commits into
apache:masterfrom
thisisnic:ARROW-14840

Conversation

@thisisnic

@thisisnicthisisnic commented Nov 30, 2021

Copy link
Copy Markdown
Member

I'm not 100% sure why this fixes this fail, but downgrading the Ubuntu version to 20.04 seems to fix it, and here's my reasoning.

So, apt-key, which is used as part of the R bit of the docs build is now deprecated[1] and Ubuntu 20.10 (Groovy Gorilla) is no longer a supported release as of 22nd July 2021 [2] which can apparently cause issues subsequently trying to do stuff via apt[3].

Reading the R docs for Ubuntu packages[4], it says there that "Package for the current R 4.1. release* are available for most stable Desktop releases of Ubuntu until their official end of life date" which maybe explains why the URL for R packages works fine for focal[5] but results in a 404 error for groovy [6].

The way of getting the signing key for updating packages changed [4] to no longer use apt-key [7] - I have no idea if this had any effect either, but to be on the safe side I have updated that too.

[1] https://manpages.debian.org/testing/apt/apt-key.8.en.html
[2] https://wiki.ubuntu.com/Releases
[3] https://news.itsfoss.com/ubuntu-20-10-end-of-life/
[4] https://cran.r-project.org/bin/linux/ubuntu/
[5] https://cran.r-project.org/bin/linux/ubuntu/focal-cran40/
[6] https://cran.r-project.org/bin/linux/ubuntu/groovy-cran40/
[7] http://web.archive.org/web/20210618164400/https://cloud.r-project.org/bin/linux/ubuntu/

@github-actions

Copy link
Copy Markdown

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-21.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 8804c56

Submitted crossbow builds: ursacomputing/crossbow @ actions-1218

TaskStatus
test-ubuntu-21.04-docsAzure

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 518cb8a

Submitted crossbow builds: ursacomputing/crossbow @ actions-1219

TaskStatus
test-ubuntu-20.04-docsAzure

@thisisnic

Copy link
Copy Markdown
MemberAuthor

Alternatively, we could move to 21.04 after #11786 has merged

@pitrou
pitrou requested a review from kszucsNovember 30, 2021 17:58
@jonkeane

Copy link
Copy Markdown
Member

Whoa fantastic debugging and puzzle-piece-putting together here.

So, apt-key, which is used as part of the R bit of the docs build is now deprecated[1] and Ubuntu 20.10 (Groovy Gorilla) is no longer a supported release as of 22nd July 2021 [2] which can apparently cause issues subsequently trying to do stuff via apt[3].

This now makes so much sense now. I'm fine with waiting for the Clang fix and then bumping to 21.04 (or 21.10??). Also, we could add CLANG_TOOLS: 9 or CLANG_TOOLS: 11 to the task and bump now like we do for a few others

FWIW, https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1219-azure-test-ubuntu-20.04-docs looks unrelated to the R package stuff (though I suspect the R package issues masked when this was introduced):

+ sphinx-build -b html -j 2 /arrow/docs/source /build/docs
Running Sphinx v3.5.4
Extension error:
Could not import extension sphinx_tabs.tabs (exception: No module named 'sphinx_tabs')
2
Error: `docker-compose --file /home/vsts/work/1/s/arrow/docker-compose.yml run --rm -e SETUPTOOLS_SCM_PRETEND_VERSION=7.0.0.dev219 ubuntu-docs` exited with a non-zero exit code 2, see the process log above.

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 9ab33be

Submitted crossbow builds: ursacomputing/crossbow @ actions-1222

TaskStatus
test-ubuntu-20.04-docsAzure

Comment threaddev/tasks/tasks.yml Outdated
params:
env:
UBUNTU: "20.10"
UBUNTU: "20.04"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-ubuntu-default-docs already uses Ubuntu 20.04.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Given that this additional job was introduced in #10430 and things have moved on since then, I've removed the extra job. Or should I add it back in and pin it to a different version? It'd be good to know your thoughts too @jonkeane as you were the author of the PR I mentioned above and I don't fully understand everything that's going on there.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, I introduced test-ubuntu-default-docs because we started being unable to build docs on 20.04 (and that inability wasn't noticed cause we were only testing 20.10 before this)

It looks like the 20.10 build was changed from a much older one in #9933.

I'm not sure what the purpose of having a default build and then a separate build on a non-default version is. The one reason I can think of is that we want the non-default version to be a test of a new(ish) ubuntu version, to check for issues there. If that is the case (and we want to maintain that), we probably should build on 21.04 or 21.10. But I'm also totally fine removing the non-default docs build if it's more hassle than is helpful to maintain it.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sounds like it made sense at the time but no longer serves a specific purpose, so unless there's any other reason to keep it in, let's leave it out for now (and add it back in if necessary later).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We chose Ubuntu 20.10 to reduce build time by using system gRPC: #9933 (review)

I'm OK with removing the docs job with non default UBUNTU version.

Could you also remove UBUNTU=20.10 from dev/release/post-09-docs.sh and ci/docker/ubuntu-20.10-cpp.dockerfile file?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, thanks for clarifying that @kou! Just to check my understanding, did you mean remove the reference to 20.10 in dev/release/post-09-docs.sh but entirely remove the file ci/docker/ubuntu-20.10-cpp.dockerfile as no other tasks depend on this now?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Comment threadci/docker/linux-apt-docs.dockerfile
Comment threadci/docker/linux-apt-docs.dockerfile Outdated

@jonkeanejonkeane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ursabot

ursabot commented Dec 1, 2021

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 5227f24 and contender = 736a69e. 736a69e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thisisnic@jonkeane@ursabot@kou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

ARROW-14840: [R][CI] test-ubuntu-20.10-docs nightly build failing due to R install issue - #11815

Closed
thisisnic wants to merge 9 commits into
apache:masterfrom
thisisnic:ARROW-14840
Closed

ARROW-14840: [R][CI] test-ubuntu-20.10-docs nightly build failing due to R install issue#11815
thisisnic wants to merge 9 commits into
apache:masterfrom
thisisnic:ARROW-14840

Conversation

@thisisnic

@thisisnicthisisnic commented Nov 30, 2021

Copy link
Copy Markdown
Member

I'm not 100% sure why this fixes this fail, but downgrading the Ubuntu version to 20.04 seems to fix it, and here's my reasoning.

So, apt-key, which is used as part of the R bit of the docs build is now deprecated[1] and Ubuntu 20.10 (Groovy Gorilla) is no longer a supported release as of 22nd July 2021 [2] which can apparently cause issues subsequently trying to do stuff via apt[3].

Reading the R docs for Ubuntu packages[4], it says there that "Package for the current R 4.1. release* are available for most stable Desktop releases of Ubuntu until their official end of life date" which maybe explains why the URL for R packages works fine for focal[5] but results in a 404 error for groovy [6].

The way of getting the signing key for updating packages changed [4] to no longer use apt-key [7] - I have no idea if this had any effect either, but to be on the safe side I have updated that too.

[1] https://manpages.debian.org/testing/apt/apt-key.8.en.html
[2] https://wiki.ubuntu.com/Releases
[3] https://news.itsfoss.com/ubuntu-20-10-end-of-life/
[4] https://cran.r-project.org/bin/linux/ubuntu/
[5] https://cran.r-project.org/bin/linux/ubuntu/focal-cran40/
[6] https://cran.r-project.org/bin/linux/ubuntu/groovy-cran40/
[7] http://web.archive.org/web/20210618164400/https://cloud.r-project.org/bin/linux/ubuntu/

@github-actions

Copy link
Copy Markdown

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-21.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 8804c56

Submitted crossbow builds: ursacomputing/crossbow @ actions-1218

TaskStatus
test-ubuntu-21.04-docsAzure

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 518cb8a

Submitted crossbow builds: ursacomputing/crossbow @ actions-1219

TaskStatus
test-ubuntu-20.04-docsAzure

@thisisnic

Copy link
Copy Markdown
MemberAuthor

Alternatively, we could move to 21.04 after #11786 has merged

@pitrou
pitrou requested a review from kszucsNovember 30, 2021 17:58
@jonkeane

Copy link
Copy Markdown
Member

Whoa fantastic debugging and puzzle-piece-putting together here.

So, apt-key, which is used as part of the R bit of the docs build is now deprecated[1] and Ubuntu 20.10 (Groovy Gorilla) is no longer a supported release as of 22nd July 2021 [2] which can apparently cause issues subsequently trying to do stuff via apt[3].

This now makes so much sense now. I'm fine with waiting for the Clang fix and then bumping to 21.04 (or 21.10??). Also, we could add CLANG_TOOLS: 9 or CLANG_TOOLS: 11 to the task and bump now like we do for a few others

FWIW, https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1219-azure-test-ubuntu-20.04-docs looks unrelated to the R package stuff (though I suspect the R package issues masked when this was introduced):

+ sphinx-build -b html -j 2 /arrow/docs/source /build/docs
Running Sphinx v3.5.4
Extension error:
Could not import extension sphinx_tabs.tabs (exception: No module named 'sphinx_tabs')
2
Error: `docker-compose --file /home/vsts/work/1/s/arrow/docker-compose.yml run --rm -e SETUPTOOLS_SCM_PRETEND_VERSION=7.0.0.dev219 ubuntu-docs` exited with a non-zero exit code 2, see the process log above.

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 9ab33be

Submitted crossbow builds: ursacomputing/crossbow @ actions-1222

TaskStatus
test-ubuntu-20.04-docsAzure

Comment threaddev/tasks/tasks.yml Outdated
params:
env:
UBUNTU: "20.10"
UBUNTU: "20.04"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-ubuntu-default-docs already uses Ubuntu 20.04.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Given that this additional job was introduced in #10430 and things have moved on since then, I've removed the extra job. Or should I add it back in and pin it to a different version? It'd be good to know your thoughts too @jonkeane as you were the author of the PR I mentioned above and I don't fully understand everything that's going on there.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, I introduced test-ubuntu-default-docs because we started being unable to build docs on 20.04 (and that inability wasn't noticed cause we were only testing 20.10 before this)

It looks like the 20.10 build was changed from a much older one in #9933.

I'm not sure what the purpose of having a default build and then a separate build on a non-default version is. The one reason I can think of is that we want the non-default version to be a test of a new(ish) ubuntu version, to check for issues there. If that is the case (and we want to maintain that), we probably should build on 21.04 or 21.10. But I'm also totally fine removing the non-default docs build if it's more hassle than is helpful to maintain it.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sounds like it made sense at the time but no longer serves a specific purpose, so unless there's any other reason to keep it in, let's leave it out for now (and add it back in if necessary later).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We chose Ubuntu 20.10 to reduce build time by using system gRPC: #9933 (review)

I'm OK with removing the docs job with non default UBUNTU version.

Could you also remove UBUNTU=20.10 from dev/release/post-09-docs.sh and ci/docker/ubuntu-20.10-cpp.dockerfile file?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, thanks for clarifying that @kou! Just to check my understanding, did you mean remove the reference to 20.10 in dev/release/post-09-docs.sh but entirely remove the file ci/docker/ubuntu-20.10-cpp.dockerfile as no other tasks depend on this now?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Comment threadci/docker/linux-apt-docs.dockerfile
Comment threadci/docker/linux-apt-docs.dockerfile Outdated

@jonkeanejonkeane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ursabot

ursabot commented Dec 1, 2021

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 5227f24 and contender = 736a69e. 736a69e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thisisnic@jonkeane@ursabot@kou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ARROW-14840: [R][CI] test-ubuntu-20.10-docs nightly build failing due to R install issue - #11815

Closed
thisisnic wants to merge 9 commits into
apache:masterfrom
thisisnic:ARROW-14840
Closed

ARROW-14840: [R][CI] test-ubuntu-20.10-docs nightly build failing due to R install issue#11815
thisisnic wants to merge 9 commits into
apache:masterfrom
thisisnic:ARROW-14840

Conversation

@thisisnic

@thisisnicthisisnic commented Nov 30, 2021

Copy link
Copy Markdown
Member

I'm not 100% sure why this fixes this fail, but downgrading the Ubuntu version to 20.04 seems to fix it, and here's my reasoning.

So, apt-key, which is used as part of the R bit of the docs build is now deprecated[1] and Ubuntu 20.10 (Groovy Gorilla) is no longer a supported release as of 22nd July 2021 [2] which can apparently cause issues subsequently trying to do stuff via apt[3].

Reading the R docs for Ubuntu packages[4], it says there that "Package for the current R 4.1. release* are available for most stable Desktop releases of Ubuntu until their official end of life date" which maybe explains why the URL for R packages works fine for focal[5] but results in a 404 error for groovy [6].

The way of getting the signing key for updating packages changed [4] to no longer use apt-key [7] - I have no idea if this had any effect either, but to be on the safe side I have updated that too.

[1] https://manpages.debian.org/testing/apt/apt-key.8.en.html
[2] https://wiki.ubuntu.com/Releases
[3] https://news.itsfoss.com/ubuntu-20-10-end-of-life/
[4] https://cran.r-project.org/bin/linux/ubuntu/
[5] https://cran.r-project.org/bin/linux/ubuntu/focal-cran40/
[6] https://cran.r-project.org/bin/linux/ubuntu/groovy-cran40/
[7] http://web.archive.org/web/20210618164400/https://cloud.r-project.org/bin/linux/ubuntu/

@github-actions

Copy link
Copy Markdown

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-21.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 8804c56

Submitted crossbow builds: ursacomputing/crossbow @ actions-1218

TaskStatus
test-ubuntu-21.04-docsAzure

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 518cb8a

Submitted crossbow builds: ursacomputing/crossbow @ actions-1219

TaskStatus
test-ubuntu-20.04-docsAzure

@thisisnic

Copy link
Copy Markdown
MemberAuthor

Alternatively, we could move to 21.04 after #11786 has merged

@pitrou
pitrou requested a review from kszucsNovember 30, 2021 17:58
@jonkeane

Copy link
Copy Markdown
Member

Whoa fantastic debugging and puzzle-piece-putting together here.

So, apt-key, which is used as part of the R bit of the docs build is now deprecated[1] and Ubuntu 20.10 (Groovy Gorilla) is no longer a supported release as of 22nd July 2021 [2] which can apparently cause issues subsequently trying to do stuff via apt[3].

This now makes so much sense now. I'm fine with waiting for the Clang fix and then bumping to 21.04 (or 21.10??). Also, we could add CLANG_TOOLS: 9 or CLANG_TOOLS: 11 to the task and bump now like we do for a few others

FWIW, https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1219-azure-test-ubuntu-20.04-docs looks unrelated to the R package stuff (though I suspect the R package issues masked when this was introduced):

+ sphinx-build -b html -j 2 /arrow/docs/source /build/docs
Running Sphinx v3.5.4
Extension error:
Could not import extension sphinx_tabs.tabs (exception: No module named 'sphinx_tabs')
2
Error: `docker-compose --file /home/vsts/work/1/s/arrow/docker-compose.yml run --rm -e SETUPTOOLS_SCM_PRETEND_VERSION=7.0.0.dev219 ubuntu-docs` exited with a non-zero exit code 2, see the process log above.

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 9ab33be

Submitted crossbow builds: ursacomputing/crossbow @ actions-1222

TaskStatus
test-ubuntu-20.04-docsAzure

Comment threaddev/tasks/tasks.yml Outdated
params:
env:
UBUNTU: "20.10"
UBUNTU: "20.04"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-ubuntu-default-docs already uses Ubuntu 20.04.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Given that this additional job was introduced in #10430 and things have moved on since then, I've removed the extra job. Or should I add it back in and pin it to a different version? It'd be good to know your thoughts too @jonkeane as you were the author of the PR I mentioned above and I don't fully understand everything that's going on there.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, I introduced test-ubuntu-default-docs because we started being unable to build docs on 20.04 (and that inability wasn't noticed cause we were only testing 20.10 before this)

It looks like the 20.10 build was changed from a much older one in #9933.

I'm not sure what the purpose of having a default build and then a separate build on a non-default version is. The one reason I can think of is that we want the non-default version to be a test of a new(ish) ubuntu version, to check for issues there. If that is the case (and we want to maintain that), we probably should build on 21.04 or 21.10. But I'm also totally fine removing the non-default docs build if it's more hassle than is helpful to maintain it.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sounds like it made sense at the time but no longer serves a specific purpose, so unless there's any other reason to keep it in, let's leave it out for now (and add it back in if necessary later).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We chose Ubuntu 20.10 to reduce build time by using system gRPC: #9933 (review)

I'm OK with removing the docs job with non default UBUNTU version.

Could you also remove UBUNTU=20.10 from dev/release/post-09-docs.sh and ci/docker/ubuntu-20.10-cpp.dockerfile file?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, thanks for clarifying that @kou! Just to check my understanding, did you mean remove the reference to 20.10 in dev/release/post-09-docs.sh but entirely remove the file ci/docker/ubuntu-20.10-cpp.dockerfile as no other tasks depend on this now?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Comment threadci/docker/linux-apt-docs.dockerfile
Comment threadci/docker/linux-apt-docs.dockerfile Outdated

@jonkeanejonkeane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ursabot

ursabot commented Dec 1, 2021

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 5227f24 and contender = 736a69e. 736a69e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thisisnic@jonkeane@ursabot@kou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ARROW-14840: [R][CI] test-ubuntu-20.10-docs nightly build failing due to R install issue - #11815

Closed
thisisnic wants to merge 9 commits into
apache:masterfrom
thisisnic:ARROW-14840
Closed

ARROW-14840: [R][CI] test-ubuntu-20.10-docs nightly build failing due to R install issue#11815
thisisnic wants to merge 9 commits into
apache:masterfrom
thisisnic:ARROW-14840

Conversation

@thisisnic

@thisisnicthisisnic commented Nov 30, 2021

Copy link
Copy Markdown
Member

I'm not 100% sure why this fixes this fail, but downgrading the Ubuntu version to 20.04 seems to fix it, and here's my reasoning.

So, apt-key, which is used as part of the R bit of the docs build is now deprecated[1] and Ubuntu 20.10 (Groovy Gorilla) is no longer a supported release as of 22nd July 2021 [2] which can apparently cause issues subsequently trying to do stuff via apt[3].

Reading the R docs for Ubuntu packages[4], it says there that "Package for the current R 4.1. release* are available for most stable Desktop releases of Ubuntu until their official end of life date" which maybe explains why the URL for R packages works fine for focal[5] but results in a 404 error for groovy [6].

The way of getting the signing key for updating packages changed [4] to no longer use apt-key [7] - I have no idea if this had any effect either, but to be on the safe side I have updated that too.

[1] https://manpages.debian.org/testing/apt/apt-key.8.en.html
[2] https://wiki.ubuntu.com/Releases
[3] https://news.itsfoss.com/ubuntu-20-10-end-of-life/
[4] https://cran.r-project.org/bin/linux/ubuntu/
[5] https://cran.r-project.org/bin/linux/ubuntu/focal-cran40/
[6] https://cran.r-project.org/bin/linux/ubuntu/groovy-cran40/
[7] http://web.archive.org/web/20210618164400/https://cloud.r-project.org/bin/linux/ubuntu/

@github-actions

Copy link
Copy Markdown

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-21.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 8804c56

Submitted crossbow builds: ursacomputing/crossbow @ actions-1218

TaskStatus
test-ubuntu-21.04-docsAzure

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 518cb8a

Submitted crossbow builds: ursacomputing/crossbow @ actions-1219

TaskStatus
test-ubuntu-20.04-docsAzure

@thisisnic

Copy link
Copy Markdown
MemberAuthor

Alternatively, we could move to 21.04 after #11786 has merged

@pitrou
pitrou requested a review from kszucsNovember 30, 2021 17:58
@jonkeane

Copy link
Copy Markdown
Member

Whoa fantastic debugging and puzzle-piece-putting together here.

So, apt-key, which is used as part of the R bit of the docs build is now deprecated[1] and Ubuntu 20.10 (Groovy Gorilla) is no longer a supported release as of 22nd July 2021 [2] which can apparently cause issues subsequently trying to do stuff via apt[3].

This now makes so much sense now. I'm fine with waiting for the Clang fix and then bumping to 21.04 (or 21.10??). Also, we could add CLANG_TOOLS: 9 or CLANG_TOOLS: 11 to the task and bump now like we do for a few others

FWIW, https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1219-azure-test-ubuntu-20.04-docs looks unrelated to the R package stuff (though I suspect the R package issues masked when this was introduced):

+ sphinx-build -b html -j 2 /arrow/docs/source /build/docs
Running Sphinx v3.5.4
Extension error:
Could not import extension sphinx_tabs.tabs (exception: No module named 'sphinx_tabs')
2
Error: `docker-compose --file /home/vsts/work/1/s/arrow/docker-compose.yml run --rm -e SETUPTOOLS_SCM_PRETEND_VERSION=7.0.0.dev219 ubuntu-docs` exited with a non-zero exit code 2, see the process log above.

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 9ab33be

Submitted crossbow builds: ursacomputing/crossbow @ actions-1222

TaskStatus
test-ubuntu-20.04-docsAzure

Comment threaddev/tasks/tasks.yml Outdated
params:
env:
UBUNTU: "20.10"
UBUNTU: "20.04"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-ubuntu-default-docs already uses Ubuntu 20.04.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Given that this additional job was introduced in #10430 and things have moved on since then, I've removed the extra job. Or should I add it back in and pin it to a different version? It'd be good to know your thoughts too @jonkeane as you were the author of the PR I mentioned above and I don't fully understand everything that's going on there.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, I introduced test-ubuntu-default-docs because we started being unable to build docs on 20.04 (and that inability wasn't noticed cause we were only testing 20.10 before this)

It looks like the 20.10 build was changed from a much older one in #9933.

I'm not sure what the purpose of having a default build and then a separate build on a non-default version is. The one reason I can think of is that we want the non-default version to be a test of a new(ish) ubuntu version, to check for issues there. If that is the case (and we want to maintain that), we probably should build on 21.04 or 21.10. But I'm also totally fine removing the non-default docs build if it's more hassle than is helpful to maintain it.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sounds like it made sense at the time but no longer serves a specific purpose, so unless there's any other reason to keep it in, let's leave it out for now (and add it back in if necessary later).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We chose Ubuntu 20.10 to reduce build time by using system gRPC: #9933 (review)

I'm OK with removing the docs job with non default UBUNTU version.

Could you also remove UBUNTU=20.10 from dev/release/post-09-docs.sh and ci/docker/ubuntu-20.10-cpp.dockerfile file?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, thanks for clarifying that @kou! Just to check my understanding, did you mean remove the reference to 20.10 in dev/release/post-09-docs.sh but entirely remove the file ci/docker/ubuntu-20.10-cpp.dockerfile as no other tasks depend on this now?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Comment threadci/docker/linux-apt-docs.dockerfile
Comment threadci/docker/linux-apt-docs.dockerfile Outdated

@jonkeanejonkeane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ursabot

ursabot commented Dec 1, 2021

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 5227f24 and contender = 736a69e. 736a69e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thisisnic@jonkeane@ursabot@kou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

ARROW-14840: [R][CI] test-ubuntu-20.10-docs nightly build failing due to R install issue - #11815

Closed
thisisnic wants to merge 9 commits into
apache:masterfrom
thisisnic:ARROW-14840
Closed

ARROW-14840: [R][CI] test-ubuntu-20.10-docs nightly build failing due to R install issue#11815
thisisnic wants to merge 9 commits into
apache:masterfrom
thisisnic:ARROW-14840

Conversation

@thisisnic

@thisisnicthisisnic commented Nov 30, 2021

Copy link
Copy Markdown
Member

I'm not 100% sure why this fixes this fail, but downgrading the Ubuntu version to 20.04 seems to fix it, and here's my reasoning.

So, apt-key, which is used as part of the R bit of the docs build is now deprecated[1] and Ubuntu 20.10 (Groovy Gorilla) is no longer a supported release as of 22nd July 2021 [2] which can apparently cause issues subsequently trying to do stuff via apt[3].

Reading the R docs for Ubuntu packages[4], it says there that "Package for the current R 4.1. release* are available for most stable Desktop releases of Ubuntu until their official end of life date" which maybe explains why the URL for R packages works fine for focal[5] but results in a 404 error for groovy [6].

The way of getting the signing key for updating packages changed [4] to no longer use apt-key [7] - I have no idea if this had any effect either, but to be on the safe side I have updated that too.

[1] https://manpages.debian.org/testing/apt/apt-key.8.en.html
[2] https://wiki.ubuntu.com/Releases
[3] https://news.itsfoss.com/ubuntu-20-10-end-of-life/
[4] https://cran.r-project.org/bin/linux/ubuntu/
[5] https://cran.r-project.org/bin/linux/ubuntu/focal-cran40/
[6] https://cran.r-project.org/bin/linux/ubuntu/groovy-cran40/
[7] http://web.archive.org/web/20210618164400/https://cloud.r-project.org/bin/linux/ubuntu/

@github-actions

Copy link
Copy Markdown

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-21.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 8804c56

Submitted crossbow builds: ursacomputing/crossbow @ actions-1218

TaskStatus
test-ubuntu-21.04-docsAzure

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 518cb8a

Submitted crossbow builds: ursacomputing/crossbow @ actions-1219

TaskStatus
test-ubuntu-20.04-docsAzure

@thisisnic

Copy link
Copy Markdown
MemberAuthor

Alternatively, we could move to 21.04 after #11786 has merged

@pitrou
pitrou requested a review from kszucsNovember 30, 2021 17:58
@jonkeane

Copy link
Copy Markdown
Member

Whoa fantastic debugging and puzzle-piece-putting together here.

So, apt-key, which is used as part of the R bit of the docs build is now deprecated[1] and Ubuntu 20.10 (Groovy Gorilla) is no longer a supported release as of 22nd July 2021 [2] which can apparently cause issues subsequently trying to do stuff via apt[3].

This now makes so much sense now. I'm fine with waiting for the Clang fix and then bumping to 21.04 (or 21.10??). Also, we could add CLANG_TOOLS: 9 or CLANG_TOOLS: 11 to the task and bump now like we do for a few others

FWIW, https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1219-azure-test-ubuntu-20.04-docs looks unrelated to the R package stuff (though I suspect the R package issues masked when this was introduced):

+ sphinx-build -b html -j 2 /arrow/docs/source /build/docs
Running Sphinx v3.5.4
Extension error:
Could not import extension sphinx_tabs.tabs (exception: No module named 'sphinx_tabs')
2
Error: `docker-compose --file /home/vsts/work/1/s/arrow/docker-compose.yml run --rm -e SETUPTOOLS_SCM_PRETEND_VERSION=7.0.0.dev219 ubuntu-docs` exited with a non-zero exit code 2, see the process log above.

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 9ab33be

Submitted crossbow builds: ursacomputing/crossbow @ actions-1222

TaskStatus
test-ubuntu-20.04-docsAzure

Comment threaddev/tasks/tasks.yml Outdated
params:
env:
UBUNTU: "20.10"
UBUNTU: "20.04"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-ubuntu-default-docs already uses Ubuntu 20.04.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Given that this additional job was introduced in #10430 and things have moved on since then, I've removed the extra job. Or should I add it back in and pin it to a different version? It'd be good to know your thoughts too @jonkeane as you were the author of the PR I mentioned above and I don't fully understand everything that's going on there.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, I introduced test-ubuntu-default-docs because we started being unable to build docs on 20.04 (and that inability wasn't noticed cause we were only testing 20.10 before this)

It looks like the 20.10 build was changed from a much older one in #9933.

I'm not sure what the purpose of having a default build and then a separate build on a non-default version is. The one reason I can think of is that we want the non-default version to be a test of a new(ish) ubuntu version, to check for issues there. If that is the case (and we want to maintain that), we probably should build on 21.04 or 21.10. But I'm also totally fine removing the non-default docs build if it's more hassle than is helpful to maintain it.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sounds like it made sense at the time but no longer serves a specific purpose, so unless there's any other reason to keep it in, let's leave it out for now (and add it back in if necessary later).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We chose Ubuntu 20.10 to reduce build time by using system gRPC: #9933 (review)

I'm OK with removing the docs job with non default UBUNTU version.

Could you also remove UBUNTU=20.10 from dev/release/post-09-docs.sh and ci/docker/ubuntu-20.10-cpp.dockerfile file?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, thanks for clarifying that @kou! Just to check my understanding, did you mean remove the reference to 20.10 in dev/release/post-09-docs.sh but entirely remove the file ci/docker/ubuntu-20.10-cpp.dockerfile as no other tasks depend on this now?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Comment threadci/docker/linux-apt-docs.dockerfile
Comment threadci/docker/linux-apt-docs.dockerfile Outdated

@jonkeanejonkeane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ursabot

ursabot commented Dec 1, 2021

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 5227f24 and contender = 736a69e. 736a69e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thisisnic@jonkeane@ursabot@kou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ARROW-14840: [R][CI] test-ubuntu-20.10-docs nightly build failing due to R install issue - #11815

Closed
thisisnic wants to merge 9 commits into
apache:masterfrom
thisisnic:ARROW-14840
Closed

ARROW-14840: [R][CI] test-ubuntu-20.10-docs nightly build failing due to R install issue#11815
thisisnic wants to merge 9 commits into
apache:masterfrom
thisisnic:ARROW-14840

Conversation

@thisisnic

@thisisnicthisisnic commented Nov 30, 2021

Copy link
Copy Markdown
Member

I'm not 100% sure why this fixes this fail, but downgrading the Ubuntu version to 20.04 seems to fix it, and here's my reasoning.

So, apt-key, which is used as part of the R bit of the docs build is now deprecated[1] and Ubuntu 20.10 (Groovy Gorilla) is no longer a supported release as of 22nd July 2021 [2] which can apparently cause issues subsequently trying to do stuff via apt[3].

Reading the R docs for Ubuntu packages[4], it says there that "Package for the current R 4.1. release* are available for most stable Desktop releases of Ubuntu until their official end of life date" which maybe explains why the URL for R packages works fine for focal[5] but results in a 404 error for groovy [6].

The way of getting the signing key for updating packages changed [4] to no longer use apt-key [7] - I have no idea if this had any effect either, but to be on the safe side I have updated that too.

[1] https://manpages.debian.org/testing/apt/apt-key.8.en.html
[2] https://wiki.ubuntu.com/Releases
[3] https://news.itsfoss.com/ubuntu-20-10-end-of-life/
[4] https://cran.r-project.org/bin/linux/ubuntu/
[5] https://cran.r-project.org/bin/linux/ubuntu/focal-cran40/
[6] https://cran.r-project.org/bin/linux/ubuntu/groovy-cran40/
[7] http://web.archive.org/web/20210618164400/https://cloud.r-project.org/bin/linux/ubuntu/

@github-actions

Copy link
Copy Markdown

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-21.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 8804c56

Submitted crossbow builds: ursacomputing/crossbow @ actions-1218

TaskStatus
test-ubuntu-21.04-docsAzure

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 518cb8a

Submitted crossbow builds: ursacomputing/crossbow @ actions-1219

TaskStatus
test-ubuntu-20.04-docsAzure

@thisisnic

Copy link
Copy Markdown
MemberAuthor

Alternatively, we could move to 21.04 after #11786 has merged

@pitrou
pitrou requested a review from kszucsNovember 30, 2021 17:58
@jonkeane

Copy link
Copy Markdown
Member

Whoa fantastic debugging and puzzle-piece-putting together here.

So, apt-key, which is used as part of the R bit of the docs build is now deprecated[1] and Ubuntu 20.10 (Groovy Gorilla) is no longer a supported release as of 22nd July 2021 [2] which can apparently cause issues subsequently trying to do stuff via apt[3].

This now makes so much sense now. I'm fine with waiting for the Clang fix and then bumping to 21.04 (or 21.10??). Also, we could add CLANG_TOOLS: 9 or CLANG_TOOLS: 11 to the task and bump now like we do for a few others

FWIW, https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1219-azure-test-ubuntu-20.04-docs looks unrelated to the R package stuff (though I suspect the R package issues masked when this was introduced):

+ sphinx-build -b html -j 2 /arrow/docs/source /build/docs
Running Sphinx v3.5.4
Extension error:
Could not import extension sphinx_tabs.tabs (exception: No module named 'sphinx_tabs')
2
Error: `docker-compose --file /home/vsts/work/1/s/arrow/docker-compose.yml run --rm -e SETUPTOOLS_SCM_PRETEND_VERSION=7.0.0.dev219 ubuntu-docs` exited with a non-zero exit code 2, see the process log above.

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 9ab33be

Submitted crossbow builds: ursacomputing/crossbow @ actions-1222

TaskStatus
test-ubuntu-20.04-docsAzure

Comment threaddev/tasks/tasks.yml Outdated
params:
env:
UBUNTU: "20.10"
UBUNTU: "20.04"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-ubuntu-default-docs already uses Ubuntu 20.04.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Given that this additional job was introduced in #10430 and things have moved on since then, I've removed the extra job. Or should I add it back in and pin it to a different version? It'd be good to know your thoughts too @jonkeane as you were the author of the PR I mentioned above and I don't fully understand everything that's going on there.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, I introduced test-ubuntu-default-docs because we started being unable to build docs on 20.04 (and that inability wasn't noticed cause we were only testing 20.10 before this)

It looks like the 20.10 build was changed from a much older one in #9933.

I'm not sure what the purpose of having a default build and then a separate build on a non-default version is. The one reason I can think of is that we want the non-default version to be a test of a new(ish) ubuntu version, to check for issues there. If that is the case (and we want to maintain that), we probably should build on 21.04 or 21.10. But I'm also totally fine removing the non-default docs build if it's more hassle than is helpful to maintain it.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sounds like it made sense at the time but no longer serves a specific purpose, so unless there's any other reason to keep it in, let's leave it out for now (and add it back in if necessary later).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We chose Ubuntu 20.10 to reduce build time by using system gRPC: #9933 (review)

I'm OK with removing the docs job with non default UBUNTU version.

Could you also remove UBUNTU=20.10 from dev/release/post-09-docs.sh and ci/docker/ubuntu-20.10-cpp.dockerfile file?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, thanks for clarifying that @kou! Just to check my understanding, did you mean remove the reference to 20.10 in dev/release/post-09-docs.sh but entirely remove the file ci/docker/ubuntu-20.10-cpp.dockerfile as no other tasks depend on this now?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Comment threadci/docker/linux-apt-docs.dockerfile
Comment threadci/docker/linux-apt-docs.dockerfile Outdated

@jonkeanejonkeane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ursabot

ursabot commented Dec 1, 2021

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 5227f24 and contender = 736a69e. 736a69e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thisisnic@jonkeane@ursabot@kou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ARROW-14840: [R][CI] test-ubuntu-20.10-docs nightly build failing due to R install issue - #11815

Closed
thisisnic wants to merge 9 commits into
apache:masterfrom
thisisnic:ARROW-14840
Closed

ARROW-14840: [R][CI] test-ubuntu-20.10-docs nightly build failing due to R install issue#11815
thisisnic wants to merge 9 commits into
apache:masterfrom
thisisnic:ARROW-14840

Conversation

@thisisnic

@thisisnicthisisnic commented Nov 30, 2021

Copy link
Copy Markdown
Member

I'm not 100% sure why this fixes this fail, but downgrading the Ubuntu version to 20.04 seems to fix it, and here's my reasoning.

So, apt-key, which is used as part of the R bit of the docs build is now deprecated[1] and Ubuntu 20.10 (Groovy Gorilla) is no longer a supported release as of 22nd July 2021 [2] which can apparently cause issues subsequently trying to do stuff via apt[3].

Reading the R docs for Ubuntu packages[4], it says there that "Package for the current R 4.1. release* are available for most stable Desktop releases of Ubuntu until their official end of life date" which maybe explains why the URL for R packages works fine for focal[5] but results in a 404 error for groovy [6].

The way of getting the signing key for updating packages changed [4] to no longer use apt-key [7] - I have no idea if this had any effect either, but to be on the safe side I have updated that too.

[1] https://manpages.debian.org/testing/apt/apt-key.8.en.html
[2] https://wiki.ubuntu.com/Releases
[3] https://news.itsfoss.com/ubuntu-20-10-end-of-life/
[4] https://cran.r-project.org/bin/linux/ubuntu/
[5] https://cran.r-project.org/bin/linux/ubuntu/focal-cran40/
[6] https://cran.r-project.org/bin/linux/ubuntu/groovy-cran40/
[7] http://web.archive.org/web/20210618164400/https://cloud.r-project.org/bin/linux/ubuntu/

@github-actions

Copy link
Copy Markdown

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-21.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 8804c56

Submitted crossbow builds: ursacomputing/crossbow @ actions-1218

TaskStatus
test-ubuntu-21.04-docsAzure

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 518cb8a

Submitted crossbow builds: ursacomputing/crossbow @ actions-1219

TaskStatus
test-ubuntu-20.04-docsAzure

@thisisnic

Copy link
Copy Markdown
MemberAuthor

Alternatively, we could move to 21.04 after #11786 has merged

@pitrou
pitrou requested a review from kszucsNovember 30, 2021 17:58
@jonkeane

Copy link
Copy Markdown
Member

Whoa fantastic debugging and puzzle-piece-putting together here.

So, apt-key, which is used as part of the R bit of the docs build is now deprecated[1] and Ubuntu 20.10 (Groovy Gorilla) is no longer a supported release as of 22nd July 2021 [2] which can apparently cause issues subsequently trying to do stuff via apt[3].

This now makes so much sense now. I'm fine with waiting for the Clang fix and then bumping to 21.04 (or 21.10??). Also, we could add CLANG_TOOLS: 9 or CLANG_TOOLS: 11 to the task and bump now like we do for a few others

FWIW, https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1219-azure-test-ubuntu-20.04-docs looks unrelated to the R package stuff (though I suspect the R package issues masked when this was introduced):

+ sphinx-build -b html -j 2 /arrow/docs/source /build/docs
Running Sphinx v3.5.4
Extension error:
Could not import extension sphinx_tabs.tabs (exception: No module named 'sphinx_tabs')
2
Error: `docker-compose --file /home/vsts/work/1/s/arrow/docker-compose.yml run --rm -e SETUPTOOLS_SCM_PRETEND_VERSION=7.0.0.dev219 ubuntu-docs` exited with a non-zero exit code 2, see the process log above.

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 9ab33be

Submitted crossbow builds: ursacomputing/crossbow @ actions-1222

TaskStatus
test-ubuntu-20.04-docsAzure

Comment threaddev/tasks/tasks.yml Outdated
params:
env:
UBUNTU: "20.10"
UBUNTU: "20.04"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-ubuntu-default-docs already uses Ubuntu 20.04.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Given that this additional job was introduced in #10430 and things have moved on since then, I've removed the extra job. Or should I add it back in and pin it to a different version? It'd be good to know your thoughts too @jonkeane as you were the author of the PR I mentioned above and I don't fully understand everything that's going on there.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, I introduced test-ubuntu-default-docs because we started being unable to build docs on 20.04 (and that inability wasn't noticed cause we were only testing 20.10 before this)

It looks like the 20.10 build was changed from a much older one in #9933.

I'm not sure what the purpose of having a default build and then a separate build on a non-default version is. The one reason I can think of is that we want the non-default version to be a test of a new(ish) ubuntu version, to check for issues there. If that is the case (and we want to maintain that), we probably should build on 21.04 or 21.10. But I'm also totally fine removing the non-default docs build if it's more hassle than is helpful to maintain it.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sounds like it made sense at the time but no longer serves a specific purpose, so unless there's any other reason to keep it in, let's leave it out for now (and add it back in if necessary later).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We chose Ubuntu 20.10 to reduce build time by using system gRPC: #9933 (review)

I'm OK with removing the docs job with non default UBUNTU version.

Could you also remove UBUNTU=20.10 from dev/release/post-09-docs.sh and ci/docker/ubuntu-20.10-cpp.dockerfile file?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, thanks for clarifying that @kou! Just to check my understanding, did you mean remove the reference to 20.10 in dev/release/post-09-docs.sh but entirely remove the file ci/docker/ubuntu-20.10-cpp.dockerfile as no other tasks depend on this now?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Comment threadci/docker/linux-apt-docs.dockerfile
Comment threadci/docker/linux-apt-docs.dockerfile Outdated

@jonkeanejonkeane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ursabot

ursabot commented Dec 1, 2021

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 5227f24 and contender = 736a69e. 736a69e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thisisnic@jonkeane@ursabot@kou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

ARROW-14840: [R][CI] test-ubuntu-20.10-docs nightly build failing due to R install issue - #11815

Closed
thisisnic wants to merge 9 commits into
apache:masterfrom
thisisnic:ARROW-14840
Closed

ARROW-14840: [R][CI] test-ubuntu-20.10-docs nightly build failing due to R install issue#11815
thisisnic wants to merge 9 commits into
apache:masterfrom
thisisnic:ARROW-14840

Conversation

@thisisnic

@thisisnicthisisnic commented Nov 30, 2021

Copy link
Copy Markdown
Member

I'm not 100% sure why this fixes this fail, but downgrading the Ubuntu version to 20.04 seems to fix it, and here's my reasoning.

So, apt-key, which is used as part of the R bit of the docs build is now deprecated[1] and Ubuntu 20.10 (Groovy Gorilla) is no longer a supported release as of 22nd July 2021 [2] which can apparently cause issues subsequently trying to do stuff via apt[3].

Reading the R docs for Ubuntu packages[4], it says there that "Package for the current R 4.1. release* are available for most stable Desktop releases of Ubuntu until their official end of life date" which maybe explains why the URL for R packages works fine for focal[5] but results in a 404 error for groovy [6].

The way of getting the signing key for updating packages changed [4] to no longer use apt-key [7] - I have no idea if this had any effect either, but to be on the safe side I have updated that too.

[1] https://manpages.debian.org/testing/apt/apt-key.8.en.html
[2] https://wiki.ubuntu.com/Releases
[3] https://news.itsfoss.com/ubuntu-20-10-end-of-life/
[4] https://cran.r-project.org/bin/linux/ubuntu/
[5] https://cran.r-project.org/bin/linux/ubuntu/focal-cran40/
[6] https://cran.r-project.org/bin/linux/ubuntu/groovy-cran40/
[7] http://web.archive.org/web/20210618164400/https://cloud.r-project.org/bin/linux/ubuntu/

@github-actions

Copy link
Copy Markdown

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-21.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 8804c56

Submitted crossbow builds: ursacomputing/crossbow @ actions-1218

TaskStatus
test-ubuntu-21.04-docsAzure

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 518cb8a

Submitted crossbow builds: ursacomputing/crossbow @ actions-1219

TaskStatus
test-ubuntu-20.04-docsAzure

@thisisnic

Copy link
Copy Markdown
MemberAuthor

Alternatively, we could move to 21.04 after #11786 has merged

@pitrou
pitrou requested a review from kszucsNovember 30, 2021 17:58
@jonkeane

Copy link
Copy Markdown
Member

Whoa fantastic debugging and puzzle-piece-putting together here.

So, apt-key, which is used as part of the R bit of the docs build is now deprecated[1] and Ubuntu 20.10 (Groovy Gorilla) is no longer a supported release as of 22nd July 2021 [2] which can apparently cause issues subsequently trying to do stuff via apt[3].

This now makes so much sense now. I'm fine with waiting for the Clang fix and then bumping to 21.04 (or 21.10??). Also, we could add CLANG_TOOLS: 9 or CLANG_TOOLS: 11 to the task and bump now like we do for a few others

FWIW, https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1219-azure-test-ubuntu-20.04-docs looks unrelated to the R package stuff (though I suspect the R package issues masked when this was introduced):

+ sphinx-build -b html -j 2 /arrow/docs/source /build/docs
Running Sphinx v3.5.4
Extension error:
Could not import extension sphinx_tabs.tabs (exception: No module named 'sphinx_tabs')
2
Error: `docker-compose --file /home/vsts/work/1/s/arrow/docker-compose.yml run --rm -e SETUPTOOLS_SCM_PRETEND_VERSION=7.0.0.dev219 ubuntu-docs` exited with a non-zero exit code 2, see the process log above.

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.04-docs

@github-actions

Copy link
Copy Markdown

Revision: 9ab33be

Submitted crossbow builds: ursacomputing/crossbow @ actions-1222

TaskStatus
test-ubuntu-20.04-docsAzure

Comment threaddev/tasks/tasks.yml Outdated
params:
env:
UBUNTU: "20.10"
UBUNTU: "20.04"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-ubuntu-default-docs already uses Ubuntu 20.04.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Given that this additional job was introduced in #10430 and things have moved on since then, I've removed the extra job. Or should I add it back in and pin it to a different version? It'd be good to know your thoughts too @jonkeane as you were the author of the PR I mentioned above and I don't fully understand everything that's going on there.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, I introduced test-ubuntu-default-docs because we started being unable to build docs on 20.04 (and that inability wasn't noticed cause we were only testing 20.10 before this)

It looks like the 20.10 build was changed from a much older one in #9933.

I'm not sure what the purpose of having a default build and then a separate build on a non-default version is. The one reason I can think of is that we want the non-default version to be a test of a new(ish) ubuntu version, to check for issues there. If that is the case (and we want to maintain that), we probably should build on 21.04 or 21.10. But I'm also totally fine removing the non-default docs build if it's more hassle than is helpful to maintain it.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sounds like it made sense at the time but no longer serves a specific purpose, so unless there's any other reason to keep it in, let's leave it out for now (and add it back in if necessary later).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We chose Ubuntu 20.10 to reduce build time by using system gRPC: #9933 (review)

I'm OK with removing the docs job with non default UBUNTU version.

Could you also remove UBUNTU=20.10 from dev/release/post-09-docs.sh and ci/docker/ubuntu-20.10-cpp.dockerfile file?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, thanks for clarifying that @kou! Just to check my understanding, did you mean remove the reference to 20.10 in dev/release/post-09-docs.sh but entirely remove the file ci/docker/ubuntu-20.10-cpp.dockerfile as no other tasks depend on this now?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Comment threadci/docker/linux-apt-docs.dockerfile
Comment threadci/docker/linux-apt-docs.dockerfile Outdated

@jonkeanejonkeane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ursabot

ursabot commented Dec 1, 2021

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 5227f24 and contender = 736a69e. 736a69e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thisisnic@jonkeane@ursabot@kou