Skip to content

ARROW-16247: [GLib] Add GArrowGCSFileSystem - #12931

Closed
kou wants to merge 1 commit into
apache:masterfrom
kou:glib-gcs-file-system
Closed

ARROW-16247: [GLib] Add GArrowGCSFileSystem#12931
kou wants to merge 1 commit into
apache:masterfrom
kou:glib-gcs-file-system

Conversation

@kou

@koukou commented Apr 20, 2022

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actionsBot commented Apr 20, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16247

@github-actions

github-actionsBot commented Apr 20, 2022

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@pitrou

pitrou commented Apr 21, 2022

Copy link
Copy Markdown
Member

Hmm... this looks quite empty, are you planning to add support for GcsOptions? Or are people expected to instantiate these filesystems using an URI?

@kou

kou commented Apr 22, 2022

Copy link
Copy Markdown
MemberAuthor

this looks quite empty, are you planning to add support for GcsOptions?

I'll add do it eventually but it's usable without this by #12763 (or #12932).

Or are people expected to instantiate these filesystems using an URI?

Yes. We can load data by Arrow::Table.load("gcs://bucket/a.arrow") with this. https://github.com/apache/arrow/blob/master/ruby/red-arrow-dataset/lib/arrow-dataset/arrow-table-loadable.rb#L38 instantiates GArrowGCSFileSystem and it's used to load data.

@pitrou

pitrou commented Apr 22, 2022

Copy link
Copy Markdown
Member

Ok, so should there be a dedicated test?

@kou

kou commented Apr 22, 2022

Copy link
Copy Markdown
MemberAuthor

We can't implement now because gcs://bucket/a.arrow doesn't work without #12763.

@pitrou

pitrou commented Apr 22, 2022

Copy link
Copy Markdown
Member

Ah, fair enough :-)

@koukou closed this in 65e8863Apr 22, 2022
@kou
kou deleted the glib-gcs-file-system branch April 22, 2022 08:21
@ursabot

ursabot commented Apr 25, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 24b4808 and contender = 65e8863. 65e8863 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Failed ⬇️1.13% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.22% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/582|65e88630 ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/570|65e88630 test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/568|65e88630 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/580|65e88630 ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/581|24b48083 ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/569|24b48083 test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/567|24b48083 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/579|24b48083 ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot

ursabot commented Apr 26, 2022

Copy link
Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees

No one assigned

Labels

Component: GLib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kou@pitrou@ursabot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
ARROW-16247: [GLib] Add GArrowGCSFileSystem by kou · Pull Request #12931 · apache/arrow · GitHub
Skip to content
ARROW-16247: [GLib] Add GArrowGCSFileSystem - #12931
Closed
kou wants to merge 1 commit into
apache:masterfrom 
kou:glib-gcs-file-system
Closed
ARROW-16247: [GLib] Add GArrowGCSFileSystem#12931
kou wants to merge 1 commit into
apache:masterfrom 
kou:glib-gcs-file-system
Conversation
@kou
@koukou
commented
Apr 20, 2022

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Apr 20, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16247
@github-actions
github-actionsBot
commented
Apr 20, 2022

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
@pitrou
pitrou
commented
Apr 21, 2022

Copy link


Copy Markdown

Member
Hmm... this looks quite empty, are you planning to add support for GcsOptions? Or are people expected to instantiate these filesystems using an URI?
@kou
kou
commented
Apr 22, 2022

Copy link


Copy Markdown

MemberAuthor
this looks quite empty, are you planning to add support for GcsOptions?
I'll add do it eventually but it's usable without this by #12763 (or #12932).
Or are people expected to instantiate these filesystems using an URI?
Yes. We can load data by Arrow::Table.load("gcs://bucket/a.arrow") with this. https://github.com/apache/arrow/blob/master/ruby/red-arrow-dataset/lib/arrow-dataset/arrow-table-loadable.rb#L38 instantiates GArrowGCSFileSystem and it's used to load data.
@pitrou
pitrou
commented
Apr 22, 2022

Copy link


Copy Markdown

Member
Ok, so should there be a dedicated test?
@kou
kou
commented
Apr 22, 2022

Copy link


Copy Markdown

MemberAuthor
We can't implement now because gcs://bucket/a.arrow doesn't work without #12763.
@pitrou
pitrou
commented
Apr 22, 2022

Copy link


Copy Markdown

Member
Ah, fair enough :-)
@koukou
closed this
in
65e8863Apr 22, 2022
@kou
kou
deleted the

glib-gcs-file-system

branch
April 22, 2022 08:21
@ursabot
ursabot
commented
Apr 25, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 24b4808 and contender = 65e8863. 65e8863 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed] test-mac-arm

[Failed ⬇️1.13% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️1.22% ⬆️0.04%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/582|65e88630 ec2-t3-xlarge-us-east-2>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/570|65e88630 test-mac-arm>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/568|65e88630 ursa-i9-9960x>

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/580|65e88630 ursa-thinkcentre-m75q>

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/581|24b48083 ec2-t3-xlarge-us-east-2>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/569|24b48083 test-mac-arm>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/567|24b48083 ursa-i9-9960x>

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/579|24b48083 ursa-thinkcentre-m75q>

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@ursabot
ursabot
commented
Apr 26, 2022

Copy link


Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: GLib

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kou@pitrou@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ARROW-16247: [GLib] Add GArrowGCSFileSystem by kou · Pull Request #12931 · apache/arrow · GitHub
Skip to content
ARROW-16247: [GLib] Add GArrowGCSFileSystem - #12931
Closed
kou wants to merge 1 commit into
apache:masterfrom 
kou:glib-gcs-file-system
Closed
ARROW-16247: [GLib] Add GArrowGCSFileSystem#12931
kou wants to merge 1 commit into
apache:masterfrom 
kou:glib-gcs-file-system
Conversation
@kou
@koukou
commented
Apr 20, 2022

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Apr 20, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16247
@github-actions
github-actionsBot
commented
Apr 20, 2022

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
@pitrou
pitrou
commented
Apr 21, 2022

Copy link


Copy Markdown

Member
Hmm... this looks quite empty, are you planning to add support for GcsOptions? Or are people expected to instantiate these filesystems using an URI?
@kou
kou
commented
Apr 22, 2022

Copy link


Copy Markdown

MemberAuthor
this looks quite empty, are you planning to add support for GcsOptions?
I'll add do it eventually but it's usable without this by #12763 (or #12932).
Or are people expected to instantiate these filesystems using an URI?
Yes. We can load data by Arrow::Table.load("gcs://bucket/a.arrow") with this. https://github.com/apache/arrow/blob/master/ruby/red-arrow-dataset/lib/arrow-dataset/arrow-table-loadable.rb#L38 instantiates GArrowGCSFileSystem and it's used to load data.
@pitrou
pitrou
commented
Apr 22, 2022

Copy link


Copy Markdown

Member
Ok, so should there be a dedicated test?
@kou
kou
commented
Apr 22, 2022

Copy link


Copy Markdown

MemberAuthor
We can't implement now because gcs://bucket/a.arrow doesn't work without #12763.
@pitrou
pitrou
commented
Apr 22, 2022

Copy link


Copy Markdown

Member
Ah, fair enough :-)
@koukou
closed this
in
65e8863Apr 22, 2022
@kou
kou
deleted the

glib-gcs-file-system

branch
April 22, 2022 08:21
@ursabot
ursabot
commented
Apr 25, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 24b4808 and contender = 65e8863. 65e8863 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed] test-mac-arm

[Failed ⬇️1.13% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️1.22% ⬆️0.04%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/582|65e88630 ec2-t3-xlarge-us-east-2>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/570|65e88630 test-mac-arm>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/568|65e88630 ursa-i9-9960x>

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/580|65e88630 ursa-thinkcentre-m75q>

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/581|24b48083 ec2-t3-xlarge-us-east-2>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/569|24b48083 test-mac-arm>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/567|24b48083 ursa-i9-9960x>

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/579|24b48083 ursa-thinkcentre-m75q>

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@ursabot
ursabot
commented
Apr 26, 2022

Copy link


Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: GLib

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kou@pitrou@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ARROW-16247: [GLib] Add GArrowGCSFileSystem by kou · Pull Request #12931 · apache/arrow · GitHub
Skip to content
ARROW-16247: [GLib] Add GArrowGCSFileSystem - #12931
Closed
kou wants to merge 1 commit into
apache:masterfrom 
kou:glib-gcs-file-system
Closed
ARROW-16247: [GLib] Add GArrowGCSFileSystem#12931
kou wants to merge 1 commit into
apache:masterfrom 
kou:glib-gcs-file-system
Conversation
@kou
@koukou
commented
Apr 20, 2022

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Apr 20, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16247
@github-actions
github-actionsBot
commented
Apr 20, 2022

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
@pitrou
pitrou
commented
Apr 21, 2022

Copy link


Copy Markdown

Member
Hmm... this looks quite empty, are you planning to add support for GcsOptions? Or are people expected to instantiate these filesystems using an URI?
@kou
kou
commented
Apr 22, 2022

Copy link


Copy Markdown

MemberAuthor
this looks quite empty, are you planning to add support for GcsOptions?
I'll add do it eventually but it's usable without this by #12763 (or #12932).
Or are people expected to instantiate these filesystems using an URI?
Yes. We can load data by Arrow::Table.load("gcs://bucket/a.arrow") with this. https://github.com/apache/arrow/blob/master/ruby/red-arrow-dataset/lib/arrow-dataset/arrow-table-loadable.rb#L38 instantiates GArrowGCSFileSystem and it's used to load data.
@pitrou
pitrou
commented
Apr 22, 2022

Copy link


Copy Markdown

Member
Ok, so should there be a dedicated test?
@kou
kou
commented
Apr 22, 2022

Copy link


Copy Markdown

MemberAuthor
We can't implement now because gcs://bucket/a.arrow doesn't work without #12763.
@pitrou
pitrou
commented
Apr 22, 2022

Copy link


Copy Markdown

Member
Ah, fair enough :-)
@koukou
closed this
in
65e8863Apr 22, 2022
@kou
kou
deleted the

glib-gcs-file-system

branch
April 22, 2022 08:21
@ursabot
ursabot
commented
Apr 25, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 24b4808 and contender = 65e8863. 65e8863 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed] test-mac-arm

[Failed ⬇️1.13% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️1.22% ⬆️0.04%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/582|65e88630 ec2-t3-xlarge-us-east-2>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/570|65e88630 test-mac-arm>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/568|65e88630 ursa-i9-9960x>

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/580|65e88630 ursa-thinkcentre-m75q>

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/581|24b48083 ec2-t3-xlarge-us-east-2>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/569|24b48083 test-mac-arm>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/567|24b48083 ursa-i9-9960x>

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/579|24b48083 ursa-thinkcentre-m75q>

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@ursabot
ursabot
commented
Apr 26, 2022

Copy link


Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: GLib

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kou@pitrou@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
ARROW-16247: [GLib] Add GArrowGCSFileSystem by kou · Pull Request #12931 · apache/arrow · GitHub
Skip to content
ARROW-16247: [GLib] Add GArrowGCSFileSystem - #12931
Closed
kou wants to merge 1 commit into
apache:masterfrom 
kou:glib-gcs-file-system
Closed
ARROW-16247: [GLib] Add GArrowGCSFileSystem#12931
kou wants to merge 1 commit into
apache:masterfrom 
kou:glib-gcs-file-system
Conversation
@kou
@koukou
commented
Apr 20, 2022

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Apr 20, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16247
@github-actions
github-actionsBot
commented
Apr 20, 2022

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
@pitrou
pitrou
commented
Apr 21, 2022

Copy link


Copy Markdown

Member
Hmm... this looks quite empty, are you planning to add support for GcsOptions? Or are people expected to instantiate these filesystems using an URI?
@kou
kou
commented
Apr 22, 2022

Copy link


Copy Markdown

MemberAuthor
this looks quite empty, are you planning to add support for GcsOptions?
I'll add do it eventually but it's usable without this by #12763 (or #12932).
Or are people expected to instantiate these filesystems using an URI?
Yes. We can load data by Arrow::Table.load("gcs://bucket/a.arrow") with this. https://github.com/apache/arrow/blob/master/ruby/red-arrow-dataset/lib/arrow-dataset/arrow-table-loadable.rb#L38 instantiates GArrowGCSFileSystem and it's used to load data.
@pitrou
pitrou
commented
Apr 22, 2022

Copy link


Copy Markdown

Member
Ok, so should there be a dedicated test?
@kou
kou
commented
Apr 22, 2022

Copy link


Copy Markdown

MemberAuthor
We can't implement now because gcs://bucket/a.arrow doesn't work without #12763.
@pitrou
pitrou
commented
Apr 22, 2022

Copy link


Copy Markdown

Member
Ah, fair enough :-)
@koukou
closed this
in
65e8863Apr 22, 2022
@kou
kou
deleted the

glib-gcs-file-system

branch
April 22, 2022 08:21
@ursabot
ursabot
commented
Apr 25, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 24b4808 and contender = 65e8863. 65e8863 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed] test-mac-arm

[Failed ⬇️1.13% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️1.22% ⬆️0.04%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/582|65e88630 ec2-t3-xlarge-us-east-2>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/570|65e88630 test-mac-arm>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/568|65e88630 ursa-i9-9960x>

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/580|65e88630 ursa-thinkcentre-m75q>

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/581|24b48083 ec2-t3-xlarge-us-east-2>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/569|24b48083 test-mac-arm>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/567|24b48083 ursa-i9-9960x>

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/579|24b48083 ursa-thinkcentre-m75q>

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@ursabot
ursabot
commented
Apr 26, 2022

Copy link


Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: GLib

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kou@pitrou@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ARROW-16247: [GLib] Add GArrowGCSFileSystem by kou · Pull Request #12931 · apache/arrow · GitHub
Skip to content
ARROW-16247: [GLib] Add GArrowGCSFileSystem - #12931
Closed
kou wants to merge 1 commit into
apache:masterfrom 
kou:glib-gcs-file-system
Closed
ARROW-16247: [GLib] Add GArrowGCSFileSystem#12931
kou wants to merge 1 commit into
apache:masterfrom 
kou:glib-gcs-file-system
Conversation
@kou
@koukou
commented
Apr 20, 2022

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Apr 20, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16247
@github-actions
github-actionsBot
commented
Apr 20, 2022

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
@pitrou
pitrou
commented
Apr 21, 2022

Copy link


Copy Markdown

Member
Hmm... this looks quite empty, are you planning to add support for GcsOptions? Or are people expected to instantiate these filesystems using an URI?
@kou
kou
commented
Apr 22, 2022

Copy link


Copy Markdown

MemberAuthor
this looks quite empty, are you planning to add support for GcsOptions?
I'll add do it eventually but it's usable without this by #12763 (or #12932).
Or are people expected to instantiate these filesystems using an URI?
Yes. We can load data by Arrow::Table.load("gcs://bucket/a.arrow") with this. https://github.com/apache/arrow/blob/master/ruby/red-arrow-dataset/lib/arrow-dataset/arrow-table-loadable.rb#L38 instantiates GArrowGCSFileSystem and it's used to load data.
@pitrou
pitrou
commented
Apr 22, 2022

Copy link


Copy Markdown

Member
Ok, so should there be a dedicated test?
@kou
kou
commented
Apr 22, 2022

Copy link


Copy Markdown

MemberAuthor
We can't implement now because gcs://bucket/a.arrow doesn't work without #12763.
@pitrou
pitrou
commented
Apr 22, 2022

Copy link


Copy Markdown

Member
Ah, fair enough :-)
@koukou
closed this
in
65e8863Apr 22, 2022
@kou
kou
deleted the

glib-gcs-file-system

branch
April 22, 2022 08:21
@ursabot
ursabot
commented
Apr 25, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 24b4808 and contender = 65e8863. 65e8863 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed] test-mac-arm

[Failed ⬇️1.13% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️1.22% ⬆️0.04%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/582|65e88630 ec2-t3-xlarge-us-east-2>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/570|65e88630 test-mac-arm>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/568|65e88630 ursa-i9-9960x>

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/580|65e88630 ursa-thinkcentre-m75q>

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/581|24b48083 ec2-t3-xlarge-us-east-2>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/569|24b48083 test-mac-arm>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/567|24b48083 ursa-i9-9960x>

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/579|24b48083 ursa-thinkcentre-m75q>

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@ursabot
ursabot
commented
Apr 26, 2022

Copy link


Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: GLib

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kou@pitrou@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
ARROW-16247: [GLib] Add GArrowGCSFileSystem by kou · Pull Request #12931 · apache/arrow · GitHub
Skip to content
ARROW-16247: [GLib] Add GArrowGCSFileSystem - #12931
Closed
kou wants to merge 1 commit into
apache:masterfrom 
kou:glib-gcs-file-system
Closed
ARROW-16247: [GLib] Add GArrowGCSFileSystem#12931
kou wants to merge 1 commit into
apache:masterfrom 
kou:glib-gcs-file-system
Conversation
@kou
@koukou
commented
Apr 20, 2022

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Apr 20, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16247
@github-actions
github-actionsBot
commented
Apr 20, 2022

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
@pitrou
pitrou
commented
Apr 21, 2022

Copy link


Copy Markdown

Member
Hmm... this looks quite empty, are you planning to add support for GcsOptions? Or are people expected to instantiate these filesystems using an URI?
@kou
kou
commented
Apr 22, 2022

Copy link


Copy Markdown

MemberAuthor
this looks quite empty, are you planning to add support for GcsOptions?
I'll add do it eventually but it's usable without this by #12763 (or #12932).
Or are people expected to instantiate these filesystems using an URI?
Yes. We can load data by Arrow::Table.load("gcs://bucket/a.arrow") with this. https://github.com/apache/arrow/blob/master/ruby/red-arrow-dataset/lib/arrow-dataset/arrow-table-loadable.rb#L38 instantiates GArrowGCSFileSystem and it's used to load data.
@pitrou
pitrou
commented
Apr 22, 2022

Copy link


Copy Markdown

Member
Ok, so should there be a dedicated test?
@kou
kou
commented
Apr 22, 2022

Copy link


Copy Markdown

MemberAuthor
We can't implement now because gcs://bucket/a.arrow doesn't work without #12763.
@pitrou
pitrou
commented
Apr 22, 2022

Copy link


Copy Markdown

Member
Ah, fair enough :-)
@koukou
closed this
in
65e8863Apr 22, 2022
@kou
kou
deleted the

glib-gcs-file-system

branch
April 22, 2022 08:21
@ursabot
ursabot
commented
Apr 25, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 24b4808 and contender = 65e8863. 65e8863 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed] test-mac-arm

[Failed ⬇️1.13% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️1.22% ⬆️0.04%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/582|65e88630 ec2-t3-xlarge-us-east-2>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/570|65e88630 test-mac-arm>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/568|65e88630 ursa-i9-9960x>

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/580|65e88630 ursa-thinkcentre-m75q>

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/581|24b48083 ec2-t3-xlarge-us-east-2>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/569|24b48083 test-mac-arm>

[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/567|24b48083 ursa-i9-9960x>

[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/579|24b48083 ursa-thinkcentre-m75q>

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@ursabot
ursabot
commented
Apr 26, 2022

Copy link


Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: GLib

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kou@pitrou@ursabot