') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); ARROW-16248: [C++][FS] Actually enable GCS support in FileSystemFromUri() by kou · Pull Request #12932 · apache/arrow · GitHub
Skip to content

ARROW-16248: [C++][FS] Actually enable GCS support in FileSystemFromUri() - #12932

Closed
kou wants to merge 1 commit into
apache:masterfrom
kou:cpp-filesystem-arrow-gcs
Closed

ARROW-16248: [C++][FS] Actually enable GCS support in FileSystemFromUri()#12932
kou wants to merge 1 commit into
apache:masterfrom
kou:cpp-filesystem-arrow-gcs

Conversation

@kou

@koukou commented Apr 20, 2022•
edited by pitrou
Loading

Copy link
Copy Markdown
Member

Define the ARROW_GCS macro, otherwise the relevant code wasn't compiled.

@kou
kou requested review from emkornfield and pitrouApril 20, 2022 07:17
@kou

kou commented Apr 20, 2022

Copy link
Copy Markdown
MemberAuthor

Cc: @coryan

@github-actions

github-actionsBot commented Apr 20, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16248

@github-actions

github-actionsBot commented Apr 20, 2022

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@pitroupitrou changed the title ARROW-16248: [C++][FS] Add GCS support to FileSystemFromUri()ARROW-16248: [C++][FS] Update FileSystemFromUri() docstring for GCS supportApr 20, 2022
pitrou
pitrou approved these changes Apr 20, 2022
View reviewed changes

@pitroupitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kou
kou commented Apr 20, 2022
View reviewed changes
Comment threadcpp/src/arrow/util/config.h.cmake
#cmakedefine ARROW_IPC
#cmakedefine ARROW_JSON

#cmakedefine ARROW_GCS

@koukouApr 20, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't have this, ARROW_GCS macro isn't defined even when we build Apache Arrow with -DARROW_GCS=ON.

If ARROW_GCS macro isn't defined, we always get a "Got GCS URI but Arrow compiled without GCS support" error even when we build Apache Arrow with -DARROW_GCS=ON.

@pitroupitrouApr 20, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I see, does this mean there are no tests for this?

@emkornfieldemkornfieldApr 20, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My PR also covers this

@pitroupitrou changed the title ARROW-16248: [C++][FS] Update FileSystemFromUri() docstring for GCS supportARROW-16248: [C++][FS] Actually enable GCS support in FileSystemFromUri()Apr 20, 2022
coryan
coryan approved these changes Apr 20, 2022
View reviewed changes

@coryancoryan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I guess I missed that. LGTM.

@emkornfield

emkornfield commented Apr 20, 2022

Copy link
Copy Markdown
Contributor

I would prefer not to merge this separately because I think without the python binding PR users are going to get unexpected results when reading existing datasets

@pitrou

pitrou commented Apr 20, 2022

Copy link
Copy Markdown
Member

For the record, @emkornfield 's PR is #12763.

@kou

kou commented Apr 20, 2022

Copy link
Copy Markdown
MemberAuthor

OK. I withdraw this in favor of #12763.

@koukou closed this Apr 20, 2022
@kou
kou deleted the cpp-filesystem-arrow-gcs branch April 20, 2022 21:26
@koukou mentioned this pull request Apr 22, 2022
Closed
@asfimportasfimport mentioned this pull request Apr 20, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes
@emkornfieldemkornfieldAwaiting requested review from emkornfield
+1 more reviewer
@coryancoryancoryan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kou@emkornfield@pitrou@coryan