Skip to content

ARROW-17693: [C++] Remove string_view backport - #14177

Merged
pitrou merged 5 commits into
apache:masterfrom
pitrou:ARROW-17693-std-string-view
Sep 21, 2022
Merged

ARROW-17693: [C++] Remove string_view backport#14177
pitrou merged 5 commits into
apache:masterfrom
pitrou:ARROW-17693-std-string-view

Conversation

@pitrou

@pitroupitrou commented Sep 20, 2022

Copy link
Copy Markdown
Member

No description provided.

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou

This comment was marked as outdated.

Sign in to view
@github-actions

github-actionsBot commented Sep 20, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-17693

@github-actions

github-actionsBot commented Sep 20, 2022

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@pitrou
pitrouforce-pushed the ARROW-17693-std-string-view branch from 9845b80 to c9a2044CompareSeptember 20, 2022 17:02
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrouforce-pushed the ARROW-17693-std-string-view branch from c9a2044 to 9f63712CompareSeptember 20, 2022 17:32
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrouforce-pushed the ARROW-17693-std-string-view branch from 9f63712 to 3fbeb9aCompareSeptember 20, 2022 17:53
@pitrou
pitrouforce-pushed the ARROW-17693-std-string-view branch from 62bbdcf to f92c450CompareSeptember 20, 2022 18:50
@pitrou

This comment was marked as outdated.

Sign in to view
pitrou
pitrou commented Sep 20, 2022
View reviewed changes
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake

set(GTEST_CMAKE_ARGS
${EP_COMMON_TOOLCHAIN}
${EP_COMMON_CMAKE_ARGS}

@pitroupitrouSep 20, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so that CMAKE_CXX_STANDARD is propagated to the GTest build.

@pitrou
pitrou requested a review from kouSeptember 20, 2022 18:53
@pitrou

pitrou commented Sep 20, 2022

Copy link
Copy Markdown
MemberAuthor

Revision: c7e43c9

Submitted crossbow builds: ursacomputing/crossbow @ string-view-5

TaskStatus
almalinux-8-amd64Github Actions
almalinux-8-arm64TravisCI
almalinux-9-amd64Github Actions
almalinux-9-arm64TravisCI
amazon-linux-2-amd64Github Actions
amazon-linux-2-arm64TravisCI
centos-7-amd64Github Actions
centos-8-stream-amd64Github Actions
centos-8-stream-arm64TravisCI
centos-9-stream-amd64Github Actions
centos-9-stream-arm64TravisCI
conan-maximumGithub Actions
conan-minimumGithub Actions
conda-cleanAzure
conda-linux-gcc-py310-arm64Azure
conda-linux-gcc-py310-cpuAzure
conda-linux-gcc-py310-cudaAzure
conda-linux-gcc-py310-ppc64leAzure
conda-linux-gcc-py37-arm64Azure
conda-linux-gcc-py37-cpu-r40Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-linux-gcc-py37-cudaAzure
conda-linux-gcc-py37-ppc64leAzure
conda-linux-gcc-py38-arm64Azure
conda-linux-gcc-py38-cpuAzure
conda-linux-gcc-py38-cudaAzure
conda-linux-gcc-py38-ppc64leAzure
conda-linux-gcc-py39-arm64Azure
conda-linux-gcc-py39-cpuAzure
conda-linux-gcc-py39-cudaAzure
conda-linux-gcc-py39-ppc64leAzure
conda-osx-arm64-clang-py310Azure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py310Azure
conda-osx-clang-py37-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2019-py310Azure
conda-win-vs2019-py37-r40Azure
conda-win-vs2019-py37-r41Azure
conda-win-vs2019-py38Azure
conda-win-vs2019-py39Azure
debian-bookworm-amd64Github Actions
debian-bookworm-arm64TravisCI
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
example-python-minimal-build-fedora-condaGithub Actions
example-python-minimal-build-ubuntu-venvGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
r-binary-packagesGithub Actions
test-alpine-linux-cppGithub Actions
test-build-cpp-fuzzGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.10Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-v3.1.2Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-v3.2.0Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-dask-latestGithub Actions
test-conda-python-3.9-dask-masterGithub Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-conda-python-3.9-spark-masterGithub Actions
test-debian-10-cpp-amd64Github Actions
test-debian-10-cpp-i386Github Actions
test-debian-11-cpp-amd64Github Actions
test-debian-11-cpp-i386Github Actions
test-debian-11-go-1.17Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-35-cppGithub Actions
test-fedora-35-python-3Azure
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-skyhook-integrationGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-bundledGithub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.04-python-3Azure
test-ubuntu-22.04-cppGithub Actions
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-jammy-amd64Github Actions
ubuntu-jammy-arm64TravisCI
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-mojave-cp310-amd64Github Actions
wheel-macos-mojave-cp37-amd64Github Actions
wheel-macos-mojave-cp38-amd64Github Actions
wheel-macos-mojave-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions

kou
kou approved these changes Sep 21, 2022
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment thread.github/workflows/cpp.yml
ARROW_WITH_ZSTD: ON
# System Abseil installed by Homebrew uses C++ 17
CMAKE_CXX_STANDARD: 17
GTest_SOURCE: BUNDLED

@koukouSep 21, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this? Do we need newer GTest for std::string_view? If so, how about updating required GTest version too? https://github.com/apache/arrow/blob/master/cpp/cmake_modules/ThirdpartyToolchain.cmake#L2078

@pitroupitrouSep 21, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GTest version does not need to be new, but GTest needs to be compiled in C++17 mode otherwise some test helpers are needed (such as equality between string_views).

@koukouSep 21, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see.

@pitrou

pitrou commented Sep 21, 2022

Copy link
Copy Markdown
MemberAuthor

Ok, all CI failures are unrelated, I'll merge.

@pitrou
pitrou merged commit 91ee6da into apache:masterSep 21, 2022
@pitrou
pitrou deleted the ARROW-17693-std-string-view branch September 21, 2022 08:12
@ursabot

ursabot commented Sep 21, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = afd3c40 and contender = 91ee6da. 91ee6da is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️1.57% ⬆️0.61%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.56%] ursa-i9-9960x
[Finished ⬇️1.1% ⬆️0.85%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 91ee6dad ec2-t3-xlarge-us-east-2
[Failed] 91ee6dad test-mac-arm
[Failed] 91ee6dad ursa-i9-9960x
[Finished] 91ee6dad ursa-thinkcentre-m75q
[Finished] afd3c40a ec2-t3-xlarge-us-east-2
[Failed] afd3c40a test-mac-arm
[Failed] afd3c40a ursa-i9-9960x
[Finished] afd3c40a ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@pitrou@zagto
ARROW-17693: [C++] Remove string_view backport (apache#14177)
0597968
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@asfimportasfimport mentioned this pull request Sep 21, 2022
Closed
@raulcdraulcd mentioned this pull request Apr 3, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees

No one assigned

Labels

Component: C++Component: DocumentationComponent: FlightRPCComponent: GandivaComponent: GLibComponent: ParquetComponent: PythonComponent: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pitrou@ursabot@kou