Uh oh!
There was an error while loading. Please reload this page.
GH-45986: [C++] Update bundled GoogleTest - #45996
Conversation
a7bec63 to
c4aea3fComparekou
commented
Apr 2, 2025
This is ready. |
| ARROW_WITH_SNAPPY: ON | ||
| ARROW_WITH_ZLIB: ON | ||
| ARROW_WITH_ZSTD: ON | ||
| GTest_SOURCE: BUNDLED |
There was a problem hiding this comment.
Note for self: next time we add something like this we probably want to add a comment on why we are adding it so we understand we can remove it later on. I didn't find a good enough reason on why it was added.
I had to go to a comment:
#14177 (comment)
and a commit to see where was this coming from:
1e33ad9
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit eaeb64b. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 17 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change The current bundle Google 1.11.0 was released in 2021. It's too old. ### What changes are included in this PR? Update to the latest GoogleTest: 1.16.0 ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#45986 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
### Rationale for this change The current bundle Google 1.11.0 was released in 2021. It's too old. ### What changes are included in this PR? Update to the latest GoogleTest: 1.16.0 ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#45986 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
### Rationale for this change The current bundle Google 1.11.0 was released in 2021. It's too old. ### What changes are included in this PR? Update to the latest GoogleTest: 1.16.0 ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #45986 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Rationale for this change
The current bundle Google 1.11.0 was released in 2021. It's too old.
What changes are included in this PR?
Update to the latest GoogleTest: 1.16.0
Are these changes tested?
Yes.
Are there any user-facing changes?
No.