ARROW-18162: [C++] Add Arm SVE compiler options#14515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cyb70289 merged 2 commits into from
Nov 1, 2022
Merged

ARROW-18162: [C++] Add Arm SVE compiler options #14515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa8ee3e
ARROW-18162: [C++] Add Arm SVE compiler options
cyb70289 Oct 25, 2022
f99b57a
Remove ARROW_ARMV8_ARCH cmake option
cyb70289 Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions cpp/cmake_modules/DefineOptions.cmake
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -185,6 +185,10 @@ takes precedence over ccache if a storage backend is configured" ON)
"AVX2"
"AVX512"
"NEON"
"SVE" # size agnostic SVE
"SVE128" # fixed size SVE
"SVE256" # "
"SVE512" # "
"DEFAULT")

define_option_string(ARROW_RUNTIME_SIMD_LEVEL
Expand All@@ -196,17 +200,6 @@ takes precedence over ccache if a storage backend is configured" ON)
"AVX512"
"MAX")

# Arm64 architectures and extensions can lead to exploding combinations.
# So set it directly through cmake command line.
#
# If you change this, you need to change the definition in
# python/CMakeLists.txt too.
define_option_string(ARROW_ARMV8_ARCH
"Arm64 arch and extensions"
"armv8-a" # Default
"armv8-a"
"armv8-a+crc+crypto")

define_option(ARROW_ALTIVEC "Build with Altivec if compiler has support" ON)

define_option(ARROW_RPATH_ORIGIN "Build Arrow libraries with RATH set to \$ORIGIN" OFF)
Expand Down
39 changes: 20 additions & 19 deletions cpp/cmake_modules/SetupCxxFlags.cmake
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -110,8 +110,8 @@ elseif(ARROW_CPU_FLAG STREQUAL "ppc")
endif()
elseif(ARROW_CPU_FLAG STREQUAL "armv8")
# Arm64 compiler flags, gcc/clang only
set(ARROW_ARMV8_ARCH_FLAG "-march=${ARROW_ARMV8_ARCH}")
check_cxx_compiler_flag(${ARROW_ARMV8_ARCH_FLAG} CXX_SUPPORTS_ARMV8_ARCH)
set(ARROW_ARMV8_MARCH "armv8-a")
check_cxx_compiler_flag("-march=${ARROW_ARMV8_MARCH}+sve" CXX_SUPPORTS_SVE)
if(ARROW_SIMD_LEVEL STREQUAL "DEFAULT")
set(ARROW_SIMD_LEVEL "NEON")
endif()
Expand DownExpand Up@@ -485,26 +485,27 @@ if(ARROW_CPU_FLAG STREQUAL "ppc")
endif()

if(ARROW_CPU_FLAG STREQUAL "armv8")
if(ARROW_SIMD_LEVEL STREQUAL "NEON")
if(ARROW_SIMD_LEVEL MATCHES "NEON|SVE[0-9]*")
set(ARROW_HAVE_NEON ON)
Comment thread
cyb70289 marked this conversation as resolved.
Outdated

if(NOT CXX_SUPPORTS_ARMV8_ARCH)
message(FATAL_ERROR "Unsupported arch flag: ${ARROW_ARMV8_ARCH_FLAG}.")
endif()
if(ARROW_ARMV8_ARCH_FLAG MATCHES "native")
message(FATAL_ERROR "native arch not allowed, please specify arch explicitly.")
endif()
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} ${ARROW_ARMV8_ARCH_FLAG}")

add_definitions(-DARROW_HAVE_NEON)

if(ARROW_ARMV8_ARCH_FLAG MATCHES "\\+crypto")
add_definitions(-DARROW_HAVE_ARMV8_CRYPTO)
endif()
# armv8.1+ implies crc support
if(ARROW_ARMV8_ARCH_FLAG MATCHES "armv8\\.[1-9]|\\+crc")
add_definitions(-DARROW_HAVE_ARMV8_CRC)
if(ARROW_SIMD_LEVEL MATCHES "SVE[0-9]*")
if(NOT CXX_SUPPORTS_SVE)
message(FATAL_ERROR "SVE required but compiler doesn't support it.")
endif()
# -march=armv8-a+sve
set(ARROW_ARMV8_MARCH "${ARROW_ARMV8_MARCH}+sve")
string(REGEX MATCH "[0-9]+" SVE_VECTOR_BITS ${ARROW_SIMD_LEVEL})
if(SVE_VECTOR_BITS)
set(ARROW_HAVE_SVE${SVE_VECTOR_BITS} ON)
add_definitions(-DARROW_HAVE_SVE${SVE_VECTOR_BITS})
# -msve-vector-bits=256
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -msve-vector-bits=${SVE_VECTOR_BITS}")
else()
set(ARROW_HAVE_SVE_SIZELESS ON)
add_definitions(-DARROW_HAVE_SVE_SIZELSS)
endif()
endif()
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -march=${ARROW_ARMV8_MARCH}")
elseif(NOT ARROW_SIMD_LEVEL STREQUAL "NONE")
message(WARNING "ARROW_SIMD_LEVEL=${ARROW_SIMD_LEVEL} not supported by Arm.")
endif()
Expand Down
4 changes: 2 additions & 2 deletions cpp/src/arrow/io/memory_benchmark.cc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -154,7 +154,7 @@ static void StreamReadWrite(void* src, void* dst, size_t size) {

#endif // ARROW_HAVE_SSE4_2

#ifdef ARROW_HAVE_ARMV8_CRYPTO
#ifdef ARROW_HAVE_NEON

using VectorType = uint8x16_t;
using VectorTypeDual = uint8x16x2_t;
Expand DownExpand Up@@ -237,7 +237,7 @@ static void StreamReadWrite(void* src, void* dst, size_t size) {
}
}

#endif // ARROW_HAVE_ARMV8_CRYPTO
#endif // ARROW_HAVE_NEON

static void PlatformMemcpy(void* src, void* dst, size_t size) { memcpy(src, dst, size); }

Expand Down
4 changes: 0 additions & 4 deletions cpp/src/arrow/util/simd.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,8 +41,4 @@
#include <arm_neon.h>
#endif

#ifdef ARROW_HAVE_ARMV8_CRC
#include <arm_acle.h>
#endif

#endif
5 changes: 0 additions & 5 deletions dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,11 +30,6 @@ else
export PYARROW_WITH_CUDA=0
fi

# Resolve: Make Error at cmake_modules/SetupCxxFlags.cmake:338 (message): Unsupported arch flag: -march=.
Comment thread
cyb70289 marked this conversation as resolved.
Outdated
if [[ "${target_platform}" == "linux-aarch64" ]]; then
export PYARROW_CMAKE_OPTIONS="-DARROW_ARMV8_ARCH=armv8-a ${PYARROW_CMAKE_OPTIONS}"
fi

if [[ "${target_platform}" == osx-* ]]; then
# See https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk
CXXFLAGS="${CXXFLAGS} -D_LIBCPP_DISABLE_AVAILABILITY"
Expand Down
5 changes: 0 additions & 5 deletions python/CMakeLists.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -126,11 +126,6 @@ if(NOT DEFINED ARROW_RUNTIME_SIMD_LEVEL)
"MAX"
CACHE STRING "Max runtime SIMD optimization level")
endif()
if(NOT DEFINED ARROW_ARMV8_ARCH)
set(ARROW_ARMV8_ARCH
"armv8-a"
CACHE STRING "Arm64 arch and extensions: armv8-a, armv8-a or armv8-a+crc+crypto")
endif()
include(SetupCxxFlags)

# Add common flags
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ARROW-18162: [C++] Add Arm SVE compiler options#14515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

cyb70289
merged 2 commits into

from

Nov 1, 2022
 Merged


ARROW-18162: [C++] Add Arm SVE compiler options
#14515
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
aa8ee3e

ARROW-18162: [C++] Add Arm SVE compiler options


cyb70289 Oct 25, 2022
f99b57a

Remove ARROW_ARMV8_ARCH cmake option


cyb70289 Oct 27, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 4 additions & 11 deletions
cpp/cmake_modules/DefineOptions.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -185,6 +185,10 @@ takes precedence over ccache if a storage backend is configured" ON)
 "AVX2"
 "AVX512"
 "NEON"
 "SVE" # size agnostic SVE
 "SVE128" # fixed size SVE
 "SVE256" # "
 "SVE512" # "
 "DEFAULT")

 define_option_string(ARROW_RUNTIME_SIMD_LEVEL
Expand All@@ -196,17 +200,6 @@ takes precedence over ccache if a storage backend is configured" ON)
 "AVX512"
 "MAX")

 # Arm64 architectures and extensions can lead to exploding combinations.
 # So set it directly through cmake command line.
 #
 # If you change this, you need to change the definition in
 # python/CMakeLists.txt too.
 define_option_string(ARROW_ARMV8_ARCH
 "Arm64 arch and extensions"
 "armv8-a" # Default
 "armv8-a"
 "armv8-a+crc+crypto")

 define_option(ARROW_ALTIVEC "Build with Altivec if compiler has support" ON)

 define_option(ARROW_RPATH_ORIGIN "Build Arrow libraries with RATH set to \$ORIGIN" OFF)
Expand Down

39 changes: 20 additions & 19 deletions
cpp/cmake_modules/SetupCxxFlags.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,8 +110,8 @@ elseif(ARROW_CPU_FLAG STREQUAL "ppc")
 endif()
elseif(ARROW_CPU_FLAG STREQUAL "armv8")
 # Arm64 compiler flags, gcc/clang only
 set(ARROW_ARMV8_ARCH_FLAG "-march=${ARROW_ARMV8_ARCH}")
 check_cxx_compiler_flag(${ARROW_ARMV8_ARCH_FLAG} CXX_SUPPORTS_ARMV8_ARCH)
 set(ARROW_ARMV8_MARCH "armv8-a")
 check_cxx_compiler_flag("-march=${ARROW_ARMV8_MARCH}+sve" CXX_SUPPORTS_SVE)
 if(ARROW_SIMD_LEVEL STREQUAL "DEFAULT")
 set(ARROW_SIMD_LEVEL "NEON")
 endif()
Expand DownExpand Up@@ -485,26 +485,27 @@ if(ARROW_CPU_FLAG STREQUAL "ppc")
endif()

if(ARROW_CPU_FLAG STREQUAL "armv8")
 if(ARROW_SIMD_LEVEL STREQUAL "NEON")
 if(ARROW_SIMD_LEVEL MATCHES "NEON|SVE[0-9]*")
 set(ARROW_HAVE_NEON ON)
Comment thread
cyb70289 marked this conversation as resolved.


Outdated


 if(NOT CXX_SUPPORTS_ARMV8_ARCH)
 message(FATAL_ERROR "Unsupported arch flag: ${ARROW_ARMV8_ARCH_FLAG}.")
 endif()
 if(ARROW_ARMV8_ARCH_FLAG MATCHES "native")
 message(FATAL_ERROR "native arch not allowed, please specify arch explicitly.")
 endif()
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} ${ARROW_ARMV8_ARCH_FLAG}")

 add_definitions(-DARROW_HAVE_NEON)

 if(ARROW_ARMV8_ARCH_FLAG MATCHES "\\+crypto")
 add_definitions(-DARROW_HAVE_ARMV8_CRYPTO)
 endif()
 # armv8.1+ implies crc support
 if(ARROW_ARMV8_ARCH_FLAG MATCHES "armv8\\.[1-9]|\\+crc")
 add_definitions(-DARROW_HAVE_ARMV8_CRC)
 if(ARROW_SIMD_LEVEL MATCHES "SVE[0-9]*")
 if(NOT CXX_SUPPORTS_SVE)
 message(FATAL_ERROR "SVE required but compiler doesn't support it.")
 endif()
 # -march=armv8-a+sve
 set(ARROW_ARMV8_MARCH "${ARROW_ARMV8_MARCH}+sve")
 string(REGEX MATCH "[0-9]+" SVE_VECTOR_BITS ${ARROW_SIMD_LEVEL})
 if(SVE_VECTOR_BITS)
 set(ARROW_HAVE_SVE${SVE_VECTOR_BITS} ON)
 add_definitions(-DARROW_HAVE_SVE${SVE_VECTOR_BITS})
 # -msve-vector-bits=256
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -msve-vector-bits=${SVE_VECTOR_BITS}")
 else()
 set(ARROW_HAVE_SVE_SIZELESS ON)
 add_definitions(-DARROW_HAVE_SVE_SIZELSS)
 endif()
 endif()
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -march=${ARROW_ARMV8_MARCH}")
 elseif(NOT ARROW_SIMD_LEVEL STREQUAL "NONE")
 message(WARNING "ARROW_SIMD_LEVEL=${ARROW_SIMD_LEVEL} not supported by Arm.")
 endif()
Expand Down

4 changes: 2 additions & 2 deletions
cpp/src/arrow/io/memory_benchmark.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -154,7 +154,7 @@ static void StreamReadWrite(void* src, void* dst, size_t size) {

#endif // ARROW_HAVE_SSE4_2

#ifdef ARROW_HAVE_ARMV8_CRYPTO
#ifdef ARROW_HAVE_NEON

using VectorType = uint8x16_t;
using VectorTypeDual = uint8x16x2_t;
Expand DownExpand Up@@ -237,7 +237,7 @@ static void StreamReadWrite(void* src, void* dst, size_t size) {
 }
}

#endif // ARROW_HAVE_ARMV8_CRYPTO
#endif // ARROW_HAVE_NEON

static void PlatformMemcpy(void* src, void* dst, size_t size) { memcpy(src, dst, size); }

Expand Down

4 changes: 0 additions & 4 deletions
cpp/src/arrow/util/simd.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -41,8 +41,4 @@
#include <arm_neon.h>
#endif

#ifdef ARROW_HAVE_ARMV8_CRC
#include <arm_acle.h>
#endif

#endif

5 changes: 0 additions & 5 deletions
dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,11 +30,6 @@ else
 export PYARROW_WITH_CUDA=0
fi

# Resolve: Make Error at cmake_modules/SetupCxxFlags.cmake:338 (message): Unsupported arch flag: -march=.
Comment thread
cyb70289 marked this conversation as resolved.


Outdated

if [[ "${target_platform}" == "linux-aarch64" ]]; then
 export PYARROW_CMAKE_OPTIONS="-DARROW_ARMV8_ARCH=armv8-a ${PYARROW_CMAKE_OPTIONS}"
fi

if [[ "${target_platform}" == osx-* ]]; then
 # See https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk
 CXXFLAGS="${CXXFLAGS} -D_LIBCPP_DISABLE_AVAILABILITY"
Expand Down

5 changes: 0 additions & 5 deletions
python/CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -126,11 +126,6 @@ if(NOT DEFINED ARROW_RUNTIME_SIMD_LEVEL)
 "MAX"
 CACHE STRING "Max runtime SIMD optimization level")
endif()
if(NOT DEFINED ARROW_ARMV8_ARCH)
 set(ARROW_ARMV8_ARCH
 "armv8-a"
 CACHE STRING "Arm64 arch and extensions: armv8-a, armv8-a or armv8-a+crc+crypto")
endif()
include(SetupCxxFlags)

# Add common flags
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-18162: [C++] Add Arm SVE compiler options#14515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

cyb70289
merged 2 commits into

from

Nov 1, 2022
 Merged


ARROW-18162: [C++] Add Arm SVE compiler options
#14515
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
aa8ee3e

ARROW-18162: [C++] Add Arm SVE compiler options


cyb70289 Oct 25, 2022
f99b57a

Remove ARROW_ARMV8_ARCH cmake option


cyb70289 Oct 27, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 4 additions & 11 deletions
cpp/cmake_modules/DefineOptions.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -185,6 +185,10 @@ takes precedence over ccache if a storage backend is configured" ON)
 "AVX2"
 "AVX512"
 "NEON"
 "SVE" # size agnostic SVE
 "SVE128" # fixed size SVE
 "SVE256" # "
 "SVE512" # "
 "DEFAULT")

 define_option_string(ARROW_RUNTIME_SIMD_LEVEL
Expand All@@ -196,17 +200,6 @@ takes precedence over ccache if a storage backend is configured" ON)
 "AVX512"
 "MAX")

 # Arm64 architectures and extensions can lead to exploding combinations.
 # So set it directly through cmake command line.
 #
 # If you change this, you need to change the definition in
 # python/CMakeLists.txt too.
 define_option_string(ARROW_ARMV8_ARCH
 "Arm64 arch and extensions"
 "armv8-a" # Default
 "armv8-a"
 "armv8-a+crc+crypto")

 define_option(ARROW_ALTIVEC "Build with Altivec if compiler has support" ON)

 define_option(ARROW_RPATH_ORIGIN "Build Arrow libraries with RATH set to \$ORIGIN" OFF)
Expand Down

39 changes: 20 additions & 19 deletions
cpp/cmake_modules/SetupCxxFlags.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,8 +110,8 @@ elseif(ARROW_CPU_FLAG STREQUAL "ppc")
 endif()
elseif(ARROW_CPU_FLAG STREQUAL "armv8")
 # Arm64 compiler flags, gcc/clang only
 set(ARROW_ARMV8_ARCH_FLAG "-march=${ARROW_ARMV8_ARCH}")
 check_cxx_compiler_flag(${ARROW_ARMV8_ARCH_FLAG} CXX_SUPPORTS_ARMV8_ARCH)
 set(ARROW_ARMV8_MARCH "armv8-a")
 check_cxx_compiler_flag("-march=${ARROW_ARMV8_MARCH}+sve" CXX_SUPPORTS_SVE)
 if(ARROW_SIMD_LEVEL STREQUAL "DEFAULT")
 set(ARROW_SIMD_LEVEL "NEON")
 endif()
Expand DownExpand Up@@ -485,26 +485,27 @@ if(ARROW_CPU_FLAG STREQUAL "ppc")
endif()

if(ARROW_CPU_FLAG STREQUAL "armv8")
 if(ARROW_SIMD_LEVEL STREQUAL "NEON")
 if(ARROW_SIMD_LEVEL MATCHES "NEON|SVE[0-9]*")
 set(ARROW_HAVE_NEON ON)
Comment thread
cyb70289 marked this conversation as resolved.


Outdated


 if(NOT CXX_SUPPORTS_ARMV8_ARCH)
 message(FATAL_ERROR "Unsupported arch flag: ${ARROW_ARMV8_ARCH_FLAG}.")
 endif()
 if(ARROW_ARMV8_ARCH_FLAG MATCHES "native")
 message(FATAL_ERROR "native arch not allowed, please specify arch explicitly.")
 endif()
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} ${ARROW_ARMV8_ARCH_FLAG}")

 add_definitions(-DARROW_HAVE_NEON)

 if(ARROW_ARMV8_ARCH_FLAG MATCHES "\\+crypto")
 add_definitions(-DARROW_HAVE_ARMV8_CRYPTO)
 endif()
 # armv8.1+ implies crc support
 if(ARROW_ARMV8_ARCH_FLAG MATCHES "armv8\\.[1-9]|\\+crc")
 add_definitions(-DARROW_HAVE_ARMV8_CRC)
 if(ARROW_SIMD_LEVEL MATCHES "SVE[0-9]*")
 if(NOT CXX_SUPPORTS_SVE)
 message(FATAL_ERROR "SVE required but compiler doesn't support it.")
 endif()
 # -march=armv8-a+sve
 set(ARROW_ARMV8_MARCH "${ARROW_ARMV8_MARCH}+sve")
 string(REGEX MATCH "[0-9]+" SVE_VECTOR_BITS ${ARROW_SIMD_LEVEL})
 if(SVE_VECTOR_BITS)
 set(ARROW_HAVE_SVE${SVE_VECTOR_BITS} ON)
 add_definitions(-DARROW_HAVE_SVE${SVE_VECTOR_BITS})
 # -msve-vector-bits=256
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -msve-vector-bits=${SVE_VECTOR_BITS}")
 else()
 set(ARROW_HAVE_SVE_SIZELESS ON)
 add_definitions(-DARROW_HAVE_SVE_SIZELSS)
 endif()
 endif()
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -march=${ARROW_ARMV8_MARCH}")
 elseif(NOT ARROW_SIMD_LEVEL STREQUAL "NONE")
 message(WARNING "ARROW_SIMD_LEVEL=${ARROW_SIMD_LEVEL} not supported by Arm.")
 endif()
Expand Down

4 changes: 2 additions & 2 deletions
cpp/src/arrow/io/memory_benchmark.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -154,7 +154,7 @@ static void StreamReadWrite(void* src, void* dst, size_t size) {

#endif // ARROW_HAVE_SSE4_2

#ifdef ARROW_HAVE_ARMV8_CRYPTO
#ifdef ARROW_HAVE_NEON

using VectorType = uint8x16_t;
using VectorTypeDual = uint8x16x2_t;
Expand DownExpand Up@@ -237,7 +237,7 @@ static void StreamReadWrite(void* src, void* dst, size_t size) {
 }
}

#endif // ARROW_HAVE_ARMV8_CRYPTO
#endif // ARROW_HAVE_NEON

static void PlatformMemcpy(void* src, void* dst, size_t size) { memcpy(src, dst, size); }

Expand Down

4 changes: 0 additions & 4 deletions
cpp/src/arrow/util/simd.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -41,8 +41,4 @@
#include <arm_neon.h>
#endif

#ifdef ARROW_HAVE_ARMV8_CRC
#include <arm_acle.h>
#endif

#endif

5 changes: 0 additions & 5 deletions
dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,11 +30,6 @@ else
 export PYARROW_WITH_CUDA=0
fi

# Resolve: Make Error at cmake_modules/SetupCxxFlags.cmake:338 (message): Unsupported arch flag: -march=.
Comment thread
cyb70289 marked this conversation as resolved.


Outdated

if [[ "${target_platform}" == "linux-aarch64" ]]; then
 export PYARROW_CMAKE_OPTIONS="-DARROW_ARMV8_ARCH=armv8-a ${PYARROW_CMAKE_OPTIONS}"
fi

if [[ "${target_platform}" == osx-* ]]; then
 # See https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk
 CXXFLAGS="${CXXFLAGS} -D_LIBCPP_DISABLE_AVAILABILITY"
Expand Down

5 changes: 0 additions & 5 deletions
python/CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -126,11 +126,6 @@ if(NOT DEFINED ARROW_RUNTIME_SIMD_LEVEL)
 "MAX"
 CACHE STRING "Max runtime SIMD optimization level")
endif()
if(NOT DEFINED ARROW_ARMV8_ARCH)
 set(ARROW_ARMV8_ARCH
 "armv8-a"
 CACHE STRING "Arm64 arch and extensions: armv8-a, armv8-a or armv8-a+crc+crypto")
endif()
include(SetupCxxFlags)

# Add common flags
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-18162: [C++] Add Arm SVE compiler options#14515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

cyb70289
merged 2 commits into

from

Nov 1, 2022
 Merged


ARROW-18162: [C++] Add Arm SVE compiler options
#14515
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
aa8ee3e

ARROW-18162: [C++] Add Arm SVE compiler options


cyb70289 Oct 25, 2022
f99b57a

Remove ARROW_ARMV8_ARCH cmake option


cyb70289 Oct 27, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 4 additions & 11 deletions
cpp/cmake_modules/DefineOptions.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -185,6 +185,10 @@ takes precedence over ccache if a storage backend is configured" ON)
 "AVX2"
 "AVX512"
 "NEON"
 "SVE" # size agnostic SVE
 "SVE128" # fixed size SVE
 "SVE256" # "
 "SVE512" # "
 "DEFAULT")

 define_option_string(ARROW_RUNTIME_SIMD_LEVEL
Expand All@@ -196,17 +200,6 @@ takes precedence over ccache if a storage backend is configured" ON)
 "AVX512"
 "MAX")

 # Arm64 architectures and extensions can lead to exploding combinations.
 # So set it directly through cmake command line.
 #
 # If you change this, you need to change the definition in
 # python/CMakeLists.txt too.
 define_option_string(ARROW_ARMV8_ARCH
 "Arm64 arch and extensions"
 "armv8-a" # Default
 "armv8-a"
 "armv8-a+crc+crypto")

 define_option(ARROW_ALTIVEC "Build with Altivec if compiler has support" ON)

 define_option(ARROW_RPATH_ORIGIN "Build Arrow libraries with RATH set to \$ORIGIN" OFF)
Expand Down

39 changes: 20 additions & 19 deletions
cpp/cmake_modules/SetupCxxFlags.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,8 +110,8 @@ elseif(ARROW_CPU_FLAG STREQUAL "ppc")
 endif()
elseif(ARROW_CPU_FLAG STREQUAL "armv8")
 # Arm64 compiler flags, gcc/clang only
 set(ARROW_ARMV8_ARCH_FLAG "-march=${ARROW_ARMV8_ARCH}")
 check_cxx_compiler_flag(${ARROW_ARMV8_ARCH_FLAG} CXX_SUPPORTS_ARMV8_ARCH)
 set(ARROW_ARMV8_MARCH "armv8-a")
 check_cxx_compiler_flag("-march=${ARROW_ARMV8_MARCH}+sve" CXX_SUPPORTS_SVE)
 if(ARROW_SIMD_LEVEL STREQUAL "DEFAULT")
 set(ARROW_SIMD_LEVEL "NEON")
 endif()
Expand DownExpand Up@@ -485,26 +485,27 @@ if(ARROW_CPU_FLAG STREQUAL "ppc")
endif()

if(ARROW_CPU_FLAG STREQUAL "armv8")
 if(ARROW_SIMD_LEVEL STREQUAL "NEON")
 if(ARROW_SIMD_LEVEL MATCHES "NEON|SVE[0-9]*")
 set(ARROW_HAVE_NEON ON)
Comment thread
cyb70289 marked this conversation as resolved.


Outdated


 if(NOT CXX_SUPPORTS_ARMV8_ARCH)
 message(FATAL_ERROR "Unsupported arch flag: ${ARROW_ARMV8_ARCH_FLAG}.")
 endif()
 if(ARROW_ARMV8_ARCH_FLAG MATCHES "native")
 message(FATAL_ERROR "native arch not allowed, please specify arch explicitly.")
 endif()
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} ${ARROW_ARMV8_ARCH_FLAG}")

 add_definitions(-DARROW_HAVE_NEON)

 if(ARROW_ARMV8_ARCH_FLAG MATCHES "\\+crypto")
 add_definitions(-DARROW_HAVE_ARMV8_CRYPTO)
 endif()
 # armv8.1+ implies crc support
 if(ARROW_ARMV8_ARCH_FLAG MATCHES "armv8\\.[1-9]|\\+crc")
 add_definitions(-DARROW_HAVE_ARMV8_CRC)
 if(ARROW_SIMD_LEVEL MATCHES "SVE[0-9]*")
 if(NOT CXX_SUPPORTS_SVE)
 message(FATAL_ERROR "SVE required but compiler doesn't support it.")
 endif()
 # -march=armv8-a+sve
 set(ARROW_ARMV8_MARCH "${ARROW_ARMV8_MARCH}+sve")
 string(REGEX MATCH "[0-9]+" SVE_VECTOR_BITS ${ARROW_SIMD_LEVEL})
 if(SVE_VECTOR_BITS)
 set(ARROW_HAVE_SVE${SVE_VECTOR_BITS} ON)
 add_definitions(-DARROW_HAVE_SVE${SVE_VECTOR_BITS})
 # -msve-vector-bits=256
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -msve-vector-bits=${SVE_VECTOR_BITS}")
 else()
 set(ARROW_HAVE_SVE_SIZELESS ON)
 add_definitions(-DARROW_HAVE_SVE_SIZELSS)
 endif()
 endif()
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -march=${ARROW_ARMV8_MARCH}")
 elseif(NOT ARROW_SIMD_LEVEL STREQUAL "NONE")
 message(WARNING "ARROW_SIMD_LEVEL=${ARROW_SIMD_LEVEL} not supported by Arm.")
 endif()
Expand Down

4 changes: 2 additions & 2 deletions
cpp/src/arrow/io/memory_benchmark.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -154,7 +154,7 @@ static void StreamReadWrite(void* src, void* dst, size_t size) {

#endif // ARROW_HAVE_SSE4_2

#ifdef ARROW_HAVE_ARMV8_CRYPTO
#ifdef ARROW_HAVE_NEON

using VectorType = uint8x16_t;
using VectorTypeDual = uint8x16x2_t;
Expand DownExpand Up@@ -237,7 +237,7 @@ static void StreamReadWrite(void* src, void* dst, size_t size) {
 }
}

#endif // ARROW_HAVE_ARMV8_CRYPTO
#endif // ARROW_HAVE_NEON

static void PlatformMemcpy(void* src, void* dst, size_t size) { memcpy(src, dst, size); }

Expand Down

4 changes: 0 additions & 4 deletions
cpp/src/arrow/util/simd.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -41,8 +41,4 @@
#include <arm_neon.h>
#endif

#ifdef ARROW_HAVE_ARMV8_CRC
#include <arm_acle.h>
#endif

#endif

5 changes: 0 additions & 5 deletions
dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,11 +30,6 @@ else
 export PYARROW_WITH_CUDA=0
fi

# Resolve: Make Error at cmake_modules/SetupCxxFlags.cmake:338 (message): Unsupported arch flag: -march=.
Comment thread
cyb70289 marked this conversation as resolved.


Outdated

if [[ "${target_platform}" == "linux-aarch64" ]]; then
 export PYARROW_CMAKE_OPTIONS="-DARROW_ARMV8_ARCH=armv8-a ${PYARROW_CMAKE_OPTIONS}"
fi

if [[ "${target_platform}" == osx-* ]]; then
 # See https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk
 CXXFLAGS="${CXXFLAGS} -D_LIBCPP_DISABLE_AVAILABILITY"
Expand Down

5 changes: 0 additions & 5 deletions
python/CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -126,11 +126,6 @@ if(NOT DEFINED ARROW_RUNTIME_SIMD_LEVEL)
 "MAX"
 CACHE STRING "Max runtime SIMD optimization level")
endif()
if(NOT DEFINED ARROW_ARMV8_ARCH)
 set(ARROW_ARMV8_ARCH
 "armv8-a"
 CACHE STRING "Arm64 arch and extensions: armv8-a, armv8-a or armv8-a+crc+crypto")
endif()
include(SetupCxxFlags)

# Add common flags
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ARROW-18162: [C++] Add Arm SVE compiler options#14515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

cyb70289
merged 2 commits into

from

Nov 1, 2022
 Merged


ARROW-18162: [C++] Add Arm SVE compiler options
#14515
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
aa8ee3e

ARROW-18162: [C++] Add Arm SVE compiler options


cyb70289 Oct 25, 2022
f99b57a

Remove ARROW_ARMV8_ARCH cmake option


cyb70289 Oct 27, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 4 additions & 11 deletions
cpp/cmake_modules/DefineOptions.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -185,6 +185,10 @@ takes precedence over ccache if a storage backend is configured" ON)
 "AVX2"
 "AVX512"
 "NEON"
 "SVE" # size agnostic SVE
 "SVE128" # fixed size SVE
 "SVE256" # "
 "SVE512" # "
 "DEFAULT")

 define_option_string(ARROW_RUNTIME_SIMD_LEVEL
Expand All@@ -196,17 +200,6 @@ takes precedence over ccache if a storage backend is configured" ON)
 "AVX512"
 "MAX")

 # Arm64 architectures and extensions can lead to exploding combinations.
 # So set it directly through cmake command line.
 #
 # If you change this, you need to change the definition in
 # python/CMakeLists.txt too.
 define_option_string(ARROW_ARMV8_ARCH
 "Arm64 arch and extensions"
 "armv8-a" # Default
 "armv8-a"
 "armv8-a+crc+crypto")

 define_option(ARROW_ALTIVEC "Build with Altivec if compiler has support" ON)

 define_option(ARROW_RPATH_ORIGIN "Build Arrow libraries with RATH set to \$ORIGIN" OFF)
Expand Down

39 changes: 20 additions & 19 deletions
cpp/cmake_modules/SetupCxxFlags.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,8 +110,8 @@ elseif(ARROW_CPU_FLAG STREQUAL "ppc")
 endif()
elseif(ARROW_CPU_FLAG STREQUAL "armv8")
 # Arm64 compiler flags, gcc/clang only
 set(ARROW_ARMV8_ARCH_FLAG "-march=${ARROW_ARMV8_ARCH}")
 check_cxx_compiler_flag(${ARROW_ARMV8_ARCH_FLAG} CXX_SUPPORTS_ARMV8_ARCH)
 set(ARROW_ARMV8_MARCH "armv8-a")
 check_cxx_compiler_flag("-march=${ARROW_ARMV8_MARCH}+sve" CXX_SUPPORTS_SVE)
 if(ARROW_SIMD_LEVEL STREQUAL "DEFAULT")
 set(ARROW_SIMD_LEVEL "NEON")
 endif()
Expand DownExpand Up@@ -485,26 +485,27 @@ if(ARROW_CPU_FLAG STREQUAL "ppc")
endif()

if(ARROW_CPU_FLAG STREQUAL "armv8")
 if(ARROW_SIMD_LEVEL STREQUAL "NEON")
 if(ARROW_SIMD_LEVEL MATCHES "NEON|SVE[0-9]*")
 set(ARROW_HAVE_NEON ON)
Comment thread
cyb70289 marked this conversation as resolved.


Outdated


 if(NOT CXX_SUPPORTS_ARMV8_ARCH)
 message(FATAL_ERROR "Unsupported arch flag: ${ARROW_ARMV8_ARCH_FLAG}.")
 endif()
 if(ARROW_ARMV8_ARCH_FLAG MATCHES "native")
 message(FATAL_ERROR "native arch not allowed, please specify arch explicitly.")
 endif()
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} ${ARROW_ARMV8_ARCH_FLAG}")

 add_definitions(-DARROW_HAVE_NEON)

 if(ARROW_ARMV8_ARCH_FLAG MATCHES "\\+crypto")
 add_definitions(-DARROW_HAVE_ARMV8_CRYPTO)
 endif()
 # armv8.1+ implies crc support
 if(ARROW_ARMV8_ARCH_FLAG MATCHES "armv8\\.[1-9]|\\+crc")
 add_definitions(-DARROW_HAVE_ARMV8_CRC)
 if(ARROW_SIMD_LEVEL MATCHES "SVE[0-9]*")
 if(NOT CXX_SUPPORTS_SVE)
 message(FATAL_ERROR "SVE required but compiler doesn't support it.")
 endif()
 # -march=armv8-a+sve
 set(ARROW_ARMV8_MARCH "${ARROW_ARMV8_MARCH}+sve")
 string(REGEX MATCH "[0-9]+" SVE_VECTOR_BITS ${ARROW_SIMD_LEVEL})
 if(SVE_VECTOR_BITS)
 set(ARROW_HAVE_SVE${SVE_VECTOR_BITS} ON)
 add_definitions(-DARROW_HAVE_SVE${SVE_VECTOR_BITS})
 # -msve-vector-bits=256
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -msve-vector-bits=${SVE_VECTOR_BITS}")
 else()
 set(ARROW_HAVE_SVE_SIZELESS ON)
 add_definitions(-DARROW_HAVE_SVE_SIZELSS)
 endif()
 endif()
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -march=${ARROW_ARMV8_MARCH}")
 elseif(NOT ARROW_SIMD_LEVEL STREQUAL "NONE")
 message(WARNING "ARROW_SIMD_LEVEL=${ARROW_SIMD_LEVEL} not supported by Arm.")
 endif()
Expand Down

4 changes: 2 additions & 2 deletions
cpp/src/arrow/io/memory_benchmark.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -154,7 +154,7 @@ static void StreamReadWrite(void* src, void* dst, size_t size) {

#endif // ARROW_HAVE_SSE4_2

#ifdef ARROW_HAVE_ARMV8_CRYPTO
#ifdef ARROW_HAVE_NEON

using VectorType = uint8x16_t;
using VectorTypeDual = uint8x16x2_t;
Expand DownExpand Up@@ -237,7 +237,7 @@ static void StreamReadWrite(void* src, void* dst, size_t size) {
 }
}

#endif // ARROW_HAVE_ARMV8_CRYPTO
#endif // ARROW_HAVE_NEON

static void PlatformMemcpy(void* src, void* dst, size_t size) { memcpy(src, dst, size); }

Expand Down

4 changes: 0 additions & 4 deletions
cpp/src/arrow/util/simd.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -41,8 +41,4 @@
#include <arm_neon.h>
#endif

#ifdef ARROW_HAVE_ARMV8_CRC
#include <arm_acle.h>
#endif

#endif

5 changes: 0 additions & 5 deletions
dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,11 +30,6 @@ else
 export PYARROW_WITH_CUDA=0
fi

# Resolve: Make Error at cmake_modules/SetupCxxFlags.cmake:338 (message): Unsupported arch flag: -march=.
Comment thread
cyb70289 marked this conversation as resolved.


Outdated

if [[ "${target_platform}" == "linux-aarch64" ]]; then
 export PYARROW_CMAKE_OPTIONS="-DARROW_ARMV8_ARCH=armv8-a ${PYARROW_CMAKE_OPTIONS}"
fi

if [[ "${target_platform}" == osx-* ]]; then
 # See https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk
 CXXFLAGS="${CXXFLAGS} -D_LIBCPP_DISABLE_AVAILABILITY"
Expand Down

5 changes: 0 additions & 5 deletions
python/CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -126,11 +126,6 @@ if(NOT DEFINED ARROW_RUNTIME_SIMD_LEVEL)
 "MAX"
 CACHE STRING "Max runtime SIMD optimization level")
endif()
if(NOT DEFINED ARROW_ARMV8_ARCH)
 set(ARROW_ARMV8_ARCH
 "armv8-a"
 CACHE STRING "Arm64 arch and extensions: armv8-a, armv8-a or armv8-a+crc+crypto")
endif()
include(SetupCxxFlags)

# Add common flags
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-18162: [C++] Add Arm SVE compiler options#14515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

cyb70289
merged 2 commits into

from

Nov 1, 2022
 Merged


ARROW-18162: [C++] Add Arm SVE compiler options
#14515
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
aa8ee3e

ARROW-18162: [C++] Add Arm SVE compiler options


cyb70289 Oct 25, 2022
f99b57a

Remove ARROW_ARMV8_ARCH cmake option


cyb70289 Oct 27, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 4 additions & 11 deletions
cpp/cmake_modules/DefineOptions.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -185,6 +185,10 @@ takes precedence over ccache if a storage backend is configured" ON)
 "AVX2"
 "AVX512"
 "NEON"
 "SVE" # size agnostic SVE
 "SVE128" # fixed size SVE
 "SVE256" # "
 "SVE512" # "
 "DEFAULT")

 define_option_string(ARROW_RUNTIME_SIMD_LEVEL
Expand All@@ -196,17 +200,6 @@ takes precedence over ccache if a storage backend is configured" ON)
 "AVX512"
 "MAX")

 # Arm64 architectures and extensions can lead to exploding combinations.
 # So set it directly through cmake command line.
 #
 # If you change this, you need to change the definition in
 # python/CMakeLists.txt too.
 define_option_string(ARROW_ARMV8_ARCH
 "Arm64 arch and extensions"
 "armv8-a" # Default
 "armv8-a"
 "armv8-a+crc+crypto")

 define_option(ARROW_ALTIVEC "Build with Altivec if compiler has support" ON)

 define_option(ARROW_RPATH_ORIGIN "Build Arrow libraries with RATH set to \$ORIGIN" OFF)
Expand Down

39 changes: 20 additions & 19 deletions
cpp/cmake_modules/SetupCxxFlags.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,8 +110,8 @@ elseif(ARROW_CPU_FLAG STREQUAL "ppc")
 endif()
elseif(ARROW_CPU_FLAG STREQUAL "armv8")
 # Arm64 compiler flags, gcc/clang only
 set(ARROW_ARMV8_ARCH_FLAG "-march=${ARROW_ARMV8_ARCH}")
 check_cxx_compiler_flag(${ARROW_ARMV8_ARCH_FLAG} CXX_SUPPORTS_ARMV8_ARCH)
 set(ARROW_ARMV8_MARCH "armv8-a")
 check_cxx_compiler_flag("-march=${ARROW_ARMV8_MARCH}+sve" CXX_SUPPORTS_SVE)
 if(ARROW_SIMD_LEVEL STREQUAL "DEFAULT")
 set(ARROW_SIMD_LEVEL "NEON")
 endif()
Expand DownExpand Up@@ -485,26 +485,27 @@ if(ARROW_CPU_FLAG STREQUAL "ppc")
endif()

if(ARROW_CPU_FLAG STREQUAL "armv8")
 if(ARROW_SIMD_LEVEL STREQUAL "NEON")
 if(ARROW_SIMD_LEVEL MATCHES "NEON|SVE[0-9]*")
 set(ARROW_HAVE_NEON ON)
Comment thread
cyb70289 marked this conversation as resolved.


Outdated


 if(NOT CXX_SUPPORTS_ARMV8_ARCH)
 message(FATAL_ERROR "Unsupported arch flag: ${ARROW_ARMV8_ARCH_FLAG}.")
 endif()
 if(ARROW_ARMV8_ARCH_FLAG MATCHES "native")
 message(FATAL_ERROR "native arch not allowed, please specify arch explicitly.")
 endif()
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} ${ARROW_ARMV8_ARCH_FLAG}")

 add_definitions(-DARROW_HAVE_NEON)

 if(ARROW_ARMV8_ARCH_FLAG MATCHES "\\+crypto")
 add_definitions(-DARROW_HAVE_ARMV8_CRYPTO)
 endif()
 # armv8.1+ implies crc support
 if(ARROW_ARMV8_ARCH_FLAG MATCHES "armv8\\.[1-9]|\\+crc")
 add_definitions(-DARROW_HAVE_ARMV8_CRC)
 if(ARROW_SIMD_LEVEL MATCHES "SVE[0-9]*")
 if(NOT CXX_SUPPORTS_SVE)
 message(FATAL_ERROR "SVE required but compiler doesn't support it.")
 endif()
 # -march=armv8-a+sve
 set(ARROW_ARMV8_MARCH "${ARROW_ARMV8_MARCH}+sve")
 string(REGEX MATCH "[0-9]+" SVE_VECTOR_BITS ${ARROW_SIMD_LEVEL})
 if(SVE_VECTOR_BITS)
 set(ARROW_HAVE_SVE${SVE_VECTOR_BITS} ON)
 add_definitions(-DARROW_HAVE_SVE${SVE_VECTOR_BITS})
 # -msve-vector-bits=256
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -msve-vector-bits=${SVE_VECTOR_BITS}")
 else()
 set(ARROW_HAVE_SVE_SIZELESS ON)
 add_definitions(-DARROW_HAVE_SVE_SIZELSS)
 endif()
 endif()
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -march=${ARROW_ARMV8_MARCH}")
 elseif(NOT ARROW_SIMD_LEVEL STREQUAL "NONE")
 message(WARNING "ARROW_SIMD_LEVEL=${ARROW_SIMD_LEVEL} not supported by Arm.")
 endif()
Expand Down

4 changes: 2 additions & 2 deletions
cpp/src/arrow/io/memory_benchmark.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -154,7 +154,7 @@ static void StreamReadWrite(void* src, void* dst, size_t size) {

#endif // ARROW_HAVE_SSE4_2

#ifdef ARROW_HAVE_ARMV8_CRYPTO
#ifdef ARROW_HAVE_NEON

using VectorType = uint8x16_t;
using VectorTypeDual = uint8x16x2_t;
Expand DownExpand Up@@ -237,7 +237,7 @@ static void StreamReadWrite(void* src, void* dst, size_t size) {
 }
}

#endif // ARROW_HAVE_ARMV8_CRYPTO
#endif // ARROW_HAVE_NEON

static void PlatformMemcpy(void* src, void* dst, size_t size) { memcpy(src, dst, size); }

Expand Down

4 changes: 0 additions & 4 deletions
cpp/src/arrow/util/simd.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -41,8 +41,4 @@
#include <arm_neon.h>
#endif

#ifdef ARROW_HAVE_ARMV8_CRC
#include <arm_acle.h>
#endif

#endif

5 changes: 0 additions & 5 deletions
dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,11 +30,6 @@ else
 export PYARROW_WITH_CUDA=0
fi

# Resolve: Make Error at cmake_modules/SetupCxxFlags.cmake:338 (message): Unsupported arch flag: -march=.
Comment thread
cyb70289 marked this conversation as resolved.


Outdated

if [[ "${target_platform}" == "linux-aarch64" ]]; then
 export PYARROW_CMAKE_OPTIONS="-DARROW_ARMV8_ARCH=armv8-a ${PYARROW_CMAKE_OPTIONS}"
fi

if [[ "${target_platform}" == osx-* ]]; then
 # See https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk
 CXXFLAGS="${CXXFLAGS} -D_LIBCPP_DISABLE_AVAILABILITY"
Expand Down

5 changes: 0 additions & 5 deletions
python/CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -126,11 +126,6 @@ if(NOT DEFINED ARROW_RUNTIME_SIMD_LEVEL)
 "MAX"
 CACHE STRING "Max runtime SIMD optimization level")
endif()
if(NOT DEFINED ARROW_ARMV8_ARCH)
 set(ARROW_ARMV8_ARCH
 "armv8-a"
 CACHE STRING "Arm64 arch and extensions: armv8-a, armv8-a or armv8-a+crc+crypto")
endif()
include(SetupCxxFlags)

# Add common flags
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-18162: [C++] Add Arm SVE compiler options#14515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

cyb70289
merged 2 commits into

from

Nov 1, 2022
 Merged


ARROW-18162: [C++] Add Arm SVE compiler options
#14515
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
aa8ee3e

ARROW-18162: [C++] Add Arm SVE compiler options


cyb70289 Oct 25, 2022
f99b57a

Remove ARROW_ARMV8_ARCH cmake option


cyb70289 Oct 27, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 4 additions & 11 deletions
cpp/cmake_modules/DefineOptions.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -185,6 +185,10 @@ takes precedence over ccache if a storage backend is configured" ON)
 "AVX2"
 "AVX512"
 "NEON"
 "SVE" # size agnostic SVE
 "SVE128" # fixed size SVE
 "SVE256" # "
 "SVE512" # "
 "DEFAULT")

 define_option_string(ARROW_RUNTIME_SIMD_LEVEL
Expand All@@ -196,17 +200,6 @@ takes precedence over ccache if a storage backend is configured" ON)
 "AVX512"
 "MAX")

 # Arm64 architectures and extensions can lead to exploding combinations.
 # So set it directly through cmake command line.
 #
 # If you change this, you need to change the definition in
 # python/CMakeLists.txt too.
 define_option_string(ARROW_ARMV8_ARCH
 "Arm64 arch and extensions"
 "armv8-a" # Default
 "armv8-a"
 "armv8-a+crc+crypto")

 define_option(ARROW_ALTIVEC "Build with Altivec if compiler has support" ON)

 define_option(ARROW_RPATH_ORIGIN "Build Arrow libraries with RATH set to \$ORIGIN" OFF)
Expand Down

39 changes: 20 additions & 19 deletions
cpp/cmake_modules/SetupCxxFlags.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,8 +110,8 @@ elseif(ARROW_CPU_FLAG STREQUAL "ppc")
 endif()
elseif(ARROW_CPU_FLAG STREQUAL "armv8")
 # Arm64 compiler flags, gcc/clang only
 set(ARROW_ARMV8_ARCH_FLAG "-march=${ARROW_ARMV8_ARCH}")
 check_cxx_compiler_flag(${ARROW_ARMV8_ARCH_FLAG} CXX_SUPPORTS_ARMV8_ARCH)
 set(ARROW_ARMV8_MARCH "armv8-a")
 check_cxx_compiler_flag("-march=${ARROW_ARMV8_MARCH}+sve" CXX_SUPPORTS_SVE)
 if(ARROW_SIMD_LEVEL STREQUAL "DEFAULT")
 set(ARROW_SIMD_LEVEL "NEON")
 endif()
Expand DownExpand Up@@ -485,26 +485,27 @@ if(ARROW_CPU_FLAG STREQUAL "ppc")
endif()

if(ARROW_CPU_FLAG STREQUAL "armv8")
 if(ARROW_SIMD_LEVEL STREQUAL "NEON")
 if(ARROW_SIMD_LEVEL MATCHES "NEON|SVE[0-9]*")
 set(ARROW_HAVE_NEON ON)
Comment thread
cyb70289 marked this conversation as resolved.


Outdated


 if(NOT CXX_SUPPORTS_ARMV8_ARCH)
 message(FATAL_ERROR "Unsupported arch flag: ${ARROW_ARMV8_ARCH_FLAG}.")
 endif()
 if(ARROW_ARMV8_ARCH_FLAG MATCHES "native")
 message(FATAL_ERROR "native arch not allowed, please specify arch explicitly.")
 endif()
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} ${ARROW_ARMV8_ARCH_FLAG}")

 add_definitions(-DARROW_HAVE_NEON)

 if(ARROW_ARMV8_ARCH_FLAG MATCHES "\\+crypto")
 add_definitions(-DARROW_HAVE_ARMV8_CRYPTO)
 endif()
 # armv8.1+ implies crc support
 if(ARROW_ARMV8_ARCH_FLAG MATCHES "armv8\\.[1-9]|\\+crc")
 add_definitions(-DARROW_HAVE_ARMV8_CRC)
 if(ARROW_SIMD_LEVEL MATCHES "SVE[0-9]*")
 if(NOT CXX_SUPPORTS_SVE)
 message(FATAL_ERROR "SVE required but compiler doesn't support it.")
 endif()
 # -march=armv8-a+sve
 set(ARROW_ARMV8_MARCH "${ARROW_ARMV8_MARCH}+sve")
 string(REGEX MATCH "[0-9]+" SVE_VECTOR_BITS ${ARROW_SIMD_LEVEL})
 if(SVE_VECTOR_BITS)
 set(ARROW_HAVE_SVE${SVE_VECTOR_BITS} ON)
 add_definitions(-DARROW_HAVE_SVE${SVE_VECTOR_BITS})
 # -msve-vector-bits=256
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -msve-vector-bits=${SVE_VECTOR_BITS}")
 else()
 set(ARROW_HAVE_SVE_SIZELESS ON)
 add_definitions(-DARROW_HAVE_SVE_SIZELSS)
 endif()
 endif()
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -march=${ARROW_ARMV8_MARCH}")
 elseif(NOT ARROW_SIMD_LEVEL STREQUAL "NONE")
 message(WARNING "ARROW_SIMD_LEVEL=${ARROW_SIMD_LEVEL} not supported by Arm.")
 endif()
Expand Down

4 changes: 2 additions & 2 deletions
cpp/src/arrow/io/memory_benchmark.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -154,7 +154,7 @@ static void StreamReadWrite(void* src, void* dst, size_t size) {

#endif // ARROW_HAVE_SSE4_2

#ifdef ARROW_HAVE_ARMV8_CRYPTO
#ifdef ARROW_HAVE_NEON

using VectorType = uint8x16_t;
using VectorTypeDual = uint8x16x2_t;
Expand DownExpand Up@@ -237,7 +237,7 @@ static void StreamReadWrite(void* src, void* dst, size_t size) {
 }
}

#endif // ARROW_HAVE_ARMV8_CRYPTO
#endif // ARROW_HAVE_NEON

static void PlatformMemcpy(void* src, void* dst, size_t size) { memcpy(src, dst, size); }

Expand Down

4 changes: 0 additions & 4 deletions
cpp/src/arrow/util/simd.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -41,8 +41,4 @@
#include <arm_neon.h>
#endif

#ifdef ARROW_HAVE_ARMV8_CRC
#include <arm_acle.h>
#endif

#endif

5 changes: 0 additions & 5 deletions
dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,11 +30,6 @@ else
 export PYARROW_WITH_CUDA=0
fi

# Resolve: Make Error at cmake_modules/SetupCxxFlags.cmake:338 (message): Unsupported arch flag: -march=.
Comment thread
cyb70289 marked this conversation as resolved.


Outdated

if [[ "${target_platform}" == "linux-aarch64" ]]; then
 export PYARROW_CMAKE_OPTIONS="-DARROW_ARMV8_ARCH=armv8-a ${PYARROW_CMAKE_OPTIONS}"
fi

if [[ "${target_platform}" == osx-* ]]; then
 # See https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk
 CXXFLAGS="${CXXFLAGS} -D_LIBCPP_DISABLE_AVAILABILITY"
Expand Down

5 changes: 0 additions & 5 deletions
python/CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -126,11 +126,6 @@ if(NOT DEFINED ARROW_RUNTIME_SIMD_LEVEL)
 "MAX"
 CACHE STRING "Max runtime SIMD optimization level")
endif()
if(NOT DEFINED ARROW_ARMV8_ARCH)
 set(ARROW_ARMV8_ARCH
 "armv8-a"
 CACHE STRING "Arm64 arch and extensions: armv8-a, armv8-a or armv8-a+crc+crypto")
endif()
include(SetupCxxFlags)

# Add common flags
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ARROW-18162: [C++] Add Arm SVE compiler options#14515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

cyb70289
merged 2 commits into

from

Nov 1, 2022
 Merged


ARROW-18162: [C++] Add Arm SVE compiler options
#14515
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
aa8ee3e

ARROW-18162: [C++] Add Arm SVE compiler options


cyb70289 Oct 25, 2022
f99b57a

Remove ARROW_ARMV8_ARCH cmake option


cyb70289 Oct 27, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 4 additions & 11 deletions
cpp/cmake_modules/DefineOptions.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -185,6 +185,10 @@ takes precedence over ccache if a storage backend is configured" ON)
 "AVX2"
 "AVX512"
 "NEON"
 "SVE" # size agnostic SVE
 "SVE128" # fixed size SVE
 "SVE256" # "
 "SVE512" # "
 "DEFAULT")

 define_option_string(ARROW_RUNTIME_SIMD_LEVEL
Expand All@@ -196,17 +200,6 @@ takes precedence over ccache if a storage backend is configured" ON)
 "AVX512"
 "MAX")

 # Arm64 architectures and extensions can lead to exploding combinations.
 # So set it directly through cmake command line.
 #
 # If you change this, you need to change the definition in
 # python/CMakeLists.txt too.
 define_option_string(ARROW_ARMV8_ARCH
 "Arm64 arch and extensions"
 "armv8-a" # Default
 "armv8-a"
 "armv8-a+crc+crypto")

 define_option(ARROW_ALTIVEC "Build with Altivec if compiler has support" ON)

 define_option(ARROW_RPATH_ORIGIN "Build Arrow libraries with RATH set to \$ORIGIN" OFF)
Expand Down

39 changes: 20 additions & 19 deletions
cpp/cmake_modules/SetupCxxFlags.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,8 +110,8 @@ elseif(ARROW_CPU_FLAG STREQUAL "ppc")
 endif()
elseif(ARROW_CPU_FLAG STREQUAL "armv8")
 # Arm64 compiler flags, gcc/clang only
 set(ARROW_ARMV8_ARCH_FLAG "-march=${ARROW_ARMV8_ARCH}")
 check_cxx_compiler_flag(${ARROW_ARMV8_ARCH_FLAG} CXX_SUPPORTS_ARMV8_ARCH)
 set(ARROW_ARMV8_MARCH "armv8-a")
 check_cxx_compiler_flag("-march=${ARROW_ARMV8_MARCH}+sve" CXX_SUPPORTS_SVE)
 if(ARROW_SIMD_LEVEL STREQUAL "DEFAULT")
 set(ARROW_SIMD_LEVEL "NEON")
 endif()
Expand DownExpand Up@@ -485,26 +485,27 @@ if(ARROW_CPU_FLAG STREQUAL "ppc")
endif()

if(ARROW_CPU_FLAG STREQUAL "armv8")
 if(ARROW_SIMD_LEVEL STREQUAL "NEON")
 if(ARROW_SIMD_LEVEL MATCHES "NEON|SVE[0-9]*")
 set(ARROW_HAVE_NEON ON)
Comment thread
cyb70289 marked this conversation as resolved.


Outdated


 if(NOT CXX_SUPPORTS_ARMV8_ARCH)
 message(FATAL_ERROR "Unsupported arch flag: ${ARROW_ARMV8_ARCH_FLAG}.")
 endif()
 if(ARROW_ARMV8_ARCH_FLAG MATCHES "native")
 message(FATAL_ERROR "native arch not allowed, please specify arch explicitly.")
 endif()
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} ${ARROW_ARMV8_ARCH_FLAG}")

 add_definitions(-DARROW_HAVE_NEON)

 if(ARROW_ARMV8_ARCH_FLAG MATCHES "\\+crypto")
 add_definitions(-DARROW_HAVE_ARMV8_CRYPTO)
 endif()
 # armv8.1+ implies crc support
 if(ARROW_ARMV8_ARCH_FLAG MATCHES "armv8\\.[1-9]|\\+crc")
 add_definitions(-DARROW_HAVE_ARMV8_CRC)
 if(ARROW_SIMD_LEVEL MATCHES "SVE[0-9]*")
 if(NOT CXX_SUPPORTS_SVE)
 message(FATAL_ERROR "SVE required but compiler doesn't support it.")
 endif()
 # -march=armv8-a+sve
 set(ARROW_ARMV8_MARCH "${ARROW_ARMV8_MARCH}+sve")
 string(REGEX MATCH "[0-9]+" SVE_VECTOR_BITS ${ARROW_SIMD_LEVEL})
 if(SVE_VECTOR_BITS)
 set(ARROW_HAVE_SVE${SVE_VECTOR_BITS} ON)
 add_definitions(-DARROW_HAVE_SVE${SVE_VECTOR_BITS})
 # -msve-vector-bits=256
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -msve-vector-bits=${SVE_VECTOR_BITS}")
 else()
 set(ARROW_HAVE_SVE_SIZELESS ON)
 add_definitions(-DARROW_HAVE_SVE_SIZELSS)
 endif()
 endif()
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -march=${ARROW_ARMV8_MARCH}")
 elseif(NOT ARROW_SIMD_LEVEL STREQUAL "NONE")
 message(WARNING "ARROW_SIMD_LEVEL=${ARROW_SIMD_LEVEL} not supported by Arm.")
 endif()
Expand Down

4 changes: 2 additions & 2 deletions
cpp/src/arrow/io/memory_benchmark.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -154,7 +154,7 @@ static void StreamReadWrite(void* src, void* dst, size_t size) {

#endif // ARROW_HAVE_SSE4_2

#ifdef ARROW_HAVE_ARMV8_CRYPTO
#ifdef ARROW_HAVE_NEON

using VectorType = uint8x16_t;
using VectorTypeDual = uint8x16x2_t;
Expand DownExpand Up@@ -237,7 +237,7 @@ static void StreamReadWrite(void* src, void* dst, size_t size) {
 }
}

#endif // ARROW_HAVE_ARMV8_CRYPTO
#endif // ARROW_HAVE_NEON

static void PlatformMemcpy(void* src, void* dst, size_t size) { memcpy(src, dst, size); }

Expand Down

4 changes: 0 additions & 4 deletions
cpp/src/arrow/util/simd.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -41,8 +41,4 @@
#include <arm_neon.h>
#endif

#ifdef ARROW_HAVE_ARMV8_CRC
#include <arm_acle.h>
#endif

#endif

5 changes: 0 additions & 5 deletions
dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,11 +30,6 @@ else
 export PYARROW_WITH_CUDA=0
fi

# Resolve: Make Error at cmake_modules/SetupCxxFlags.cmake:338 (message): Unsupported arch flag: -march=.
Comment thread
cyb70289 marked this conversation as resolved.


Outdated

if [[ "${target_platform}" == "linux-aarch64" ]]; then
 export PYARROW_CMAKE_OPTIONS="-DARROW_ARMV8_ARCH=armv8-a ${PYARROW_CMAKE_OPTIONS}"
fi

if [[ "${target_platform}" == osx-* ]]; then
 # See https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk
 CXXFLAGS="${CXXFLAGS} -D_LIBCPP_DISABLE_AVAILABILITY"
Expand Down

5 changes: 0 additions & 5 deletions
python/CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -126,11 +126,6 @@ if(NOT DEFINED ARROW_RUNTIME_SIMD_LEVEL)
 "MAX"
 CACHE STRING "Max runtime SIMD optimization level")
endif()
if(NOT DEFINED ARROW_ARMV8_ARCH)
 set(ARROW_ARMV8_ARCH
 "armv8-a"
 CACHE STRING "Arm64 arch and extensions: armv8-a, armv8-a or armv8-a+crc+crypto")
endif()
include(SetupCxxFlags)

# Add common flags
Expand Down