Skip to content

ARROW-2225: [JS] support tables split across buffers - #1670

Closed
trxcllnt wants to merge 1 commit into
apache:masterfrom
trxcllnt:js-fix-multiple-buffers
Closed

ARROW-2225: [JS] support tables split across buffers#1670
trxcllnt wants to merge 1 commit into
apache:masterfrom
trxcllnt:js-fix-multiple-buffers

Conversation

@trxcllnt

@trxcllnttrxcllnt commented Feb 27, 2018

Copy link
Copy Markdown
Contributor

@TheNeuralBit somewhere along the way we lost this. Resolves https://issues.apache.org/jira/browse/ARROW-2225

@trxcllnttrxcllnt changed the title [JS]: support tables split across buffersARROW-2225: [JS] support tables split across buffersFeb 27, 2018
@wesm

wesm commented Feb 27, 2018

Copy link
Copy Markdown
Member

Any way to test this?

@TheNeuralBit

TheNeuralBit commented Feb 27, 2018

Copy link
Copy Markdown
Member

@wesm I'm working on testing it right now, I can merge when I'm done

Edit: If you mean automated tests - we used to have snapshot files that exercised this feature but not anymore after switching over to integration tests

@TheNeuralBit

Copy link
Copy Markdown
Member

LGTM - Tested locally with an Arrow stream I manually split into a "Schema" and a "Batches" buffer.

We should definitely add a test for this, but I'm not sure how to do it right now.. any objections to waiting until we have a JS IPC writer?

@trxcllnt

Copy link
Copy Markdown
ContributorAuthor

@TheNeuralBit yeah, that's what I was thinking too. I think we can sit tight since that's now back in progress.

@TheNeuralBit

Copy link
Copy Markdown
Member

Created ARROW-2235 to track test creation

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@trxcllnt@wesm@TheNeuralBit