Skip to content

ARROW-2225: [JS] support tables split across buffers#1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trxcllnt wants to merge 1 commit into from
Closed

ARROW-2225: [JS] support tables split across buffers #1670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions js/src/ipc/reader/binary.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,7 +49,7 @@ export function* readBuffers<T extends Uint8Array | Buffer | string>(sources: It
}
for (const source of sources) {
const bb = toByteBuffer(source);
if ((!schema && ({ schema, readMessages } = readSchema(bb))) && schema && readMessages) {
if ((!schema && ({ schema, readMessages } = readSchema(bb)) || true) && schema && readMessages) {
for (const message of readMessages(bb)) {
yield {
schema, message,
Expand All@@ -71,7 +71,7 @@ export async function* readBuffersAsync<T extends Uint8Array | Buffer | string>(
let readMessages: MessageReader | null = null;
for await (const source of sources) {
const bb = toByteBuffer(source);
if ((!schema && ({ schema, readMessages } = readSchema(bb))) && schema && readMessages) {
if ((!schema && ({ schema, readMessages } = readSchema(bb)) || true) && schema && readMessages) {
for (const message of readMessages(bb)) {
yield {
schema, message,
Expand Down