ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit - #3443

Closed
kou wants to merge 1 commit into
apache:masterfrom
kou:cpp-mingw-32
Closed

ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit#3443
kou wants to merge 1 commit into
apache:masterfrom
kou:cpp-mingw-32

Conversation

@kou

@koukou commented Jan 21, 2019

Copy link
Copy Markdown
Member

No description provided.

@kszucs

kszucs commented Jan 21, 2019

Copy link
Copy Markdown
Member

How could We test this in an automatized way?

@kou

kou commented Jan 21, 2019

Copy link
Copy Markdown
MemberAuthor

I'm working: https://github.com/kou/arrow/tree/appveyor-msys :-)

@codecov-io

codecov-io commented Jan 21, 2019

Copy link
Copy Markdown

Codecov Report

Merging #3443 into master will increase coverage by 0.98%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #3443 +/- ##
==========================================
+ Coverage 88.31% 89.29% +0.98% 
==========================================
Files 632 503 -129 Lines 79288 70321 -8967 Branches 1069 0 -1069 ==========================================
- Hits 70021 62793 -7228 + Misses 9152 7528 -1624 + Partials 115 0 -115
Impacted FilesCoverage Δ
cpp/src/arrow/util/sse-util.h100% <ø> (ø)⬆️
cpp/src/arrow/csv/column-builder.cc95.45% <0%> (-1.95%)⬇️
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
js/src/enum.ts
go/arrow/array/builder.go
js/src/Arrow.node.ts
js/src/schema.ts
go/arrow/type_traits_boolean.go
js/src/ipc/node/writer.ts
... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 349a957...bd8b8eb. Read the comment docs.

pitrou
pitrou requested changes Jan 21, 2019
View reviewed changes
Comment threadcpp/src/arrow/util/sse-util.h

static inline uint32_t SSE4_crc32_u64(uint32_t crc, uint64_t v) {
#if defined(__MINGW32__) && !defined(__MINGW64__)
DCHECK(false) << "MinGW-w64 32-bit doesn't support _mm_crc32_u64()";

@pitroupitrouJan 21, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run the tests or are you only concerned about building? This is pretty much not the right solution.

@koukouJan 25, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for fixing build error.
I'm working on test support on MSYS2 in separated issues.
I'll be back again after we can run tests on MSYS2.

@pitrou

pitrou commented Jan 21, 2019

Copy link
Copy Markdown
Member

The appropriate solution is something like this, though according to @jeroen it is insufficient:
https://gist.github.com/pitrou/f4282f68a8dc9b11fe931bd0eeb1f8af

@jeroen

jeroen commented Jan 24, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

@pitrou your patch will probably work icw/ this PR. You do need to put the call to _mm_crc32_u64 behind a macro as Kohei as done here, otherwise it will give an error _mm_crc32_u64 undefined, even if you're not actually using that function.

@pitrou

pitrou commented Jan 24, 2019

Copy link
Copy Markdown
Member

@jeroen Right. Can you open a PR for that?

@javierluraschijavierluraschi mentioned this pull request Feb 18, 2019
Closed
kou pushed a commit that referenced this pull request Mar 1, 2019
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
d4931c9
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from #3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes#3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd14 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894f <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266 <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e9 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f711 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b1 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa <Javier Luraschi> Skip python since not installed in appveyor
e0058b2 <Javier Luraschi> Skip failing tests to investigate later
3a0620f <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e4 <Javier Luraschi> skip array-dict-test in win32 builds
057347a <Javier Luraschi> Install gflags as suggested in pull/3693
a24285b <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc9 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2 <Javier Luraschi> Apply patch discussed under pull/3443
219384f <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
@kou

kou commented Mar 1, 2019

Copy link
Copy Markdown
MemberAuthor

Done by #3693.

@koukou closed this Mar 1, 2019
@kou
kou deleted the cpp-mingw-32 branch April 4, 2019 02:10
alamb pushed a commit to apache/arrow-rs that referenced this pull request Apr 20, 2021
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
7f560dc
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from apache/arrow#3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes#3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd142 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894ff <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266e <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e95 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa1 <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f7115 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b17 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa4 <Javier Luraschi> Skip python since not installed in appveyor
e0058b2a <Javier Luraschi> Skip failing tests to investigate later
3a0620f6 <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e46 <Javier Luraschi> skip array-dict-test in win32 builds
057347a0 <Javier Luraschi> Install gflags as suggested in pull/3693
a24285ba <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc91 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2f <Javier Luraschi> Apply patch discussed under pull/3443
219384f0 <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
@asfimportasfimport mentioned this pull request Apr 3, 2019
Closed
QuietCraftsmanship pushed a commit to QuietCraftsmanship/arrow that referenced this pull request Jul 7, 2025
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
b938e87
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from apache/arrow#3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes #3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd142 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894ff <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266e <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e95 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa1 <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f7115 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b17 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa4 <Javier Luraschi> Skip python since not installed in appveyor
e0058b2a <Javier Luraschi> Skip failing tests to investigate later
3a0620f6 <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e46 <Javier Luraschi> skip array-dict-test in win32 builds
057347a0 <Javier Luraschi> Install gflags as suggested in pull/3693
a24285ba <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc91 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2f <Javier Luraschi> Apply patch discussed under pull/3443
219384f0 <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitroupitroupitrou requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kou@kszucs@codecov-io@pitrou@jeroen
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit - #3443
Closed
kou wants to merge 1 commit into
apache:masterfrom 
kou:cpp-mingw-32
Closed
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit#3443
kou wants to merge 1 commit into
apache:masterfrom 
kou:cpp-mingw-32
Conversation
@kou
@koukou
commented
Jan 21, 2019

Copy link


Copy Markdown

Member
 No description provided. 
@kszucs
kszucs
commented
Jan 21, 2019

Copy link


Copy Markdown

Member
How could We test this in an automatized way?
@kou
kou
commented
Jan 21, 2019

Copy link


Copy Markdown

MemberAuthor
I'm working: https://github.com/kou/arrow/tree/appveyor-msys :-)
@codecov-io
codecov-io
commented
Jan 21, 2019

Copy link


Copy Markdown

Codecov Report
Merging #3443 into master will increase coverage by 0.98%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #3443 +/- ##
==========================================
+ Coverage 88.31% 89.29% +0.98% 
==========================================
Files 632 503 -129 Lines 79288 70321 -8967 Branches 1069 0 -1069 ==========================================
- Hits 70021 62793 -7228 + Misses 9152 7528 -1624 + Partials 115 0 -115
Impacted FilesCoverage Δ
cpp/src/arrow/util/sse-util.h100% <ø> (ø)⬆️
cpp/src/arrow/csv/column-builder.cc95.45% <0%> (-1.95%)⬇️
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
js/src/enum.ts
go/arrow/array/builder.go
js/src/Arrow.node.ts
js/src/schema.ts
go/arrow/type_traits_boolean.go
js/src/ipc/node/writer.ts
... and 121 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 349a957...bd8b8eb. Read the comment docs.
pitrou
pitrou
requested changes
Jan 21, 2019
View reviewed changes
Comment threadcpp/src/arrow/util/sse-util.h

static inline uint32_t SSE4_crc32_u64(uint32_t crc, uint64_t v) {
#if defined(__MINGW32__) && !defined(__MINGW64__)
 DCHECK(false) << "MinGW-w64 32-bit doesn't support _mm_crc32_u64()";
@pitroupitrouJan 21, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run the tests or are you only concerned about building? This is pretty much not the right solution.
@koukouJan 25, 2019•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for fixing build error.

I'm working on test support on MSYS2 in separated issues.

I'll be back again after we can run tests on MSYS2.
@pitrou
pitrou
commented
Jan 21, 2019

Copy link


Copy Markdown

Member
The appropriate solution is something like this, though according to @jeroen it is insufficient:
https://gist.github.com/pitrou/f4282f68a8dc9b11fe931bd0eeb1f8af
@jeroen
jeroen
commented
Jan 24, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
@pitrou your patch will probably work icw/ this PR. You do need to put the call to _mm_crc32_u64 behind a macro as Kohei as done here, otherwise it will give an error _mm_crc32_u64 undefined, even if you're not actually using that function.
@pitrou
pitrou
commented
Jan 24, 2019

Copy link


Copy Markdown

Member
@jeroen Right. Can you open a PR for that?
@javierluraschijavierluraschi
mentioned this pull request
Feb 18, 2019
 Closed

kou pushed a commit
that referenced
this pull request
Mar 1, 2019
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
d4931c9
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from #3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes#3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd14 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894f <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266 <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e9 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f711 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b1 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa <Javier Luraschi> Skip python since not installed in appveyor
e0058b2 <Javier Luraschi> Skip failing tests to investigate later
3a0620f <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e4 <Javier Luraschi> skip array-dict-test in win32 builds
057347a <Javier Luraschi> Install gflags as suggested in pull/3693
a24285b <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc9 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2 <Javier Luraschi> Apply patch discussed under pull/3443
219384f <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
@kou
kou
commented
Mar 1, 2019

Copy link


Copy Markdown

MemberAuthor
Done by #3693.
@koukou
closed this
Mar 1, 2019
@kou
kou
deleted the

cpp-mingw-32

branch
April 4, 2019 02:10
alamb pushed a commit
to apache/arrow-rs
that referenced
this pull request
Apr 20, 2021
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
7f560dc
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from apache/arrow#3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes#3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd142 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894ff <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266e <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e95 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa1 <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f7115 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b17 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa4 <Javier Luraschi> Skip python since not installed in appveyor
e0058b2a <Javier Luraschi> Skip failing tests to investigate later
3a0620f6 <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e46 <Javier Luraschi> skip array-dict-test in win32 builds
057347a0 <Javier Luraschi> Install gflags as suggested in pull/3693
a24285ba <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc91 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2f <Javier Luraschi> Apply patch discussed under pull/3443
219384f0 <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
@asfimportasfimport
mentioned this pull request
Apr 3, 2019

Closed

QuietCraftsmanship pushed a commit
to QuietCraftsmanship/arrow
that referenced
this pull request
Jul 7, 2025
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
b938e87
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from apache/arrow#3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes #3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd142 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894ff <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266e <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e95 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa1 <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f7115 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b17 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa4 <Javier Luraschi> Skip python since not installed in appveyor
e0058b2a <Javier Luraschi> Skip failing tests to investigate later
3a0620f6 <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e46 <Javier Luraschi> skip array-dict-test in win32 builds
057347a0 <Javier Luraschi> Install gflags as suggested in pull/3693
a24285ba <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc91 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2f <Javier Luraschi> Apply patch discussed under pull/3443
219384f0 <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou requested changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@kou@kszucs@codecov-io@pitrou@jeroen

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit - #3443
Closed
kou wants to merge 1 commit into
apache:masterfrom 
kou:cpp-mingw-32
Closed
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit#3443
kou wants to merge 1 commit into
apache:masterfrom 
kou:cpp-mingw-32
Conversation
@kou
@koukou
commented
Jan 21, 2019

Copy link


Copy Markdown

Member
 No description provided. 
@kszucs
kszucs
commented
Jan 21, 2019

Copy link


Copy Markdown

Member
How could We test this in an automatized way?
@kou
kou
commented
Jan 21, 2019

Copy link


Copy Markdown

MemberAuthor
I'm working: https://github.com/kou/arrow/tree/appveyor-msys :-)
@codecov-io
codecov-io
commented
Jan 21, 2019

Copy link


Copy Markdown

Codecov Report
Merging #3443 into master will increase coverage by 0.98%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #3443 +/- ##
==========================================
+ Coverage 88.31% 89.29% +0.98% 
==========================================
Files 632 503 -129 Lines 79288 70321 -8967 Branches 1069 0 -1069 ==========================================
- Hits 70021 62793 -7228 + Misses 9152 7528 -1624 + Partials 115 0 -115
Impacted FilesCoverage Δ
cpp/src/arrow/util/sse-util.h100% <ø> (ø)⬆️
cpp/src/arrow/csv/column-builder.cc95.45% <0%> (-1.95%)⬇️
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
js/src/enum.ts
go/arrow/array/builder.go
js/src/Arrow.node.ts
js/src/schema.ts
go/arrow/type_traits_boolean.go
js/src/ipc/node/writer.ts
... and 121 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 349a957...bd8b8eb. Read the comment docs.
pitrou
pitrou
requested changes
Jan 21, 2019
View reviewed changes
Comment threadcpp/src/arrow/util/sse-util.h

static inline uint32_t SSE4_crc32_u64(uint32_t crc, uint64_t v) {
#if defined(__MINGW32__) && !defined(__MINGW64__)
 DCHECK(false) << "MinGW-w64 32-bit doesn't support _mm_crc32_u64()";
@pitroupitrouJan 21, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run the tests or are you only concerned about building? This is pretty much not the right solution.
@koukouJan 25, 2019•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for fixing build error.

I'm working on test support on MSYS2 in separated issues.

I'll be back again after we can run tests on MSYS2.
@pitrou
pitrou
commented
Jan 21, 2019

Copy link


Copy Markdown

Member
The appropriate solution is something like this, though according to @jeroen it is insufficient:
https://gist.github.com/pitrou/f4282f68a8dc9b11fe931bd0eeb1f8af
@jeroen
jeroen
commented
Jan 24, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
@pitrou your patch will probably work icw/ this PR. You do need to put the call to _mm_crc32_u64 behind a macro as Kohei as done here, otherwise it will give an error _mm_crc32_u64 undefined, even if you're not actually using that function.
@pitrou
pitrou
commented
Jan 24, 2019

Copy link


Copy Markdown

Member
@jeroen Right. Can you open a PR for that?
@javierluraschijavierluraschi
mentioned this pull request
Feb 18, 2019
 Closed

kou pushed a commit
that referenced
this pull request
Mar 1, 2019
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
d4931c9
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from #3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes#3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd14 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894f <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266 <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e9 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f711 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b1 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa <Javier Luraschi> Skip python since not installed in appveyor
e0058b2 <Javier Luraschi> Skip failing tests to investigate later
3a0620f <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e4 <Javier Luraschi> skip array-dict-test in win32 builds
057347a <Javier Luraschi> Install gflags as suggested in pull/3693
a24285b <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc9 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2 <Javier Luraschi> Apply patch discussed under pull/3443
219384f <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
@kou
kou
commented
Mar 1, 2019

Copy link


Copy Markdown

MemberAuthor
Done by #3693.
@koukou
closed this
Mar 1, 2019
@kou
kou
deleted the

cpp-mingw-32

branch
April 4, 2019 02:10
alamb pushed a commit
to apache/arrow-rs
that referenced
this pull request
Apr 20, 2021
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
7f560dc
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from apache/arrow#3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes#3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd142 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894ff <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266e <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e95 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa1 <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f7115 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b17 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa4 <Javier Luraschi> Skip python since not installed in appveyor
e0058b2a <Javier Luraschi> Skip failing tests to investigate later
3a0620f6 <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e46 <Javier Luraschi> skip array-dict-test in win32 builds
057347a0 <Javier Luraschi> Install gflags as suggested in pull/3693
a24285ba <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc91 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2f <Javier Luraschi> Apply patch discussed under pull/3443
219384f0 <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
@asfimportasfimport
mentioned this pull request
Apr 3, 2019

Closed

QuietCraftsmanship pushed a commit
to QuietCraftsmanship/arrow
that referenced
this pull request
Jul 7, 2025
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
b938e87
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from apache/arrow#3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes #3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd142 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894ff <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266e <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e95 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa1 <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f7115 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b17 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa4 <Javier Luraschi> Skip python since not installed in appveyor
e0058b2a <Javier Luraschi> Skip failing tests to investigate later
3a0620f6 <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e46 <Javier Luraschi> skip array-dict-test in win32 builds
057347a0 <Javier Luraschi> Install gflags as suggested in pull/3693
a24285ba <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc91 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2f <Javier Luraschi> Apply patch discussed under pull/3443
219384f0 <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou requested changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@kou@kszucs@codecov-io@pitrou@jeroen

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit - #3443
Closed
kou wants to merge 1 commit into
apache:masterfrom 
kou:cpp-mingw-32
Closed
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit#3443
kou wants to merge 1 commit into
apache:masterfrom 
kou:cpp-mingw-32
Conversation
@kou
@koukou
commented
Jan 21, 2019

Copy link


Copy Markdown

Member
 No description provided. 
@kszucs
kszucs
commented
Jan 21, 2019

Copy link


Copy Markdown

Member
How could We test this in an automatized way?
@kou
kou
commented
Jan 21, 2019

Copy link


Copy Markdown

MemberAuthor
I'm working: https://github.com/kou/arrow/tree/appveyor-msys :-)
@codecov-io
codecov-io
commented
Jan 21, 2019

Copy link


Copy Markdown

Codecov Report
Merging #3443 into master will increase coverage by 0.98%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #3443 +/- ##
==========================================
+ Coverage 88.31% 89.29% +0.98% 
==========================================
Files 632 503 -129 Lines 79288 70321 -8967 Branches 1069 0 -1069 ==========================================
- Hits 70021 62793 -7228 + Misses 9152 7528 -1624 + Partials 115 0 -115
Impacted FilesCoverage Δ
cpp/src/arrow/util/sse-util.h100% <ø> (ø)⬆️
cpp/src/arrow/csv/column-builder.cc95.45% <0%> (-1.95%)⬇️
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
js/src/enum.ts
go/arrow/array/builder.go
js/src/Arrow.node.ts
js/src/schema.ts
go/arrow/type_traits_boolean.go
js/src/ipc/node/writer.ts
... and 121 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 349a957...bd8b8eb. Read the comment docs.
pitrou
pitrou
requested changes
Jan 21, 2019
View reviewed changes
Comment threadcpp/src/arrow/util/sse-util.h

static inline uint32_t SSE4_crc32_u64(uint32_t crc, uint64_t v) {
#if defined(__MINGW32__) && !defined(__MINGW64__)
 DCHECK(false) << "MinGW-w64 32-bit doesn't support _mm_crc32_u64()";
@pitroupitrouJan 21, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run the tests or are you only concerned about building? This is pretty much not the right solution.
@koukouJan 25, 2019•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for fixing build error.

I'm working on test support on MSYS2 in separated issues.

I'll be back again after we can run tests on MSYS2.
@pitrou
pitrou
commented
Jan 21, 2019

Copy link


Copy Markdown

Member
The appropriate solution is something like this, though according to @jeroen it is insufficient:
https://gist.github.com/pitrou/f4282f68a8dc9b11fe931bd0eeb1f8af
@jeroen
jeroen
commented
Jan 24, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
@pitrou your patch will probably work icw/ this PR. You do need to put the call to _mm_crc32_u64 behind a macro as Kohei as done here, otherwise it will give an error _mm_crc32_u64 undefined, even if you're not actually using that function.
@pitrou
pitrou
commented
Jan 24, 2019

Copy link


Copy Markdown

Member
@jeroen Right. Can you open a PR for that?
@javierluraschijavierluraschi
mentioned this pull request
Feb 18, 2019
 Closed

kou pushed a commit
that referenced
this pull request
Mar 1, 2019
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
d4931c9
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from #3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes#3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd14 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894f <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266 <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e9 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f711 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b1 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa <Javier Luraschi> Skip python since not installed in appveyor
e0058b2 <Javier Luraschi> Skip failing tests to investigate later
3a0620f <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e4 <Javier Luraschi> skip array-dict-test in win32 builds
057347a <Javier Luraschi> Install gflags as suggested in pull/3693
a24285b <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc9 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2 <Javier Luraschi> Apply patch discussed under pull/3443
219384f <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
@kou
kou
commented
Mar 1, 2019

Copy link


Copy Markdown

MemberAuthor
Done by #3693.
@koukou
closed this
Mar 1, 2019
@kou
kou
deleted the

cpp-mingw-32

branch
April 4, 2019 02:10
alamb pushed a commit
to apache/arrow-rs
that referenced
this pull request
Apr 20, 2021
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
7f560dc
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from apache/arrow#3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes#3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd142 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894ff <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266e <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e95 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa1 <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f7115 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b17 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa4 <Javier Luraschi> Skip python since not installed in appveyor
e0058b2a <Javier Luraschi> Skip failing tests to investigate later
3a0620f6 <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e46 <Javier Luraschi> skip array-dict-test in win32 builds
057347a0 <Javier Luraschi> Install gflags as suggested in pull/3693
a24285ba <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc91 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2f <Javier Luraschi> Apply patch discussed under pull/3443
219384f0 <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
@asfimportasfimport
mentioned this pull request
Apr 3, 2019

Closed

QuietCraftsmanship pushed a commit
to QuietCraftsmanship/arrow
that referenced
this pull request
Jul 7, 2025
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
b938e87
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from apache/arrow#3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes #3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd142 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894ff <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266e <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e95 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa1 <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f7115 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b17 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa4 <Javier Luraschi> Skip python since not installed in appveyor
e0058b2a <Javier Luraschi> Skip failing tests to investigate later
3a0620f6 <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e46 <Javier Luraschi> skip array-dict-test in win32 builds
057347a0 <Javier Luraschi> Install gflags as suggested in pull/3693
a24285ba <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc91 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2f <Javier Luraschi> Apply patch discussed under pull/3443
219384f0 <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou requested changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@kou@kszucs@codecov-io@pitrou@jeroen

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit - #3443
Closed
kou wants to merge 1 commit into
apache:masterfrom 
kou:cpp-mingw-32
Closed
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit#3443
kou wants to merge 1 commit into
apache:masterfrom 
kou:cpp-mingw-32
Conversation
@kou
@koukou
commented
Jan 21, 2019

Copy link


Copy Markdown

Member
 No description provided. 
@kszucs
kszucs
commented
Jan 21, 2019

Copy link


Copy Markdown

Member
How could We test this in an automatized way?
@kou
kou
commented
Jan 21, 2019

Copy link


Copy Markdown

MemberAuthor
I'm working: https://github.com/kou/arrow/tree/appveyor-msys :-)
@codecov-io
codecov-io
commented
Jan 21, 2019

Copy link


Copy Markdown

Codecov Report
Merging #3443 into master will increase coverage by 0.98%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #3443 +/- ##
==========================================
+ Coverage 88.31% 89.29% +0.98% 
==========================================
Files 632 503 -129 Lines 79288 70321 -8967 Branches 1069 0 -1069 ==========================================
- Hits 70021 62793 -7228 + Misses 9152 7528 -1624 + Partials 115 0 -115
Impacted FilesCoverage Δ
cpp/src/arrow/util/sse-util.h100% <ø> (ø)⬆️
cpp/src/arrow/csv/column-builder.cc95.45% <0%> (-1.95%)⬇️
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
js/src/enum.ts
go/arrow/array/builder.go
js/src/Arrow.node.ts
js/src/schema.ts
go/arrow/type_traits_boolean.go
js/src/ipc/node/writer.ts
... and 121 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 349a957...bd8b8eb. Read the comment docs.
pitrou
pitrou
requested changes
Jan 21, 2019
View reviewed changes
Comment threadcpp/src/arrow/util/sse-util.h

static inline uint32_t SSE4_crc32_u64(uint32_t crc, uint64_t v) {
#if defined(__MINGW32__) && !defined(__MINGW64__)
 DCHECK(false) << "MinGW-w64 32-bit doesn't support _mm_crc32_u64()";
@pitroupitrouJan 21, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run the tests or are you only concerned about building? This is pretty much not the right solution.
@koukouJan 25, 2019•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for fixing build error.

I'm working on test support on MSYS2 in separated issues.

I'll be back again after we can run tests on MSYS2.
@pitrou
pitrou
commented
Jan 21, 2019

Copy link


Copy Markdown

Member
The appropriate solution is something like this, though according to @jeroen it is insufficient:
https://gist.github.com/pitrou/f4282f68a8dc9b11fe931bd0eeb1f8af
@jeroen
jeroen
commented
Jan 24, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
@pitrou your patch will probably work icw/ this PR. You do need to put the call to _mm_crc32_u64 behind a macro as Kohei as done here, otherwise it will give an error _mm_crc32_u64 undefined, even if you're not actually using that function.
@pitrou
pitrou
commented
Jan 24, 2019

Copy link


Copy Markdown

Member
@jeroen Right. Can you open a PR for that?
@javierluraschijavierluraschi
mentioned this pull request
Feb 18, 2019
 Closed

kou pushed a commit
that referenced
this pull request
Mar 1, 2019
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
d4931c9
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from #3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes#3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd14 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894f <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266 <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e9 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f711 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b1 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa <Javier Luraschi> Skip python since not installed in appveyor
e0058b2 <Javier Luraschi> Skip failing tests to investigate later
3a0620f <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e4 <Javier Luraschi> skip array-dict-test in win32 builds
057347a <Javier Luraschi> Install gflags as suggested in pull/3693
a24285b <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc9 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2 <Javier Luraschi> Apply patch discussed under pull/3443
219384f <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
@kou
kou
commented
Mar 1, 2019

Copy link


Copy Markdown

MemberAuthor
Done by #3693.
@koukou
closed this
Mar 1, 2019
@kou
kou
deleted the

cpp-mingw-32

branch
April 4, 2019 02:10
alamb pushed a commit
to apache/arrow-rs
that referenced
this pull request
Apr 20, 2021
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
7f560dc
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from apache/arrow#3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes#3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd142 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894ff <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266e <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e95 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa1 <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f7115 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b17 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa4 <Javier Luraschi> Skip python since not installed in appveyor
e0058b2a <Javier Luraschi> Skip failing tests to investigate later
3a0620f6 <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e46 <Javier Luraschi> skip array-dict-test in win32 builds
057347a0 <Javier Luraschi> Install gflags as suggested in pull/3693
a24285ba <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc91 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2f <Javier Luraschi> Apply patch discussed under pull/3443
219384f0 <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
@asfimportasfimport
mentioned this pull request
Apr 3, 2019

Closed

QuietCraftsmanship pushed a commit
to QuietCraftsmanship/arrow
that referenced
this pull request
Jul 7, 2025
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
b938e87
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from apache/arrow#3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes #3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd142 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894ff <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266e <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e95 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa1 <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f7115 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b17 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa4 <Javier Luraschi> Skip python since not installed in appveyor
e0058b2a <Javier Luraschi> Skip failing tests to investigate later
3a0620f6 <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e46 <Javier Luraschi> skip array-dict-test in win32 builds
057347a0 <Javier Luraschi> Install gflags as suggested in pull/3693
a24285ba <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc91 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2f <Javier Luraschi> Apply patch discussed under pull/3443
219384f0 <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou requested changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@kou@kszucs@codecov-io@pitrou@jeroen

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit - #3443
Closed
kou wants to merge 1 commit into
apache:masterfrom 
kou:cpp-mingw-32
Closed
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit#3443
kou wants to merge 1 commit into
apache:masterfrom 
kou:cpp-mingw-32
Conversation
@kou
@koukou
commented
Jan 21, 2019

Copy link


Copy Markdown

Member
 No description provided. 
@kszucs
kszucs
commented
Jan 21, 2019

Copy link


Copy Markdown

Member
How could We test this in an automatized way?
@kou
kou
commented
Jan 21, 2019

Copy link


Copy Markdown

MemberAuthor
I'm working: https://github.com/kou/arrow/tree/appveyor-msys :-)
@codecov-io
codecov-io
commented
Jan 21, 2019

Copy link


Copy Markdown

Codecov Report
Merging #3443 into master will increase coverage by 0.98%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #3443 +/- ##
==========================================
+ Coverage 88.31% 89.29% +0.98% 
==========================================
Files 632 503 -129 Lines 79288 70321 -8967 Branches 1069 0 -1069 ==========================================
- Hits 70021 62793 -7228 + Misses 9152 7528 -1624 + Partials 115 0 -115
Impacted FilesCoverage Δ
cpp/src/arrow/util/sse-util.h100% <ø> (ø)⬆️
cpp/src/arrow/csv/column-builder.cc95.45% <0%> (-1.95%)⬇️
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
js/src/enum.ts
go/arrow/array/builder.go
js/src/Arrow.node.ts
js/src/schema.ts
go/arrow/type_traits_boolean.go
js/src/ipc/node/writer.ts
... and 121 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 349a957...bd8b8eb. Read the comment docs.
pitrou
pitrou
requested changes
Jan 21, 2019
View reviewed changes
Comment threadcpp/src/arrow/util/sse-util.h

static inline uint32_t SSE4_crc32_u64(uint32_t crc, uint64_t v) {
#if defined(__MINGW32__) && !defined(__MINGW64__)
 DCHECK(false) << "MinGW-w64 32-bit doesn't support _mm_crc32_u64()";
@pitroupitrouJan 21, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run the tests or are you only concerned about building? This is pretty much not the right solution.
@koukouJan 25, 2019•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for fixing build error.

I'm working on test support on MSYS2 in separated issues.

I'll be back again after we can run tests on MSYS2.
@pitrou
pitrou
commented
Jan 21, 2019

Copy link


Copy Markdown

Member
The appropriate solution is something like this, though according to @jeroen it is insufficient:
https://gist.github.com/pitrou/f4282f68a8dc9b11fe931bd0eeb1f8af
@jeroen
jeroen
commented
Jan 24, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
@pitrou your patch will probably work icw/ this PR. You do need to put the call to _mm_crc32_u64 behind a macro as Kohei as done here, otherwise it will give an error _mm_crc32_u64 undefined, even if you're not actually using that function.
@pitrou
pitrou
commented
Jan 24, 2019

Copy link


Copy Markdown

Member
@jeroen Right. Can you open a PR for that?
@javierluraschijavierluraschi
mentioned this pull request
Feb 18, 2019
 Closed

kou pushed a commit
that referenced
this pull request
Mar 1, 2019
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
d4931c9
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from #3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes#3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd14 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894f <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266 <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e9 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f711 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b1 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa <Javier Luraschi> Skip python since not installed in appveyor
e0058b2 <Javier Luraschi> Skip failing tests to investigate later
3a0620f <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e4 <Javier Luraschi> skip array-dict-test in win32 builds
057347a <Javier Luraschi> Install gflags as suggested in pull/3693
a24285b <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc9 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2 <Javier Luraschi> Apply patch discussed under pull/3443
219384f <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
@kou
kou
commented
Mar 1, 2019

Copy link


Copy Markdown

MemberAuthor
Done by #3693.
@koukou
closed this
Mar 1, 2019
@kou
kou
deleted the

cpp-mingw-32

branch
April 4, 2019 02:10
alamb pushed a commit
to apache/arrow-rs
that referenced
this pull request
Apr 20, 2021
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
7f560dc
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from apache/arrow#3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes#3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd142 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894ff <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266e <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e95 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa1 <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f7115 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b17 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa4 <Javier Luraschi> Skip python since not installed in appveyor
e0058b2a <Javier Luraschi> Skip failing tests to investigate later
3a0620f6 <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e46 <Javier Luraschi> skip array-dict-test in win32 builds
057347a0 <Javier Luraschi> Install gflags as suggested in pull/3693
a24285ba <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc91 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2f <Javier Luraschi> Apply patch discussed under pull/3443
219384f0 <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
@asfimportasfimport
mentioned this pull request
Apr 3, 2019

Closed

QuietCraftsmanship pushed a commit
to QuietCraftsmanship/arrow
that referenced
this pull request
Jul 7, 2025
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
b938e87
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from apache/arrow#3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes #3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd142 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894ff <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266e <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e95 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa1 <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f7115 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b17 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa4 <Javier Luraschi> Skip python since not installed in appveyor
e0058b2a <Javier Luraschi> Skip failing tests to investigate later
3a0620f6 <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e46 <Javier Luraschi> skip array-dict-test in win32 builds
057347a0 <Javier Luraschi> Install gflags as suggested in pull/3693
a24285ba <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc91 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2f <Javier Luraschi> Apply patch discussed under pull/3443
219384f0 <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou requested changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@kou@kszucs@codecov-io@pitrou@jeroen

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit - #3443
Closed
kou wants to merge 1 commit into
apache:masterfrom 
kou:cpp-mingw-32
Closed
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit#3443
kou wants to merge 1 commit into
apache:masterfrom 
kou:cpp-mingw-32
Conversation
@kou
@koukou
commented
Jan 21, 2019

Copy link


Copy Markdown

Member
 No description provided. 
@kszucs
kszucs
commented
Jan 21, 2019

Copy link


Copy Markdown

Member
How could We test this in an automatized way?
@kou
kou
commented
Jan 21, 2019

Copy link


Copy Markdown

MemberAuthor
I'm working: https://github.com/kou/arrow/tree/appveyor-msys :-)
@codecov-io
codecov-io
commented
Jan 21, 2019

Copy link


Copy Markdown

Codecov Report
Merging #3443 into master will increase coverage by 0.98%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #3443 +/- ##
==========================================
+ Coverage 88.31% 89.29% +0.98% 
==========================================
Files 632 503 -129 Lines 79288 70321 -8967 Branches 1069 0 -1069 ==========================================
- Hits 70021 62793 -7228 + Misses 9152 7528 -1624 + Partials 115 0 -115
Impacted FilesCoverage Δ
cpp/src/arrow/util/sse-util.h100% <ø> (ø)⬆️
cpp/src/arrow/csv/column-builder.cc95.45% <0%> (-1.95%)⬇️
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
js/src/enum.ts
go/arrow/array/builder.go
js/src/Arrow.node.ts
js/src/schema.ts
go/arrow/type_traits_boolean.go
js/src/ipc/node/writer.ts
... and 121 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 349a957...bd8b8eb. Read the comment docs.
pitrou
pitrou
requested changes
Jan 21, 2019
View reviewed changes
Comment threadcpp/src/arrow/util/sse-util.h

static inline uint32_t SSE4_crc32_u64(uint32_t crc, uint64_t v) {
#if defined(__MINGW32__) && !defined(__MINGW64__)
 DCHECK(false) << "MinGW-w64 32-bit doesn't support _mm_crc32_u64()";
@pitroupitrouJan 21, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run the tests or are you only concerned about building? This is pretty much not the right solution.
@koukouJan 25, 2019•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for fixing build error.

I'm working on test support on MSYS2 in separated issues.

I'll be back again after we can run tests on MSYS2.
@pitrou
pitrou
commented
Jan 21, 2019

Copy link


Copy Markdown

Member
The appropriate solution is something like this, though according to @jeroen it is insufficient:
https://gist.github.com/pitrou/f4282f68a8dc9b11fe931bd0eeb1f8af
@jeroen
jeroen
commented
Jan 24, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
@pitrou your patch will probably work icw/ this PR. You do need to put the call to _mm_crc32_u64 behind a macro as Kohei as done here, otherwise it will give an error _mm_crc32_u64 undefined, even if you're not actually using that function.
@pitrou
pitrou
commented
Jan 24, 2019

Copy link


Copy Markdown

Member
@jeroen Right. Can you open a PR for that?
@javierluraschijavierluraschi
mentioned this pull request
Feb 18, 2019
 Closed

kou pushed a commit
that referenced
this pull request
Mar 1, 2019
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
d4931c9
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from #3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes#3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd14 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894f <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266 <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e9 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f711 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b1 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa <Javier Luraschi> Skip python since not installed in appveyor
e0058b2 <Javier Luraschi> Skip failing tests to investigate later
3a0620f <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e4 <Javier Luraschi> skip array-dict-test in win32 builds
057347a <Javier Luraschi> Install gflags as suggested in pull/3693
a24285b <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc9 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2 <Javier Luraschi> Apply patch discussed under pull/3443
219384f <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
@kou
kou
commented
Mar 1, 2019

Copy link


Copy Markdown

MemberAuthor
Done by #3693.
@koukou
closed this
Mar 1, 2019
@kou
kou
deleted the

cpp-mingw-32

branch
April 4, 2019 02:10
alamb pushed a commit
to apache/arrow-rs
that referenced
this pull request
Apr 20, 2021
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
7f560dc
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from apache/arrow#3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes#3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd142 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894ff <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266e <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e95 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa1 <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f7115 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b17 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa4 <Javier Luraschi> Skip python since not installed in appveyor
e0058b2a <Javier Luraschi> Skip failing tests to investigate later
3a0620f6 <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e46 <Javier Luraschi> skip array-dict-test in win32 builds
057347a0 <Javier Luraschi> Install gflags as suggested in pull/3693
a24285ba <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc91 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2f <Javier Luraschi> Apply patch discussed under pull/3443
219384f0 <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
@asfimportasfimport
mentioned this pull request
Apr 3, 2019

Closed

QuietCraftsmanship pushed a commit
to QuietCraftsmanship/arrow
that referenced
this pull request
Jul 7, 2025
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
b938e87
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from apache/arrow#3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes #3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd142 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894ff <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266e <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e95 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa1 <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f7115 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b17 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa4 <Javier Luraschi> Skip python since not installed in appveyor
e0058b2a <Javier Luraschi> Skip failing tests to investigate later
3a0620f6 <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e46 <Javier Luraschi> skip array-dict-test in win32 builds
057347a0 <Javier Luraschi> Install gflags as suggested in pull/3693
a24285ba <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc91 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2f <Javier Luraschi> Apply patch discussed under pull/3443
219384f0 <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou requested changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@kou@kszucs@codecov-io@pitrou@jeroen

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit - #3443
Closed
kou wants to merge 1 commit into
apache:masterfrom 
kou:cpp-mingw-32
Closed
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit#3443
kou wants to merge 1 commit into
apache:masterfrom 
kou:cpp-mingw-32
Conversation
@kou
@koukou
commented
Jan 21, 2019

Copy link


Copy Markdown

Member
 No description provided. 
@kszucs
kszucs
commented
Jan 21, 2019

Copy link


Copy Markdown

Member
How could We test this in an automatized way?
@kou
kou
commented
Jan 21, 2019

Copy link


Copy Markdown

MemberAuthor
I'm working: https://github.com/kou/arrow/tree/appveyor-msys :-)
@codecov-io
codecov-io
commented
Jan 21, 2019

Copy link


Copy Markdown

Codecov Report
Merging #3443 into master will increase coverage by 0.98%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #3443 +/- ##
==========================================
+ Coverage 88.31% 89.29% +0.98% 
==========================================
Files 632 503 -129 Lines 79288 70321 -8967 Branches 1069 0 -1069 ==========================================
- Hits 70021 62793 -7228 + Misses 9152 7528 -1624 + Partials 115 0 -115
Impacted FilesCoverage Δ
cpp/src/arrow/util/sse-util.h100% <ø> (ø)⬆️
cpp/src/arrow/csv/column-builder.cc95.45% <0%> (-1.95%)⬇️
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
js/src/enum.ts
go/arrow/array/builder.go
js/src/Arrow.node.ts
js/src/schema.ts
go/arrow/type_traits_boolean.go
js/src/ipc/node/writer.ts
... and 121 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 349a957...bd8b8eb. Read the comment docs.
pitrou
pitrou
requested changes
Jan 21, 2019
View reviewed changes
Comment threadcpp/src/arrow/util/sse-util.h

static inline uint32_t SSE4_crc32_u64(uint32_t crc, uint64_t v) {
#if defined(__MINGW32__) && !defined(__MINGW64__)
 DCHECK(false) << "MinGW-w64 32-bit doesn't support _mm_crc32_u64()";
@pitroupitrouJan 21, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run the tests or are you only concerned about building? This is pretty much not the right solution.
@koukouJan 25, 2019•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for fixing build error.

I'm working on test support on MSYS2 in separated issues.

I'll be back again after we can run tests on MSYS2.
@pitrou
pitrou
commented
Jan 21, 2019

Copy link


Copy Markdown

Member
The appropriate solution is something like this, though according to @jeroen it is insufficient:
https://gist.github.com/pitrou/f4282f68a8dc9b11fe931bd0eeb1f8af
@jeroen
jeroen
commented
Jan 24, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
@pitrou your patch will probably work icw/ this PR. You do need to put the call to _mm_crc32_u64 behind a macro as Kohei as done here, otherwise it will give an error _mm_crc32_u64 undefined, even if you're not actually using that function.
@pitrou
pitrou
commented
Jan 24, 2019

Copy link


Copy Markdown

Member
@jeroen Right. Can you open a PR for that?
@javierluraschijavierluraschi
mentioned this pull request
Feb 18, 2019
 Closed

kou pushed a commit
that referenced
this pull request
Mar 1, 2019
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
d4931c9
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from #3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes#3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd14 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894f <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266 <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e9 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f711 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b1 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa <Javier Luraschi> Skip python since not installed in appveyor
e0058b2 <Javier Luraschi> Skip failing tests to investigate later
3a0620f <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e4 <Javier Luraschi> skip array-dict-test in win32 builds
057347a <Javier Luraschi> Install gflags as suggested in pull/3693
a24285b <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc9 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2 <Javier Luraschi> Apply patch discussed under pull/3443
219384f <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
@kou
kou
commented
Mar 1, 2019

Copy link


Copy Markdown

MemberAuthor
Done by #3693.
@koukou
closed this
Mar 1, 2019
@kou
kou
deleted the

cpp-mingw-32

branch
April 4, 2019 02:10
alamb pushed a commit
to apache/arrow-rs
that referenced
this pull request
Apr 20, 2021
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
7f560dc
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from apache/arrow#3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes#3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd142 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894ff <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266e <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e95 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa1 <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f7115 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b17 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa4 <Javier Luraschi> Skip python since not installed in appveyor
e0058b2a <Javier Luraschi> Skip failing tests to investigate later
3a0620f6 <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e46 <Javier Luraschi> skip array-dict-test in win32 builds
057347a0 <Javier Luraschi> Install gflags as suggested in pull/3693
a24285ba <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc91 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2f <Javier Luraschi> Apply patch discussed under pull/3443
219384f0 <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
@asfimportasfimport
mentioned this pull request
Apr 3, 2019

Closed

QuietCraftsmanship pushed a commit
to QuietCraftsmanship/arrow
that referenced
this pull request
Jul 7, 2025
@javierluraschi@kou
ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit
b938e87
Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from apache/arrow#3443.
Author: Javier Luraschi <javierluraschi@hotmail.com>
Author: Kouhei Sutou <kou@clear-code.com>
Closes #3693 from javierluraschi/bugfix/mingw32 and squashes the following commits:
e56dd142 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693""
2ee894ff <Javier Luraschi> Revert " Revert install python as suggested in pull/3693"
41ae266e <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure"
e69b1e95 <Javier Luraschi> Revert install python as suggested in pull/3693
f2e4dfa1 <Javier Luraschi> Revert disabled test to investigate appveyor failure
aa9f7115 <Javier Luraschi> Install python as suggested in pull/3693
4cb63b17 <Javier Luraschi> Show error details in test as suggested in pull/3693
5b904fa4 <Javier Luraschi> Skip python since not installed in appveyor
e0058b2a <Javier Luraschi> Skip failing tests to investigate later
3a0620f6 <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks
9c1d6e46 <Javier Luraschi> skip array-dict-test in win32 builds
057347a0 <Javier Luraschi> Install gflags as suggested in pull/3693
a24285ba <Javier Luraschi> Remove allow_failures as suggested in pull/3693
695bdc91 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693
aad43b2f <Javier Luraschi> Apply patch discussed under pull/3443
219384f0 <Kouhei Sutou> Fix build error with MinGW-w64 32-bit
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou requested changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@kou@kszucs@codecov-io@pitrou@jeroen