Uh oh!
There was an error while loading. Please reload this page.
GH-36187: [C++] Display the name of the problematic field when returning status "Data type ... is not supported in join non-key field" for HashJoin - #36539
Conversation
westonpace
left a comment
There was a problem hiding this comment.
This looks good to me modulo a few very minor nits.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| np.testing.assert_allclose(result, expected) | ||
| assert result.dtype == "int32" | ||
There was a problem hiding this comment.
We need to add @pytest.mark.acero because this depends on Acero.
I'm adding it in #36681 but we may want to do it in a separated PR only for it...
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 95e3e77. There were 3 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
The change is bases on a user filed issue. This would provide a readable error message.
What changes are included in this PR?
Did modification to
hash_join_node.ccto include field name to the already provided error message.Added python tests to validate the response.
Are these changes tested?
A test case has been added to Python under
test_table.pyAre there any user-facing changes?
No, just a clear error message is provided.