Uh oh!
There was an error while loading. Please reload this page.
GH-36969: [C++][R] Bump abseil-cpp version - #37066
Closed
assignUser wants to merge 8 commits into
Closed
Conversation
assignUser
commented
Aug 8, 2023
MemberAuthor
@github-actions crossbow submit -g cpp -g r |
Revision: 8edb066 Submitted crossbow builds: ursacomputing/crossbow @ actions-5c039443fa
|
h-vetinari
commented
Aug 9, 2023
Contributor
Just a note that you need to be careful with abseil which C++ standard version you're using, as the ABI is affected by that choice (and you might e.g. run into missing symbols if one part is compiled with C++11 and one with C++17). |
assignUser
commented
Aug 9, 2023
MemberAuthor
@github-actions crossbow submit r-binary-packages test-fedora-35-cpp |
Revision: 00986bc Submitted crossbow builds: ursacomputing/crossbow @ actions-08314a188d
|
assignUser
commented
Aug 10, 2023
MemberAuthor
@github-actions crossbow submit r-binary-packages test-fedora-35-cpp |
Revision: e1de598 Submitted crossbow builds: ursacomputing/crossbow @ actions-28e37993e0
|
Comment on lines
+26
to
+27
| ARROW_ABSL_BUILD_VERSION=20230125.3 | ||
| ARROW_ABSL_BUILD_SHA256_CHECKSUM=5366d7e7fa7ba0d915014d387b66d0d002c03236448e1ba9ef98122c13b35c36 |
Contributor
There was a problem hiding this comment.
JFYI, abseil very recently released a new LTS version.
Not sure if you're interested in upgrading this quickly, but presumably that'd mean you'd save half a year until the next abseil bump
assignUser pushed a commit
that referenced
this pull request
Jul 26, 2024
### Rationale for this change When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a `<cstdint>` include, this PR addresses the issue by adding the missing include. There have been past reports for this issue too: #36969 This is a more minimal fix that tries to avoid the complexity of previous attempts like #43147 and #37066 which involved updating Abseil and facing additional issues to fix. ### What changes are included in this PR? Add the missing include when GCC>=13 ### Are these changes tested? They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds. ### Are there any user-facing changes? No, all behaviours should remain the same * GitHub Issue: #43228 Lead-authored-by: Alessandro Molina <alessandro@molina.fyi> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
jonkeane pushed a commit
that referenced
this pull request
Jul 31, 2024
### Rationale for this change When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a `<cstdint>` include, this PR addresses the issue by adding the missing include. There have been past reports for this issue too: #36969 This is a more minimal fix that tries to avoid the complexity of previous attempts like #43147 and #37066 which involved updating Abseil and facing additional issues to fix. ### What changes are included in this PR? Add the missing include when GCC>=13 ### Are these changes tested? They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds. ### Are there any user-facing changes? No, all behaviours should remain the same * GitHub Issue: #43228 Lead-authored-by: Alessandro Molina <alessandro@molina.fyi> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Our current version of abseil-cpp fails to build with gcc 13 which is used on CRAN machines.
Are these changes tested?
CI