GH-43228: [C++] Fix Abseil compile error on GCC 13 - #43157

Merged
assignUser merged 21 commits into
apache:mainfrom
amol-:GH-36969-minimal
Jul 26, 2024
Merged

GH-43228: [C++] Fix Abseil compile error on GCC 13#43157
assignUser merged 21 commits into
apache:mainfrom
amol-:GH-36969-minimal

Conversation

@amol-

@amol-amol- commented Jul 5, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Rationale for this change

When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a <cstdint> include, this PR addresses the issue by adding the missing include.

There have been past reports for this issue too: #36969

This is a more minimal fix that tries to avoid the complexity of previous attempts like #43147 and #37066 which involved updating Abseil and facing additional issues to fix.

What changes are included in this PR?

Add the missing include when GCC>=13

Are these changes tested?

They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds.

Are there any user-facing changes?

No, all behaviours should remain the same

@amol-
amol-force-pushed the GH-36969-minimal branch from 7ccde25 to 8f503aeCompareJuly 5, 2024 16:36
@amol-

amol- commented Jul 5, 2024

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g r

@github-actions

github-actionsBot commented Jul 5, 2024

Copy link
Copy Markdown

Revision: 8f503ae7d8bab313b6325992c32859770dc29a98

Submitted crossbow builds: ursacomputing/crossbow @ actions-defadac854

TaskStatus
r-binary-packagesGitHub Actions
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-cuda-cppGitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-clang-sanitizerGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.1-opensuse155Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions
test-ubuntu-20.04-cppGitHub Actions
test-ubuntu-20.04-cpp-bundledGitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-r-sanitizerGitHub Actions

@amol-
amol- marked this pull request as ready for review July 5, 2024 18:34
@amol-

amol- commented Jul 5, 2024

Copy link
Copy Markdown
MemberAuthor

@raulcd@assignUser this should be ready for review, I tried a more conservative approach as upgrading Abseil introduced more problems than it fixed even on the most conservative version upgrade.

@koukou changed the title GH-36969: [C++] Fix ABSEIL compile error on GCC 13GH-36969: [C++] Fix Abseil compile error on GCC 13Jul 5, 2024
@kou

kou commented Jul 5, 2024

Copy link
Copy Markdown
Member

Could you open a new issue for this instead of reusing existing closed issue?

@amol-

amol- commented Jul 11, 2024

Copy link
Copy Markdown
MemberAuthor

Could you open a new issue for this instead of reusing existing closed issue?

Given it's the same exact error message shouldn't we preserve a consolidated history by keeping the original issue?
Happy to open a new issue if that's the preference

@raulcd

raulcd commented Jul 11, 2024

Copy link
Copy Markdown
Member

The problem is that the original issue is in the 13.0.0 milestone and all our current release scripts take that into account to generate release notes, etcetera. If we reuse the same issue it would be as if this PR was released on 13.0.0 and if we require to back port this issue it gets messy.
It has it's pros and cons but the current process doesn't account for two PRs pointing to the same GH issue.

@amol-

amol- commented Jul 11, 2024

Copy link
Copy Markdown
MemberAuthor

The problem is that the original issue is in the 13.0.0 milestone

Makes sense, I didn't check and thought it was closed without being done. I'll open a new one.

@amol-amol- changed the title GH-36969: [C++] Fix Abseil compile error on GCC 13GH-43228: [C++] Fix Abseil compile error on GCC 13Jul 11, 2024
@github-actions

github-actionsBot commented Jul 11, 2024

Copy link
Copy Markdown

⚠️ GitHub issue #43228has been automatically assigned in GitHub to PR creator.

kou
kou reviewed Jul 11, 2024
View reviewed changes

@koukou left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reproduce this by the following change?

diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml
index 45417acf85..cd5f119b77 100644
--- a/dev/tasks/tasks.yml+++ b/dev/tasks/tasks.yml@@ -1418,6 +1418,16 @@ tasks:
GCC_VERSION: 12
image: ubuntu-r-only-r
+ # This also has -flto=auto+ test-r-gcc-13:+ ci: github+ template: docker-tests/github.linux.yml+ params:+ env:+ UBUNTU: 24.04+ GCC_VERSION: 13+ image: ubuntu-r-only-r+
test-r-minimal-build:
ci: azure
template: r/azure.linux.yml

Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake Outdated
@github-actionsgithub-actionsBot added awaiting review Awaiting review awaiting changes Awaiting changes awaiting committer review Awaiting committer review and removed awaiting review Awaiting review awaiting changes Awaiting changes awaiting committer review Awaiting committer review labels Jul 11, 2024
@github-actionsgithub-actionsBot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jul 23, 2024
@amol-

amol- commented Jul 25, 2024

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-13-bundled

@apacheapache deleted a comment from github-actionsBotJul 25, 2024
@github-actions

github-actionsBot commented Jul 25, 2024

Copy link
Copy Markdown

Revision: d59f39b

Submitted crossbow builds: ursacomputing/crossbow @ actions-a91e2018b6

TaskStatus
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions

@amol-

amol- commented Jul 25, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@koutest-ubuntu-24.04-cpp-gcc-13-bundled now compiles correctly. It fails the test, but it seems unrelated as they are timezone related tests. I'll kick-off a check on ubuntu-20.04 to confirm the test failures are unrelated.

I think that this is ready for final review.

@amol-

amol- commented Jul 25, 2024

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled

@github-actions

github-actionsBot commented Jul 25, 2024

Copy link
Copy Markdown

Revision: 70e6e7d

Submitted crossbow builds: ursacomputing/crossbow @ actions-3d162f80dd

TaskStatus
test-ubuntu-20.04-cpp-bundledGitHub Actions

@amol-

amol- commented Jul 25, 2024

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-13-bundled

@github-actions

github-actionsBot commented Jul 25, 2024

Copy link
Copy Markdown

Revision: 943baa0

Submitted crossbow builds: ursacomputing/crossbow @ actions-ecde5a2c6e

TaskStatus
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions

@amol-

amol- commented Jul 25, 2024

Copy link
Copy Markdown
MemberAuthor

The timestamp tests now pass too by installing tzdata-legacy

@amol-
amol- requested a review from kouJuly 25, 2024 17:24
assignUser
assignUser approved these changes Jul 25, 2024
View reviewed changes

@assignUserassignUser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Could you also remove the workaround we added to r/configure?

@apacheapache deleted a comment from github-actionsBotJul 26, 2024
@amol-

amol- commented Jul 26, 2024

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-depsource-bundled

@github-actions

github-actionsBot commented Jul 26, 2024

Copy link
Copy Markdown

Revision: 0a6e367

Submitted crossbow builds: ursacomputing/crossbow @ actions-c9cac2c09c

TaskStatus
test-r-depsource-bundledAzure

@amol-

amol- commented Jul 26, 2024

Copy link
Copy Markdown
MemberAuthor

Looks good, thanks! Could you also remove the workaround we added to r/configure?

Done and tested on test-r-depsource-bundled

@assignUser

assignUser commented Jul 26, 2024

Copy link
Copy Markdown
Member

@github-actions crossbow submit r-binary-packages
Nice, thanks. I'll run this as it has a build on 24.04 which comes with the new gcc. I'll merge after

@github-actions

github-actionsBot commented Jul 26, 2024

Copy link
Copy Markdown

Revision: 0a6e367

Submitted crossbow builds: ursacomputing/crossbow @ actions-4b94da66a4

TaskStatus
r-binary-packagesGitHub Actions

@assignUser

assignUser commented Jul 26, 2024

Copy link
Copy Markdown
Member

Ugh, turns out ubuntu-latest is still 22.04, I modified the crossbow workflow to re-run on 24.04

@assignUser
assignUser merged commit aaeff72 into apache:mainJul 26, 2024
@assignUserassignUser removed the awaiting change review Awaiting change review label Jul 26, 2024
@assignUserassignUser mentioned this pull request Jul 26, 2024
Closed
@conbench-apache-arrow

conbench-apache-arrowBot commented Jul 27, 2024

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit aaeff72.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

@jonkeanejonkeane mentioned this pull request Jul 31, 2024
Closed
38 tasks
jonkeane pushed a commit that referenced this pull request Jul 31, 2024
@amol-@kou@jonkeane
GH-43228: [C++] Fix Abseil compile error on GCC 13 (#43157)
cbd6b5c
### Rationale for this change
When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a `<cstdint>` include, this PR addresses the issue by adding the missing include.
There have been past reports for this issue too: #36969 This is a more minimal fix that tries to avoid the complexity of previous attempts like #43147 and #37066 which involved updating Abseil and facing additional issues to fix.
### What changes are included in this PR?
Add the missing include when GCC>=13
### Are these changes tested?
They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds.
### Are there any user-facing changes?
No, all behaviours should remain the same
* GitHub Issue: #43228
Lead-authored-by: Alessandro Molina <alessandro@molina.fyi>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assignUserassignUserassignUser approved these changes
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@koukouAwaiting requested review from koukou is a code owner

Assignees

No one assigned

Labels

Component: C++Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amol-@kou@raulcd@assignUser
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
GH-43228: [C++] Fix Abseil compile error on GCC 13 - #43157
Merged
assignUser merged 21 commits into
apache:mainfrom 
amol-:GH-36969-minimal
Jul 26, 2024
Merged
GH-43228: [C++] Fix Abseil compile error on GCC 13#43157
assignUser merged 21 commits into
apache:mainfrom 
amol-:GH-36969-minimal
Conversation
@amol-
@amol-amol-
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Rationale for this change
When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a <cstdint> include, this PR addresses the issue by adding the missing include.
There have been past reports for this issue too: #36969
This is a more minimal fix that tries to avoid the complexity of previous attempts like #43147 and #37066 which involved updating Abseil and facing additional issues to fix.
What changes are included in this PR?
Add the missing include when GCC>=13
Are these changes tested?
They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds.
Are there any user-facing changes?
No, all behaviours should remain the same
@amol-
amol-force-pushed
the
GH-36969-minimal
branch
from
7ccde25 to
8f503aeCompareJuly 5, 2024 16:36
@amol-
amol-
commented
Jul 5, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g r
@github-actions
github-actionsBot
commented
Jul 5, 2024

Copy link


Copy Markdown

Revision: 8f503ae7d8bab313b6325992c32859770dc29a98
Submitted crossbow builds: ursacomputing/crossbow @ actions-defadac854
TaskStatus
r-binary-packagesGitHub Actions
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-cuda-cppGitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-clang-sanitizerGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.1-opensuse155Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions
test-ubuntu-20.04-cppGitHub Actions
test-ubuntu-20.04-cpp-bundledGitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-r-sanitizerGitHub Actions
@amol-
amol-
marked this pull request as ready for review
July 5, 2024 18:34
@amol-
amol-
commented
Jul 5, 2024

Copy link


Copy Markdown

MemberAuthor
@raulcd@assignUser this should be ready for review, I tried a more conservative approach as upgrading Abseil introduced more problems than it fixed even on the most conservative version upgrade.
@koukou
changed the title
GH-36969: [C++] Fix ABSEIL compile error on GCC 13GH-36969: [C++] Fix Abseil compile error on GCC 13Jul 5, 2024
@kou
kou
commented
Jul 5, 2024

Copy link


Copy Markdown

Member
Could you open a new issue for this instead of reusing existing closed issue?
@amol-
amol-
commented
Jul 11, 2024

Copy link


Copy Markdown

MemberAuthor
Could you open a new issue for this instead of reusing existing closed issue?
Given it's the same exact error message shouldn't we preserve a consolidated history by keeping the original issue?

Happy to open a new issue if that's the preference
@raulcd
raulcd
commented
Jul 11, 2024

Copy link


Copy Markdown

Member
The problem is that the original issue is in the 13.0.0 milestone and all our current release scripts take that into account to generate release notes, etcetera. If we reuse the same issue it would be as if this PR was released on 13.0.0 and if we require to back port this issue it gets messy.

It has it's pros and cons but the current process doesn't account for two PRs pointing to the same GH issue.
@amol-
amol-
commented
Jul 11, 2024

Copy link


Copy Markdown

MemberAuthor
The problem is that the original issue is in the 13.0.0 milestone
Makes sense, I didn't check and thought it was closed without being done. I'll open a new one.
@amol-amol-
changed the title
GH-36969: [C++] Fix Abseil compile error on GCC 13GH-43228: [C++] Fix Abseil compile error on GCC 13Jul 11, 2024
@github-actions
github-actionsBot
commented
Jul 11, 2024

Copy link


Copy Markdown

⚠️ GitHub issue #43228has been automatically assigned in GitHub to PR creator.
kou
kou
reviewed
Jul 11, 2024
View reviewed changes
@koukou
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reproduce this by the following change?
diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml
index 45417acf85..cd5f119b77 100644
--- a/dev/tasks/tasks.yml+++ b/dev/tasks/tasks.yml@@ -1418,6 +1418,16 @@ tasks:
GCC_VERSION: 12
image: ubuntu-r-only-r
+ # This also has -flto=auto+ test-r-gcc-13:+ ci: github+ template: docker-tests/github.linux.yml+ params:+ env:+ UBUNTU: 24.04+ GCC_VERSION: 13+ image: ubuntu-r-only-r+
test-r-minimal-build:
ci: azure
template: r/azure.linux.yml
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated

@github-actionsgithub-actionsBot
added

awaiting review
Awaiting review
awaiting changes
Awaiting changes
awaiting committer review
Awaiting committer review
and removed

awaiting review
Awaiting review
awaiting changes
Awaiting changes
awaiting committer review
Awaiting committer review
labels
Jul 11, 2024
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Jul 23, 2024
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-13-bundled
@apacheapache
deleted a comment from github-actionsBotJul 25, 2024
@github-actions
github-actionsBot
commented
Jul 25, 2024

Copy link


Copy Markdown

Revision: d59f39b
Submitted crossbow builds: ursacomputing/crossbow @ actions-a91e2018b6
TaskStatus
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
@amol-
amol-
commented
Jul 25, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
@koutest-ubuntu-24.04-cpp-gcc-13-bundled now compiles correctly. It fails the test, but it seems unrelated as they are timezone related tests. I'll kick-off a check on ubuntu-20.04 to confirm the test failures are unrelated.
I think that this is ready for final review.
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled
@github-actions
github-actionsBot
commented
Jul 25, 2024

Copy link


Copy Markdown

Revision: 70e6e7d
Submitted crossbow builds: ursacomputing/crossbow @ actions-3d162f80dd
TaskStatus
test-ubuntu-20.04-cpp-bundledGitHub Actions
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-13-bundled
@github-actions
github-actionsBot
commented
Jul 25, 2024

Copy link


Copy Markdown

Revision: 943baa0
Submitted crossbow builds: ursacomputing/crossbow @ actions-ecde5a2c6e
TaskStatus
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
The timestamp tests now pass too by installing tzdata-legacy
@amol-
amol-
requested a review
from kouJuly 25, 2024 17:24
assignUser
assignUser
approved these changes
Jul 25, 2024
View reviewed changes
@assignUserassignUser
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Could you also remove the workaround we added to r/configure?
@apacheapache
deleted a comment from github-actionsBotJul 26, 2024
@amol-
amol-
commented
Jul 26, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-depsource-bundled
@github-actions
github-actionsBot
commented
Jul 26, 2024

Copy link


Copy Markdown

Revision: 0a6e367
Submitted crossbow builds: ursacomputing/crossbow @ actions-c9cac2c09c
TaskStatus
test-r-depsource-bundledAzure
@amol-
amol-
commented
Jul 26, 2024

Copy link


Copy Markdown

MemberAuthor
Looks good, thanks! Could you also remove the workaround we added to r/configure?
Done and tested on test-r-depsource-bundled
@assignUser
assignUser
commented
Jul 26, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit r-binary-packages

Nice, thanks. I'll run this as it has a build on 24.04 which comes with the new gcc. I'll merge after
@github-actions
github-actionsBot
commented
Jul 26, 2024

Copy link


Copy Markdown

Revision: 0a6e367
Submitted crossbow builds: ursacomputing/crossbow @ actions-4b94da66a4
TaskStatus
r-binary-packagesGitHub Actions
@assignUser
assignUser
commented
Jul 26, 2024

Copy link


Copy Markdown

Member
Ugh, turns out ubuntu-latest is still 22.04, I modified the crossbow workflow to re-run on 24.04
@assignUser
assignUser
merged commit aaeff72
into
apache:mainJul 26, 2024
@assignUserassignUser
removed
the 
awaiting change review
Awaiting change review
label
Jul 26, 2024
@assignUserassignUser
mentioned this pull request
Jul 26, 2024

Closed

@conbench-apache-arrow
conbench-apache-arrowBot
commented
Jul 27, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit aaeff72.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
@jonkeanejonkeane
mentioned this pull request
Jul 31, 2024

Closed

38 tasks
jonkeane pushed a commit
that referenced
this pull request
Jul 31, 2024
@amol-@kou@jonkeane
GH-43228: [C++] Fix Abseil compile error on GCC 13 (#43157)
cbd6b5c
### Rationale for this change
When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a `<cstdint>` include, this PR addresses the issue by adding the missing include.
There have been past reports for this issue too: #36969 This is a more minimal fix that tries to avoid the complexity of previous attempts like #43147 and #37066 which involved updating Abseil and facing additional issues to fix.
### What changes are included in this PR?
Add the missing include when GCC>=13
### Are these changes tested?
They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds.
### Are there any user-facing changes?
No, all behaviours should remain the same
* GitHub Issue: #43228
Lead-authored-by: Alessandro Molina <alessandro@molina.fyi>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@assignUserassignUserassignUser approved these changes
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@koukouAwaiting requested review from koukou is a code owner

Assignees


No one assigned


Labels

Component: C++Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@amol-@kou@raulcd@assignUser

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-43228: [C++] Fix Abseil compile error on GCC 13 - #43157
Merged
assignUser merged 21 commits into
apache:mainfrom 
amol-:GH-36969-minimal
Jul 26, 2024
Merged
GH-43228: [C++] Fix Abseil compile error on GCC 13#43157
assignUser merged 21 commits into
apache:mainfrom 
amol-:GH-36969-minimal
Conversation
@amol-
@amol-amol-
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Rationale for this change
When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a <cstdint> include, this PR addresses the issue by adding the missing include.
There have been past reports for this issue too: #36969
This is a more minimal fix that tries to avoid the complexity of previous attempts like #43147 and #37066 which involved updating Abseil and facing additional issues to fix.
What changes are included in this PR?
Add the missing include when GCC>=13
Are these changes tested?
They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds.
Are there any user-facing changes?
No, all behaviours should remain the same
@amol-
amol-force-pushed
the
GH-36969-minimal
branch
from
7ccde25 to
8f503aeCompareJuly 5, 2024 16:36
@amol-
amol-
commented
Jul 5, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g r
@github-actions
github-actionsBot
commented
Jul 5, 2024

Copy link


Copy Markdown

Revision: 8f503ae7d8bab313b6325992c32859770dc29a98
Submitted crossbow builds: ursacomputing/crossbow @ actions-defadac854
TaskStatus
r-binary-packagesGitHub Actions
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-cuda-cppGitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-clang-sanitizerGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.1-opensuse155Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions
test-ubuntu-20.04-cppGitHub Actions
test-ubuntu-20.04-cpp-bundledGitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-r-sanitizerGitHub Actions
@amol-
amol-
marked this pull request as ready for review
July 5, 2024 18:34
@amol-
amol-
commented
Jul 5, 2024

Copy link


Copy Markdown

MemberAuthor
@raulcd@assignUser this should be ready for review, I tried a more conservative approach as upgrading Abseil introduced more problems than it fixed even on the most conservative version upgrade.
@koukou
changed the title
GH-36969: [C++] Fix ABSEIL compile error on GCC 13GH-36969: [C++] Fix Abseil compile error on GCC 13Jul 5, 2024
@kou
kou
commented
Jul 5, 2024

Copy link


Copy Markdown

Member
Could you open a new issue for this instead of reusing existing closed issue?
@amol-
amol-
commented
Jul 11, 2024

Copy link


Copy Markdown

MemberAuthor
Could you open a new issue for this instead of reusing existing closed issue?
Given it's the same exact error message shouldn't we preserve a consolidated history by keeping the original issue?

Happy to open a new issue if that's the preference
@raulcd
raulcd
commented
Jul 11, 2024

Copy link


Copy Markdown

Member
The problem is that the original issue is in the 13.0.0 milestone and all our current release scripts take that into account to generate release notes, etcetera. If we reuse the same issue it would be as if this PR was released on 13.0.0 and if we require to back port this issue it gets messy.

It has it's pros and cons but the current process doesn't account for two PRs pointing to the same GH issue.
@amol-
amol-
commented
Jul 11, 2024

Copy link


Copy Markdown

MemberAuthor
The problem is that the original issue is in the 13.0.0 milestone
Makes sense, I didn't check and thought it was closed without being done. I'll open a new one.
@amol-amol-
changed the title
GH-36969: [C++] Fix Abseil compile error on GCC 13GH-43228: [C++] Fix Abseil compile error on GCC 13Jul 11, 2024
@github-actions
github-actionsBot
commented
Jul 11, 2024

Copy link


Copy Markdown

⚠️ GitHub issue #43228has been automatically assigned in GitHub to PR creator.
kou
kou
reviewed
Jul 11, 2024
View reviewed changes
@koukou
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reproduce this by the following change?
diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml
index 45417acf85..cd5f119b77 100644
--- a/dev/tasks/tasks.yml+++ b/dev/tasks/tasks.yml@@ -1418,6 +1418,16 @@ tasks:
GCC_VERSION: 12
image: ubuntu-r-only-r
+ # This also has -flto=auto+ test-r-gcc-13:+ ci: github+ template: docker-tests/github.linux.yml+ params:+ env:+ UBUNTU: 24.04+ GCC_VERSION: 13+ image: ubuntu-r-only-r+
test-r-minimal-build:
ci: azure
template: r/azure.linux.yml
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated

@github-actionsgithub-actionsBot
added

awaiting review
Awaiting review
awaiting changes
Awaiting changes
awaiting committer review
Awaiting committer review
and removed

awaiting review
Awaiting review
awaiting changes
Awaiting changes
awaiting committer review
Awaiting committer review
labels
Jul 11, 2024
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Jul 23, 2024
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-13-bundled
@apacheapache
deleted a comment from github-actionsBotJul 25, 2024
@github-actions
github-actionsBot
commented
Jul 25, 2024

Copy link


Copy Markdown

Revision: d59f39b
Submitted crossbow builds: ursacomputing/crossbow @ actions-a91e2018b6
TaskStatus
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
@amol-
amol-
commented
Jul 25, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
@koutest-ubuntu-24.04-cpp-gcc-13-bundled now compiles correctly. It fails the test, but it seems unrelated as they are timezone related tests. I'll kick-off a check on ubuntu-20.04 to confirm the test failures are unrelated.
I think that this is ready for final review.
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled
@github-actions
github-actionsBot
commented
Jul 25, 2024

Copy link


Copy Markdown

Revision: 70e6e7d
Submitted crossbow builds: ursacomputing/crossbow @ actions-3d162f80dd
TaskStatus
test-ubuntu-20.04-cpp-bundledGitHub Actions
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-13-bundled
@github-actions
github-actionsBot
commented
Jul 25, 2024

Copy link


Copy Markdown

Revision: 943baa0
Submitted crossbow builds: ursacomputing/crossbow @ actions-ecde5a2c6e
TaskStatus
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
The timestamp tests now pass too by installing tzdata-legacy
@amol-
amol-
requested a review
from kouJuly 25, 2024 17:24
assignUser
assignUser
approved these changes
Jul 25, 2024
View reviewed changes
@assignUserassignUser
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Could you also remove the workaround we added to r/configure?
@apacheapache
deleted a comment from github-actionsBotJul 26, 2024
@amol-
amol-
commented
Jul 26, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-depsource-bundled
@github-actions
github-actionsBot
commented
Jul 26, 2024

Copy link


Copy Markdown

Revision: 0a6e367
Submitted crossbow builds: ursacomputing/crossbow @ actions-c9cac2c09c
TaskStatus
test-r-depsource-bundledAzure
@amol-
amol-
commented
Jul 26, 2024

Copy link


Copy Markdown

MemberAuthor
Looks good, thanks! Could you also remove the workaround we added to r/configure?
Done and tested on test-r-depsource-bundled
@assignUser
assignUser
commented
Jul 26, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit r-binary-packages

Nice, thanks. I'll run this as it has a build on 24.04 which comes with the new gcc. I'll merge after
@github-actions
github-actionsBot
commented
Jul 26, 2024

Copy link


Copy Markdown

Revision: 0a6e367
Submitted crossbow builds: ursacomputing/crossbow @ actions-4b94da66a4
TaskStatus
r-binary-packagesGitHub Actions
@assignUser
assignUser
commented
Jul 26, 2024

Copy link


Copy Markdown

Member
Ugh, turns out ubuntu-latest is still 22.04, I modified the crossbow workflow to re-run on 24.04
@assignUser
assignUser
merged commit aaeff72
into
apache:mainJul 26, 2024
@assignUserassignUser
removed
the 
awaiting change review
Awaiting change review
label
Jul 26, 2024
@assignUserassignUser
mentioned this pull request
Jul 26, 2024

Closed

@conbench-apache-arrow
conbench-apache-arrowBot
commented
Jul 27, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit aaeff72.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
@jonkeanejonkeane
mentioned this pull request
Jul 31, 2024

Closed

38 tasks
jonkeane pushed a commit
that referenced
this pull request
Jul 31, 2024
@amol-@kou@jonkeane
GH-43228: [C++] Fix Abseil compile error on GCC 13 (#43157)
cbd6b5c
### Rationale for this change
When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a `<cstdint>` include, this PR addresses the issue by adding the missing include.
There have been past reports for this issue too: #36969 This is a more minimal fix that tries to avoid the complexity of previous attempts like #43147 and #37066 which involved updating Abseil and facing additional issues to fix.
### What changes are included in this PR?
Add the missing include when GCC>=13
### Are these changes tested?
They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds.
### Are there any user-facing changes?
No, all behaviours should remain the same
* GitHub Issue: #43228
Lead-authored-by: Alessandro Molina <alessandro@molina.fyi>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@assignUserassignUserassignUser approved these changes
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@koukouAwaiting requested review from koukou is a code owner

Assignees


No one assigned


Labels

Component: C++Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@amol-@kou@raulcd@assignUser

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-43228: [C++] Fix Abseil compile error on GCC 13 - #43157
Merged
assignUser merged 21 commits into
apache:mainfrom 
amol-:GH-36969-minimal
Jul 26, 2024
Merged
GH-43228: [C++] Fix Abseil compile error on GCC 13#43157
assignUser merged 21 commits into
apache:mainfrom 
amol-:GH-36969-minimal
Conversation
@amol-
@amol-amol-
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Rationale for this change
When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a <cstdint> include, this PR addresses the issue by adding the missing include.
There have been past reports for this issue too: #36969
This is a more minimal fix that tries to avoid the complexity of previous attempts like #43147 and #37066 which involved updating Abseil and facing additional issues to fix.
What changes are included in this PR?
Add the missing include when GCC>=13
Are these changes tested?
They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds.
Are there any user-facing changes?
No, all behaviours should remain the same
@amol-
amol-force-pushed
the
GH-36969-minimal
branch
from
7ccde25 to
8f503aeCompareJuly 5, 2024 16:36
@amol-
amol-
commented
Jul 5, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g r
@github-actions
github-actionsBot
commented
Jul 5, 2024

Copy link


Copy Markdown

Revision: 8f503ae7d8bab313b6325992c32859770dc29a98
Submitted crossbow builds: ursacomputing/crossbow @ actions-defadac854
TaskStatus
r-binary-packagesGitHub Actions
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-cuda-cppGitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-clang-sanitizerGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.1-opensuse155Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions
test-ubuntu-20.04-cppGitHub Actions
test-ubuntu-20.04-cpp-bundledGitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-r-sanitizerGitHub Actions
@amol-
amol-
marked this pull request as ready for review
July 5, 2024 18:34
@amol-
amol-
commented
Jul 5, 2024

Copy link


Copy Markdown

MemberAuthor
@raulcd@assignUser this should be ready for review, I tried a more conservative approach as upgrading Abseil introduced more problems than it fixed even on the most conservative version upgrade.
@koukou
changed the title
GH-36969: [C++] Fix ABSEIL compile error on GCC 13GH-36969: [C++] Fix Abseil compile error on GCC 13Jul 5, 2024
@kou
kou
commented
Jul 5, 2024

Copy link


Copy Markdown

Member
Could you open a new issue for this instead of reusing existing closed issue?
@amol-
amol-
commented
Jul 11, 2024

Copy link


Copy Markdown

MemberAuthor
Could you open a new issue for this instead of reusing existing closed issue?
Given it's the same exact error message shouldn't we preserve a consolidated history by keeping the original issue?

Happy to open a new issue if that's the preference
@raulcd
raulcd
commented
Jul 11, 2024

Copy link


Copy Markdown

Member
The problem is that the original issue is in the 13.0.0 milestone and all our current release scripts take that into account to generate release notes, etcetera. If we reuse the same issue it would be as if this PR was released on 13.0.0 and if we require to back port this issue it gets messy.

It has it's pros and cons but the current process doesn't account for two PRs pointing to the same GH issue.
@amol-
amol-
commented
Jul 11, 2024

Copy link


Copy Markdown

MemberAuthor
The problem is that the original issue is in the 13.0.0 milestone
Makes sense, I didn't check and thought it was closed without being done. I'll open a new one.
@amol-amol-
changed the title
GH-36969: [C++] Fix Abseil compile error on GCC 13GH-43228: [C++] Fix Abseil compile error on GCC 13Jul 11, 2024
@github-actions
github-actionsBot
commented
Jul 11, 2024

Copy link


Copy Markdown

⚠️ GitHub issue #43228has been automatically assigned in GitHub to PR creator.
kou
kou
reviewed
Jul 11, 2024
View reviewed changes
@koukou
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reproduce this by the following change?
diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml
index 45417acf85..cd5f119b77 100644
--- a/dev/tasks/tasks.yml+++ b/dev/tasks/tasks.yml@@ -1418,6 +1418,16 @@ tasks:
GCC_VERSION: 12
image: ubuntu-r-only-r
+ # This also has -flto=auto+ test-r-gcc-13:+ ci: github+ template: docker-tests/github.linux.yml+ params:+ env:+ UBUNTU: 24.04+ GCC_VERSION: 13+ image: ubuntu-r-only-r+
test-r-minimal-build:
ci: azure
template: r/azure.linux.yml
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated

@github-actionsgithub-actionsBot
added

awaiting review
Awaiting review
awaiting changes
Awaiting changes
awaiting committer review
Awaiting committer review
and removed

awaiting review
Awaiting review
awaiting changes
Awaiting changes
awaiting committer review
Awaiting committer review
labels
Jul 11, 2024
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Jul 23, 2024
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-13-bundled
@apacheapache
deleted a comment from github-actionsBotJul 25, 2024
@github-actions
github-actionsBot
commented
Jul 25, 2024

Copy link


Copy Markdown

Revision: d59f39b
Submitted crossbow builds: ursacomputing/crossbow @ actions-a91e2018b6
TaskStatus
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
@amol-
amol-
commented
Jul 25, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
@koutest-ubuntu-24.04-cpp-gcc-13-bundled now compiles correctly. It fails the test, but it seems unrelated as they are timezone related tests. I'll kick-off a check on ubuntu-20.04 to confirm the test failures are unrelated.
I think that this is ready for final review.
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled
@github-actions
github-actionsBot
commented
Jul 25, 2024

Copy link


Copy Markdown

Revision: 70e6e7d
Submitted crossbow builds: ursacomputing/crossbow @ actions-3d162f80dd
TaskStatus
test-ubuntu-20.04-cpp-bundledGitHub Actions
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-13-bundled
@github-actions
github-actionsBot
commented
Jul 25, 2024

Copy link


Copy Markdown

Revision: 943baa0
Submitted crossbow builds: ursacomputing/crossbow @ actions-ecde5a2c6e
TaskStatus
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
The timestamp tests now pass too by installing tzdata-legacy
@amol-
amol-
requested a review
from kouJuly 25, 2024 17:24
assignUser
assignUser
approved these changes
Jul 25, 2024
View reviewed changes
@assignUserassignUser
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Could you also remove the workaround we added to r/configure?
@apacheapache
deleted a comment from github-actionsBotJul 26, 2024
@amol-
amol-
commented
Jul 26, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-depsource-bundled
@github-actions
github-actionsBot
commented
Jul 26, 2024

Copy link


Copy Markdown

Revision: 0a6e367
Submitted crossbow builds: ursacomputing/crossbow @ actions-c9cac2c09c
TaskStatus
test-r-depsource-bundledAzure
@amol-
amol-
commented
Jul 26, 2024

Copy link


Copy Markdown

MemberAuthor
Looks good, thanks! Could you also remove the workaround we added to r/configure?
Done and tested on test-r-depsource-bundled
@assignUser
assignUser
commented
Jul 26, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit r-binary-packages

Nice, thanks. I'll run this as it has a build on 24.04 which comes with the new gcc. I'll merge after
@github-actions
github-actionsBot
commented
Jul 26, 2024

Copy link


Copy Markdown

Revision: 0a6e367
Submitted crossbow builds: ursacomputing/crossbow @ actions-4b94da66a4
TaskStatus
r-binary-packagesGitHub Actions
@assignUser
assignUser
commented
Jul 26, 2024

Copy link


Copy Markdown

Member
Ugh, turns out ubuntu-latest is still 22.04, I modified the crossbow workflow to re-run on 24.04
@assignUser
assignUser
merged commit aaeff72
into
apache:mainJul 26, 2024
@assignUserassignUser
removed
the 
awaiting change review
Awaiting change review
label
Jul 26, 2024
@assignUserassignUser
mentioned this pull request
Jul 26, 2024

Closed

@conbench-apache-arrow
conbench-apache-arrowBot
commented
Jul 27, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit aaeff72.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
@jonkeanejonkeane
mentioned this pull request
Jul 31, 2024

Closed

38 tasks
jonkeane pushed a commit
that referenced
this pull request
Jul 31, 2024
@amol-@kou@jonkeane
GH-43228: [C++] Fix Abseil compile error on GCC 13 (#43157)
cbd6b5c
### Rationale for this change
When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a `<cstdint>` include, this PR addresses the issue by adding the missing include.
There have been past reports for this issue too: #36969 This is a more minimal fix that tries to avoid the complexity of previous attempts like #43147 and #37066 which involved updating Abseil and facing additional issues to fix.
### What changes are included in this PR?
Add the missing include when GCC>=13
### Are these changes tested?
They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds.
### Are there any user-facing changes?
No, all behaviours should remain the same
* GitHub Issue: #43228
Lead-authored-by: Alessandro Molina <alessandro@molina.fyi>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@assignUserassignUserassignUser approved these changes
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@koukouAwaiting requested review from koukou is a code owner

Assignees


No one assigned


Labels

Component: C++Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@amol-@kou@raulcd@assignUser

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
GH-43228: [C++] Fix Abseil compile error on GCC 13 - #43157
Merged
assignUser merged 21 commits into
apache:mainfrom 
amol-:GH-36969-minimal
Jul 26, 2024
Merged
GH-43228: [C++] Fix Abseil compile error on GCC 13#43157
assignUser merged 21 commits into
apache:mainfrom 
amol-:GH-36969-minimal
Conversation
@amol-
@amol-amol-
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Rationale for this change
When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a <cstdint> include, this PR addresses the issue by adding the missing include.
There have been past reports for this issue too: #36969
This is a more minimal fix that tries to avoid the complexity of previous attempts like #43147 and #37066 which involved updating Abseil and facing additional issues to fix.
What changes are included in this PR?
Add the missing include when GCC>=13
Are these changes tested?
They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds.
Are there any user-facing changes?
No, all behaviours should remain the same
@amol-
amol-force-pushed
the
GH-36969-minimal
branch
from
7ccde25 to
8f503aeCompareJuly 5, 2024 16:36
@amol-
amol-
commented
Jul 5, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g r
@github-actions
github-actionsBot
commented
Jul 5, 2024

Copy link


Copy Markdown

Revision: 8f503ae7d8bab313b6325992c32859770dc29a98
Submitted crossbow builds: ursacomputing/crossbow @ actions-defadac854
TaskStatus
r-binary-packagesGitHub Actions
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-cuda-cppGitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-clang-sanitizerGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.1-opensuse155Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions
test-ubuntu-20.04-cppGitHub Actions
test-ubuntu-20.04-cpp-bundledGitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-r-sanitizerGitHub Actions
@amol-
amol-
marked this pull request as ready for review
July 5, 2024 18:34
@amol-
amol-
commented
Jul 5, 2024

Copy link


Copy Markdown

MemberAuthor
@raulcd@assignUser this should be ready for review, I tried a more conservative approach as upgrading Abseil introduced more problems than it fixed even on the most conservative version upgrade.
@koukou
changed the title
GH-36969: [C++] Fix ABSEIL compile error on GCC 13GH-36969: [C++] Fix Abseil compile error on GCC 13Jul 5, 2024
@kou
kou
commented
Jul 5, 2024

Copy link


Copy Markdown

Member
Could you open a new issue for this instead of reusing existing closed issue?
@amol-
amol-
commented
Jul 11, 2024

Copy link


Copy Markdown

MemberAuthor
Could you open a new issue for this instead of reusing existing closed issue?
Given it's the same exact error message shouldn't we preserve a consolidated history by keeping the original issue?

Happy to open a new issue if that's the preference
@raulcd
raulcd
commented
Jul 11, 2024

Copy link


Copy Markdown

Member
The problem is that the original issue is in the 13.0.0 milestone and all our current release scripts take that into account to generate release notes, etcetera. If we reuse the same issue it would be as if this PR was released on 13.0.0 and if we require to back port this issue it gets messy.

It has it's pros and cons but the current process doesn't account for two PRs pointing to the same GH issue.
@amol-
amol-
commented
Jul 11, 2024

Copy link


Copy Markdown

MemberAuthor
The problem is that the original issue is in the 13.0.0 milestone
Makes sense, I didn't check and thought it was closed without being done. I'll open a new one.
@amol-amol-
changed the title
GH-36969: [C++] Fix Abseil compile error on GCC 13GH-43228: [C++] Fix Abseil compile error on GCC 13Jul 11, 2024
@github-actions
github-actionsBot
commented
Jul 11, 2024

Copy link


Copy Markdown

⚠️ GitHub issue #43228has been automatically assigned in GitHub to PR creator.
kou
kou
reviewed
Jul 11, 2024
View reviewed changes
@koukou
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reproduce this by the following change?
diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml
index 45417acf85..cd5f119b77 100644
--- a/dev/tasks/tasks.yml+++ b/dev/tasks/tasks.yml@@ -1418,6 +1418,16 @@ tasks:
GCC_VERSION: 12
image: ubuntu-r-only-r
+ # This also has -flto=auto+ test-r-gcc-13:+ ci: github+ template: docker-tests/github.linux.yml+ params:+ env:+ UBUNTU: 24.04+ GCC_VERSION: 13+ image: ubuntu-r-only-r+
test-r-minimal-build:
ci: azure
template: r/azure.linux.yml
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated

@github-actionsgithub-actionsBot
added

awaiting review
Awaiting review
awaiting changes
Awaiting changes
awaiting committer review
Awaiting committer review
and removed

awaiting review
Awaiting review
awaiting changes
Awaiting changes
awaiting committer review
Awaiting committer review
labels
Jul 11, 2024
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Jul 23, 2024
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-13-bundled
@apacheapache
deleted a comment from github-actionsBotJul 25, 2024
@github-actions
github-actionsBot
commented
Jul 25, 2024

Copy link


Copy Markdown

Revision: d59f39b
Submitted crossbow builds: ursacomputing/crossbow @ actions-a91e2018b6
TaskStatus
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
@amol-
amol-
commented
Jul 25, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
@koutest-ubuntu-24.04-cpp-gcc-13-bundled now compiles correctly. It fails the test, but it seems unrelated as they are timezone related tests. I'll kick-off a check on ubuntu-20.04 to confirm the test failures are unrelated.
I think that this is ready for final review.
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled
@github-actions
github-actionsBot
commented
Jul 25, 2024

Copy link


Copy Markdown

Revision: 70e6e7d
Submitted crossbow builds: ursacomputing/crossbow @ actions-3d162f80dd
TaskStatus
test-ubuntu-20.04-cpp-bundledGitHub Actions
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-13-bundled
@github-actions
github-actionsBot
commented
Jul 25, 2024

Copy link


Copy Markdown

Revision: 943baa0
Submitted crossbow builds: ursacomputing/crossbow @ actions-ecde5a2c6e
TaskStatus
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
The timestamp tests now pass too by installing tzdata-legacy
@amol-
amol-
requested a review
from kouJuly 25, 2024 17:24
assignUser
assignUser
approved these changes
Jul 25, 2024
View reviewed changes
@assignUserassignUser
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Could you also remove the workaround we added to r/configure?
@apacheapache
deleted a comment from github-actionsBotJul 26, 2024
@amol-
amol-
commented
Jul 26, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-depsource-bundled
@github-actions
github-actionsBot
commented
Jul 26, 2024

Copy link


Copy Markdown

Revision: 0a6e367
Submitted crossbow builds: ursacomputing/crossbow @ actions-c9cac2c09c
TaskStatus
test-r-depsource-bundledAzure
@amol-
amol-
commented
Jul 26, 2024

Copy link


Copy Markdown

MemberAuthor
Looks good, thanks! Could you also remove the workaround we added to r/configure?
Done and tested on test-r-depsource-bundled
@assignUser
assignUser
commented
Jul 26, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit r-binary-packages

Nice, thanks. I'll run this as it has a build on 24.04 which comes with the new gcc. I'll merge after
@github-actions
github-actionsBot
commented
Jul 26, 2024

Copy link


Copy Markdown

Revision: 0a6e367
Submitted crossbow builds: ursacomputing/crossbow @ actions-4b94da66a4
TaskStatus
r-binary-packagesGitHub Actions
@assignUser
assignUser
commented
Jul 26, 2024

Copy link


Copy Markdown

Member
Ugh, turns out ubuntu-latest is still 22.04, I modified the crossbow workflow to re-run on 24.04
@assignUser
assignUser
merged commit aaeff72
into
apache:mainJul 26, 2024
@assignUserassignUser
removed
the 
awaiting change review
Awaiting change review
label
Jul 26, 2024
@assignUserassignUser
mentioned this pull request
Jul 26, 2024

Closed

@conbench-apache-arrow
conbench-apache-arrowBot
commented
Jul 27, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit aaeff72.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
@jonkeanejonkeane
mentioned this pull request
Jul 31, 2024

Closed

38 tasks
jonkeane pushed a commit
that referenced
this pull request
Jul 31, 2024
@amol-@kou@jonkeane
GH-43228: [C++] Fix Abseil compile error on GCC 13 (#43157)
cbd6b5c
### Rationale for this change
When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a `<cstdint>` include, this PR addresses the issue by adding the missing include.
There have been past reports for this issue too: #36969 This is a more minimal fix that tries to avoid the complexity of previous attempts like #43147 and #37066 which involved updating Abseil and facing additional issues to fix.
### What changes are included in this PR?
Add the missing include when GCC>=13
### Are these changes tested?
They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds.
### Are there any user-facing changes?
No, all behaviours should remain the same
* GitHub Issue: #43228
Lead-authored-by: Alessandro Molina <alessandro@molina.fyi>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@assignUserassignUserassignUser approved these changes
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@koukouAwaiting requested review from koukou is a code owner

Assignees


No one assigned


Labels

Component: C++Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@amol-@kou@raulcd@assignUser

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-43228: [C++] Fix Abseil compile error on GCC 13 - #43157
Merged
assignUser merged 21 commits into
apache:mainfrom 
amol-:GH-36969-minimal
Jul 26, 2024
Merged
GH-43228: [C++] Fix Abseil compile error on GCC 13#43157
assignUser merged 21 commits into
apache:mainfrom 
amol-:GH-36969-minimal
Conversation
@amol-
@amol-amol-
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Rationale for this change
When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a <cstdint> include, this PR addresses the issue by adding the missing include.
There have been past reports for this issue too: #36969
This is a more minimal fix that tries to avoid the complexity of previous attempts like #43147 and #37066 which involved updating Abseil and facing additional issues to fix.
What changes are included in this PR?
Add the missing include when GCC>=13
Are these changes tested?
They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds.
Are there any user-facing changes?
No, all behaviours should remain the same
@amol-
amol-force-pushed
the
GH-36969-minimal
branch
from
7ccde25 to
8f503aeCompareJuly 5, 2024 16:36
@amol-
amol-
commented
Jul 5, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g r
@github-actions
github-actionsBot
commented
Jul 5, 2024

Copy link


Copy Markdown

Revision: 8f503ae7d8bab313b6325992c32859770dc29a98
Submitted crossbow builds: ursacomputing/crossbow @ actions-defadac854
TaskStatus
r-binary-packagesGitHub Actions
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-cuda-cppGitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-clang-sanitizerGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.1-opensuse155Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions
test-ubuntu-20.04-cppGitHub Actions
test-ubuntu-20.04-cpp-bundledGitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-r-sanitizerGitHub Actions
@amol-
amol-
marked this pull request as ready for review
July 5, 2024 18:34
@amol-
amol-
commented
Jul 5, 2024

Copy link


Copy Markdown

MemberAuthor
@raulcd@assignUser this should be ready for review, I tried a more conservative approach as upgrading Abseil introduced more problems than it fixed even on the most conservative version upgrade.
@koukou
changed the title
GH-36969: [C++] Fix ABSEIL compile error on GCC 13GH-36969: [C++] Fix Abseil compile error on GCC 13Jul 5, 2024
@kou
kou
commented
Jul 5, 2024

Copy link


Copy Markdown

Member
Could you open a new issue for this instead of reusing existing closed issue?
@amol-
amol-
commented
Jul 11, 2024

Copy link


Copy Markdown

MemberAuthor
Could you open a new issue for this instead of reusing existing closed issue?
Given it's the same exact error message shouldn't we preserve a consolidated history by keeping the original issue?

Happy to open a new issue if that's the preference
@raulcd
raulcd
commented
Jul 11, 2024

Copy link


Copy Markdown

Member
The problem is that the original issue is in the 13.0.0 milestone and all our current release scripts take that into account to generate release notes, etcetera. If we reuse the same issue it would be as if this PR was released on 13.0.0 and if we require to back port this issue it gets messy.

It has it's pros and cons but the current process doesn't account for two PRs pointing to the same GH issue.
@amol-
amol-
commented
Jul 11, 2024

Copy link


Copy Markdown

MemberAuthor
The problem is that the original issue is in the 13.0.0 milestone
Makes sense, I didn't check and thought it was closed without being done. I'll open a new one.
@amol-amol-
changed the title
GH-36969: [C++] Fix Abseil compile error on GCC 13GH-43228: [C++] Fix Abseil compile error on GCC 13Jul 11, 2024
@github-actions
github-actionsBot
commented
Jul 11, 2024

Copy link


Copy Markdown

⚠️ GitHub issue #43228has been automatically assigned in GitHub to PR creator.
kou
kou
reviewed
Jul 11, 2024
View reviewed changes
@koukou
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reproduce this by the following change?
diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml
index 45417acf85..cd5f119b77 100644
--- a/dev/tasks/tasks.yml+++ b/dev/tasks/tasks.yml@@ -1418,6 +1418,16 @@ tasks:
GCC_VERSION: 12
image: ubuntu-r-only-r
+ # This also has -flto=auto+ test-r-gcc-13:+ ci: github+ template: docker-tests/github.linux.yml+ params:+ env:+ UBUNTU: 24.04+ GCC_VERSION: 13+ image: ubuntu-r-only-r+
test-r-minimal-build:
ci: azure
template: r/azure.linux.yml
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated

@github-actionsgithub-actionsBot
added

awaiting review
Awaiting review
awaiting changes
Awaiting changes
awaiting committer review
Awaiting committer review
and removed

awaiting review
Awaiting review
awaiting changes
Awaiting changes
awaiting committer review
Awaiting committer review
labels
Jul 11, 2024
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Jul 23, 2024
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-13-bundled
@apacheapache
deleted a comment from github-actionsBotJul 25, 2024
@github-actions
github-actionsBot
commented
Jul 25, 2024

Copy link


Copy Markdown

Revision: d59f39b
Submitted crossbow builds: ursacomputing/crossbow @ actions-a91e2018b6
TaskStatus
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
@amol-
amol-
commented
Jul 25, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
@koutest-ubuntu-24.04-cpp-gcc-13-bundled now compiles correctly. It fails the test, but it seems unrelated as they are timezone related tests. I'll kick-off a check on ubuntu-20.04 to confirm the test failures are unrelated.
I think that this is ready for final review.
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled
@github-actions
github-actionsBot
commented
Jul 25, 2024

Copy link


Copy Markdown

Revision: 70e6e7d
Submitted crossbow builds: ursacomputing/crossbow @ actions-3d162f80dd
TaskStatus
test-ubuntu-20.04-cpp-bundledGitHub Actions
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-13-bundled
@github-actions
github-actionsBot
commented
Jul 25, 2024

Copy link


Copy Markdown

Revision: 943baa0
Submitted crossbow builds: ursacomputing/crossbow @ actions-ecde5a2c6e
TaskStatus
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
The timestamp tests now pass too by installing tzdata-legacy
@amol-
amol-
requested a review
from kouJuly 25, 2024 17:24
assignUser
assignUser
approved these changes
Jul 25, 2024
View reviewed changes
@assignUserassignUser
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Could you also remove the workaround we added to r/configure?
@apacheapache
deleted a comment from github-actionsBotJul 26, 2024
@amol-
amol-
commented
Jul 26, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-depsource-bundled
@github-actions
github-actionsBot
commented
Jul 26, 2024

Copy link


Copy Markdown

Revision: 0a6e367
Submitted crossbow builds: ursacomputing/crossbow @ actions-c9cac2c09c
TaskStatus
test-r-depsource-bundledAzure
@amol-
amol-
commented
Jul 26, 2024

Copy link


Copy Markdown

MemberAuthor
Looks good, thanks! Could you also remove the workaround we added to r/configure?
Done and tested on test-r-depsource-bundled
@assignUser
assignUser
commented
Jul 26, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit r-binary-packages

Nice, thanks. I'll run this as it has a build on 24.04 which comes with the new gcc. I'll merge after
@github-actions
github-actionsBot
commented
Jul 26, 2024

Copy link


Copy Markdown

Revision: 0a6e367
Submitted crossbow builds: ursacomputing/crossbow @ actions-4b94da66a4
TaskStatus
r-binary-packagesGitHub Actions
@assignUser
assignUser
commented
Jul 26, 2024

Copy link


Copy Markdown

Member
Ugh, turns out ubuntu-latest is still 22.04, I modified the crossbow workflow to re-run on 24.04
@assignUser
assignUser
merged commit aaeff72
into
apache:mainJul 26, 2024
@assignUserassignUser
removed
the 
awaiting change review
Awaiting change review
label
Jul 26, 2024
@assignUserassignUser
mentioned this pull request
Jul 26, 2024

Closed

@conbench-apache-arrow
conbench-apache-arrowBot
commented
Jul 27, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit aaeff72.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
@jonkeanejonkeane
mentioned this pull request
Jul 31, 2024

Closed

38 tasks
jonkeane pushed a commit
that referenced
this pull request
Jul 31, 2024
@amol-@kou@jonkeane
GH-43228: [C++] Fix Abseil compile error on GCC 13 (#43157)
cbd6b5c
### Rationale for this change
When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a `<cstdint>` include, this PR addresses the issue by adding the missing include.
There have been past reports for this issue too: #36969 This is a more minimal fix that tries to avoid the complexity of previous attempts like #43147 and #37066 which involved updating Abseil and facing additional issues to fix.
### What changes are included in this PR?
Add the missing include when GCC>=13
### Are these changes tested?
They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds.
### Are there any user-facing changes?
No, all behaviours should remain the same
* GitHub Issue: #43228
Lead-authored-by: Alessandro Molina <alessandro@molina.fyi>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@assignUserassignUserassignUser approved these changes
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@koukouAwaiting requested review from koukou is a code owner

Assignees


No one assigned


Labels

Component: C++Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@amol-@kou@raulcd@assignUser

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-43228: [C++] Fix Abseil compile error on GCC 13 - #43157
Merged
assignUser merged 21 commits into
apache:mainfrom 
amol-:GH-36969-minimal
Jul 26, 2024
Merged
GH-43228: [C++] Fix Abseil compile error on GCC 13#43157
assignUser merged 21 commits into
apache:mainfrom 
amol-:GH-36969-minimal
Conversation
@amol-
@amol-amol-
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Rationale for this change
When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a <cstdint> include, this PR addresses the issue by adding the missing include.
There have been past reports for this issue too: #36969
This is a more minimal fix that tries to avoid the complexity of previous attempts like #43147 and #37066 which involved updating Abseil and facing additional issues to fix.
What changes are included in this PR?
Add the missing include when GCC>=13
Are these changes tested?
They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds.
Are there any user-facing changes?
No, all behaviours should remain the same
@amol-
amol-force-pushed
the
GH-36969-minimal
branch
from
7ccde25 to
8f503aeCompareJuly 5, 2024 16:36
@amol-
amol-
commented
Jul 5, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g r
@github-actions
github-actionsBot
commented
Jul 5, 2024

Copy link


Copy Markdown

Revision: 8f503ae7d8bab313b6325992c32859770dc29a98
Submitted crossbow builds: ursacomputing/crossbow @ actions-defadac854
TaskStatus
r-binary-packagesGitHub Actions
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-cuda-cppGitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-clang-sanitizerGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.1-opensuse155Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions
test-ubuntu-20.04-cppGitHub Actions
test-ubuntu-20.04-cpp-bundledGitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-r-sanitizerGitHub Actions
@amol-
amol-
marked this pull request as ready for review
July 5, 2024 18:34
@amol-
amol-
commented
Jul 5, 2024

Copy link


Copy Markdown

MemberAuthor
@raulcd@assignUser this should be ready for review, I tried a more conservative approach as upgrading Abseil introduced more problems than it fixed even on the most conservative version upgrade.
@koukou
changed the title
GH-36969: [C++] Fix ABSEIL compile error on GCC 13GH-36969: [C++] Fix Abseil compile error on GCC 13Jul 5, 2024
@kou
kou
commented
Jul 5, 2024

Copy link


Copy Markdown

Member
Could you open a new issue for this instead of reusing existing closed issue?
@amol-
amol-
commented
Jul 11, 2024

Copy link


Copy Markdown

MemberAuthor
Could you open a new issue for this instead of reusing existing closed issue?
Given it's the same exact error message shouldn't we preserve a consolidated history by keeping the original issue?

Happy to open a new issue if that's the preference
@raulcd
raulcd
commented
Jul 11, 2024

Copy link


Copy Markdown

Member
The problem is that the original issue is in the 13.0.0 milestone and all our current release scripts take that into account to generate release notes, etcetera. If we reuse the same issue it would be as if this PR was released on 13.0.0 and if we require to back port this issue it gets messy.

It has it's pros and cons but the current process doesn't account for two PRs pointing to the same GH issue.
@amol-
amol-
commented
Jul 11, 2024

Copy link


Copy Markdown

MemberAuthor
The problem is that the original issue is in the 13.0.0 milestone
Makes sense, I didn't check and thought it was closed without being done. I'll open a new one.
@amol-amol-
changed the title
GH-36969: [C++] Fix Abseil compile error on GCC 13GH-43228: [C++] Fix Abseil compile error on GCC 13Jul 11, 2024
@github-actions
github-actionsBot
commented
Jul 11, 2024

Copy link


Copy Markdown

⚠️ GitHub issue #43228has been automatically assigned in GitHub to PR creator.
kou
kou
reviewed
Jul 11, 2024
View reviewed changes
@koukou
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reproduce this by the following change?
diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml
index 45417acf85..cd5f119b77 100644
--- a/dev/tasks/tasks.yml+++ b/dev/tasks/tasks.yml@@ -1418,6 +1418,16 @@ tasks:
GCC_VERSION: 12
image: ubuntu-r-only-r
+ # This also has -flto=auto+ test-r-gcc-13:+ ci: github+ template: docker-tests/github.linux.yml+ params:+ env:+ UBUNTU: 24.04+ GCC_VERSION: 13+ image: ubuntu-r-only-r+
test-r-minimal-build:
ci: azure
template: r/azure.linux.yml
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated

@github-actionsgithub-actionsBot
added

awaiting review
Awaiting review
awaiting changes
Awaiting changes
awaiting committer review
Awaiting committer review
and removed

awaiting review
Awaiting review
awaiting changes
Awaiting changes
awaiting committer review
Awaiting committer review
labels
Jul 11, 2024
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Jul 23, 2024
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-13-bundled
@apacheapache
deleted a comment from github-actionsBotJul 25, 2024
@github-actions
github-actionsBot
commented
Jul 25, 2024

Copy link


Copy Markdown

Revision: d59f39b
Submitted crossbow builds: ursacomputing/crossbow @ actions-a91e2018b6
TaskStatus
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
@amol-
amol-
commented
Jul 25, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
@koutest-ubuntu-24.04-cpp-gcc-13-bundled now compiles correctly. It fails the test, but it seems unrelated as they are timezone related tests. I'll kick-off a check on ubuntu-20.04 to confirm the test failures are unrelated.
I think that this is ready for final review.
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled
@github-actions
github-actionsBot
commented
Jul 25, 2024

Copy link


Copy Markdown

Revision: 70e6e7d
Submitted crossbow builds: ursacomputing/crossbow @ actions-3d162f80dd
TaskStatus
test-ubuntu-20.04-cpp-bundledGitHub Actions
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-13-bundled
@github-actions
github-actionsBot
commented
Jul 25, 2024

Copy link


Copy Markdown

Revision: 943baa0
Submitted crossbow builds: ursacomputing/crossbow @ actions-ecde5a2c6e
TaskStatus
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
The timestamp tests now pass too by installing tzdata-legacy
@amol-
amol-
requested a review
from kouJuly 25, 2024 17:24
assignUser
assignUser
approved these changes
Jul 25, 2024
View reviewed changes
@assignUserassignUser
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Could you also remove the workaround we added to r/configure?
@apacheapache
deleted a comment from github-actionsBotJul 26, 2024
@amol-
amol-
commented
Jul 26, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-depsource-bundled
@github-actions
github-actionsBot
commented
Jul 26, 2024

Copy link


Copy Markdown

Revision: 0a6e367
Submitted crossbow builds: ursacomputing/crossbow @ actions-c9cac2c09c
TaskStatus
test-r-depsource-bundledAzure
@amol-
amol-
commented
Jul 26, 2024

Copy link


Copy Markdown

MemberAuthor
Looks good, thanks! Could you also remove the workaround we added to r/configure?
Done and tested on test-r-depsource-bundled
@assignUser
assignUser
commented
Jul 26, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit r-binary-packages

Nice, thanks. I'll run this as it has a build on 24.04 which comes with the new gcc. I'll merge after
@github-actions
github-actionsBot
commented
Jul 26, 2024

Copy link


Copy Markdown

Revision: 0a6e367
Submitted crossbow builds: ursacomputing/crossbow @ actions-4b94da66a4
TaskStatus
r-binary-packagesGitHub Actions
@assignUser
assignUser
commented
Jul 26, 2024

Copy link


Copy Markdown

Member
Ugh, turns out ubuntu-latest is still 22.04, I modified the crossbow workflow to re-run on 24.04
@assignUser
assignUser
merged commit aaeff72
into
apache:mainJul 26, 2024
@assignUserassignUser
removed
the 
awaiting change review
Awaiting change review
label
Jul 26, 2024
@assignUserassignUser
mentioned this pull request
Jul 26, 2024

Closed

@conbench-apache-arrow
conbench-apache-arrowBot
commented
Jul 27, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit aaeff72.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
@jonkeanejonkeane
mentioned this pull request
Jul 31, 2024

Closed

38 tasks
jonkeane pushed a commit
that referenced
this pull request
Jul 31, 2024
@amol-@kou@jonkeane
GH-43228: [C++] Fix Abseil compile error on GCC 13 (#43157)
cbd6b5c
### Rationale for this change
When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a `<cstdint>` include, this PR addresses the issue by adding the missing include.
There have been past reports for this issue too: #36969 This is a more minimal fix that tries to avoid the complexity of previous attempts like #43147 and #37066 which involved updating Abseil and facing additional issues to fix.
### What changes are included in this PR?
Add the missing include when GCC>=13
### Are these changes tested?
They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds.
### Are there any user-facing changes?
No, all behaviours should remain the same
* GitHub Issue: #43228
Lead-authored-by: Alessandro Molina <alessandro@molina.fyi>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@assignUserassignUserassignUser approved these changes
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@koukouAwaiting requested review from koukou is a code owner

Assignees


No one assigned


Labels

Component: C++Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@amol-@kou@raulcd@assignUser

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
GH-43228: [C++] Fix Abseil compile error on GCC 13 - #43157
Merged
assignUser merged 21 commits into
apache:mainfrom 
amol-:GH-36969-minimal
Jul 26, 2024
Merged
GH-43228: [C++] Fix Abseil compile error on GCC 13#43157
assignUser merged 21 commits into
apache:mainfrom 
amol-:GH-36969-minimal
Conversation
@amol-
@amol-amol-
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Rationale for this change
When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a <cstdint> include, this PR addresses the issue by adding the missing include.
There have been past reports for this issue too: #36969
This is a more minimal fix that tries to avoid the complexity of previous attempts like #43147 and #37066 which involved updating Abseil and facing additional issues to fix.
What changes are included in this PR?
Add the missing include when GCC>=13
Are these changes tested?
They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds.
Are there any user-facing changes?
No, all behaviours should remain the same
@amol-
amol-force-pushed
the
GH-36969-minimal
branch
from
7ccde25 to
8f503aeCompareJuly 5, 2024 16:36
@amol-
amol-
commented
Jul 5, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g r
@github-actions
github-actionsBot
commented
Jul 5, 2024

Copy link


Copy Markdown

Revision: 8f503ae7d8bab313b6325992c32859770dc29a98
Submitted crossbow builds: ursacomputing/crossbow @ actions-defadac854
TaskStatus
r-binary-packagesGitHub Actions
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-cuda-cppGitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-clang-sanitizerGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.1-opensuse155Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions
test-ubuntu-20.04-cppGitHub Actions
test-ubuntu-20.04-cpp-bundledGitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-r-sanitizerGitHub Actions
@amol-
amol-
marked this pull request as ready for review
July 5, 2024 18:34
@amol-
amol-
commented
Jul 5, 2024

Copy link


Copy Markdown

MemberAuthor
@raulcd@assignUser this should be ready for review, I tried a more conservative approach as upgrading Abseil introduced more problems than it fixed even on the most conservative version upgrade.
@koukou
changed the title
GH-36969: [C++] Fix ABSEIL compile error on GCC 13GH-36969: [C++] Fix Abseil compile error on GCC 13Jul 5, 2024
@kou
kou
commented
Jul 5, 2024

Copy link


Copy Markdown

Member
Could you open a new issue for this instead of reusing existing closed issue?
@amol-
amol-
commented
Jul 11, 2024

Copy link


Copy Markdown

MemberAuthor
Could you open a new issue for this instead of reusing existing closed issue?
Given it's the same exact error message shouldn't we preserve a consolidated history by keeping the original issue?

Happy to open a new issue if that's the preference
@raulcd
raulcd
commented
Jul 11, 2024

Copy link


Copy Markdown

Member
The problem is that the original issue is in the 13.0.0 milestone and all our current release scripts take that into account to generate release notes, etcetera. If we reuse the same issue it would be as if this PR was released on 13.0.0 and if we require to back port this issue it gets messy.

It has it's pros and cons but the current process doesn't account for two PRs pointing to the same GH issue.
@amol-
amol-
commented
Jul 11, 2024

Copy link


Copy Markdown

MemberAuthor
The problem is that the original issue is in the 13.0.0 milestone
Makes sense, I didn't check and thought it was closed without being done. I'll open a new one.
@amol-amol-
changed the title
GH-36969: [C++] Fix Abseil compile error on GCC 13GH-43228: [C++] Fix Abseil compile error on GCC 13Jul 11, 2024
@github-actions
github-actionsBot
commented
Jul 11, 2024

Copy link


Copy Markdown

⚠️ GitHub issue #43228has been automatically assigned in GitHub to PR creator.
kou
kou
reviewed
Jul 11, 2024
View reviewed changes
@koukou
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reproduce this by the following change?
diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml
index 45417acf85..cd5f119b77 100644
--- a/dev/tasks/tasks.yml+++ b/dev/tasks/tasks.yml@@ -1418,6 +1418,16 @@ tasks:
GCC_VERSION: 12
image: ubuntu-r-only-r
+ # This also has -flto=auto+ test-r-gcc-13:+ ci: github+ template: docker-tests/github.linux.yml+ params:+ env:+ UBUNTU: 24.04+ GCC_VERSION: 13+ image: ubuntu-r-only-r+
test-r-minimal-build:
ci: azure
template: r/azure.linux.yml
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated

@github-actionsgithub-actionsBot
added

awaiting review
Awaiting review
awaiting changes
Awaiting changes
awaiting committer review
Awaiting committer review
and removed

awaiting review
Awaiting review
awaiting changes
Awaiting changes
awaiting committer review
Awaiting committer review
labels
Jul 11, 2024
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Jul 23, 2024
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-13-bundled
@apacheapache
deleted a comment from github-actionsBotJul 25, 2024
@github-actions
github-actionsBot
commented
Jul 25, 2024

Copy link


Copy Markdown

Revision: d59f39b
Submitted crossbow builds: ursacomputing/crossbow @ actions-a91e2018b6
TaskStatus
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
@amol-
amol-
commented
Jul 25, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
@koutest-ubuntu-24.04-cpp-gcc-13-bundled now compiles correctly. It fails the test, but it seems unrelated as they are timezone related tests. I'll kick-off a check on ubuntu-20.04 to confirm the test failures are unrelated.
I think that this is ready for final review.
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled
@github-actions
github-actionsBot
commented
Jul 25, 2024

Copy link


Copy Markdown

Revision: 70e6e7d
Submitted crossbow builds: ursacomputing/crossbow @ actions-3d162f80dd
TaskStatus
test-ubuntu-20.04-cpp-bundledGitHub Actions
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-13-bundled
@github-actions
github-actionsBot
commented
Jul 25, 2024

Copy link


Copy Markdown

Revision: 943baa0
Submitted crossbow builds: ursacomputing/crossbow @ actions-ecde5a2c6e
TaskStatus
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
@amol-
amol-
commented
Jul 25, 2024

Copy link


Copy Markdown

MemberAuthor
The timestamp tests now pass too by installing tzdata-legacy
@amol-
amol-
requested a review
from kouJuly 25, 2024 17:24
assignUser
assignUser
approved these changes
Jul 25, 2024
View reviewed changes
@assignUserassignUser
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Could you also remove the workaround we added to r/configure?
@apacheapache
deleted a comment from github-actionsBotJul 26, 2024
@amol-
amol-
commented
Jul 26, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-depsource-bundled
@github-actions
github-actionsBot
commented
Jul 26, 2024

Copy link


Copy Markdown

Revision: 0a6e367
Submitted crossbow builds: ursacomputing/crossbow @ actions-c9cac2c09c
TaskStatus
test-r-depsource-bundledAzure
@amol-
amol-
commented
Jul 26, 2024

Copy link


Copy Markdown

MemberAuthor
Looks good, thanks! Could you also remove the workaround we added to r/configure?
Done and tested on test-r-depsource-bundled
@assignUser
assignUser
commented
Jul 26, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit r-binary-packages

Nice, thanks. I'll run this as it has a build on 24.04 which comes with the new gcc. I'll merge after
@github-actions
github-actionsBot
commented
Jul 26, 2024

Copy link


Copy Markdown

Revision: 0a6e367
Submitted crossbow builds: ursacomputing/crossbow @ actions-4b94da66a4
TaskStatus
r-binary-packagesGitHub Actions
@assignUser
assignUser
commented
Jul 26, 2024

Copy link


Copy Markdown

Member
Ugh, turns out ubuntu-latest is still 22.04, I modified the crossbow workflow to re-run on 24.04
@assignUser
assignUser
merged commit aaeff72
into
apache:mainJul 26, 2024
@assignUserassignUser
removed
the 
awaiting change review
Awaiting change review
label
Jul 26, 2024
@assignUserassignUser
mentioned this pull request
Jul 26, 2024

Closed

@conbench-apache-arrow
conbench-apache-arrowBot
commented
Jul 27, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit aaeff72.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
@jonkeanejonkeane
mentioned this pull request
Jul 31, 2024

Closed

38 tasks
jonkeane pushed a commit
that referenced
this pull request
Jul 31, 2024
@amol-@kou@jonkeane
GH-43228: [C++] Fix Abseil compile error on GCC 13 (#43157)
cbd6b5c
### Rationale for this change
When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a `<cstdint>` include, this PR addresses the issue by adding the missing include.
There have been past reports for this issue too: #36969 This is a more minimal fix that tries to avoid the complexity of previous attempts like #43147 and #37066 which involved updating Abseil and facing additional issues to fix.
### What changes are included in this PR?
Add the missing include when GCC>=13
### Are these changes tested?
They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds.
### Are there any user-facing changes?
No, all behaviours should remain the same
* GitHub Issue: #43228
Lead-authored-by: Alessandro Molina <alessandro@molina.fyi>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@assignUserassignUserassignUser approved these changes
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@koukouAwaiting requested review from koukou is a code owner

Assignees


No one assigned


Labels

Component: C++Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@amol-@kou@raulcd@assignUser