GH-38209: [Docs] Reduce width of header items and keep header height default (small) on smaller screens by AlenkaF · Pull Request #38148 · apache/arrow

AlenkaF · 2023-10-09T08:27:28Z

Rationale for this change

The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the #36591 we have updated the code and are now using version 0.14.0 for the dev docs.

This PR fixes bugs we have encountered after the PR updating the theme has been merged.

What changes are included in this PR?

Have default header size for smaller screens and keep it increased for bigger screens.

Closes: [Docs] Reduce width of header items and keep header height default (small) on smaller screens #38209

jorisvandenbossche · 2023-10-09T08:53:32Z


+/* Change header hight to make the logo a bit larger */
+/* only on wider screens */
+@media only screen and (min-width: 950px){


How did you decide on the min width of 950? From doing a quick experiment with the "Responsive design mode" in Firefox, I already see it wraparound (causing a very large header) at a width of around 1380 px

Or this is only for the "mobile" layout? (where there is no header at all anymore, except for the logo and expand buttons)
I indeed suggested on the issue to do this in this case, but, we can maybe also already do it when you are on a normal but small screen, i.e. for the cases where all the header navbar items are visible, but start to wrap around because there is not enough space, like:

I am not sure this will help any as the version switcher and search buttons are already causing issues (see pydata/pydata-sphinx-theme#1493 (comment)), but am trying locally now to see.

Ok, setting the minimum width of the screen to have the bigger header height to 1380px gave me two layouts to compare as the limit for the double header is a bit higher:
just under 1380px and smaller header height:
just over 1380px and bigger header height:
I agree the smaller header size is better in this case also (double navbar), but the logo is too small to read it and that is not something I would keep.
I propose to have the bigger header height for 1400px but in the case of default header height I would use a different logo: Chevron-only logo

AlenkaF · 2023-10-11T09:35:47Z

@jorisvandenbossche I changed "Specifications and Protocol" to just "Specifications" and "Language implementations" to just "Implementations". Then the double header comes up at approx 1170px and that is when we default back to the smaller header size.

I would still change the logo to Chevron-only in the smaller header case as the current one is not readable on smaller screens.

jorisvandenbossche · 2023-10-11T10:30:54Z

I would still change the logo to Chevron-only in the smaller header case as the current one is not readable on smaller screens.

It's only the "Apache" part that is not readable, right? I agree it doesn't look great with the Apache not being readable, but on the other hand I think it is nice you still see "Arrow" .. (but I suppose having a logo with just Arrow without Apache will violate the rules of how the name should be used)

AlenkaF · 2023-10-11T10:42:07Z

It's only the "Apache" part that is not readable, right?

Yes, correct.

I agree it doesn't look great with the Apache not being readable, but on the other hand I think it is nice you still see "Arrow" .. (but I suppose having a logo with just Arrow without Apache will violate the rules of how the name should be used)

I do not think it is violating, Apache is still there, it is just very small and I think in that case using only chevron without Apache Arrow would be better. But I understand, Arrow will then not be there, which is a bummer.

No rush to change though. We can decide for 15.0.0 and have the header change included in 14.0.0.

github-actions · 2023-10-11T16:18:34Z

⚠️ GitHub issue #38209has been automatically assigned in GitHub to PR creator.

…default (small) on smaller screens (#38148) ### Rationale for this change The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the #36591 we have updated the code and are now using version 0.14.0 for the dev docs. This PR fixes bugs we have encountered after the PR updating the theme has been merged. ### What changes are included in this PR? - Have default header size for smaller screens and keep it increased for bigger screens. * Closes: #38209 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

conbench-apache-arrow · 2023-10-15T06:13:25Z

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 1cc0f14.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

…eight default (small) on smaller screens (apache#38148) ### Rationale for this change The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the apache#36591 we have updated the code and are now using version 0.14.0 for the dev docs. This PR fixes bugs we have encountered after the PR updating the theme has been merged. ### What changes are included in this PR? - Have default header size for smaller screens and keep it increased for bigger screens. * Closes: apache#38209 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

AlenkaF · 2023-10-09T08:27:28Z

Rationale for this change

The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the #36591 we have updated the code and are now using version 0.14.0 for the dev docs.

This PR fixes bugs we have encountered after the PR updating the theme has been merged.

What changes are included in this PR?

Have default header size for smaller screens and keep it increased for bigger screens.

Closes: [Docs] Reduce width of header items and keep header height default (small) on smaller screens #38209

jorisvandenbossche · 2023-10-09T08:53:32Z


+/* Change header hight to make the logo a bit larger */
+/* only on wider screens */
+@media only screen and (min-width: 950px){


How did you decide on the min width of 950? From doing a quick experiment with the "Responsive design mode" in Firefox, I already see it wraparound (causing a very large header) at a width of around 1380 px

Or this is only for the "mobile" layout? (where there is no header at all anymore, except for the logo and expand buttons)
I indeed suggested on the issue to do this in this case, but, we can maybe also already do it when you are on a normal but small screen, i.e. for the cases where all the header navbar items are visible, but start to wrap around because there is not enough space, like:

I am not sure this will help any as the version switcher and search buttons are already causing issues (see pydata/pydata-sphinx-theme#1493 (comment)), but am trying locally now to see.

Ok, setting the minimum width of the screen to have the bigger header height to 1380px gave me two layouts to compare as the limit for the double header is a bit higher:
just under 1380px and smaller header height:
just over 1380px and bigger header height:
I agree the smaller header size is better in this case also (double navbar), but the logo is too small to read it and that is not something I would keep.
I propose to have the bigger header height for 1400px but in the case of default header height I would use a different logo: Chevron-only logo

AlenkaF · 2023-10-11T09:35:47Z

@jorisvandenbossche I changed "Specifications and Protocol" to just "Specifications" and "Language implementations" to just "Implementations". Then the double header comes up at approx 1170px and that is when we default back to the smaller header size.

I would still change the logo to Chevron-only in the smaller header case as the current one is not readable on smaller screens.

jorisvandenbossche · 2023-10-11T10:30:54Z

I would still change the logo to Chevron-only in the smaller header case as the current one is not readable on smaller screens.

It's only the "Apache" part that is not readable, right? I agree it doesn't look great with the Apache not being readable, but on the other hand I think it is nice you still see "Arrow" .. (but I suppose having a logo with just Arrow without Apache will violate the rules of how the name should be used)

AlenkaF · 2023-10-11T10:42:07Z

It's only the "Apache" part that is not readable, right?

Yes, correct.

I agree it doesn't look great with the Apache not being readable, but on the other hand I think it is nice you still see "Arrow" .. (but I suppose having a logo with just Arrow without Apache will violate the rules of how the name should be used)

I do not think it is violating, Apache is still there, it is just very small and I think in that case using only chevron without Apache Arrow would be better. But I understand, Arrow will then not be there, which is a bummer.

No rush to change though. We can decide for 15.0.0 and have the header change included in 14.0.0.

github-actions · 2023-10-11T16:18:34Z

⚠️ GitHub issue #38209has been automatically assigned in GitHub to PR creator.

…default (small) on smaller screens (#38148) ### Rationale for this change The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the #36591 we have updated the code and are now using version 0.14.0 for the dev docs. This PR fixes bugs we have encountered after the PR updating the theme has been merged. ### What changes are included in this PR? - Have default header size for smaller screens and keep it increased for bigger screens. * Closes: #38209 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

conbench-apache-arrow · 2023-10-15T06:13:25Z

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 1cc0f14.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

…eight default (small) on smaller screens (apache#38148) ### Rationale for this change The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the apache#36591 we have updated the code and are now using version 0.14.0 for the dev docs. This PR fixes bugs we have encountered after the PR updating the theme has been merged. ### What changes are included in this PR? - Have default header size for smaller screens and keep it increased for bigger screens. * Closes: apache#38209 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

AlenkaF · 2023-10-09T08:27:28Z

Rationale for this change

The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the #36591 we have updated the code and are now using version 0.14.0 for the dev docs.

This PR fixes bugs we have encountered after the PR updating the theme has been merged.

What changes are included in this PR?

Have default header size for smaller screens and keep it increased for bigger screens.

Closes: [Docs] Reduce width of header items and keep header height default (small) on smaller screens #38209

jorisvandenbossche · 2023-10-09T08:53:32Z


+/* Change header hight to make the logo a bit larger */
+/* only on wider screens */
+@media only screen and (min-width: 950px){


How did you decide on the min width of 950? From doing a quick experiment with the "Responsive design mode" in Firefox, I already see it wraparound (causing a very large header) at a width of around 1380 px

Or this is only for the "mobile" layout? (where there is no header at all anymore, except for the logo and expand buttons)
I indeed suggested on the issue to do this in this case, but, we can maybe also already do it when you are on a normal but small screen, i.e. for the cases where all the header navbar items are visible, but start to wrap around because there is not enough space, like:

I am not sure this will help any as the version switcher and search buttons are already causing issues (see pydata/pydata-sphinx-theme#1493 (comment)), but am trying locally now to see.

Ok, setting the minimum width of the screen to have the bigger header height to 1380px gave me two layouts to compare as the limit for the double header is a bit higher:
just under 1380px and smaller header height:
just over 1380px and bigger header height:
I agree the smaller header size is better in this case also (double navbar), but the logo is too small to read it and that is not something I would keep.
I propose to have the bigger header height for 1400px but in the case of default header height I would use a different logo: Chevron-only logo

AlenkaF · 2023-10-11T09:35:47Z

@jorisvandenbossche I changed "Specifications and Protocol" to just "Specifications" and "Language implementations" to just "Implementations". Then the double header comes up at approx 1170px and that is when we default back to the smaller header size.

I would still change the logo to Chevron-only in the smaller header case as the current one is not readable on smaller screens.

jorisvandenbossche · 2023-10-11T10:30:54Z

I would still change the logo to Chevron-only in the smaller header case as the current one is not readable on smaller screens.

It's only the "Apache" part that is not readable, right? I agree it doesn't look great with the Apache not being readable, but on the other hand I think it is nice you still see "Arrow" .. (but I suppose having a logo with just Arrow without Apache will violate the rules of how the name should be used)

AlenkaF · 2023-10-11T10:42:07Z

It's only the "Apache" part that is not readable, right?

Yes, correct.

I agree it doesn't look great with the Apache not being readable, but on the other hand I think it is nice you still see "Arrow" .. (but I suppose having a logo with just Arrow without Apache will violate the rules of how the name should be used)

I do not think it is violating, Apache is still there, it is just very small and I think in that case using only chevron without Apache Arrow would be better. But I understand, Arrow will then not be there, which is a bummer.

No rush to change though. We can decide for 15.0.0 and have the header change included in 14.0.0.

github-actions · 2023-10-11T16:18:34Z

⚠️ GitHub issue #38209has been automatically assigned in GitHub to PR creator.

…default (small) on smaller screens (#38148) ### Rationale for this change The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the #36591 we have updated the code and are now using version 0.14.0 for the dev docs. This PR fixes bugs we have encountered after the PR updating the theme has been merged. ### What changes are included in this PR? - Have default header size for smaller screens and keep it increased for bigger screens. * Closes: #38209 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

conbench-apache-arrow · 2023-10-15T06:13:25Z

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 1cc0f14.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

…eight default (small) on smaller screens (apache#38148) ### Rationale for this change The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the apache#36591 we have updated the code and are now using version 0.14.0 for the dev docs. This PR fixes bugs we have encountered after the PR updating the theme has been merged. ### What changes are included in this PR? - Have default header size for smaller screens and keep it increased for bigger screens. * Closes: apache#38209 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

AlenkaF · 2023-10-09T08:27:28Z

Rationale for this change

The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the #36591 we have updated the code and are now using version 0.14.0 for the dev docs.

This PR fixes bugs we have encountered after the PR updating the theme has been merged.

What changes are included in this PR?

Have default header size for smaller screens and keep it increased for bigger screens.

Closes: [Docs] Reduce width of header items and keep header height default (small) on smaller screens #38209

jorisvandenbossche · 2023-10-09T08:53:32Z


+/* Change header hight to make the logo a bit larger */
+/* only on wider screens */
+@media only screen and (min-width: 950px){


How did you decide on the min width of 950? From doing a quick experiment with the "Responsive design mode" in Firefox, I already see it wraparound (causing a very large header) at a width of around 1380 px

Or this is only for the "mobile" layout? (where there is no header at all anymore, except for the logo and expand buttons)
I indeed suggested on the issue to do this in this case, but, we can maybe also already do it when you are on a normal but small screen, i.e. for the cases where all the header navbar items are visible, but start to wrap around because there is not enough space, like:

I am not sure this will help any as the version switcher and search buttons are already causing issues (see pydata/pydata-sphinx-theme#1493 (comment)), but am trying locally now to see.

Ok, setting the minimum width of the screen to have the bigger header height to 1380px gave me two layouts to compare as the limit for the double header is a bit higher:
just under 1380px and smaller header height:
just over 1380px and bigger header height:
I agree the smaller header size is better in this case also (double navbar), but the logo is too small to read it and that is not something I would keep.
I propose to have the bigger header height for 1400px but in the case of default header height I would use a different logo: Chevron-only logo

AlenkaF · 2023-10-11T09:35:47Z

@jorisvandenbossche I changed "Specifications and Protocol" to just "Specifications" and "Language implementations" to just "Implementations". Then the double header comes up at approx 1170px and that is when we default back to the smaller header size.

I would still change the logo to Chevron-only in the smaller header case as the current one is not readable on smaller screens.

jorisvandenbossche · 2023-10-11T10:30:54Z

I would still change the logo to Chevron-only in the smaller header case as the current one is not readable on smaller screens.

It's only the "Apache" part that is not readable, right? I agree it doesn't look great with the Apache not being readable, but on the other hand I think it is nice you still see "Arrow" .. (but I suppose having a logo with just Arrow without Apache will violate the rules of how the name should be used)

AlenkaF · 2023-10-11T10:42:07Z

It's only the "Apache" part that is not readable, right?

Yes, correct.

I agree it doesn't look great with the Apache not being readable, but on the other hand I think it is nice you still see "Arrow" .. (but I suppose having a logo with just Arrow without Apache will violate the rules of how the name should be used)

I do not think it is violating, Apache is still there, it is just very small and I think in that case using only chevron without Apache Arrow would be better. But I understand, Arrow will then not be there, which is a bummer.

No rush to change though. We can decide for 15.0.0 and have the header change included in 14.0.0.

github-actions · 2023-10-11T16:18:34Z

⚠️ GitHub issue #38209has been automatically assigned in GitHub to PR creator.

…default (small) on smaller screens (#38148) ### Rationale for this change The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the #36591 we have updated the code and are now using version 0.14.0 for the dev docs. This PR fixes bugs we have encountered after the PR updating the theme has been merged. ### What changes are included in this PR? - Have default header size for smaller screens and keep it increased for bigger screens. * Closes: #38209 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

conbench-apache-arrow · 2023-10-15T06:13:25Z

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 1cc0f14.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

…eight default (small) on smaller screens (apache#38148) ### Rationale for this change The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the apache#36591 we have updated the code and are now using version 0.14.0 for the dev docs. This PR fixes bugs we have encountered after the PR updating the theme has been merged. ### What changes are included in this PR? - Have default header size for smaller screens and keep it increased for bigger screens. * Closes: apache#38209 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

AlenkaF · 2023-10-09T08:27:28Z

Rationale for this change

The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the #36591 we have updated the code and are now using version 0.14.0 for the dev docs.

This PR fixes bugs we have encountered after the PR updating the theme has been merged.

What changes are included in this PR?

Have default header size for smaller screens and keep it increased for bigger screens.

Closes: [Docs] Reduce width of header items and keep header height default (small) on smaller screens #38209

jorisvandenbossche · 2023-10-09T08:53:32Z


+/* Change header hight to make the logo a bit larger */
+/* only on wider screens */
+@media only screen and (min-width: 950px){


How did you decide on the min width of 950? From doing a quick experiment with the "Responsive design mode" in Firefox, I already see it wraparound (causing a very large header) at a width of around 1380 px

Or this is only for the "mobile" layout? (where there is no header at all anymore, except for the logo and expand buttons)
I indeed suggested on the issue to do this in this case, but, we can maybe also already do it when you are on a normal but small screen, i.e. for the cases where all the header navbar items are visible, but start to wrap around because there is not enough space, like:

I am not sure this will help any as the version switcher and search buttons are already causing issues (see pydata/pydata-sphinx-theme#1493 (comment)), but am trying locally now to see.

Ok, setting the minimum width of the screen to have the bigger header height to 1380px gave me two layouts to compare as the limit for the double header is a bit higher:
just under 1380px and smaller header height:
just over 1380px and bigger header height:
I agree the smaller header size is better in this case also (double navbar), but the logo is too small to read it and that is not something I would keep.
I propose to have the bigger header height for 1400px but in the case of default header height I would use a different logo: Chevron-only logo

AlenkaF · 2023-10-11T09:35:47Z

@jorisvandenbossche I changed "Specifications and Protocol" to just "Specifications" and "Language implementations" to just "Implementations". Then the double header comes up at approx 1170px and that is when we default back to the smaller header size.

I would still change the logo to Chevron-only in the smaller header case as the current one is not readable on smaller screens.

jorisvandenbossche · 2023-10-11T10:30:54Z

I would still change the logo to Chevron-only in the smaller header case as the current one is not readable on smaller screens.

It's only the "Apache" part that is not readable, right? I agree it doesn't look great with the Apache not being readable, but on the other hand I think it is nice you still see "Arrow" .. (but I suppose having a logo with just Arrow without Apache will violate the rules of how the name should be used)

AlenkaF · 2023-10-11T10:42:07Z

It's only the "Apache" part that is not readable, right?

Yes, correct.

I agree it doesn't look great with the Apache not being readable, but on the other hand I think it is nice you still see "Arrow" .. (but I suppose having a logo with just Arrow without Apache will violate the rules of how the name should be used)

I do not think it is violating, Apache is still there, it is just very small and I think in that case using only chevron without Apache Arrow would be better. But I understand, Arrow will then not be there, which is a bummer.

No rush to change though. We can decide for 15.0.0 and have the header change included in 14.0.0.

github-actions · 2023-10-11T16:18:34Z

⚠️ GitHub issue #38209has been automatically assigned in GitHub to PR creator.

…default (small) on smaller screens (#38148) ### Rationale for this change The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the #36591 we have updated the code and are now using version 0.14.0 for the dev docs. This PR fixes bugs we have encountered after the PR updating the theme has been merged. ### What changes are included in this PR? - Have default header size for smaller screens and keep it increased for bigger screens. * Closes: #38209 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

conbench-apache-arrow · 2023-10-15T06:13:25Z

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 1cc0f14.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

…eight default (small) on smaller screens (apache#38148) ### Rationale for this change The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the apache#36591 we have updated the code and are now using version 0.14.0 for the dev docs. This PR fixes bugs we have encountered after the PR updating the theme has been merged. ### What changes are included in this PR? - Have default header size for smaller screens and keep it increased for bigger screens. * Closes: apache#38209 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

AlenkaF · 2023-10-09T08:27:28Z

Rationale for this change

The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the #36591 we have updated the code and are now using version 0.14.0 for the dev docs.

This PR fixes bugs we have encountered after the PR updating the theme has been merged.

What changes are included in this PR?

Have default header size for smaller screens and keep it increased for bigger screens.

Closes: [Docs] Reduce width of header items and keep header height default (small) on smaller screens #38209

jorisvandenbossche · 2023-10-09T08:53:32Z


+/* Change header hight to make the logo a bit larger */
+/* only on wider screens */
+@media only screen and (min-width: 950px){


How did you decide on the min width of 950? From doing a quick experiment with the "Responsive design mode" in Firefox, I already see it wraparound (causing a very large header) at a width of around 1380 px

Or this is only for the "mobile" layout? (where there is no header at all anymore, except for the logo and expand buttons)
I indeed suggested on the issue to do this in this case, but, we can maybe also already do it when you are on a normal but small screen, i.e. for the cases where all the header navbar items are visible, but start to wrap around because there is not enough space, like:

I am not sure this will help any as the version switcher and search buttons are already causing issues (see pydata/pydata-sphinx-theme#1493 (comment)), but am trying locally now to see.

Ok, setting the minimum width of the screen to have the bigger header height to 1380px gave me two layouts to compare as the limit for the double header is a bit higher:
just under 1380px and smaller header height:
just over 1380px and bigger header height:
I agree the smaller header size is better in this case also (double navbar), but the logo is too small to read it and that is not something I would keep.
I propose to have the bigger header height for 1400px but in the case of default header height I would use a different logo: Chevron-only logo

AlenkaF · 2023-10-11T09:35:47Z

@jorisvandenbossche I changed "Specifications and Protocol" to just "Specifications" and "Language implementations" to just "Implementations". Then the double header comes up at approx 1170px and that is when we default back to the smaller header size.

I would still change the logo to Chevron-only in the smaller header case as the current one is not readable on smaller screens.

jorisvandenbossche · 2023-10-11T10:30:54Z

I would still change the logo to Chevron-only in the smaller header case as the current one is not readable on smaller screens.

It's only the "Apache" part that is not readable, right? I agree it doesn't look great with the Apache not being readable, but on the other hand I think it is nice you still see "Arrow" .. (but I suppose having a logo with just Arrow without Apache will violate the rules of how the name should be used)

AlenkaF · 2023-10-11T10:42:07Z

It's only the "Apache" part that is not readable, right?

Yes, correct.

I agree it doesn't look great with the Apache not being readable, but on the other hand I think it is nice you still see "Arrow" .. (but I suppose having a logo with just Arrow without Apache will violate the rules of how the name should be used)

I do not think it is violating, Apache is still there, it is just very small and I think in that case using only chevron without Apache Arrow would be better. But I understand, Arrow will then not be there, which is a bummer.

No rush to change though. We can decide for 15.0.0 and have the header change included in 14.0.0.

github-actions · 2023-10-11T16:18:34Z

⚠️ GitHub issue #38209has been automatically assigned in GitHub to PR creator.

…default (small) on smaller screens (#38148) ### Rationale for this change The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the #36591 we have updated the code and are now using version 0.14.0 for the dev docs. This PR fixes bugs we have encountered after the PR updating the theme has been merged. ### What changes are included in this PR? - Have default header size for smaller screens and keep it increased for bigger screens. * Closes: #38209 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

conbench-apache-arrow · 2023-10-15T06:13:25Z

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 1cc0f14.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

…eight default (small) on smaller screens (apache#38148) ### Rationale for this change The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the apache#36591 we have updated the code and are now using version 0.14.0 for the dev docs. This PR fixes bugs we have encountered after the PR updating the theme has been merged. ### What changes are included in this PR? - Have default header size for smaller screens and keep it increased for bigger screens. * Closes: apache#38209 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

AlenkaF · 2023-10-09T08:27:28Z

Rationale for this change

The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the #36591 we have updated the code and are now using version 0.14.0 for the dev docs.

This PR fixes bugs we have encountered after the PR updating the theme has been merged.

What changes are included in this PR?

Have default header size for smaller screens and keep it increased for bigger screens.

Closes: [Docs] Reduce width of header items and keep header height default (small) on smaller screens #38209

jorisvandenbossche · 2023-10-09T08:53:32Z


+/* Change header hight to make the logo a bit larger */
+/* only on wider screens */
+@media only screen and (min-width: 950px){


How did you decide on the min width of 950? From doing a quick experiment with the "Responsive design mode" in Firefox, I already see it wraparound (causing a very large header) at a width of around 1380 px

Or this is only for the "mobile" layout? (where there is no header at all anymore, except for the logo and expand buttons)
I indeed suggested on the issue to do this in this case, but, we can maybe also already do it when you are on a normal but small screen, i.e. for the cases where all the header navbar items are visible, but start to wrap around because there is not enough space, like:

I am not sure this will help any as the version switcher and search buttons are already causing issues (see pydata/pydata-sphinx-theme#1493 (comment)), but am trying locally now to see.

Ok, setting the minimum width of the screen to have the bigger header height to 1380px gave me two layouts to compare as the limit for the double header is a bit higher:
just under 1380px and smaller header height:
just over 1380px and bigger header height:
I agree the smaller header size is better in this case also (double navbar), but the logo is too small to read it and that is not something I would keep.
I propose to have the bigger header height for 1400px but in the case of default header height I would use a different logo: Chevron-only logo

AlenkaF · 2023-10-11T09:35:47Z

@jorisvandenbossche I changed "Specifications and Protocol" to just "Specifications" and "Language implementations" to just "Implementations". Then the double header comes up at approx 1170px and that is when we default back to the smaller header size.

I would still change the logo to Chevron-only in the smaller header case as the current one is not readable on smaller screens.

jorisvandenbossche · 2023-10-11T10:30:54Z

I would still change the logo to Chevron-only in the smaller header case as the current one is not readable on smaller screens.

It's only the "Apache" part that is not readable, right? I agree it doesn't look great with the Apache not being readable, but on the other hand I think it is nice you still see "Arrow" .. (but I suppose having a logo with just Arrow without Apache will violate the rules of how the name should be used)

AlenkaF · 2023-10-11T10:42:07Z

It's only the "Apache" part that is not readable, right?

Yes, correct.

I agree it doesn't look great with the Apache not being readable, but on the other hand I think it is nice you still see "Arrow" .. (but I suppose having a logo with just Arrow without Apache will violate the rules of how the name should be used)

I do not think it is violating, Apache is still there, it is just very small and I think in that case using only chevron without Apache Arrow would be better. But I understand, Arrow will then not be there, which is a bummer.

No rush to change though. We can decide for 15.0.0 and have the header change included in 14.0.0.

github-actions · 2023-10-11T16:18:34Z

⚠️ GitHub issue #38209has been automatically assigned in GitHub to PR creator.

…default (small) on smaller screens (#38148) ### Rationale for this change The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the #36591 we have updated the code and are now using version 0.14.0 for the dev docs. This PR fixes bugs we have encountered after the PR updating the theme has been merged. ### What changes are included in this PR? - Have default header size for smaller screens and keep it increased for bigger screens. * Closes: #38209 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

conbench-apache-arrow · 2023-10-15T06:13:25Z

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 1cc0f14.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

…eight default (small) on smaller screens (apache#38148) ### Rationale for this change The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the apache#36591 we have updated the code and are now using version 0.14.0 for the dev docs. This PR fixes bugs we have encountered after the PR updating the theme has been merged. ### What changes are included in this PR? - Have default header size for smaller screens and keep it increased for bigger screens. * Closes: apache#38209 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

AlenkaF · 2023-10-09T08:27:28Z

Rationale for this change

The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the #36591 we have updated the code and are now using version 0.14.0 for the dev docs.

This PR fixes bugs we have encountered after the PR updating the theme has been merged.

What changes are included in this PR?

Have default header size for smaller screens and keep it increased for bigger screens.

Closes: [Docs] Reduce width of header items and keep header height default (small) on smaller screens #38209

jorisvandenbossche · 2023-10-09T08:53:32Z


+/* Change header hight to make the logo a bit larger */
+/* only on wider screens */
+@media only screen and (min-width: 950px){


How did you decide on the min width of 950? From doing a quick experiment with the "Responsive design mode" in Firefox, I already see it wraparound (causing a very large header) at a width of around 1380 px

Or this is only for the "mobile" layout? (where there is no header at all anymore, except for the logo and expand buttons)
I indeed suggested on the issue to do this in this case, but, we can maybe also already do it when you are on a normal but small screen, i.e. for the cases where all the header navbar items are visible, but start to wrap around because there is not enough space, like:

I am not sure this will help any as the version switcher and search buttons are already causing issues (see pydata/pydata-sphinx-theme#1493 (comment)), but am trying locally now to see.

Ok, setting the minimum width of the screen to have the bigger header height to 1380px gave me two layouts to compare as the limit for the double header is a bit higher:
just under 1380px and smaller header height:
just over 1380px and bigger header height:
I agree the smaller header size is better in this case also (double navbar), but the logo is too small to read it and that is not something I would keep.
I propose to have the bigger header height for 1400px but in the case of default header height I would use a different logo: Chevron-only logo

AlenkaF · 2023-10-11T09:35:47Z

@jorisvandenbossche I changed "Specifications and Protocol" to just "Specifications" and "Language implementations" to just "Implementations". Then the double header comes up at approx 1170px and that is when we default back to the smaller header size.

I would still change the logo to Chevron-only in the smaller header case as the current one is not readable on smaller screens.

jorisvandenbossche · 2023-10-11T10:30:54Z

I would still change the logo to Chevron-only in the smaller header case as the current one is not readable on smaller screens.

It's only the "Apache" part that is not readable, right? I agree it doesn't look great with the Apache not being readable, but on the other hand I think it is nice you still see "Arrow" .. (but I suppose having a logo with just Arrow without Apache will violate the rules of how the name should be used)

AlenkaF · 2023-10-11T10:42:07Z

It's only the "Apache" part that is not readable, right?

Yes, correct.

I agree it doesn't look great with the Apache not being readable, but on the other hand I think it is nice you still see "Arrow" .. (but I suppose having a logo with just Arrow without Apache will violate the rules of how the name should be used)

I do not think it is violating, Apache is still there, it is just very small and I think in that case using only chevron without Apache Arrow would be better. But I understand, Arrow will then not be there, which is a bummer.

No rush to change though. We can decide for 15.0.0 and have the header change included in 14.0.0.

github-actions · 2023-10-11T16:18:34Z

⚠️ GitHub issue #38209has been automatically assigned in GitHub to PR creator.

…default (small) on smaller screens (#38148) ### Rationale for this change The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the #36591 we have updated the code and are now using version 0.14.0 for the dev docs. This PR fixes bugs we have encountered after the PR updating the theme has been merged. ### What changes are included in this PR? - Have default header size for smaller screens and keep it increased for bigger screens. * Closes: #38209 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

conbench-apache-arrow · 2023-10-15T06:13:25Z

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 1cc0f14.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

…eight default (small) on smaller screens (apache#38148) ### Rationale for this change The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the apache#36591 we have updated the code and are now using version 0.14.0 for the dev docs. This PR fixes bugs we have encountered after the PR updating the theme has been merged. ### What changes are included in this PR? - Have default header size for smaller screens and keep it increased for bigger screens. * Closes: apache#38209 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

Make logo smaller on small screens
91d6d99

github-actionsBot added Component: Documentation awaiting review Awaiting review labels Oct 9, 2023

AlenkaF mentioned this pull request Oct 9, 2023
[Docs] New PyData Sphinx theme update bugs #37947
Closed
2 tasks

jorisvandenbossche reviewed Oct 9, 2023
View reviewed changes

github-actionsBot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Oct 9, 2023

Change navbar text and header hight limit
d721f11

github-actionsBot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Oct 11, 2023

AlenkaF marked this pull request as ready for review October 11, 2023 10:16

jorisvandenbossche changed the title ~~GH-37947:[Docs] Keep header size default (small) on smaller screens~~GH-37947: [Docs] Reduce width of header items and keep header height default (small) on smaller screensOct 11, 2023

jorisvandenbossche changed the title ~~GH-37947: [Docs] Reduce width of header items and keep header height default (small) on smaller screens~~GH-38209: [Docs] Reduce width of header items and keep header height default (small) on smaller screensOct 11, 2023

jorisvandenbossche merged commit 1cc0f14 into apache:mainOct 11, 2023

jorisvandenbossche removed the awaiting change review Awaiting change review label Oct 11, 2023

AlenkaF deleted the gh-37947-new-theme-bug-fix branch December 13, 2023 14:12

ianmcook mentioned this pull request Jan 13, 2025
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems #45228
Merged