Skip to content

GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems - #45228

Merged
ianmcook merged 8 commits into
apache:mainfrom
ianmcook:linkedin
Jan 13, 2025
Merged

GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems#45228
ianmcook merged 8 commits into
apache:mainfrom
ianmcook:linkedin

Conversation

@ianmcook

@ianmcookianmcook commented Jan 11, 2025•
edited
Loading

Copy link
Copy Markdown
Member

This adds a LinkedIn icon social link to the main docs pages. This follows the creation of a Linkedin page for the project in mid-2024, the active use of that page since then, and the addition of a LinkedIn follow button to the website homepage earlier this month.

This also fixes the layout of the top nav, which previously looked bad at widths between 960px and 1200px.

@ianmcook
ianmcook marked this pull request as draft January 11, 2025 20:11
@ianmcookianmcook changed the title MINOR: [Docs] Add LinkedIn social linkGH-45230: [Docs] Add LinkedIn social linkJan 11, 2025
@ianmcookianmcook changed the title GH-45230: [Docs] Add LinkedIn social linkGH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problemsJan 11, 2025
@apacheapache deleted a comment from github-actionsBotJan 11, 2025
@ianmcook
ianmcook marked this pull request as ready for review January 11, 2025 22:18
@apacheapache deleted a comment from github-actionsBotJan 11, 2025
ianmcook
ianmcook commented Jan 11, 2025
View reviewed changes
Comment threaddocs/source/_static/theme_overrides.css Outdated
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jan 11, 2025
@apacheapache deleted a comment from github-actionsBotJan 11, 2025
@github-actionsgithub-actionsBot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 11, 2025
@apacheapache deleted a comment from github-actionsBotJan 11, 2025
@ianmcook
ianmcook requested a review from AlenkaFJanuary 11, 2025 23:28
@apacheapache deleted a comment from github-actionsBotJan 12, 2025
@ianmcook

ianmcook commented Jan 12, 2025

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit preview-docs

@github-actions

github-actionsBot commented Jan 12, 2025

Copy link
Copy Markdown

Revision: 1625b92

Submitted crossbow builds: ursacomputing/crossbow @ actions-3f63c22984

TaskStatus
preview-docsGitHub Actions

@ianmcook

ianmcook commented Jan 12, 2025

Copy link
Copy Markdown
MemberAuthor

Preview: http://crossbow.voltrondata.com/pr_docs/45228

kou
kou reviewed Jan 12, 2025
View reviewed changes
Comment threaddocs/source/_static/theme_overrides.css Outdated
Comment threaddocs/source/_static/theme_overrides.css Outdated
kou
kou approved these changes Jan 12, 2025
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jan 12, 2025
@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting changes Awaiting changes labels Jan 12, 2025
@ianmcook

ianmcook commented Jan 12, 2025

Copy link
Copy Markdown
MemberAuthor

I tested on Windows. The font-stretch property did not apply to the Segoe UI font. So I switched to using letter-spacing to condense the nav text, which works across platforms.

@ianmcook

ianmcook commented Jan 12, 2025

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit preview-docs

@github-actions

github-actionsBot commented Jan 12, 2025

Copy link
Copy Markdown

Revision: cb30167

Submitted crossbow builds: ursacomputing/crossbow @ actions-3bcb2181c1

TaskStatus
preview-docsGitHub Actions

@ianmcook

ianmcook commented Jan 13, 2025

Copy link
Copy Markdown
MemberAuthor

@AlenkaF since you worked on some similar issues in #38148, you might want to take a look at this, thanks!

@ianmcookianmcook mentioned this pull request Jan 13, 2025
Closed
AlenkaF
AlenkaF approved these changes Jan 13, 2025
View reviewed changes

@AlenkaFAlenkaF left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top nav behaves much, much better now, thanks!

@ianmcook
ianmcook merged commit 1f63646 into apache:mainJan 13, 2025
@ianmcook
ianmcook deleted the linkedin branch January 13, 2025 14:24
@conbench-apache-arrow

conbench-apache-arrowBot commented Jan 16, 2025

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1f63646.

There were 7 benchmark results indicating a performance regression:

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

@ianmcookianmcook mentioned this pull request Jan 23, 2025
Closed
amoeba pushed a commit that referenced this pull request Jan 31, 2025
@ianmcook@amoeba
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling pro…
b3b3b29
…blems (#45228)
This adds a LinkedIn icon social link to the main docs pages and fixes the layout of the top nav, which previously looked bad
at widths between 960px and 1200px.
* GitHub Issue: #45230
amoeba pushed a commit that referenced this pull request Jan 31, 2025
@ianmcook@amoeba
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling pro…
16a0408
…blems (#45228)
This adds a LinkedIn icon social link to the main docs pages and fixes the layout of the top nav, which previously looked bad
at widths between 960px and 1200px.
* GitHub Issue: #45230
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou approved these changes
@AlenkaFAlenkaFAlenkaF approved these changes

Assignees

No one assigned

Labels

awaiting mergeAwaiting mergeComponent: Documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ianmcook@kou@AlenkaF
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems by ianmcook · Pull Request #45228 · apache/arrow · GitHub
Skip to content
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems - #45228
Merged
ianmcook merged 8 commits into
apache:mainfrom 
ianmcook:linkedin
Jan 13, 2025
Merged
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems#45228
ianmcook merged 8 commits into
apache:mainfrom 
ianmcook:linkedin
Conversation
@ianmcook
@ianmcookianmcook
commented
Jan 11, 2025•

edited

Loading

Copy link


Copy Markdown

Member
This adds a LinkedIn icon social link to the main docs pages. This follows the creation of a Linkedin page for the project in mid-2024, the active use of that page since then, and the addition of a LinkedIn follow button to the website homepage earlier this month.
This also fixes the layout of the top nav, which previously looked bad at widths between 960px and 1200px.
@ianmcook
ianmcook
marked this pull request as draft
January 11, 2025 20:11
@ianmcookianmcook
changed the title
MINOR: [Docs] Add LinkedIn social linkGH-45230: [Docs] Add LinkedIn social linkJan 11, 2025
@ianmcookianmcook
changed the title
GH-45230: [Docs] Add LinkedIn social linkGH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problemsJan 11, 2025
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
@ianmcook
ianmcook
marked this pull request as ready for review
January 11, 2025 22:18
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
ianmcook
ianmcook
commented
Jan 11, 2025
View reviewed changes
Comment threaddocs/source/_static/theme_overrides.css
Outdated

@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting committer review
Awaiting committer review
labels
Jan 11, 2025
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Jan 11, 2025
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
@ianmcook
ianmcook
requested a review
from AlenkaFJanuary 11, 2025 23:28
@apacheapache
deleted a comment from github-actionsBotJan 12, 2025
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit preview-docs
@github-actions
github-actionsBot
commented
Jan 12, 2025

Copy link


Copy Markdown

Revision: 1625b92
Submitted crossbow builds: ursacomputing/crossbow @ actions-3f63c22984
TaskStatus
preview-docsGitHub Actions
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
Preview: http://crossbow.voltrondata.com/pr_docs/45228
kou
kou
reviewed
Jan 12, 2025
View reviewed changes
Comment threaddocs/source/_static/theme_overrides.css
Outdated

Comment threaddocs/source/_static/theme_overrides.css
Outdated

kou
kou
approved these changes
Jan 12, 2025
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Jan 12, 2025
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting changes
Awaiting changes
labels
Jan 12, 2025
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
I tested on Windows. The font-stretch property did not apply to the Segoe UI font. So I switched to using letter-spacing to condense the nav text, which works across platforms.
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit preview-docs
@github-actions
github-actionsBot
commented
Jan 12, 2025

Copy link


Copy Markdown

Revision: cb30167
Submitted crossbow builds: ursacomputing/crossbow @ actions-3bcb2181c1
TaskStatus
preview-docsGitHub Actions
@ianmcook
ianmcook
commented
Jan 13, 2025

Copy link


Copy Markdown

MemberAuthor
@AlenkaF since you worked on some similar issues in #38148, you might want to take a look at this, thanks!
@ianmcookianmcook
mentioned this pull request
Jan 13, 2025

Closed

AlenkaF
AlenkaF
approved these changes
Jan 13, 2025
View reviewed changes
@AlenkaFAlenkaF
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top nav behaves much, much better now, thanks!
@ianmcook
ianmcook
merged commit 1f63646
into
apache:mainJan 13, 2025
@ianmcook
ianmcook
deleted the

linkedin

branch
January 13, 2025 14:24
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Jan 16, 2025

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1f63646.
There were 7 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
@ianmcookianmcook
mentioned this pull request
Jan 23, 2025

Closed

amoeba pushed a commit
that referenced
this pull request
Jan 31, 2025
@ianmcook@amoeba
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling pro…
b3b3b29
…blems (#45228)
This adds a LinkedIn icon social link to the main docs pages and fixes the layout of the top nav, which previously looked bad
at widths between 960px and 1200px.
* GitHub Issue: #45230
amoeba pushed a commit
that referenced
this pull request
Jan 31, 2025
@ianmcook@amoeba
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling pro…
16a0408
…blems (#45228)
This adds a LinkedIn icon social link to the main docs pages and fixes the layout of the top nav, which previously looked bad
at widths between 960px and 1200px.
* GitHub Issue: #45230
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@AlenkaFAlenkaFAlenkaF approved these changes

Assignees


No one assigned


Labels

awaiting mergeAwaiting mergeComponent: Documentation

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ianmcook@kou@AlenkaF

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems by ianmcook · Pull Request #45228 · apache/arrow · GitHub
Skip to content
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems - #45228
Merged
ianmcook merged 8 commits into
apache:mainfrom 
ianmcook:linkedin
Jan 13, 2025
Merged
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems#45228
ianmcook merged 8 commits into
apache:mainfrom 
ianmcook:linkedin
Conversation
@ianmcook
@ianmcookianmcook
commented
Jan 11, 2025•

edited

Loading

Copy link


Copy Markdown

Member
This adds a LinkedIn icon social link to the main docs pages. This follows the creation of a Linkedin page for the project in mid-2024, the active use of that page since then, and the addition of a LinkedIn follow button to the website homepage earlier this month.
This also fixes the layout of the top nav, which previously looked bad at widths between 960px and 1200px.
@ianmcook
ianmcook
marked this pull request as draft
January 11, 2025 20:11
@ianmcookianmcook
changed the title
MINOR: [Docs] Add LinkedIn social linkGH-45230: [Docs] Add LinkedIn social linkJan 11, 2025
@ianmcookianmcook
changed the title
GH-45230: [Docs] Add LinkedIn social linkGH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problemsJan 11, 2025
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
@ianmcook
ianmcook
marked this pull request as ready for review
January 11, 2025 22:18
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
ianmcook
ianmcook
commented
Jan 11, 2025
View reviewed changes
Comment threaddocs/source/_static/theme_overrides.css
Outdated

@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting committer review
Awaiting committer review
labels
Jan 11, 2025
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Jan 11, 2025
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
@ianmcook
ianmcook
requested a review
from AlenkaFJanuary 11, 2025 23:28
@apacheapache
deleted a comment from github-actionsBotJan 12, 2025
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit preview-docs
@github-actions
github-actionsBot
commented
Jan 12, 2025

Copy link


Copy Markdown

Revision: 1625b92
Submitted crossbow builds: ursacomputing/crossbow @ actions-3f63c22984
TaskStatus
preview-docsGitHub Actions
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
Preview: http://crossbow.voltrondata.com/pr_docs/45228
kou
kou
reviewed
Jan 12, 2025
View reviewed changes
Comment threaddocs/source/_static/theme_overrides.css
Outdated

Comment threaddocs/source/_static/theme_overrides.css
Outdated

kou
kou
approved these changes
Jan 12, 2025
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Jan 12, 2025
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting changes
Awaiting changes
labels
Jan 12, 2025
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
I tested on Windows. The font-stretch property did not apply to the Segoe UI font. So I switched to using letter-spacing to condense the nav text, which works across platforms.
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit preview-docs
@github-actions
github-actionsBot
commented
Jan 12, 2025

Copy link


Copy Markdown

Revision: cb30167
Submitted crossbow builds: ursacomputing/crossbow @ actions-3bcb2181c1
TaskStatus
preview-docsGitHub Actions
@ianmcook
ianmcook
commented
Jan 13, 2025

Copy link


Copy Markdown

MemberAuthor
@AlenkaF since you worked on some similar issues in #38148, you might want to take a look at this, thanks!
@ianmcookianmcook
mentioned this pull request
Jan 13, 2025

Closed

AlenkaF
AlenkaF
approved these changes
Jan 13, 2025
View reviewed changes
@AlenkaFAlenkaF
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top nav behaves much, much better now, thanks!
@ianmcook
ianmcook
merged commit 1f63646
into
apache:mainJan 13, 2025
@ianmcook
ianmcook
deleted the

linkedin

branch
January 13, 2025 14:24
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Jan 16, 2025

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1f63646.
There were 7 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
@ianmcookianmcook
mentioned this pull request
Jan 23, 2025

Closed

amoeba pushed a commit
that referenced
this pull request
Jan 31, 2025
@ianmcook@amoeba
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling pro…
b3b3b29
…blems (#45228)
This adds a LinkedIn icon social link to the main docs pages and fixes the layout of the top nav, which previously looked bad
at widths between 960px and 1200px.
* GitHub Issue: #45230
amoeba pushed a commit
that referenced
this pull request
Jan 31, 2025
@ianmcook@amoeba
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling pro…
16a0408
…blems (#45228)
This adds a LinkedIn icon social link to the main docs pages and fixes the layout of the top nav, which previously looked bad
at widths between 960px and 1200px.
* GitHub Issue: #45230
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@AlenkaFAlenkaFAlenkaF approved these changes

Assignees


No one assigned


Labels

awaiting mergeAwaiting mergeComponent: Documentation

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ianmcook@kou@AlenkaF

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems by ianmcook · Pull Request #45228 · apache/arrow · GitHub
Skip to content
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems - #45228
Merged
ianmcook merged 8 commits into
apache:mainfrom 
ianmcook:linkedin
Jan 13, 2025
Merged
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems#45228
ianmcook merged 8 commits into
apache:mainfrom 
ianmcook:linkedin
Conversation
@ianmcook
@ianmcookianmcook
commented
Jan 11, 2025•

edited

Loading

Copy link


Copy Markdown

Member
This adds a LinkedIn icon social link to the main docs pages. This follows the creation of a Linkedin page for the project in mid-2024, the active use of that page since then, and the addition of a LinkedIn follow button to the website homepage earlier this month.
This also fixes the layout of the top nav, which previously looked bad at widths between 960px and 1200px.
@ianmcook
ianmcook
marked this pull request as draft
January 11, 2025 20:11
@ianmcookianmcook
changed the title
MINOR: [Docs] Add LinkedIn social linkGH-45230: [Docs] Add LinkedIn social linkJan 11, 2025
@ianmcookianmcook
changed the title
GH-45230: [Docs] Add LinkedIn social linkGH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problemsJan 11, 2025
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
@ianmcook
ianmcook
marked this pull request as ready for review
January 11, 2025 22:18
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
ianmcook
ianmcook
commented
Jan 11, 2025
View reviewed changes
Comment threaddocs/source/_static/theme_overrides.css
Outdated

@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting committer review
Awaiting committer review
labels
Jan 11, 2025
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Jan 11, 2025
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
@ianmcook
ianmcook
requested a review
from AlenkaFJanuary 11, 2025 23:28
@apacheapache
deleted a comment from github-actionsBotJan 12, 2025
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit preview-docs
@github-actions
github-actionsBot
commented
Jan 12, 2025

Copy link


Copy Markdown

Revision: 1625b92
Submitted crossbow builds: ursacomputing/crossbow @ actions-3f63c22984
TaskStatus
preview-docsGitHub Actions
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
Preview: http://crossbow.voltrondata.com/pr_docs/45228
kou
kou
reviewed
Jan 12, 2025
View reviewed changes
Comment threaddocs/source/_static/theme_overrides.css
Outdated

Comment threaddocs/source/_static/theme_overrides.css
Outdated

kou
kou
approved these changes
Jan 12, 2025
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Jan 12, 2025
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting changes
Awaiting changes
labels
Jan 12, 2025
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
I tested on Windows. The font-stretch property did not apply to the Segoe UI font. So I switched to using letter-spacing to condense the nav text, which works across platforms.
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit preview-docs
@github-actions
github-actionsBot
commented
Jan 12, 2025

Copy link


Copy Markdown

Revision: cb30167
Submitted crossbow builds: ursacomputing/crossbow @ actions-3bcb2181c1
TaskStatus
preview-docsGitHub Actions
@ianmcook
ianmcook
commented
Jan 13, 2025

Copy link


Copy Markdown

MemberAuthor
@AlenkaF since you worked on some similar issues in #38148, you might want to take a look at this, thanks!
@ianmcookianmcook
mentioned this pull request
Jan 13, 2025

Closed

AlenkaF
AlenkaF
approved these changes
Jan 13, 2025
View reviewed changes
@AlenkaFAlenkaF
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top nav behaves much, much better now, thanks!
@ianmcook
ianmcook
merged commit 1f63646
into
apache:mainJan 13, 2025
@ianmcook
ianmcook
deleted the

linkedin

branch
January 13, 2025 14:24
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Jan 16, 2025

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1f63646.
There were 7 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
@ianmcookianmcook
mentioned this pull request
Jan 23, 2025

Closed

amoeba pushed a commit
that referenced
this pull request
Jan 31, 2025
@ianmcook@amoeba
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling pro…
b3b3b29
…blems (#45228)
This adds a LinkedIn icon social link to the main docs pages and fixes the layout of the top nav, which previously looked bad
at widths between 960px and 1200px.
* GitHub Issue: #45230
amoeba pushed a commit
that referenced
this pull request
Jan 31, 2025
@ianmcook@amoeba
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling pro…
16a0408
…blems (#45228)
This adds a LinkedIn icon social link to the main docs pages and fixes the layout of the top nav, which previously looked bad
at widths between 960px and 1200px.
* GitHub Issue: #45230
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@AlenkaFAlenkaFAlenkaF approved these changes

Assignees


No one assigned


Labels

awaiting mergeAwaiting mergeComponent: Documentation

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ianmcook@kou@AlenkaF

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems by ianmcook · Pull Request #45228 · apache/arrow · GitHub
Skip to content
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems - #45228
Merged
ianmcook merged 8 commits into
apache:mainfrom 
ianmcook:linkedin
Jan 13, 2025
Merged
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems#45228
ianmcook merged 8 commits into
apache:mainfrom 
ianmcook:linkedin
Conversation
@ianmcook
@ianmcookianmcook
commented
Jan 11, 2025•

edited

Loading

Copy link


Copy Markdown

Member
This adds a LinkedIn icon social link to the main docs pages. This follows the creation of a Linkedin page for the project in mid-2024, the active use of that page since then, and the addition of a LinkedIn follow button to the website homepage earlier this month.
This also fixes the layout of the top nav, which previously looked bad at widths between 960px and 1200px.
@ianmcook
ianmcook
marked this pull request as draft
January 11, 2025 20:11
@ianmcookianmcook
changed the title
MINOR: [Docs] Add LinkedIn social linkGH-45230: [Docs] Add LinkedIn social linkJan 11, 2025
@ianmcookianmcook
changed the title
GH-45230: [Docs] Add LinkedIn social linkGH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problemsJan 11, 2025
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
@ianmcook
ianmcook
marked this pull request as ready for review
January 11, 2025 22:18
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
ianmcook
ianmcook
commented
Jan 11, 2025
View reviewed changes
Comment threaddocs/source/_static/theme_overrides.css
Outdated

@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting committer review
Awaiting committer review
labels
Jan 11, 2025
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Jan 11, 2025
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
@ianmcook
ianmcook
requested a review
from AlenkaFJanuary 11, 2025 23:28
@apacheapache
deleted a comment from github-actionsBotJan 12, 2025
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit preview-docs
@github-actions
github-actionsBot
commented
Jan 12, 2025

Copy link


Copy Markdown

Revision: 1625b92
Submitted crossbow builds: ursacomputing/crossbow @ actions-3f63c22984
TaskStatus
preview-docsGitHub Actions
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
Preview: http://crossbow.voltrondata.com/pr_docs/45228
kou
kou
reviewed
Jan 12, 2025
View reviewed changes
Comment threaddocs/source/_static/theme_overrides.css
Outdated

Comment threaddocs/source/_static/theme_overrides.css
Outdated

kou
kou
approved these changes
Jan 12, 2025
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Jan 12, 2025
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting changes
Awaiting changes
labels
Jan 12, 2025
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
I tested on Windows. The font-stretch property did not apply to the Segoe UI font. So I switched to using letter-spacing to condense the nav text, which works across platforms.
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit preview-docs
@github-actions
github-actionsBot
commented
Jan 12, 2025

Copy link


Copy Markdown

Revision: cb30167
Submitted crossbow builds: ursacomputing/crossbow @ actions-3bcb2181c1
TaskStatus
preview-docsGitHub Actions
@ianmcook
ianmcook
commented
Jan 13, 2025

Copy link


Copy Markdown

MemberAuthor
@AlenkaF since you worked on some similar issues in #38148, you might want to take a look at this, thanks!
@ianmcookianmcook
mentioned this pull request
Jan 13, 2025

Closed

AlenkaF
AlenkaF
approved these changes
Jan 13, 2025
View reviewed changes
@AlenkaFAlenkaF
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top nav behaves much, much better now, thanks!
@ianmcook
ianmcook
merged commit 1f63646
into
apache:mainJan 13, 2025
@ianmcook
ianmcook
deleted the

linkedin

branch
January 13, 2025 14:24
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Jan 16, 2025

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1f63646.
There were 7 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
@ianmcookianmcook
mentioned this pull request
Jan 23, 2025

Closed

amoeba pushed a commit
that referenced
this pull request
Jan 31, 2025
@ianmcook@amoeba
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling pro…
b3b3b29
…blems (#45228)
This adds a LinkedIn icon social link to the main docs pages and fixes the layout of the top nav, which previously looked bad
at widths between 960px and 1200px.
* GitHub Issue: #45230
amoeba pushed a commit
that referenced
this pull request
Jan 31, 2025
@ianmcook@amoeba
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling pro…
16a0408
…blems (#45228)
This adds a LinkedIn icon social link to the main docs pages and fixes the layout of the top nav, which previously looked bad
at widths between 960px and 1200px.
* GitHub Issue: #45230
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@AlenkaFAlenkaFAlenkaF approved these changes

Assignees


No one assigned


Labels

awaiting mergeAwaiting mergeComponent: Documentation

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ianmcook@kou@AlenkaF

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems by ianmcook · Pull Request #45228 · apache/arrow · GitHub
Skip to content
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems - #45228
Merged
ianmcook merged 8 commits into
apache:mainfrom 
ianmcook:linkedin
Jan 13, 2025
Merged
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems#45228
ianmcook merged 8 commits into
apache:mainfrom 
ianmcook:linkedin
Conversation
@ianmcook
@ianmcookianmcook
commented
Jan 11, 2025•

edited

Loading

Copy link


Copy Markdown

Member
This adds a LinkedIn icon social link to the main docs pages. This follows the creation of a Linkedin page for the project in mid-2024, the active use of that page since then, and the addition of a LinkedIn follow button to the website homepage earlier this month.
This also fixes the layout of the top nav, which previously looked bad at widths between 960px and 1200px.
@ianmcook
ianmcook
marked this pull request as draft
January 11, 2025 20:11
@ianmcookianmcook
changed the title
MINOR: [Docs] Add LinkedIn social linkGH-45230: [Docs] Add LinkedIn social linkJan 11, 2025
@ianmcookianmcook
changed the title
GH-45230: [Docs] Add LinkedIn social linkGH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problemsJan 11, 2025
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
@ianmcook
ianmcook
marked this pull request as ready for review
January 11, 2025 22:18
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
ianmcook
ianmcook
commented
Jan 11, 2025
View reviewed changes
Comment threaddocs/source/_static/theme_overrides.css
Outdated

@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting committer review
Awaiting committer review
labels
Jan 11, 2025
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Jan 11, 2025
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
@ianmcook
ianmcook
requested a review
from AlenkaFJanuary 11, 2025 23:28
@apacheapache
deleted a comment from github-actionsBotJan 12, 2025
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit preview-docs
@github-actions
github-actionsBot
commented
Jan 12, 2025

Copy link


Copy Markdown

Revision: 1625b92
Submitted crossbow builds: ursacomputing/crossbow @ actions-3f63c22984
TaskStatus
preview-docsGitHub Actions
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
Preview: http://crossbow.voltrondata.com/pr_docs/45228
kou
kou
reviewed
Jan 12, 2025
View reviewed changes
Comment threaddocs/source/_static/theme_overrides.css
Outdated

Comment threaddocs/source/_static/theme_overrides.css
Outdated

kou
kou
approved these changes
Jan 12, 2025
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Jan 12, 2025
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting changes
Awaiting changes
labels
Jan 12, 2025
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
I tested on Windows. The font-stretch property did not apply to the Segoe UI font. So I switched to using letter-spacing to condense the nav text, which works across platforms.
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit preview-docs
@github-actions
github-actionsBot
commented
Jan 12, 2025

Copy link


Copy Markdown

Revision: cb30167
Submitted crossbow builds: ursacomputing/crossbow @ actions-3bcb2181c1
TaskStatus
preview-docsGitHub Actions
@ianmcook
ianmcook
commented
Jan 13, 2025

Copy link


Copy Markdown

MemberAuthor
@AlenkaF since you worked on some similar issues in #38148, you might want to take a look at this, thanks!
@ianmcookianmcook
mentioned this pull request
Jan 13, 2025

Closed

AlenkaF
AlenkaF
approved these changes
Jan 13, 2025
View reviewed changes
@AlenkaFAlenkaF
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top nav behaves much, much better now, thanks!
@ianmcook
ianmcook
merged commit 1f63646
into
apache:mainJan 13, 2025
@ianmcook
ianmcook
deleted the

linkedin

branch
January 13, 2025 14:24
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Jan 16, 2025

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1f63646.
There were 7 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
@ianmcookianmcook
mentioned this pull request
Jan 23, 2025

Closed

amoeba pushed a commit
that referenced
this pull request
Jan 31, 2025
@ianmcook@amoeba
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling pro…
b3b3b29
…blems (#45228)
This adds a LinkedIn icon social link to the main docs pages and fixes the layout of the top nav, which previously looked bad
at widths between 960px and 1200px.
* GitHub Issue: #45230
amoeba pushed a commit
that referenced
this pull request
Jan 31, 2025
@ianmcook@amoeba
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling pro…
16a0408
…blems (#45228)
This adds a LinkedIn icon social link to the main docs pages and fixes the layout of the top nav, which previously looked bad
at widths between 960px and 1200px.
* GitHub Issue: #45230
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@AlenkaFAlenkaFAlenkaF approved these changes

Assignees


No one assigned


Labels

awaiting mergeAwaiting mergeComponent: Documentation

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ianmcook@kou@AlenkaF

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems by ianmcook · Pull Request #45228 · apache/arrow · GitHub
Skip to content
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems - #45228
Merged
ianmcook merged 8 commits into
apache:mainfrom 
ianmcook:linkedin
Jan 13, 2025
Merged
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems#45228
ianmcook merged 8 commits into
apache:mainfrom 
ianmcook:linkedin
Conversation
@ianmcook
@ianmcookianmcook
commented
Jan 11, 2025•

edited

Loading

Copy link


Copy Markdown

Member
This adds a LinkedIn icon social link to the main docs pages. This follows the creation of a Linkedin page for the project in mid-2024, the active use of that page since then, and the addition of a LinkedIn follow button to the website homepage earlier this month.
This also fixes the layout of the top nav, which previously looked bad at widths between 960px and 1200px.
@ianmcook
ianmcook
marked this pull request as draft
January 11, 2025 20:11
@ianmcookianmcook
changed the title
MINOR: [Docs] Add LinkedIn social linkGH-45230: [Docs] Add LinkedIn social linkJan 11, 2025
@ianmcookianmcook
changed the title
GH-45230: [Docs] Add LinkedIn social linkGH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problemsJan 11, 2025
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
@ianmcook
ianmcook
marked this pull request as ready for review
January 11, 2025 22:18
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
ianmcook
ianmcook
commented
Jan 11, 2025
View reviewed changes
Comment threaddocs/source/_static/theme_overrides.css
Outdated

@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting committer review
Awaiting committer review
labels
Jan 11, 2025
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Jan 11, 2025
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
@ianmcook
ianmcook
requested a review
from AlenkaFJanuary 11, 2025 23:28
@apacheapache
deleted a comment from github-actionsBotJan 12, 2025
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit preview-docs
@github-actions
github-actionsBot
commented
Jan 12, 2025

Copy link


Copy Markdown

Revision: 1625b92
Submitted crossbow builds: ursacomputing/crossbow @ actions-3f63c22984
TaskStatus
preview-docsGitHub Actions
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
Preview: http://crossbow.voltrondata.com/pr_docs/45228
kou
kou
reviewed
Jan 12, 2025
View reviewed changes
Comment threaddocs/source/_static/theme_overrides.css
Outdated

Comment threaddocs/source/_static/theme_overrides.css
Outdated

kou
kou
approved these changes
Jan 12, 2025
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Jan 12, 2025
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting changes
Awaiting changes
labels
Jan 12, 2025
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
I tested on Windows. The font-stretch property did not apply to the Segoe UI font. So I switched to using letter-spacing to condense the nav text, which works across platforms.
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit preview-docs
@github-actions
github-actionsBot
commented
Jan 12, 2025

Copy link


Copy Markdown

Revision: cb30167
Submitted crossbow builds: ursacomputing/crossbow @ actions-3bcb2181c1
TaskStatus
preview-docsGitHub Actions
@ianmcook
ianmcook
commented
Jan 13, 2025

Copy link


Copy Markdown

MemberAuthor
@AlenkaF since you worked on some similar issues in #38148, you might want to take a look at this, thanks!
@ianmcookianmcook
mentioned this pull request
Jan 13, 2025

Closed

AlenkaF
AlenkaF
approved these changes
Jan 13, 2025
View reviewed changes
@AlenkaFAlenkaF
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top nav behaves much, much better now, thanks!
@ianmcook
ianmcook
merged commit 1f63646
into
apache:mainJan 13, 2025
@ianmcook
ianmcook
deleted the

linkedin

branch
January 13, 2025 14:24
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Jan 16, 2025

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1f63646.
There were 7 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
@ianmcookianmcook
mentioned this pull request
Jan 23, 2025

Closed

amoeba pushed a commit
that referenced
this pull request
Jan 31, 2025
@ianmcook@amoeba
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling pro…
b3b3b29
…blems (#45228)
This adds a LinkedIn icon social link to the main docs pages and fixes the layout of the top nav, which previously looked bad
at widths between 960px and 1200px.
* GitHub Issue: #45230
amoeba pushed a commit
that referenced
this pull request
Jan 31, 2025
@ianmcook@amoeba
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling pro…
16a0408
…blems (#45228)
This adds a LinkedIn icon social link to the main docs pages and fixes the layout of the top nav, which previously looked bad
at widths between 960px and 1200px.
* GitHub Issue: #45230
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@AlenkaFAlenkaFAlenkaF approved these changes

Assignees


No one assigned


Labels

awaiting mergeAwaiting mergeComponent: Documentation

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ianmcook@kou@AlenkaF

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems by ianmcook · Pull Request #45228 · apache/arrow · GitHub
Skip to content
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems - #45228
Merged
ianmcook merged 8 commits into
apache:mainfrom 
ianmcook:linkedin
Jan 13, 2025
Merged
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problems#45228
ianmcook merged 8 commits into
apache:mainfrom 
ianmcook:linkedin
Conversation
@ianmcook
@ianmcookianmcook
commented
Jan 11, 2025•

edited

Loading

Copy link


Copy Markdown

Member
This adds a LinkedIn icon social link to the main docs pages. This follows the creation of a Linkedin page for the project in mid-2024, the active use of that page since then, and the addition of a LinkedIn follow button to the website homepage earlier this month.
This also fixes the layout of the top nav, which previously looked bad at widths between 960px and 1200px.
@ianmcook
ianmcook
marked this pull request as draft
January 11, 2025 20:11
@ianmcookianmcook
changed the title
MINOR: [Docs] Add LinkedIn social linkGH-45230: [Docs] Add LinkedIn social linkJan 11, 2025
@ianmcookianmcook
changed the title
GH-45230: [Docs] Add LinkedIn social linkGH-45230: [Docs] Add LinkedIn social link and fix top nav scaling problemsJan 11, 2025
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
@ianmcook
ianmcook
marked this pull request as ready for review
January 11, 2025 22:18
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
ianmcook
ianmcook
commented
Jan 11, 2025
View reviewed changes
Comment threaddocs/source/_static/theme_overrides.css
Outdated

@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting committer review
Awaiting committer review
labels
Jan 11, 2025
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Jan 11, 2025
@apacheapache
deleted a comment from github-actionsBotJan 11, 2025
@ianmcook
ianmcook
requested a review
from AlenkaFJanuary 11, 2025 23:28
@apacheapache
deleted a comment from github-actionsBotJan 12, 2025
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit preview-docs
@github-actions
github-actionsBot
commented
Jan 12, 2025

Copy link


Copy Markdown

Revision: 1625b92
Submitted crossbow builds: ursacomputing/crossbow @ actions-3f63c22984
TaskStatus
preview-docsGitHub Actions
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
Preview: http://crossbow.voltrondata.com/pr_docs/45228
kou
kou
reviewed
Jan 12, 2025
View reviewed changes
Comment threaddocs/source/_static/theme_overrides.css
Outdated

Comment threaddocs/source/_static/theme_overrides.css
Outdated

kou
kou
approved these changes
Jan 12, 2025
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Jan 12, 2025
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting changes
Awaiting changes
labels
Jan 12, 2025
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
I tested on Windows. The font-stretch property did not apply to the Segoe UI font. So I switched to using letter-spacing to condense the nav text, which works across platforms.
@ianmcook
ianmcook
commented
Jan 12, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit preview-docs
@github-actions
github-actionsBot
commented
Jan 12, 2025

Copy link


Copy Markdown

Revision: cb30167
Submitted crossbow builds: ursacomputing/crossbow @ actions-3bcb2181c1
TaskStatus
preview-docsGitHub Actions
@ianmcook
ianmcook
commented
Jan 13, 2025

Copy link


Copy Markdown

MemberAuthor
@AlenkaF since you worked on some similar issues in #38148, you might want to take a look at this, thanks!
@ianmcookianmcook
mentioned this pull request
Jan 13, 2025

Closed

AlenkaF
AlenkaF
approved these changes
Jan 13, 2025
View reviewed changes
@AlenkaFAlenkaF
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top nav behaves much, much better now, thanks!
@ianmcook
ianmcook
merged commit 1f63646
into
apache:mainJan 13, 2025
@ianmcook
ianmcook
deleted the

linkedin

branch
January 13, 2025 14:24
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Jan 16, 2025

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1f63646.
There were 7 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
@ianmcookianmcook
mentioned this pull request
Jan 23, 2025

Closed

amoeba pushed a commit
that referenced
this pull request
Jan 31, 2025
@ianmcook@amoeba
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling pro…
b3b3b29
…blems (#45228)
This adds a LinkedIn icon social link to the main docs pages and fixes the layout of the top nav, which previously looked bad
at widths between 960px and 1200px.
* GitHub Issue: #45230
amoeba pushed a commit
that referenced
this pull request
Jan 31, 2025
@ianmcook@amoeba
GH-45230: [Docs] Add LinkedIn social link and fix top nav scaling pro…
16a0408
…blems (#45228)
This adds a LinkedIn icon social link to the main docs pages and fixes the layout of the top nav, which previously looked bad
at widths between 960px and 1200px.
* GitHub Issue: #45230
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@AlenkaFAlenkaFAlenkaF approved these changes

Assignees


No one assigned


Labels

awaiting mergeAwaiting mergeComponent: Documentation

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ianmcook@kou@AlenkaF