Uh oh!
There was an error while loading. Please reload this page.
MINOR: [Python] Deduplicate ensure_s3_initialized() call - #38451
Merged
Conversation
pentschev
commented
Oct 25, 2023
ContributorAuthor
@kou as per #38375 (comment), here's the PR to deduplicate the |
Merged
5 tasks
kou
commented
Oct 25, 2023
Member
@github-actions crossbow submit -g python -g wheel |
Revision: 4023801 Submitted crossbow builds: ursacomputing/crossbow @ actions-89f99927a7
|
The failing Appveyor tests look similar to ones I just encountered. These may be solved by this PR to update the |
kou
approved these changes
Oct 25, 2023
kou
left a comment
Member
There was a problem hiding this comment.
+1
We can ignore the AppVeyor failure in this PR.
jakirkham
commented
Oct 26, 2023
Thanks all! 🙏 |
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit ff7b3bb. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
loicalleyne pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
) ### Rationale for this change apache#38375 introduced duplicate calls to `ensure_s3_initialized()`. ### What changes are included in this PR? Deduplicates call to `ensure_s3_initialized()`. ### Are these changes tested? Yes, covered by existing S3 tests. ### Are there any user-facing changes? No. Authored-by: Peter Andreas Entschev <peter@entschev.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
) ### Rationale for this change apache#38375 introduced duplicate calls to `ensure_s3_initialized()`. ### What changes are included in this PR? Deduplicates call to `ensure_s3_initialized()`. ### Are these changes tested? Yes, covered by existing S3 tests. ### Are there any user-facing changes? No. Authored-by: Peter Andreas Entschev <peter@entschev.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
#38375 introduced duplicate calls to
ensure_s3_initialized().What changes are included in this PR?
Deduplicates call to
ensure_s3_initialized().Are these changes tested?
Yes, covered by existing S3 tests.
Are there any user-facing changes?
No.