Uh oh!
There was an error while loading. Please reload this page.
GH-38431: [Python][CI] Update fs.type_name checks for s3fs tests - #38455
Merged
Conversation
AlenkaF
commented
Oct 25, 2023
MemberAuthor
AppVeyor is passing but other Python builds are still using the old version of |
AlenkaF
marked this pull request as ready for review
October 25, 2023 13:04
raulcd
commented
Oct 25, 2023
Member
@github-actions crossbow submit -g python |
Revision: 3a53d11 Submitted crossbow builds: ursacomputing/crossbow @ actions-a83bce7a72
|
raulcd
commented
Oct 25, 2023
Member
@github-actions crossbow submit -g conda |
Revision: 3a53d11 Submitted crossbow builds: ursacomputing/crossbow @ actions-716f9fca2a
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 3f4aeab. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
raulcd pushed a commit
that referenced
this pull request
Nov 6, 2023
) ### Rationale for this change Appveyor CI is failing https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/48347810. It seems the reason for the test failures is a change in the `type_name` (from `"py::fsspec+s3"` to `"py::fsspec+('s3', 's3a')"`) and due to it tests are not being skipped. ### What changes are included in this PR? Update the check for `type_name` in case of `PyFileSystem(FSSpecHandler(s3fs.S3FileSystem()))`. * Closes: #38431 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
apache#38455) ### Rationale for this change Appveyor CI is failing https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/48347810. It seems the reason for the test failures is a change in the `type_name` (from `"py::fsspec+s3"` to `"py::fsspec+('s3', 's3a')"`) and due to it tests are not being skipped. ### What changes are included in this PR? Update the check for `type_name` in case of `PyFileSystem(FSSpecHandler(s3fs.S3FileSystem()))`. * Closes: apache#38431 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
apache#38455) ### Rationale for this change Appveyor CI is failing https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/48347810. It seems the reason for the test failures is a change in the `type_name` (from `"py::fsspec+s3"` to `"py::fsspec+('s3', 's3a')"`) and due to it tests are not being skipped. ### What changes are included in this PR? Update the check for `type_name` in case of `PyFileSystem(FSSpecHandler(s3fs.S3FileSystem()))`. * Closes: apache#38431 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Appveyor CI is failing https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/48347810. It seems the reason for the test failures is a change in the
type_name(from"py::fsspec+s3"to"py::fsspec+('s3', 's3a')") and due to it tests are not being skipped.What changes are included in this PR?
Update the check for
type_namein case ofPyFileSystem(FSSpecHandler(s3fs.S3FileSystem())).