Uh oh!
There was an error while loading. Please reload this page.
GH-38556: [C++] Add missing explicit size_t cast for i386 - #38557
Merged
Conversation
kou
commented
Nov 2, 2023
MemberAuthor
@github-actions crossbow submit test-debian-cpp-i386 |
This comment was marked as outdated.
This comment was marked as outdated.
This was introduced by apacheGH-37792.
kou
commented
Nov 2, 2023
MemberAuthor
@github-actions crossbow submit test-debian-11-cpp-i386 |
Revision: f1bc62c Submitted crossbow builds: ursacomputing/crossbow @ actions-bc4e3c2759
|
kou
commented
Nov 6, 2023
MemberAuthor
+1 |
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 9a364b8. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…he#38557) ### Rationale for this change We need explicit cast for `int64_t` to `size_t` conversion for i386 environment. This was introduced by apacheGH-37792. ### What changes are included in this PR? Add explicit cast. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38556 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…he#38557) ### Rationale for this change We need explicit cast for `int64_t` to `size_t` conversion for i386 environment. This was introduced by apacheGH-37792. ### What changes are included in this PR? Add explicit cast. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38556 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We need explicit cast for
int64_ttosize_tconversion for i386 environment.This was introduced by GH-37792.
What changes are included in this PR?
Add explicit cast.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.
long long inttosize_tconversion #38556