Uh oh!
There was an error while loading. Please reload this page.
GH-37710: [C++][Integration] Add C++ Utf8View implementation - #37792
Conversation
d468860 to
660008fCompare660008f to
614a411Compare614a411 to
b62d539CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
This changes the meaning of is_binary_like_type. For list-views I added new predicates and kept the existing predicates' semantics.
Illustrate in this graph https://gist.github.com/felipecrv/3c02f3784221d946dec1b031c6d400db
There was a problem hiding this comment.
I agree with @felipecrv btw. This may silently produce incorrect binary-view handling in operations not touched by this PR.
There was a problem hiding this comment.
These traits are used in very few places. I think the current arrangement is fine; "binary like" = has a byte array, "string like" = has a byte array which is utf8.
There was a problem hiding this comment.
The question is whether these are used by third-party code. These are not internal APIs, and there is a risk that user code will then try to use binary view data in non-compatible routines, and get UB or data corruption.
There was a problem hiding this comment.
I've reverted the change to is_binary_like_type and is_string_like_type
Uh oh!
There was an error while loading. Please reload this page.
pitrou
commented
Oct 26, 2023
@bkietz Please make sure you rebase before merging, since these are rather large changes that could unwillingly affect other parts of the code. |
2798197 to
028bca2Comparepaleolimbot
commented
Oct 26, 2023
@assignUser It looks like at least one CI job is using the latest nightly a little too oportunistically and causing the CI to fail here! https://github.com/apache/arrow/actions/runs/6658040302/job/18094056322?pr=37792#step:6:21 |
paleolimbot
commented
Oct 26, 2023
We'll add that to the PR cleaning up the edges on the (somewhat large) change to the R build system defaults. You can safely ignore that CI failure (or if you can't safely ignore it than I volunteer to fix it!) |
bkietz
commented
Oct 26, 2023
Thanks @paleolimbot ! I'll merge now |
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit f622139. There were 2 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
alamb
commented
Oct 27, 2023
Thank you for everyone who commented, reviewed and helped get this PR merged |
Rationale for this change
After the PR changing the spec and schema ( #37526 ) is accepted, this PR will be undrafted. It adds the minimal addition of a C++ implementation and was extracted from the original C++ Utf8View pr ( #35628 ) for ease of review.
What changes are included in this PR?
std::string_viewas with StringArrayRelevant mailing list discussions: