Skip to content

ARROW-5119: [Go] fix Boolean stringer implementation - #4112

Closed
sbinet wants to merge 1 commit into
apache:masterfrom
sbinet-gonum:issue-5119
Closed

ARROW-5119: [Go] fix Boolean stringer implementation#4112
sbinet wants to merge 1 commit into
apache:masterfrom
sbinet-gonum:issue-5119

Conversation

@sbinet

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #4112 into master will decrease coverage by 18.65%.
The diff coverage is 0%.

Impacted file tree graph

@@ Coverage Diff @@## master #4112 +/- ##
===========================================
- Coverage 87.82% 69.16% -18.66% 
===========================================
Files 739 61 -678 Lines 90965 4206 -86759 Branches 1252 0 -1252 ===========================================
- Hits 79886 2909 -76977 + Misses 10958 1188 -9770 + Partials 121 109 -12
Impacted FilesCoverage Δ
go/arrow/array/boolean.go48.27% <0%> (ø)⬆️
go/arrow/math/float64_sse4_amd64.go0% <0%> (-100%)⬇️
go/arrow/memory/memory_sse4_amd64.go0% <0%> (-100%)⬇️
go/arrow/math/uint64_sse4_amd64.go0% <0%> (-100%)⬇️
go/arrow/math/int64_sse4_amd64.go0% <0%> (-100%)⬇️
go/arrow/math/uint64_amd64.go33.33% <0%> (ø)⬆️
go/arrow/math/int64_amd64.go33.33% <0%> (ø)⬆️
go/arrow/math/float64_amd64.go33.33% <0%> (ø)⬆️
python/pyarrow/ipc.pxi
cpp/src/arrow/csv/chunker-test.cc
... and 682 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a93316...994c4ae. Read the comment docs.

@sbinet

Copy link
Copy Markdown
ContributorAuthor

@stuartcarnie@alexandreyc PTAL

@alexandreyc

Copy link
Copy Markdown
Contributor

Good catch!

LGTM

@sbinetsbinet closed this in 21b23f7Apr 4, 2019
@sbinet
sbinet deleted the issue-5119 branch April 4, 2019 21:33
@wesm

wesm commented Apr 4, 2019

Copy link
Copy Markdown
Member

This is not tested I guess?

@sbinet

Copy link
Copy Markdown
ContributorAuthor

this was, but the array was - by shear luck - of the correct size.
I'll modify an example/test to exercize it.

@stuartcarniestuartcarnie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sbinet

Copy link
Copy Markdown
ContributorAuthor

@wesm: added the test as part of #4114

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@sbinet@codecov-io@alexandreyc@wesm@stuartcarnie