Uh oh!
There was an error while loading. Please reload this page.
ARROW-5108: [Go] implement reading primitive arrays from Arrow file - #4114
ARROW-5108: [Go] implement reading primitive arrays from Arrow file#4114sbinet wants to merge 21 commits into
Conversation
sbinet
commented
Apr 4, 2019
@stuartcarnie@alexandreyc PTAL. it's a lot of code, but most of it is coming from the automatically generated code from flatbuffers.
|
wesm
commented
Apr 4, 2019
Is there a way to generate the Flatbuffers bindings at build time or do the files have to be checked in? |
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #4114 +/- ##
==========================================
- Coverage 88.44% 87.87% -0.57%
==========================================
Files 752 758 +6 Lines 91515 92163 +648 Branches 1251 1251 ==========================================
+ Hits 80937 80990 +53 - Misses 10457 11052 +595
Partials 121 121
Continue to review full report at Codecov.
|
sbinet
commented
Apr 4, 2019
@wesm: this (unfortunately?) isn't the way Gophers like to do it. |
19f8637 to
0f98156Comparesbinet
commented
Apr 5, 2019
the flurry of activity is now done. PTAL |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Is there any reason why you switched from pointer to value receiver?
There was a problem hiding this comment.
it was mainly to convey that method wouldn't modify the receiver.
I can switch to pointer receiver.
There was a problem hiding this comment.
Maybe check for msg.meta and msg.body to be not nil before releasing them?
There was a problem hiding this comment.
I put the check+panic in the NewMessage instead.
Uh oh!
There was an error while loading. Please reload this page.
stuartcarnie
left a comment
There was a problem hiding this comment.
Excited to see this work 🎉
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sbinet
commented
Apr 9, 2019
PTAL. |
Uh oh!
There was an error while loading. Please reload this page.
This CL adds the generation of flatbuffers-based files for the IPC backend. This CL adds the basic functionality to read an Arrow file.
This CL adds the generation of flatbuffers-based files for the IPC backend.
This CL adds the basic functionality to read an Arrow file.