Skip to content

ARROW-5110: [Go] implement reading struct arrays from Arrow file - #4158

Closed
sbinet wants to merge 3 commits into
apache:masterfrom
sbinet-gonum:issue-5110
Closed

ARROW-5110: [Go] implement reading struct arrays from Arrow file#4158
sbinet wants to merge 3 commits into
apache:masterfrom
sbinet-gonum:issue-5110

Conversation

@sbinet

Copy link
Copy Markdown
Contributor

No description provided.

@sbinet

Copy link
Copy Markdown
ContributorAuthor

needs #4157

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #4158 into master will decrease coverage by 26.75%.
The diff coverage is 4.61%.

Impacted file tree graph

@@ Coverage Diff @@## master #4158 +/- ##
===========================================
- Coverage 87.89% 61.13% -26.76% 
===========================================
Files 758 67 -691 Lines 92163 4912 -87251 Branches 1251 0 -1251 ===========================================
- Hits 81006 3003 -78003 + Misses 11040 1798 -9242 + Partials 117 111 -6
Impacted FilesCoverage Δ
go/arrow/ipc/file_reader.go0% <0%> (ø)⬆️
go/arrow/ipc/metadata.go0% <0%> (ø)⬆️
go/arrow/array/list.go74.56% <0%> (-12.18%)⬇️
go/arrow/array/struct.go84.31% <100%> (+11.67%)⬆️
python/pyarrow/ipc.pxi
cpp/src/arrow/csv/chunker-test.cc
cpp/src/parquet/column_page.h
cpp/src/parquet/bloom_filter-test.cc
cpp/src/arrow/array/builder_decimal.cc
cpp/src/plasma/client.cc
... and 687 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0930d...75f72bf. Read the comment docs.

@sbinet

Copy link
Copy Markdown
ContributorAuthor

PTAL @stuartcarnie@alexandreyc@nickpoorman

@stuartcarniestuartcarnie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sbinet@codecov-io@stuartcarnie