Skip to content

ARROW-5172: [Go] implement reading fixed-size binary arrays from Arrow file - #4159

Closed
sbinet wants to merge 2 commits into
apache:masterfrom
sbinet-gonum:issue-5172
Closed

ARROW-5172: [Go] implement reading fixed-size binary arrays from Arrow file#4159
sbinet wants to merge 2 commits into
apache:masterfrom
sbinet-gonum:issue-5172

Conversation

@sbinet

Copy link
Copy Markdown
Contributor

No description provided.

@sbinet

Copy link
Copy Markdown
ContributorAuthor

needs #4158

@codecov-io

codecov-io commented Apr 16, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4159 into master will decrease coverage by 26.97%.
The diff coverage is 22.68%.

Impacted file tree graph

@@ Coverage Diff @@## master #4159 +/- ##
===========================================
- Coverage 87.89% 60.91% -26.98% 
===========================================
Files 758 67 -691 Lines 92163 4943 -87220 Branches 1251 0 -1251 ===========================================
- Hits 81006 3011 -77995 + Misses 11040 1816 -9224 + Partials 117 116 -1
Impacted FilesCoverage Δ
go/arrow/ipc/file_reader.go0% <0%> (ø)⬆️
go/arrow/array/list.go74.56% <0%> (-12.18%)⬇️
go/arrow/ipc/metadata.go0% <0%> (ø)⬆️
go/arrow/array/struct.go84.31% <100%> (+11.67%)⬆️
go/arrow/array/fixedsize_binary.go73.8% <79.16%> (+5.38%)⬆️
go/arrow/memory/memory_avx2_amd64.go0% <0%> (-100%)⬇️
go/arrow/math/uint64_avx2_amd64.go0% <0%> (-100%)⬇️
go/arrow/math/int64_avx2_amd64.go0% <0%> (-100%)⬇️
go/arrow/math/float64_avx2_amd64.go0% <0%> (-100%)⬇️
go/arrow/memory/memory_amd64.go28.57% <0%> (-14.29%)⬇️
... and 701 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0930d...39299f1. Read the comment docs.

@sbinet

Copy link
Copy Markdown
ContributorAuthor

@sbinet

Copy link
Copy Markdown
ContributorAuthor

(the Travis-CI error is unrelated (JDK-9 is acting up?))

@wesm

wesm commented Apr 29, 2019

Copy link
Copy Markdown
Member

@stuartcarniestuartcarnie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sbinet@codecov-io@wesm@stuartcarnie