Skip to content

ARROW-5173: [Go] handle multiple concatenated record batches - #4160

Closed
sbinet wants to merge 1 commit into
apache:masterfrom
sbinet-gonum:issue-5173
Closed

ARROW-5173: [Go] handle multiple concatenated record batches#4160
sbinet wants to merge 1 commit into
apache:masterfrom
sbinet-gonum:issue-5173

Conversation

@sbinet

Copy link
Copy Markdown
Contributor

No description provided.

@sbinet

Copy link
Copy Markdown
ContributorAuthor

needs #4159

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #4160 into master will decrease coverage by 26.77%.
The diff coverage is 22.68%.

Impacted file tree graph

@@ Coverage Diff @@## master #4160 +/- ##
===========================================
- Coverage 87.89% 61.11% -26.78% 
===========================================
Files 758 67 -691 Lines 92163 4943 -87220 Branches 1251 0 -1251 ===========================================
- Hits 81006 3021 -77985 + Misses 11040 1810 -9230 + Partials 117 112 -5
Impacted FilesCoverage Δ
go/arrow/array/list.go74.56% <0%> (-12.18%)⬇️
go/arrow/ipc/file_reader.go0% <0%> (ø)⬆️
go/arrow/ipc/metadata.go0% <0%> (ø)⬆️
go/arrow/array/struct.go84.31% <100%> (+11.67%)⬆️
go/arrow/array/fixedsize_binary.go73.8% <79.16%> (+5.38%)⬆️
python/pyarrow/ipc.pxi
cpp/src/arrow/csv/chunker-test.cc
cpp/src/parquet/column_page.h
cpp/src/parquet/bloom_filter-test.cc
cpp/src/arrow/array/builder_decimal.cc
... and 688 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0930d...49ea528. Read the comment docs.

@sbinet
sbinetforce-pushed the issue-5173 branch 2 times, most recently from a4e0b27 to 4ca02bbCompareApril 29, 2019 08:30
@sbinet

Copy link
Copy Markdown
ContributorAuthor

@sbinet

Copy link
Copy Markdown
ContributorAuthor

(the Travis-CI error is unrelated (JDK-9 is acting up?))

@alexandreyc

Copy link
Copy Markdown
Contributor

Looks like this PR is a subset of #4161

@stuartcarniestuartcarnie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For building complex CLI interfaces, I'd recommend you look at https://github.com/spf13/cobra. You can then have a single binary:

$ arrow ls ...
$ arrow cat

etc

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sbinet@codecov-io@alexandreyc@stuartcarnie