Skip to content

GH-41717: [Java][Vector] fix issue with ByteBuffer rewind in MessageSerializer - #41718

Merged
lidavidm merged 5 commits into
apache:mainfrom
pjfanning:patch-1
May 20, 2024
Merged

GH-41717: [Java][Vector] fix issue with ByteBuffer rewind in MessageSerializer#41718
lidavidm merged 5 commits into
apache:mainfrom
pjfanning:patch-1

Conversation

@pjfanning

@pjfanningpjfanning commented May 19, 2024

Copy link
Copy Markdown
Member

Rationale for this change

What changes are included in this PR?

#41717 describes issue and change

Are these changes tested?

CI build

Are there any user-facing changes?

@pjfanning
pjfanning requested a review from lidavidm as a code ownerMay 19, 2024 09:40
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #41717has been automatically assigned in GitHub to PR creator.

@pjfanningpjfanning changed the title GH-41717: [JAVA] [VECTOR] fix issue with ByteBuffer rewind in MessageSerializerGH-41717: [Java][Vector] fix issue with ByteBuffer rewind in MessageSerializerMay 19, 2024
@kou

kou commented May 19, 2024

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g java

@github-actions

Copy link
Copy Markdown
module 'pygit2' has no attribute 'GIT_OBJ_COMMIT'
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/9150811236

@vibhatha

Copy link
Copy Markdown
Contributor

@kou this error is not familiar. Could be a temporary issue?

@vibhatha

Copy link
Copy Markdown
Contributor

@github-actions crossbow submit -g java

@github-actions

Copy link
Copy Markdown
module 'pygit2' has no attribute 'GIT_OBJ_COMMIT'
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/9151003846

@vibhatha

Copy link
Copy Markdown
Contributor

cc @raulcd@assignUser any idea why the crossbow bot command is failing?

@assignUser

Copy link
Copy Markdown
Member

Uhh, looks like a new version of pygit? I'll have to check

@raulcd

Copy link
Copy Markdown
Member

Uhh, looks like a new version of pygit? I'll have to check

There was a release of pygit2 (1.15.0) yesterday so that checks. @vibhatha can you open an issue?

@raulcd

Copy link
Copy Markdown
Member

@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 19, 2024
@pan3793

Copy link
Copy Markdown
Member

What happened in 16.1.0, I got another similar error(in a different place)

java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer;
at org.apache.arrow.memory.ArrowBuf.setBytes(ArrowBuf.java:907)
at org.apache.arrow.vector.BaseVariableWidthVector.setSafe(BaseVariableWidthVector.java:1183)

@vibhatha

Copy link
Copy Markdown
Contributor

@raulcd sorry about the delay.

Issue created here: #41735

@kou

kou commented May 20, 2024

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g java

@github-actions

Copy link
Copy Markdown

Revision: f47bbcf

Submitted crossbow builds: ursacomputing/crossbow @ actions-3f91e4c81b

TaskStatus
java-jarsGitHub Actions
test-conda-python-3.10-spark-v3.5.0GitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.8-spark-v3.5.0GitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64GitHub Actions
verify-rc-source-java-macos-amd64GitHub Actions

@lidavidm

Copy link
Copy Markdown
Member

Those failures are mostly expected. #41628 should help if I can get an actual review.

@lidavidm
lidavidm merged commit 1cd2872 into apache:mainMay 20, 2024
@lidavidmlidavidm removed the awaiting merge Awaiting merge label May 20, 2024
@vibhatha

Copy link
Copy Markdown
Contributor

What happened in 16.1.0, I got another similar error(in a different place)

java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer;
at org.apache.arrow.memory.ArrowBuf.setBytes(ArrowBuf.java:907)
at org.apache.arrow.vector.BaseVariableWidthVector.setSafe(BaseVariableWidthVector.java:1183)

@pan3793 still facing this issue?

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 1cd2872.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 29 possible false positives for unstable benchmarks that are known to sometimes produce them.

vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
…ssageSerializer (apache#41718)
### Rationale for this change
### What changes are included in this PR?
apache#41717 describes issue and change
### Are these changes tested?
CI build
### Are there any user-facing changes?
* GitHub Issue: apache#41717
Authored-by: PJ Fanning <pjfanning@users.noreply.github.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
…ssageSerializer (apache#41718)
### Rationale for this change
### What changes are included in this PR?
apache#41717 describes issue and change
### Are these changes tested?
CI build
### Are there any user-facing changes?
* GitHub Issue: apache#41717
Authored-by: PJ Fanning <pjfanning@users.noreply.github.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@pjfanning@kou@vibhatha@assignUser@raulcd@pan3793@lidavidm