ARROW-1280: [C++] add fixed size list type - #4278

Closed
bkietz wants to merge 8 commits into
apache:masterfrom
bkietz:1280-Implement-Fixed-Size-List-type
Closed

ARROW-1280: [C++] add fixed size list type#4278
bkietz wants to merge 8 commits into
apache:masterfrom
bkietz:1280-Implement-Fixed-Size-List-type

Conversation

@bkietz

@bkietzbkietz commented May 8, 2019

Copy link
Copy Markdown
Member
  • FixedSizeListType, parameterized by the list size (similar to FixedSizeBinaryType), constructed with fixed_size_list(<value field or type>, list_size)
  • FixedSizeListArray, including Equal and pretty print impls
  • FixedSizeListBuilder, works with MakeBuilder

fsaintjacques
fsaintjacques reviewed May 9, 2019
View reviewed changes

@fsaintjacquesfsaintjacques left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It think it's worth adding support in the integration tests as Java already support this type:

https://github.com/apache/arrow/blob/master/integration/integration_test.py

Comment threadcpp/src/arrow/array.h Outdated

@fsaintjacquesfsaintjacquesMay 9, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I prefer the explicit int64_t i as parameter. A bit better for the ABI.

@bkietzbkietzMay 9, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it's independent of index?

@pitroupitrouMay 9, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather remove the argument. Or you can provide two separate overrides. A variadic function looks bizarre here.

@bkietzbkietzMay 9, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allowing it to be called with an argument means I don't have to rewrite pretty-print :)

Comment threadcpp/src/arrow/array.h Outdated

@fsaintjacquesfsaintjacquesMay 9, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth having common abstract class?

@bkietzbkietzMay 9, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not much opportunity for code reuse in arrays/builders. The only advantage I can think of would be easier reuse of code which consumes ListArray (but only code which doesn't directly access the offsets buffer). Those algorithms could use ArrayData BasicListArray::GetView(int64_t i) or similar. This seems like speculative generality to me; I'd be more open to doing it if you can think of existing code which would benefit from being refactored this way.

FixedSizeListScalar and ListScalar are identical but also trivial.

@pitroupitrouMay 9, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @bkietz. Also code reuse can be achieved through templating (we generally care about performing non-virtual calls anyway).

@fsaintjacquesfsaintjacquesMay 10, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bkietz
bkietzforce-pushed the 1280-Implement-Fixed-Size-List-type branch from 45e309c to b47e059CompareMay 9, 2019 17:34
pitrou
pitrou reviewed May 9, 2019
View reviewed changes

@pitroupitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Overall this looks good. Still some comments below.

Side question: should support for FixedSizeListType added to ArrayFromJSON? Perhaps as a separate PR?

Comment threadcpp/src/arrow/scalar.cc Outdated
Comment threadcpp/src/arrow/pretty_print.cc Outdated
Comment threadcpp/src/arrow/ipc/metadata-internal.cc Outdated
Comment threadcpp/src/arrow/ipc/json-internal.cc Outdated

@pitroupitrouMay 9, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might add a simple test for this.

@bkietzbkietzMay 9, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How's this: https://github.com/apache/arrow/pull/4278/files#diff-4e2d1d19217cc5481a51f3aa0b65b38eR193

Comment threadcpp/src/arrow/compare.cc Outdated

@pitroupitrouMay 9, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if you could dig a bit (or perhaps open a JIRA about this, explaining the issue and/or adding a reproducer).

@bkietzbkietzMay 10, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, this is a bug.

Comment threadcpp/src/arrow/array.cc Outdated
Comment threadcpp/src/arrow/array.h Outdated
Comment threadcpp/src/arrow/array.cc Outdated
Comment threadcpp/src/arrow/array-list-test.cc Outdated
Comment threadcpp/src/arrow/array-list-test.cc Outdated

@pitroupitrouMay 9, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, this builds an invalid FixedSizeListArray? No values are appended to the child array.

@bkietzbkietzMay 9, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does build an invalid array, but the point of this test is just to check that the field name is correctly propagated to the built array

@bkietz

bkietz commented May 9, 2019

Copy link
Copy Markdown
MemberAuthor

@pitrou Added ArrayFromJSON impl

@bkietz
bkietzforce-pushed the 1280-Implement-Fixed-Size-List-type branch from 78982ab to 80f444fCompareMay 10, 2019 19:50
@pitrou

pitrou commented May 13, 2019•
edited
Loading

Copy link
Copy Markdown
Member

@kou There is a meson-related error on Travis-CI, could you advise?
See https://travis-ci.org/apache/arrow/jobs/530907671

@pitrou

pitrou commented May 13, 2019

Copy link
Copy Markdown
Member

Looks like there's also a MinGW test failure:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/24461942/job/mper2jipn6kj5bxj

Error: test: csv.gz(TableTest::#save and .load::path:::format::load: auto detect): Arrow::Error::Io: [csv-reader][read]: IOError: zlib inflate failed: invalid distance too far back
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:616:in `invoke'
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:616:in `invoke'
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:533:in `block in define_method'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:158:in `block (2 levels) in load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:147:in `block (2 levels) in wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:140:in `open_encoding_convert_stream'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:146:in `block in wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:125:in `block in open_decompress_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/block-closable.rb:25:in `open'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:124:in `open_decompress_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:145:in `wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:157:in `block in load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/block-closable.rb:25:in `open'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:156:in `load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:39:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:26:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:158:in `load_as_csv'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:50:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:22:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table.rb:27:in `load'
C:/projects/arrow/ruby/red-arrow/test/test-table.rb:503:in `block (5 levels) in <class:TableTest>'

@pitrou

pitrou commented May 13, 2019

Copy link
Copy Markdown
Member

Ok, apparently the Travis-CI failure is unrelated:
https://issues.apache.org/jira/browse/ARROW-5306

pitrou
pitrou approved these changes May 13, 2019
View reviewed changes

@pitroupitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pitrou
pitrouforce-pushed the 1280-Implement-Fixed-Size-List-type branch from 80f444f to 920a251CompareMay 13, 2019 13:25
@pitrou

pitrou commented May 13, 2019

Copy link
Copy Markdown
Member

Turns out the MinGW failure was sporadic. Merging.

@pitrou

pitrou commented May 13, 2019

Copy link
Copy Markdown
Member

Thanks @bkietz !

@fsaintjacques Integration tests are tracked in https://issues.apache.org/jira/browse/ARROW-1278.

@kou

kou commented May 13, 2019

Copy link
Copy Markdown
Member

If the MinGW failure is caused again, I'll look into it.

@bkietzbkietz mentioned this pull request May 14, 2019
Closed
emkornfield pushed a commit that referenced this pull request Jun 14, 2019
@bkietz@emkornfield
ARROW-1278: [Integration] Adding integration tests for fixed_size_list
d20963d
Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in #4278
Author: Benjamin Kietzman <bengilgit@gmail.com>
Closes#4309 from bkietz/1278-integration-tests-for-fixed-size-list and squashes the following commits:
8b356f3 <Benjamin Kietzman> revert removal of ninja-build from dockerfile
e7ed001 <Benjamin Kietzman> fix flake8 error
8ab4efc <Benjamin Kietzman> Adding integration tests for fixed_size_list
@bkietz
bkietz deleted the 1280-Implement-Fixed-Size-List-type branch February 25, 2021 16:10
@asfimportasfimport mentioned this pull request May 15, 2019
Closed
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
@bkietz@kou
ARROW-1278: [Integration] Adding integration tests for fixed_size_list
809c18f
Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in apache#4278
Author: Benjamin Kietzman <bengilgit@gmail.com>
Closesapache#4309 from bkietz/1278-integration-tests-for-fixed-size-list and squashes the following commits:
8b356f3 <Benjamin Kietzman> revert removal of ninja-build from dockerfile
e7ed001 <Benjamin Kietzman> fix flake8 error
8ab4efc <Benjamin Kietzman> Adding integration tests for fixed_size_list
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fsaintjacquesfsaintjacquesfsaintjacques left review comments
@pitroupitroupitrou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bkietz@pitrou@kou@fsaintjacques
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ARROW-1280: [C++] add fixed size list type - #4278
Closed
bkietz wants to merge 8 commits into
apache:masterfrom 
bkietz:1280-Implement-Fixed-Size-List-type
Closed
ARROW-1280: [C++] add fixed size list type#4278
bkietz wants to merge 8 commits into
apache:masterfrom 
bkietz:1280-Implement-Fixed-Size-List-type
Conversation
@bkietz
@bkietzbkietz
commented
May 8, 2019

Copy link


Copy Markdown

Member
  • FixedSizeListType, parameterized by the list size (similar to FixedSizeBinaryType), constructed with fixed_size_list(<value field or type>, list_size)
  • FixedSizeListArray, including Equal and pretty print impls
  • FixedSizeListBuilder, works with MakeBuilder
fsaintjacques
fsaintjacques
reviewed
May 9, 2019
View reviewed changes
@fsaintjacquesfsaintjacques
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It think it's worth adding support in the integration tests as Java already support this type:
https://github.com/apache/arrow/blob/master/integration/integration_test.py
Comment threadcpp/src/arrow/array.h
Outdated

@fsaintjacquesfsaintjacquesMay 9, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I prefer the explicit int64_t i as parameter. A bit better for the ABI.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it's independent of index?
@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather remove the argument. Or you can provide two separate overrides. A variadic function looks bizarre here.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allowing it to be called with an argument means I don't have to rewrite pretty-print :)
Comment threadcpp/src/arrow/array.h
Outdated

@fsaintjacquesfsaintjacquesMay 9, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth having common abstract class?
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not much opportunity for code reuse in arrays/builders. The only advantage I can think of would be easier reuse of code which consumes ListArray (but only code which doesn't directly access the offsets buffer). Those algorithms could use ArrayData BasicListArray::GetView(int64_t i) or similar. This seems like speculative generality to me; I'd be more open to doing it if you can think of existing code which would benefit from being refactored this way.
FixedSizeListScalar and ListScalar are identical but also trivial.
@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @bkietz. Also code reuse can be achieved through templating (we generally care about performing non-virtual calls anyway).
@fsaintjacquesfsaintjacquesMay 10, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@bkietz
bkietzforce-pushed
the
1280-Implement-Fixed-Size-List-type
branch
from
45e309c to
b47e059CompareMay 9, 2019 17:34
pitrou
pitrou
reviewed
May 9, 2019
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Overall this looks good. Still some comments below.
Side question: should support for FixedSizeListType added to ArrayFromJSON? Perhaps as a separate PR?
Comment threadcpp/src/arrow/scalar.cc
Outdated

Comment threadcpp/src/arrow/pretty_print.cc
Outdated

Comment threadcpp/src/arrow/ipc/metadata-internal.cc
Outdated

Comment threadcpp/src/arrow/ipc/json-internal.cc
Outdated

@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might add a simple test for this.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How's this: https://github.com/apache/arrow/pull/4278/files#diff-4e2d1d19217cc5481a51f3aa0b65b38eR193
Comment threadcpp/src/arrow/compare.cc
Outdated

@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if you could dig a bit (or perhaps open a JIRA about this, explaining the issue and/or adding a reproducer).
@bkietzbkietzMay 10, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, this is a bug.
Comment threadcpp/src/arrow/array.cc
Outdated

Comment threadcpp/src/arrow/array.h
Outdated

Comment threadcpp/src/arrow/array.cc
Outdated

Comment threadcpp/src/arrow/array-list-test.cc
Outdated

Comment threadcpp/src/arrow/array-list-test.cc
Outdated

@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, this builds an invalid FixedSizeListArray? No values are appended to the child array.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does build an invalid array, but the point of this test is just to check that the field name is correctly propagated to the built array
@bkietz
bkietz
commented
May 9, 2019

Copy link


Copy Markdown

MemberAuthor
@pitrou Added ArrayFromJSON impl
@bkietz
bkietzforce-pushed
the
1280-Implement-Fixed-Size-List-type
branch
from
78982ab to
80f444fCompareMay 10, 2019 19:50
@pitrou
pitrou
commented
May 13, 2019•

edited

Loading

Copy link


Copy Markdown

Member
@kou There is a meson-related error on Travis-CI, could you advise?

See https://travis-ci.org/apache/arrow/jobs/530907671
@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Looks like there's also a MinGW test failure:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/24461942/job/mper2jipn6kj5bxj
Error: test: csv.gz(TableTest::#save and .load::path:::format::load: auto detect): Arrow::Error::Io: [csv-reader][read]: IOError: zlib inflate failed: invalid distance too far back
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:616:in `invoke'
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:616:in `invoke'
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:533:in `block in define_method'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:158:in `block (2 levels) in load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:147:in `block (2 levels) in wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:140:in `open_encoding_convert_stream'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:146:in `block in wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:125:in `block in open_decompress_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/block-closable.rb:25:in `open'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:124:in `open_decompress_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:145:in `wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:157:in `block in load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/block-closable.rb:25:in `open'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:156:in `load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:39:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:26:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:158:in `load_as_csv'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:50:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:22:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table.rb:27:in `load'
C:/projects/arrow/ruby/red-arrow/test/test-table.rb:503:in `block (5 levels) in <class:TableTest>'

@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Ok, apparently the Travis-CI failure is unrelated:
https://issues.apache.org/jira/browse/ARROW-5306
pitrou
pitrou
approved these changes
May 13, 2019
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@pitrou
pitrouforce-pushed
the
1280-Implement-Fixed-Size-List-type
branch
from
80f444f to
920a251CompareMay 13, 2019 13:25
@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Turns out the MinGW failure was sporadic. Merging.
@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Thanks @bkietz !
@fsaintjacques Integration tests are tracked in https://issues.apache.org/jira/browse/ARROW-1278.
@kou
kou
commented
May 13, 2019

Copy link


Copy Markdown

Member
If the MinGW failure is caused again, I'll look into it.
@bkietzbkietz
mentioned this pull request
May 14, 2019
 Closed

emkornfield pushed a commit
that referenced
this pull request
Jun 14, 2019
@bkietz@emkornfield
ARROW-1278: [Integration] Adding integration tests for fixed_size_list
d20963d
Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in #4278
Author: Benjamin Kietzman <bengilgit@gmail.com>
Closes#4309 from bkietz/1278-integration-tests-for-fixed-size-list and squashes the following commits:
8b356f3 <Benjamin Kietzman> revert removal of ninja-build from dockerfile
e7ed001 <Benjamin Kietzman> fix flake8 error
8ab4efc <Benjamin Kietzman> Adding integration tests for fixed_size_list
@bkietz
bkietz
deleted the

1280-Implement-Fixed-Size-List-type

branch
February 25, 2021 16:10
@asfimportasfimport
mentioned this pull request
May 15, 2019

Closed

pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@bkietz@kou
ARROW-1278: [Integration] Adding integration tests for fixed_size_list
809c18f
Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in apache#4278
Author: Benjamin Kietzman <bengilgit@gmail.com>
Closesapache#4309 from bkietz/1278-integration-tests-for-fixed-size-list and squashes the following commits:
8b356f3 <Benjamin Kietzman> revert removal of ninja-build from dockerfile
e7ed001 <Benjamin Kietzman> fix flake8 error
8ab4efc <Benjamin Kietzman> Adding integration tests for fixed_size_list
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@fsaintjacquesfsaintjacquesfsaintjacques left review comments
@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@bkietz@pitrou@kou@fsaintjacques

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-1280: [C++] add fixed size list type - #4278
Closed
bkietz wants to merge 8 commits into
apache:masterfrom 
bkietz:1280-Implement-Fixed-Size-List-type
Closed
ARROW-1280: [C++] add fixed size list type#4278
bkietz wants to merge 8 commits into
apache:masterfrom 
bkietz:1280-Implement-Fixed-Size-List-type
Conversation
@bkietz
@bkietzbkietz
commented
May 8, 2019

Copy link


Copy Markdown

Member
  • FixedSizeListType, parameterized by the list size (similar to FixedSizeBinaryType), constructed with fixed_size_list(<value field or type>, list_size)
  • FixedSizeListArray, including Equal and pretty print impls
  • FixedSizeListBuilder, works with MakeBuilder
fsaintjacques
fsaintjacques
reviewed
May 9, 2019
View reviewed changes
@fsaintjacquesfsaintjacques
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It think it's worth adding support in the integration tests as Java already support this type:
https://github.com/apache/arrow/blob/master/integration/integration_test.py
Comment threadcpp/src/arrow/array.h
Outdated

@fsaintjacquesfsaintjacquesMay 9, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I prefer the explicit int64_t i as parameter. A bit better for the ABI.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it's independent of index?
@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather remove the argument. Or you can provide two separate overrides. A variadic function looks bizarre here.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allowing it to be called with an argument means I don't have to rewrite pretty-print :)
Comment threadcpp/src/arrow/array.h
Outdated

@fsaintjacquesfsaintjacquesMay 9, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth having common abstract class?
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not much opportunity for code reuse in arrays/builders. The only advantage I can think of would be easier reuse of code which consumes ListArray (but only code which doesn't directly access the offsets buffer). Those algorithms could use ArrayData BasicListArray::GetView(int64_t i) or similar. This seems like speculative generality to me; I'd be more open to doing it if you can think of existing code which would benefit from being refactored this way.
FixedSizeListScalar and ListScalar are identical but also trivial.
@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @bkietz. Also code reuse can be achieved through templating (we generally care about performing non-virtual calls anyway).
@fsaintjacquesfsaintjacquesMay 10, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@bkietz
bkietzforce-pushed
the
1280-Implement-Fixed-Size-List-type
branch
from
45e309c to
b47e059CompareMay 9, 2019 17:34
pitrou
pitrou
reviewed
May 9, 2019
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Overall this looks good. Still some comments below.
Side question: should support for FixedSizeListType added to ArrayFromJSON? Perhaps as a separate PR?
Comment threadcpp/src/arrow/scalar.cc
Outdated

Comment threadcpp/src/arrow/pretty_print.cc
Outdated

Comment threadcpp/src/arrow/ipc/metadata-internal.cc
Outdated

Comment threadcpp/src/arrow/ipc/json-internal.cc
Outdated

@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might add a simple test for this.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How's this: https://github.com/apache/arrow/pull/4278/files#diff-4e2d1d19217cc5481a51f3aa0b65b38eR193
Comment threadcpp/src/arrow/compare.cc
Outdated

@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if you could dig a bit (or perhaps open a JIRA about this, explaining the issue and/or adding a reproducer).
@bkietzbkietzMay 10, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, this is a bug.
Comment threadcpp/src/arrow/array.cc
Outdated

Comment threadcpp/src/arrow/array.h
Outdated

Comment threadcpp/src/arrow/array.cc
Outdated

Comment threadcpp/src/arrow/array-list-test.cc
Outdated

Comment threadcpp/src/arrow/array-list-test.cc
Outdated

@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, this builds an invalid FixedSizeListArray? No values are appended to the child array.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does build an invalid array, but the point of this test is just to check that the field name is correctly propagated to the built array
@bkietz
bkietz
commented
May 9, 2019

Copy link


Copy Markdown

MemberAuthor
@pitrou Added ArrayFromJSON impl
@bkietz
bkietzforce-pushed
the
1280-Implement-Fixed-Size-List-type
branch
from
78982ab to
80f444fCompareMay 10, 2019 19:50
@pitrou
pitrou
commented
May 13, 2019•

edited

Loading

Copy link


Copy Markdown

Member
@kou There is a meson-related error on Travis-CI, could you advise?

See https://travis-ci.org/apache/arrow/jobs/530907671
@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Looks like there's also a MinGW test failure:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/24461942/job/mper2jipn6kj5bxj
Error: test: csv.gz(TableTest::#save and .load::path:::format::load: auto detect): Arrow::Error::Io: [csv-reader][read]: IOError: zlib inflate failed: invalid distance too far back
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:616:in `invoke'
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:616:in `invoke'
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:533:in `block in define_method'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:158:in `block (2 levels) in load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:147:in `block (2 levels) in wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:140:in `open_encoding_convert_stream'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:146:in `block in wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:125:in `block in open_decompress_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/block-closable.rb:25:in `open'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:124:in `open_decompress_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:145:in `wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:157:in `block in load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/block-closable.rb:25:in `open'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:156:in `load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:39:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:26:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:158:in `load_as_csv'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:50:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:22:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table.rb:27:in `load'
C:/projects/arrow/ruby/red-arrow/test/test-table.rb:503:in `block (5 levels) in <class:TableTest>'

@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Ok, apparently the Travis-CI failure is unrelated:
https://issues.apache.org/jira/browse/ARROW-5306
pitrou
pitrou
approved these changes
May 13, 2019
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@pitrou
pitrouforce-pushed
the
1280-Implement-Fixed-Size-List-type
branch
from
80f444f to
920a251CompareMay 13, 2019 13:25
@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Turns out the MinGW failure was sporadic. Merging.
@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Thanks @bkietz !
@fsaintjacques Integration tests are tracked in https://issues.apache.org/jira/browse/ARROW-1278.
@kou
kou
commented
May 13, 2019

Copy link


Copy Markdown

Member
If the MinGW failure is caused again, I'll look into it.
@bkietzbkietz
mentioned this pull request
May 14, 2019
 Closed

emkornfield pushed a commit
that referenced
this pull request
Jun 14, 2019
@bkietz@emkornfield
ARROW-1278: [Integration] Adding integration tests for fixed_size_list
d20963d
Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in #4278
Author: Benjamin Kietzman <bengilgit@gmail.com>
Closes#4309 from bkietz/1278-integration-tests-for-fixed-size-list and squashes the following commits:
8b356f3 <Benjamin Kietzman> revert removal of ninja-build from dockerfile
e7ed001 <Benjamin Kietzman> fix flake8 error
8ab4efc <Benjamin Kietzman> Adding integration tests for fixed_size_list
@bkietz
bkietz
deleted the

1280-Implement-Fixed-Size-List-type

branch
February 25, 2021 16:10
@asfimportasfimport
mentioned this pull request
May 15, 2019

Closed

pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@bkietz@kou
ARROW-1278: [Integration] Adding integration tests for fixed_size_list
809c18f
Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in apache#4278
Author: Benjamin Kietzman <bengilgit@gmail.com>
Closesapache#4309 from bkietz/1278-integration-tests-for-fixed-size-list and squashes the following commits:
8b356f3 <Benjamin Kietzman> revert removal of ninja-build from dockerfile
e7ed001 <Benjamin Kietzman> fix flake8 error
8ab4efc <Benjamin Kietzman> Adding integration tests for fixed_size_list
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@fsaintjacquesfsaintjacquesfsaintjacques left review comments
@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@bkietz@pitrou@kou@fsaintjacques

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-1280: [C++] add fixed size list type - #4278
Closed
bkietz wants to merge 8 commits into
apache:masterfrom 
bkietz:1280-Implement-Fixed-Size-List-type
Closed
ARROW-1280: [C++] add fixed size list type#4278
bkietz wants to merge 8 commits into
apache:masterfrom 
bkietz:1280-Implement-Fixed-Size-List-type
Conversation
@bkietz
@bkietzbkietz
commented
May 8, 2019

Copy link


Copy Markdown

Member
  • FixedSizeListType, parameterized by the list size (similar to FixedSizeBinaryType), constructed with fixed_size_list(<value field or type>, list_size)
  • FixedSizeListArray, including Equal and pretty print impls
  • FixedSizeListBuilder, works with MakeBuilder
fsaintjacques
fsaintjacques
reviewed
May 9, 2019
View reviewed changes
@fsaintjacquesfsaintjacques
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It think it's worth adding support in the integration tests as Java already support this type:
https://github.com/apache/arrow/blob/master/integration/integration_test.py
Comment threadcpp/src/arrow/array.h
Outdated

@fsaintjacquesfsaintjacquesMay 9, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I prefer the explicit int64_t i as parameter. A bit better for the ABI.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it's independent of index?
@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather remove the argument. Or you can provide two separate overrides. A variadic function looks bizarre here.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allowing it to be called with an argument means I don't have to rewrite pretty-print :)
Comment threadcpp/src/arrow/array.h
Outdated

@fsaintjacquesfsaintjacquesMay 9, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth having common abstract class?
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not much opportunity for code reuse in arrays/builders. The only advantage I can think of would be easier reuse of code which consumes ListArray (but only code which doesn't directly access the offsets buffer). Those algorithms could use ArrayData BasicListArray::GetView(int64_t i) or similar. This seems like speculative generality to me; I'd be more open to doing it if you can think of existing code which would benefit from being refactored this way.
FixedSizeListScalar and ListScalar are identical but also trivial.
@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @bkietz. Also code reuse can be achieved through templating (we generally care about performing non-virtual calls anyway).
@fsaintjacquesfsaintjacquesMay 10, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@bkietz
bkietzforce-pushed
the
1280-Implement-Fixed-Size-List-type
branch
from
45e309c to
b47e059CompareMay 9, 2019 17:34
pitrou
pitrou
reviewed
May 9, 2019
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Overall this looks good. Still some comments below.
Side question: should support for FixedSizeListType added to ArrayFromJSON? Perhaps as a separate PR?
Comment threadcpp/src/arrow/scalar.cc
Outdated

Comment threadcpp/src/arrow/pretty_print.cc
Outdated

Comment threadcpp/src/arrow/ipc/metadata-internal.cc
Outdated

Comment threadcpp/src/arrow/ipc/json-internal.cc
Outdated

@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might add a simple test for this.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How's this: https://github.com/apache/arrow/pull/4278/files#diff-4e2d1d19217cc5481a51f3aa0b65b38eR193
Comment threadcpp/src/arrow/compare.cc
Outdated

@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if you could dig a bit (or perhaps open a JIRA about this, explaining the issue and/or adding a reproducer).
@bkietzbkietzMay 10, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, this is a bug.
Comment threadcpp/src/arrow/array.cc
Outdated

Comment threadcpp/src/arrow/array.h
Outdated

Comment threadcpp/src/arrow/array.cc
Outdated

Comment threadcpp/src/arrow/array-list-test.cc
Outdated

Comment threadcpp/src/arrow/array-list-test.cc
Outdated

@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, this builds an invalid FixedSizeListArray? No values are appended to the child array.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does build an invalid array, but the point of this test is just to check that the field name is correctly propagated to the built array
@bkietz
bkietz
commented
May 9, 2019

Copy link


Copy Markdown

MemberAuthor
@pitrou Added ArrayFromJSON impl
@bkietz
bkietzforce-pushed
the
1280-Implement-Fixed-Size-List-type
branch
from
78982ab to
80f444fCompareMay 10, 2019 19:50
@pitrou
pitrou
commented
May 13, 2019•

edited

Loading

Copy link


Copy Markdown

Member
@kou There is a meson-related error on Travis-CI, could you advise?

See https://travis-ci.org/apache/arrow/jobs/530907671
@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Looks like there's also a MinGW test failure:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/24461942/job/mper2jipn6kj5bxj
Error: test: csv.gz(TableTest::#save and .load::path:::format::load: auto detect): Arrow::Error::Io: [csv-reader][read]: IOError: zlib inflate failed: invalid distance too far back
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:616:in `invoke'
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:616:in `invoke'
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:533:in `block in define_method'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:158:in `block (2 levels) in load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:147:in `block (2 levels) in wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:140:in `open_encoding_convert_stream'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:146:in `block in wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:125:in `block in open_decompress_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/block-closable.rb:25:in `open'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:124:in `open_decompress_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:145:in `wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:157:in `block in load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/block-closable.rb:25:in `open'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:156:in `load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:39:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:26:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:158:in `load_as_csv'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:50:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:22:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table.rb:27:in `load'
C:/projects/arrow/ruby/red-arrow/test/test-table.rb:503:in `block (5 levels) in <class:TableTest>'

@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Ok, apparently the Travis-CI failure is unrelated:
https://issues.apache.org/jira/browse/ARROW-5306
pitrou
pitrou
approved these changes
May 13, 2019
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@pitrou
pitrouforce-pushed
the
1280-Implement-Fixed-Size-List-type
branch
from
80f444f to
920a251CompareMay 13, 2019 13:25
@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Turns out the MinGW failure was sporadic. Merging.
@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Thanks @bkietz !
@fsaintjacques Integration tests are tracked in https://issues.apache.org/jira/browse/ARROW-1278.
@kou
kou
commented
May 13, 2019

Copy link


Copy Markdown

Member
If the MinGW failure is caused again, I'll look into it.
@bkietzbkietz
mentioned this pull request
May 14, 2019
 Closed

emkornfield pushed a commit
that referenced
this pull request
Jun 14, 2019
@bkietz@emkornfield
ARROW-1278: [Integration] Adding integration tests for fixed_size_list
d20963d
Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in #4278
Author: Benjamin Kietzman <bengilgit@gmail.com>
Closes#4309 from bkietz/1278-integration-tests-for-fixed-size-list and squashes the following commits:
8b356f3 <Benjamin Kietzman> revert removal of ninja-build from dockerfile
e7ed001 <Benjamin Kietzman> fix flake8 error
8ab4efc <Benjamin Kietzman> Adding integration tests for fixed_size_list
@bkietz
bkietz
deleted the

1280-Implement-Fixed-Size-List-type

branch
February 25, 2021 16:10
@asfimportasfimport
mentioned this pull request
May 15, 2019

Closed

pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@bkietz@kou
ARROW-1278: [Integration] Adding integration tests for fixed_size_list
809c18f
Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in apache#4278
Author: Benjamin Kietzman <bengilgit@gmail.com>
Closesapache#4309 from bkietz/1278-integration-tests-for-fixed-size-list and squashes the following commits:
8b356f3 <Benjamin Kietzman> revert removal of ninja-build from dockerfile
e7ed001 <Benjamin Kietzman> fix flake8 error
8ab4efc <Benjamin Kietzman> Adding integration tests for fixed_size_list
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@fsaintjacquesfsaintjacquesfsaintjacques left review comments
@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@bkietz@pitrou@kou@fsaintjacques

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ARROW-1280: [C++] add fixed size list type - #4278
Closed
bkietz wants to merge 8 commits into
apache:masterfrom 
bkietz:1280-Implement-Fixed-Size-List-type
Closed
ARROW-1280: [C++] add fixed size list type#4278
bkietz wants to merge 8 commits into
apache:masterfrom 
bkietz:1280-Implement-Fixed-Size-List-type
Conversation
@bkietz
@bkietzbkietz
commented
May 8, 2019

Copy link


Copy Markdown

Member
  • FixedSizeListType, parameterized by the list size (similar to FixedSizeBinaryType), constructed with fixed_size_list(<value field or type>, list_size)
  • FixedSizeListArray, including Equal and pretty print impls
  • FixedSizeListBuilder, works with MakeBuilder
fsaintjacques
fsaintjacques
reviewed
May 9, 2019
View reviewed changes
@fsaintjacquesfsaintjacques
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It think it's worth adding support in the integration tests as Java already support this type:
https://github.com/apache/arrow/blob/master/integration/integration_test.py
Comment threadcpp/src/arrow/array.h
Outdated

@fsaintjacquesfsaintjacquesMay 9, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I prefer the explicit int64_t i as parameter. A bit better for the ABI.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it's independent of index?
@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather remove the argument. Or you can provide two separate overrides. A variadic function looks bizarre here.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allowing it to be called with an argument means I don't have to rewrite pretty-print :)
Comment threadcpp/src/arrow/array.h
Outdated

@fsaintjacquesfsaintjacquesMay 9, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth having common abstract class?
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not much opportunity for code reuse in arrays/builders. The only advantage I can think of would be easier reuse of code which consumes ListArray (but only code which doesn't directly access the offsets buffer). Those algorithms could use ArrayData BasicListArray::GetView(int64_t i) or similar. This seems like speculative generality to me; I'd be more open to doing it if you can think of existing code which would benefit from being refactored this way.
FixedSizeListScalar and ListScalar are identical but also trivial.
@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @bkietz. Also code reuse can be achieved through templating (we generally care about performing non-virtual calls anyway).
@fsaintjacquesfsaintjacquesMay 10, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@bkietz
bkietzforce-pushed
the
1280-Implement-Fixed-Size-List-type
branch
from
45e309c to
b47e059CompareMay 9, 2019 17:34
pitrou
pitrou
reviewed
May 9, 2019
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Overall this looks good. Still some comments below.
Side question: should support for FixedSizeListType added to ArrayFromJSON? Perhaps as a separate PR?
Comment threadcpp/src/arrow/scalar.cc
Outdated

Comment threadcpp/src/arrow/pretty_print.cc
Outdated

Comment threadcpp/src/arrow/ipc/metadata-internal.cc
Outdated

Comment threadcpp/src/arrow/ipc/json-internal.cc
Outdated

@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might add a simple test for this.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How's this: https://github.com/apache/arrow/pull/4278/files#diff-4e2d1d19217cc5481a51f3aa0b65b38eR193
Comment threadcpp/src/arrow/compare.cc
Outdated

@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if you could dig a bit (or perhaps open a JIRA about this, explaining the issue and/or adding a reproducer).
@bkietzbkietzMay 10, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, this is a bug.
Comment threadcpp/src/arrow/array.cc
Outdated

Comment threadcpp/src/arrow/array.h
Outdated

Comment threadcpp/src/arrow/array.cc
Outdated

Comment threadcpp/src/arrow/array-list-test.cc
Outdated

Comment threadcpp/src/arrow/array-list-test.cc
Outdated

@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, this builds an invalid FixedSizeListArray? No values are appended to the child array.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does build an invalid array, but the point of this test is just to check that the field name is correctly propagated to the built array
@bkietz
bkietz
commented
May 9, 2019

Copy link


Copy Markdown

MemberAuthor
@pitrou Added ArrayFromJSON impl
@bkietz
bkietzforce-pushed
the
1280-Implement-Fixed-Size-List-type
branch
from
78982ab to
80f444fCompareMay 10, 2019 19:50
@pitrou
pitrou
commented
May 13, 2019•

edited

Loading

Copy link


Copy Markdown

Member
@kou There is a meson-related error on Travis-CI, could you advise?

See https://travis-ci.org/apache/arrow/jobs/530907671
@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Looks like there's also a MinGW test failure:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/24461942/job/mper2jipn6kj5bxj
Error: test: csv.gz(TableTest::#save and .load::path:::format::load: auto detect): Arrow::Error::Io: [csv-reader][read]: IOError: zlib inflate failed: invalid distance too far back
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:616:in `invoke'
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:616:in `invoke'
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:533:in `block in define_method'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:158:in `block (2 levels) in load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:147:in `block (2 levels) in wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:140:in `open_encoding_convert_stream'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:146:in `block in wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:125:in `block in open_decompress_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/block-closable.rb:25:in `open'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:124:in `open_decompress_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:145:in `wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:157:in `block in load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/block-closable.rb:25:in `open'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:156:in `load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:39:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:26:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:158:in `load_as_csv'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:50:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:22:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table.rb:27:in `load'
C:/projects/arrow/ruby/red-arrow/test/test-table.rb:503:in `block (5 levels) in <class:TableTest>'

@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Ok, apparently the Travis-CI failure is unrelated:
https://issues.apache.org/jira/browse/ARROW-5306
pitrou
pitrou
approved these changes
May 13, 2019
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@pitrou
pitrouforce-pushed
the
1280-Implement-Fixed-Size-List-type
branch
from
80f444f to
920a251CompareMay 13, 2019 13:25
@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Turns out the MinGW failure was sporadic. Merging.
@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Thanks @bkietz !
@fsaintjacques Integration tests are tracked in https://issues.apache.org/jira/browse/ARROW-1278.
@kou
kou
commented
May 13, 2019

Copy link


Copy Markdown

Member
If the MinGW failure is caused again, I'll look into it.
@bkietzbkietz
mentioned this pull request
May 14, 2019
 Closed

emkornfield pushed a commit
that referenced
this pull request
Jun 14, 2019
@bkietz@emkornfield
ARROW-1278: [Integration] Adding integration tests for fixed_size_list
d20963d
Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in #4278
Author: Benjamin Kietzman <bengilgit@gmail.com>
Closes#4309 from bkietz/1278-integration-tests-for-fixed-size-list and squashes the following commits:
8b356f3 <Benjamin Kietzman> revert removal of ninja-build from dockerfile
e7ed001 <Benjamin Kietzman> fix flake8 error
8ab4efc <Benjamin Kietzman> Adding integration tests for fixed_size_list
@bkietz
bkietz
deleted the

1280-Implement-Fixed-Size-List-type

branch
February 25, 2021 16:10
@asfimportasfimport
mentioned this pull request
May 15, 2019

Closed

pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@bkietz@kou
ARROW-1278: [Integration] Adding integration tests for fixed_size_list
809c18f
Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in apache#4278
Author: Benjamin Kietzman <bengilgit@gmail.com>
Closesapache#4309 from bkietz/1278-integration-tests-for-fixed-size-list and squashes the following commits:
8b356f3 <Benjamin Kietzman> revert removal of ninja-build from dockerfile
e7ed001 <Benjamin Kietzman> fix flake8 error
8ab4efc <Benjamin Kietzman> Adding integration tests for fixed_size_list
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@fsaintjacquesfsaintjacquesfsaintjacques left review comments
@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@bkietz@pitrou@kou@fsaintjacques

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-1280: [C++] add fixed size list type - #4278
Closed
bkietz wants to merge 8 commits into
apache:masterfrom 
bkietz:1280-Implement-Fixed-Size-List-type
Closed
ARROW-1280: [C++] add fixed size list type#4278
bkietz wants to merge 8 commits into
apache:masterfrom 
bkietz:1280-Implement-Fixed-Size-List-type
Conversation
@bkietz
@bkietzbkietz
commented
May 8, 2019

Copy link


Copy Markdown

Member
  • FixedSizeListType, parameterized by the list size (similar to FixedSizeBinaryType), constructed with fixed_size_list(<value field or type>, list_size)
  • FixedSizeListArray, including Equal and pretty print impls
  • FixedSizeListBuilder, works with MakeBuilder
fsaintjacques
fsaintjacques
reviewed
May 9, 2019
View reviewed changes
@fsaintjacquesfsaintjacques
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It think it's worth adding support in the integration tests as Java already support this type:
https://github.com/apache/arrow/blob/master/integration/integration_test.py
Comment threadcpp/src/arrow/array.h
Outdated

@fsaintjacquesfsaintjacquesMay 9, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I prefer the explicit int64_t i as parameter. A bit better for the ABI.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it's independent of index?
@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather remove the argument. Or you can provide two separate overrides. A variadic function looks bizarre here.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allowing it to be called with an argument means I don't have to rewrite pretty-print :)
Comment threadcpp/src/arrow/array.h
Outdated

@fsaintjacquesfsaintjacquesMay 9, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth having common abstract class?
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not much opportunity for code reuse in arrays/builders. The only advantage I can think of would be easier reuse of code which consumes ListArray (but only code which doesn't directly access the offsets buffer). Those algorithms could use ArrayData BasicListArray::GetView(int64_t i) or similar. This seems like speculative generality to me; I'd be more open to doing it if you can think of existing code which would benefit from being refactored this way.
FixedSizeListScalar and ListScalar are identical but also trivial.
@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @bkietz. Also code reuse can be achieved through templating (we generally care about performing non-virtual calls anyway).
@fsaintjacquesfsaintjacquesMay 10, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@bkietz
bkietzforce-pushed
the
1280-Implement-Fixed-Size-List-type
branch
from
45e309c to
b47e059CompareMay 9, 2019 17:34
pitrou
pitrou
reviewed
May 9, 2019
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Overall this looks good. Still some comments below.
Side question: should support for FixedSizeListType added to ArrayFromJSON? Perhaps as a separate PR?
Comment threadcpp/src/arrow/scalar.cc
Outdated

Comment threadcpp/src/arrow/pretty_print.cc
Outdated

Comment threadcpp/src/arrow/ipc/metadata-internal.cc
Outdated

Comment threadcpp/src/arrow/ipc/json-internal.cc
Outdated

@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might add a simple test for this.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How's this: https://github.com/apache/arrow/pull/4278/files#diff-4e2d1d19217cc5481a51f3aa0b65b38eR193
Comment threadcpp/src/arrow/compare.cc
Outdated

@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if you could dig a bit (or perhaps open a JIRA about this, explaining the issue and/or adding a reproducer).
@bkietzbkietzMay 10, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, this is a bug.
Comment threadcpp/src/arrow/array.cc
Outdated

Comment threadcpp/src/arrow/array.h
Outdated

Comment threadcpp/src/arrow/array.cc
Outdated

Comment threadcpp/src/arrow/array-list-test.cc
Outdated

Comment threadcpp/src/arrow/array-list-test.cc
Outdated

@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, this builds an invalid FixedSizeListArray? No values are appended to the child array.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does build an invalid array, but the point of this test is just to check that the field name is correctly propagated to the built array
@bkietz
bkietz
commented
May 9, 2019

Copy link


Copy Markdown

MemberAuthor
@pitrou Added ArrayFromJSON impl
@bkietz
bkietzforce-pushed
the
1280-Implement-Fixed-Size-List-type
branch
from
78982ab to
80f444fCompareMay 10, 2019 19:50
@pitrou
pitrou
commented
May 13, 2019•

edited

Loading

Copy link


Copy Markdown

Member
@kou There is a meson-related error on Travis-CI, could you advise?

See https://travis-ci.org/apache/arrow/jobs/530907671
@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Looks like there's also a MinGW test failure:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/24461942/job/mper2jipn6kj5bxj
Error: test: csv.gz(TableTest::#save and .load::path:::format::load: auto detect): Arrow::Error::Io: [csv-reader][read]: IOError: zlib inflate failed: invalid distance too far back
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:616:in `invoke'
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:616:in `invoke'
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:533:in `block in define_method'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:158:in `block (2 levels) in load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:147:in `block (2 levels) in wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:140:in `open_encoding_convert_stream'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:146:in `block in wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:125:in `block in open_decompress_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/block-closable.rb:25:in `open'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:124:in `open_decompress_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:145:in `wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:157:in `block in load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/block-closable.rb:25:in `open'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:156:in `load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:39:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:26:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:158:in `load_as_csv'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:50:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:22:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table.rb:27:in `load'
C:/projects/arrow/ruby/red-arrow/test/test-table.rb:503:in `block (5 levels) in <class:TableTest>'

@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Ok, apparently the Travis-CI failure is unrelated:
https://issues.apache.org/jira/browse/ARROW-5306
pitrou
pitrou
approved these changes
May 13, 2019
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@pitrou
pitrouforce-pushed
the
1280-Implement-Fixed-Size-List-type
branch
from
80f444f to
920a251CompareMay 13, 2019 13:25
@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Turns out the MinGW failure was sporadic. Merging.
@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Thanks @bkietz !
@fsaintjacques Integration tests are tracked in https://issues.apache.org/jira/browse/ARROW-1278.
@kou
kou
commented
May 13, 2019

Copy link


Copy Markdown

Member
If the MinGW failure is caused again, I'll look into it.
@bkietzbkietz
mentioned this pull request
May 14, 2019
 Closed

emkornfield pushed a commit
that referenced
this pull request
Jun 14, 2019
@bkietz@emkornfield
ARROW-1278: [Integration] Adding integration tests for fixed_size_list
d20963d
Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in #4278
Author: Benjamin Kietzman <bengilgit@gmail.com>
Closes#4309 from bkietz/1278-integration-tests-for-fixed-size-list and squashes the following commits:
8b356f3 <Benjamin Kietzman> revert removal of ninja-build from dockerfile
e7ed001 <Benjamin Kietzman> fix flake8 error
8ab4efc <Benjamin Kietzman> Adding integration tests for fixed_size_list
@bkietz
bkietz
deleted the

1280-Implement-Fixed-Size-List-type

branch
February 25, 2021 16:10
@asfimportasfimport
mentioned this pull request
May 15, 2019

Closed

pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@bkietz@kou
ARROW-1278: [Integration] Adding integration tests for fixed_size_list
809c18f
Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in apache#4278
Author: Benjamin Kietzman <bengilgit@gmail.com>
Closesapache#4309 from bkietz/1278-integration-tests-for-fixed-size-list and squashes the following commits:
8b356f3 <Benjamin Kietzman> revert removal of ninja-build from dockerfile
e7ed001 <Benjamin Kietzman> fix flake8 error
8ab4efc <Benjamin Kietzman> Adding integration tests for fixed_size_list
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@fsaintjacquesfsaintjacquesfsaintjacques left review comments
@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@bkietz@pitrou@kou@fsaintjacques

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-1280: [C++] add fixed size list type - #4278
Closed
bkietz wants to merge 8 commits into
apache:masterfrom 
bkietz:1280-Implement-Fixed-Size-List-type
Closed
ARROW-1280: [C++] add fixed size list type#4278
bkietz wants to merge 8 commits into
apache:masterfrom 
bkietz:1280-Implement-Fixed-Size-List-type
Conversation
@bkietz
@bkietzbkietz
commented
May 8, 2019

Copy link


Copy Markdown

Member
  • FixedSizeListType, parameterized by the list size (similar to FixedSizeBinaryType), constructed with fixed_size_list(<value field or type>, list_size)
  • FixedSizeListArray, including Equal and pretty print impls
  • FixedSizeListBuilder, works with MakeBuilder
fsaintjacques
fsaintjacques
reviewed
May 9, 2019
View reviewed changes
@fsaintjacquesfsaintjacques
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It think it's worth adding support in the integration tests as Java already support this type:
https://github.com/apache/arrow/blob/master/integration/integration_test.py
Comment threadcpp/src/arrow/array.h
Outdated

@fsaintjacquesfsaintjacquesMay 9, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I prefer the explicit int64_t i as parameter. A bit better for the ABI.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it's independent of index?
@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather remove the argument. Or you can provide two separate overrides. A variadic function looks bizarre here.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allowing it to be called with an argument means I don't have to rewrite pretty-print :)
Comment threadcpp/src/arrow/array.h
Outdated

@fsaintjacquesfsaintjacquesMay 9, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth having common abstract class?
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not much opportunity for code reuse in arrays/builders. The only advantage I can think of would be easier reuse of code which consumes ListArray (but only code which doesn't directly access the offsets buffer). Those algorithms could use ArrayData BasicListArray::GetView(int64_t i) or similar. This seems like speculative generality to me; I'd be more open to doing it if you can think of existing code which would benefit from being refactored this way.
FixedSizeListScalar and ListScalar are identical but also trivial.
@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @bkietz. Also code reuse can be achieved through templating (we generally care about performing non-virtual calls anyway).
@fsaintjacquesfsaintjacquesMay 10, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@bkietz
bkietzforce-pushed
the
1280-Implement-Fixed-Size-List-type
branch
from
45e309c to
b47e059CompareMay 9, 2019 17:34
pitrou
pitrou
reviewed
May 9, 2019
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Overall this looks good. Still some comments below.
Side question: should support for FixedSizeListType added to ArrayFromJSON? Perhaps as a separate PR?
Comment threadcpp/src/arrow/scalar.cc
Outdated

Comment threadcpp/src/arrow/pretty_print.cc
Outdated

Comment threadcpp/src/arrow/ipc/metadata-internal.cc
Outdated

Comment threadcpp/src/arrow/ipc/json-internal.cc
Outdated

@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might add a simple test for this.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How's this: https://github.com/apache/arrow/pull/4278/files#diff-4e2d1d19217cc5481a51f3aa0b65b38eR193
Comment threadcpp/src/arrow/compare.cc
Outdated

@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if you could dig a bit (or perhaps open a JIRA about this, explaining the issue and/or adding a reproducer).
@bkietzbkietzMay 10, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, this is a bug.
Comment threadcpp/src/arrow/array.cc
Outdated

Comment threadcpp/src/arrow/array.h
Outdated

Comment threadcpp/src/arrow/array.cc
Outdated

Comment threadcpp/src/arrow/array-list-test.cc
Outdated

Comment threadcpp/src/arrow/array-list-test.cc
Outdated

@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, this builds an invalid FixedSizeListArray? No values are appended to the child array.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does build an invalid array, but the point of this test is just to check that the field name is correctly propagated to the built array
@bkietz
bkietz
commented
May 9, 2019

Copy link


Copy Markdown

MemberAuthor
@pitrou Added ArrayFromJSON impl
@bkietz
bkietzforce-pushed
the
1280-Implement-Fixed-Size-List-type
branch
from
78982ab to
80f444fCompareMay 10, 2019 19:50
@pitrou
pitrou
commented
May 13, 2019•

edited

Loading

Copy link


Copy Markdown

Member
@kou There is a meson-related error on Travis-CI, could you advise?

See https://travis-ci.org/apache/arrow/jobs/530907671
@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Looks like there's also a MinGW test failure:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/24461942/job/mper2jipn6kj5bxj
Error: test: csv.gz(TableTest::#save and .load::path:::format::load: auto detect): Arrow::Error::Io: [csv-reader][read]: IOError: zlib inflate failed: invalid distance too far back
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:616:in `invoke'
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:616:in `invoke'
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:533:in `block in define_method'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:158:in `block (2 levels) in load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:147:in `block (2 levels) in wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:140:in `open_encoding_convert_stream'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:146:in `block in wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:125:in `block in open_decompress_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/block-closable.rb:25:in `open'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:124:in `open_decompress_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:145:in `wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:157:in `block in load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/block-closable.rb:25:in `open'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:156:in `load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:39:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:26:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:158:in `load_as_csv'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:50:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:22:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table.rb:27:in `load'
C:/projects/arrow/ruby/red-arrow/test/test-table.rb:503:in `block (5 levels) in <class:TableTest>'

@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Ok, apparently the Travis-CI failure is unrelated:
https://issues.apache.org/jira/browse/ARROW-5306
pitrou
pitrou
approved these changes
May 13, 2019
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@pitrou
pitrouforce-pushed
the
1280-Implement-Fixed-Size-List-type
branch
from
80f444f to
920a251CompareMay 13, 2019 13:25
@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Turns out the MinGW failure was sporadic. Merging.
@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Thanks @bkietz !
@fsaintjacques Integration tests are tracked in https://issues.apache.org/jira/browse/ARROW-1278.
@kou
kou
commented
May 13, 2019

Copy link


Copy Markdown

Member
If the MinGW failure is caused again, I'll look into it.
@bkietzbkietz
mentioned this pull request
May 14, 2019
 Closed

emkornfield pushed a commit
that referenced
this pull request
Jun 14, 2019
@bkietz@emkornfield
ARROW-1278: [Integration] Adding integration tests for fixed_size_list
d20963d
Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in #4278
Author: Benjamin Kietzman <bengilgit@gmail.com>
Closes#4309 from bkietz/1278-integration-tests-for-fixed-size-list and squashes the following commits:
8b356f3 <Benjamin Kietzman> revert removal of ninja-build from dockerfile
e7ed001 <Benjamin Kietzman> fix flake8 error
8ab4efc <Benjamin Kietzman> Adding integration tests for fixed_size_list
@bkietz
bkietz
deleted the

1280-Implement-Fixed-Size-List-type

branch
February 25, 2021 16:10
@asfimportasfimport
mentioned this pull request
May 15, 2019

Closed

pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@bkietz@kou
ARROW-1278: [Integration] Adding integration tests for fixed_size_list
809c18f
Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in apache#4278
Author: Benjamin Kietzman <bengilgit@gmail.com>
Closesapache#4309 from bkietz/1278-integration-tests-for-fixed-size-list and squashes the following commits:
8b356f3 <Benjamin Kietzman> revert removal of ninja-build from dockerfile
e7ed001 <Benjamin Kietzman> fix flake8 error
8ab4efc <Benjamin Kietzman> Adding integration tests for fixed_size_list
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@fsaintjacquesfsaintjacquesfsaintjacques left review comments
@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@bkietz@pitrou@kou@fsaintjacques

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ARROW-1280: [C++] add fixed size list type - #4278
Closed
bkietz wants to merge 8 commits into
apache:masterfrom 
bkietz:1280-Implement-Fixed-Size-List-type
Closed
ARROW-1280: [C++] add fixed size list type#4278
bkietz wants to merge 8 commits into
apache:masterfrom 
bkietz:1280-Implement-Fixed-Size-List-type
Conversation
@bkietz
@bkietzbkietz
commented
May 8, 2019

Copy link


Copy Markdown

Member
  • FixedSizeListType, parameterized by the list size (similar to FixedSizeBinaryType), constructed with fixed_size_list(<value field or type>, list_size)
  • FixedSizeListArray, including Equal and pretty print impls
  • FixedSizeListBuilder, works with MakeBuilder
fsaintjacques
fsaintjacques
reviewed
May 9, 2019
View reviewed changes
@fsaintjacquesfsaintjacques
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It think it's worth adding support in the integration tests as Java already support this type:
https://github.com/apache/arrow/blob/master/integration/integration_test.py
Comment threadcpp/src/arrow/array.h
Outdated

@fsaintjacquesfsaintjacquesMay 9, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I prefer the explicit int64_t i as parameter. A bit better for the ABI.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it's independent of index?
@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather remove the argument. Or you can provide two separate overrides. A variadic function looks bizarre here.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allowing it to be called with an argument means I don't have to rewrite pretty-print :)
Comment threadcpp/src/arrow/array.h
Outdated

@fsaintjacquesfsaintjacquesMay 9, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth having common abstract class?
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not much opportunity for code reuse in arrays/builders. The only advantage I can think of would be easier reuse of code which consumes ListArray (but only code which doesn't directly access the offsets buffer). Those algorithms could use ArrayData BasicListArray::GetView(int64_t i) or similar. This seems like speculative generality to me; I'd be more open to doing it if you can think of existing code which would benefit from being refactored this way.
FixedSizeListScalar and ListScalar are identical but also trivial.
@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @bkietz. Also code reuse can be achieved through templating (we generally care about performing non-virtual calls anyway).
@fsaintjacquesfsaintjacquesMay 10, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@bkietz
bkietzforce-pushed
the
1280-Implement-Fixed-Size-List-type
branch
from
45e309c to
b47e059CompareMay 9, 2019 17:34
pitrou
pitrou
reviewed
May 9, 2019
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Overall this looks good. Still some comments below.
Side question: should support for FixedSizeListType added to ArrayFromJSON? Perhaps as a separate PR?
Comment threadcpp/src/arrow/scalar.cc
Outdated

Comment threadcpp/src/arrow/pretty_print.cc
Outdated

Comment threadcpp/src/arrow/ipc/metadata-internal.cc
Outdated

Comment threadcpp/src/arrow/ipc/json-internal.cc
Outdated

@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might add a simple test for this.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How's this: https://github.com/apache/arrow/pull/4278/files#diff-4e2d1d19217cc5481a51f3aa0b65b38eR193
Comment threadcpp/src/arrow/compare.cc
Outdated

@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if you could dig a bit (or perhaps open a JIRA about this, explaining the issue and/or adding a reproducer).
@bkietzbkietzMay 10, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, this is a bug.
Comment threadcpp/src/arrow/array.cc
Outdated

Comment threadcpp/src/arrow/array.h
Outdated

Comment threadcpp/src/arrow/array.cc
Outdated

Comment threadcpp/src/arrow/array-list-test.cc
Outdated

Comment threadcpp/src/arrow/array-list-test.cc
Outdated

@pitroupitrouMay 9, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, this builds an invalid FixedSizeListArray? No values are appended to the child array.
@bkietzbkietzMay 9, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does build an invalid array, but the point of this test is just to check that the field name is correctly propagated to the built array
@bkietz
bkietz
commented
May 9, 2019

Copy link


Copy Markdown

MemberAuthor
@pitrou Added ArrayFromJSON impl
@bkietz
bkietzforce-pushed
the
1280-Implement-Fixed-Size-List-type
branch
from
78982ab to
80f444fCompareMay 10, 2019 19:50
@pitrou
pitrou
commented
May 13, 2019•

edited

Loading

Copy link


Copy Markdown

Member
@kou There is a meson-related error on Travis-CI, could you advise?

See https://travis-ci.org/apache/arrow/jobs/530907671
@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Looks like there's also a MinGW test failure:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/24461942/job/mper2jipn6kj5bxj
Error: test: csv.gz(TableTest::#save and .load::path:::format::load: auto detect): Arrow::Error::Io: [csv-reader][read]: IOError: zlib inflate failed: invalid distance too far back
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:616:in `invoke'
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:616:in `invoke'
c:/Ruby26/lib/ruby/gems/2.6.0/gems/gobject-introspection-3.3.6/lib/gobject-introspection/loader.rb:533:in `block in define_method'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:158:in `block (2 levels) in load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:147:in `block (2 levels) in wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:140:in `open_encoding_convert_stream'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:146:in `block in wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:125:in `block in open_decompress_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/block-closable.rb:25:in `open'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:124:in `open_decompress_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:145:in `wrap_input'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:157:in `block in load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/block-closable.rb:25:in `open'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:156:in `load_from_path'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:39:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/csv-loader.rb:26:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:158:in `load_as_csv'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:50:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table-loader.rb:22:in `load'
C:/projects/arrow/ruby/red-arrow/lib/arrow/table.rb:27:in `load'
C:/projects/arrow/ruby/red-arrow/test/test-table.rb:503:in `block (5 levels) in <class:TableTest>'

@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Ok, apparently the Travis-CI failure is unrelated:
https://issues.apache.org/jira/browse/ARROW-5306
pitrou
pitrou
approved these changes
May 13, 2019
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@pitrou
pitrouforce-pushed
the
1280-Implement-Fixed-Size-List-type
branch
from
80f444f to
920a251CompareMay 13, 2019 13:25
@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Turns out the MinGW failure was sporadic. Merging.
@pitrou
pitrou
commented
May 13, 2019

Copy link


Copy Markdown

Member
Thanks @bkietz !
@fsaintjacques Integration tests are tracked in https://issues.apache.org/jira/browse/ARROW-1278.
@kou
kou
commented
May 13, 2019

Copy link


Copy Markdown

Member
If the MinGW failure is caused again, I'll look into it.
@bkietzbkietz
mentioned this pull request
May 14, 2019
 Closed

emkornfield pushed a commit
that referenced
this pull request
Jun 14, 2019
@bkietz@emkornfield
ARROW-1278: [Integration] Adding integration tests for fixed_size_list
d20963d
Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in #4278
Author: Benjamin Kietzman <bengilgit@gmail.com>
Closes#4309 from bkietz/1278-integration-tests-for-fixed-size-list and squashes the following commits:
8b356f3 <Benjamin Kietzman> revert removal of ninja-build from dockerfile
e7ed001 <Benjamin Kietzman> fix flake8 error
8ab4efc <Benjamin Kietzman> Adding integration tests for fixed_size_list
@bkietz
bkietz
deleted the

1280-Implement-Fixed-Size-List-type

branch
February 25, 2021 16:10
@asfimportasfimport
mentioned this pull request
May 15, 2019

Closed

pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@bkietz@kou
ARROW-1278: [Integration] Adding integration tests for fixed_size_list
809c18f
Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in apache#4278
Author: Benjamin Kietzman <bengilgit@gmail.com>
Closesapache#4309 from bkietz/1278-integration-tests-for-fixed-size-list and squashes the following commits:
8b356f3 <Benjamin Kietzman> revert removal of ninja-build from dockerfile
e7ed001 <Benjamin Kietzman> fix flake8 error
8ab4efc <Benjamin Kietzman> Adding integration tests for fixed_size_list
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@fsaintjacquesfsaintjacquesfsaintjacques left review comments
@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@bkietz@pitrou@kou@fsaintjacques