ARROW-1278: [Integration] Adding integration tests for fixed_size_list

[bkietz]

Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in #4278

[codecov-io]

Codecov Report

Merging #4309 into master will increase coverage by 0.42%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #4309 +/- ##
==========================================
+ Coverage 88.54% 88.97% +0.42% 
==========================================
Files 796 704 -92 Lines 103206 94725 -8481 Branches 1253 0 -1253 ==========================================
- Hits 91388 84277 -7111 + Misses 11573 10448 -1125 + Partials 245 0 -245

Impacted Files	Coverage Δ
cpp/src/arrow/ipc/writer.cc	93.04% <0%> (-1.15%)	⬇️
cpp/src/arrow/vendored/datetime/date.h	26.35% <0%> (-4.28%)	⬇️
cpp/src/plasma/thirdparty/ae/ae.c	70.75% <0%> (-0.95%)	⬇️
cpp/src/arrow/python/arrow_to_pandas.cc	91.55% <0%> (-0.04%)	⬇️
cpp/src/arrow/pretty_print.cc	83.18% <0%> (ø)	⬆️
cpp/src/arrow/vendored/datetime/tz.h	43.47% <0%> (ø)	⬆️
cpp/src/arrow/vendored/datetime/tz_private.h	33.33% <0%> (ø)	⬆️
cpp/src/gandiva/precompiled/epoch_time_point.h	100% <0%> (ø)	⬆️
cpp/src/arrow/pretty_print-test.cc	100% <0%> (ø)	⬆️
cpp/src/arrow/python/python-test.cc	100% <0%> (ø)	⬆️
... and 219 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c42f7...8b356f3. Read the comment docs.

[bkietz]

waiting for #4316 to be merged

[wesm]

Is it expected for the integration tests to pass (there is support in Java for reading these?)?

[bkietz]

It seems like there is support: https://github.com/apache/arrow/blob/master/java/vector/src/test/java/org/apache/arrow/vector/ipc/TestArrowFile.java#L623

I'd need to spend more time figuring out exactly which java code is exercised by integration_test.py

[wesm]

I just poked around the Java codebase. It seems it may work by accident, but it is not tested

[emkornfield]

@bkietz what are the next steps here, do you need help with something on the Java side?

[bkietz]

@emkornfield I have investigated the fixed size list tests. They're spare but present so I think we should merge this and add a JIRA to test fixed size list more thoroughly in Java.

[emkornfield]

@bkietz sounds good, can you rebase?

[bkietz]

@emkornfield rebased and green except for a coredump in test_csv (I don't think that was me)

[emkornfield]

why this change?

[bkietz]

@emkornfield ninja is installed in ci/conda_env_cpp.yml so isn't this unused?

[emkornfield]

@bkietz one small question about a change to docker file. Otherwise LGTM

[emkornfield]

@bkietz potentially not an expert on docker stuff, so I'd prefer cleanup as a separate PR

[bkietz]

@emkornfield reverted and green

[emkornfield]

+1 LGTM, please file a JIRA for the follow-up work.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.97%. Comparing base (24c42f7) to head (8b356f3).

Files with missing lines	Patch %	Lines
cpp/src/arrow/ipc/writer.cc	0.00%	7 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #4309 +/- ##
==========================================
+ Coverage 88.54% 88.97% +0.42% 
==========================================
Files 796 704 -92 Lines 103206 94725 -8481 Branches 1253 0 -1253 ==========================================
- Hits 91388 84277 -7111 + Misses 11573 10448 -1125 + Partials 245 0 -245 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bkietz]

Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in #4278

[codecov-io]

Codecov Report

Merging #4309 into master will increase coverage by 0.42%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #4309 +/- ##
==========================================
+ Coverage 88.54% 88.97% +0.42% 
==========================================
Files 796 704 -92 Lines 103206 94725 -8481 Branches 1253 0 -1253 ==========================================
- Hits 91388 84277 -7111 + Misses 11573 10448 -1125 + Partials 245 0 -245

Impacted Files	Coverage Δ
cpp/src/arrow/ipc/writer.cc	93.04% <0%> (-1.15%)	⬇️
cpp/src/arrow/vendored/datetime/date.h	26.35% <0%> (-4.28%)	⬇️
cpp/src/plasma/thirdparty/ae/ae.c	70.75% <0%> (-0.95%)	⬇️
cpp/src/arrow/python/arrow_to_pandas.cc	91.55% <0%> (-0.04%)	⬇️
cpp/src/arrow/pretty_print.cc	83.18% <0%> (ø)	⬆️
cpp/src/arrow/vendored/datetime/tz.h	43.47% <0%> (ø)	⬆️
cpp/src/arrow/vendored/datetime/tz_private.h	33.33% <0%> (ø)	⬆️
cpp/src/gandiva/precompiled/epoch_time_point.h	100% <0%> (ø)	⬆️
cpp/src/arrow/pretty_print-test.cc	100% <0%> (ø)	⬆️
cpp/src/arrow/python/python-test.cc	100% <0%> (ø)	⬆️
... and 219 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c42f7...8b356f3. Read the comment docs.

[bkietz]

waiting for #4316 to be merged

[wesm]

Is it expected for the integration tests to pass (there is support in Java for reading these?)?

[bkietz]

It seems like there is support: https://github.com/apache/arrow/blob/master/java/vector/src/test/java/org/apache/arrow/vector/ipc/TestArrowFile.java#L623

I'd need to spend more time figuring out exactly which java code is exercised by integration_test.py

[wesm]

I just poked around the Java codebase. It seems it may work by accident, but it is not tested

[emkornfield]

@bkietz what are the next steps here, do you need help with something on the Java side?

[bkietz]

@emkornfield I have investigated the fixed size list tests. They're spare but present so I think we should merge this and add a JIRA to test fixed size list more thoroughly in Java.

[emkornfield]

@bkietz sounds good, can you rebase?

[bkietz]

@emkornfield rebased and green except for a coredump in test_csv (I don't think that was me)

[emkornfield]

why this change?

[bkietz]

@emkornfield ninja is installed in ci/conda_env_cpp.yml so isn't this unused?

[emkornfield]

@bkietz one small question about a change to docker file. Otherwise LGTM

[emkornfield]

@bkietz potentially not an expert on docker stuff, so I'd prefer cleanup as a separate PR

[bkietz]

@emkornfield reverted and green

[emkornfield]

+1 LGTM, please file a JIRA for the follow-up work.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.97%. Comparing base (24c42f7) to head (8b356f3).

Files with missing lines	Patch %	Lines
cpp/src/arrow/ipc/writer.cc	0.00%	7 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #4309 +/- ##
==========================================
+ Coverage 88.54% 88.97% +0.42% 
==========================================
Files 796 704 -92 Lines 103206 94725 -8481 Branches 1253 0 -1253 ==========================================
- Hits 91388 84277 -7111 + Misses 11573 10448 -1125 + Partials 245 0 -245 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bkietz]

Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in #4278

[codecov-io]

Codecov Report

Merging #4309 into master will increase coverage by 0.42%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #4309 +/- ##
==========================================
+ Coverage 88.54% 88.97% +0.42% 
==========================================
Files 796 704 -92 Lines 103206 94725 -8481 Branches 1253 0 -1253 ==========================================
- Hits 91388 84277 -7111 + Misses 11573 10448 -1125 + Partials 245 0 -245

Impacted Files	Coverage Δ
cpp/src/arrow/ipc/writer.cc	93.04% <0%> (-1.15%)	⬇️
cpp/src/arrow/vendored/datetime/date.h	26.35% <0%> (-4.28%)	⬇️
cpp/src/plasma/thirdparty/ae/ae.c	70.75% <0%> (-0.95%)	⬇️
cpp/src/arrow/python/arrow_to_pandas.cc	91.55% <0%> (-0.04%)	⬇️
cpp/src/arrow/pretty_print.cc	83.18% <0%> (ø)	⬆️
cpp/src/arrow/vendored/datetime/tz.h	43.47% <0%> (ø)	⬆️
cpp/src/arrow/vendored/datetime/tz_private.h	33.33% <0%> (ø)	⬆️
cpp/src/gandiva/precompiled/epoch_time_point.h	100% <0%> (ø)	⬆️
cpp/src/arrow/pretty_print-test.cc	100% <0%> (ø)	⬆️
cpp/src/arrow/python/python-test.cc	100% <0%> (ø)	⬆️
... and 219 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c42f7...8b356f3. Read the comment docs.

[bkietz]

waiting for #4316 to be merged

[wesm]

Is it expected for the integration tests to pass (there is support in Java for reading these?)?

[bkietz]

It seems like there is support: https://github.com/apache/arrow/blob/master/java/vector/src/test/java/org/apache/arrow/vector/ipc/TestArrowFile.java#L623

I'd need to spend more time figuring out exactly which java code is exercised by integration_test.py

[wesm]

I just poked around the Java codebase. It seems it may work by accident, but it is not tested

[emkornfield]

@bkietz what are the next steps here, do you need help with something on the Java side?

[bkietz]

@emkornfield I have investigated the fixed size list tests. They're spare but present so I think we should merge this and add a JIRA to test fixed size list more thoroughly in Java.

[emkornfield]

@bkietz sounds good, can you rebase?

[bkietz]

@emkornfield rebased and green except for a coredump in test_csv (I don't think that was me)

[emkornfield]

why this change?

[bkietz]

@emkornfield ninja is installed in ci/conda_env_cpp.yml so isn't this unused?

[emkornfield]

@bkietz one small question about a change to docker file. Otherwise LGTM

[emkornfield]

@bkietz potentially not an expert on docker stuff, so I'd prefer cleanup as a separate PR

[bkietz]

@emkornfield reverted and green

[emkornfield]

+1 LGTM, please file a JIRA for the follow-up work.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.97%. Comparing base (24c42f7) to head (8b356f3).

Files with missing lines	Patch %	Lines
cpp/src/arrow/ipc/writer.cc	0.00%	7 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #4309 +/- ##
==========================================
+ Coverage 88.54% 88.97% +0.42% 
==========================================
Files 796 704 -92 Lines 103206 94725 -8481 Branches 1253 0 -1253 ==========================================
- Hits 91388 84277 -7111 + Misses 11573 10448 -1125 + Partials 245 0 -245 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bkietz]

Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in #4278

[codecov-io]

Codecov Report

Merging #4309 into master will increase coverage by 0.42%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #4309 +/- ##
==========================================
+ Coverage 88.54% 88.97% +0.42% 
==========================================
Files 796 704 -92 Lines 103206 94725 -8481 Branches 1253 0 -1253 ==========================================
- Hits 91388 84277 -7111 + Misses 11573 10448 -1125 + Partials 245 0 -245

Impacted Files	Coverage Δ
cpp/src/arrow/ipc/writer.cc	93.04% <0%> (-1.15%)	⬇️
cpp/src/arrow/vendored/datetime/date.h	26.35% <0%> (-4.28%)	⬇️
cpp/src/plasma/thirdparty/ae/ae.c	70.75% <0%> (-0.95%)	⬇️
cpp/src/arrow/python/arrow_to_pandas.cc	91.55% <0%> (-0.04%)	⬇️
cpp/src/arrow/pretty_print.cc	83.18% <0%> (ø)	⬆️
cpp/src/arrow/vendored/datetime/tz.h	43.47% <0%> (ø)	⬆️
cpp/src/arrow/vendored/datetime/tz_private.h	33.33% <0%> (ø)	⬆️
cpp/src/gandiva/precompiled/epoch_time_point.h	100% <0%> (ø)	⬆️
cpp/src/arrow/pretty_print-test.cc	100% <0%> (ø)	⬆️
cpp/src/arrow/python/python-test.cc	100% <0%> (ø)	⬆️
... and 219 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c42f7...8b356f3. Read the comment docs.

[bkietz]

waiting for #4316 to be merged

[wesm]

Is it expected for the integration tests to pass (there is support in Java for reading these?)?

[bkietz]

It seems like there is support: https://github.com/apache/arrow/blob/master/java/vector/src/test/java/org/apache/arrow/vector/ipc/TestArrowFile.java#L623

I'd need to spend more time figuring out exactly which java code is exercised by integration_test.py

[wesm]

I just poked around the Java codebase. It seems it may work by accident, but it is not tested

[emkornfield]

@bkietz what are the next steps here, do you need help with something on the Java side?

[bkietz]

@emkornfield I have investigated the fixed size list tests. They're spare but present so I think we should merge this and add a JIRA to test fixed size list more thoroughly in Java.

[emkornfield]

@bkietz sounds good, can you rebase?

[bkietz]

@emkornfield rebased and green except for a coredump in test_csv (I don't think that was me)

[emkornfield]

why this change?

[bkietz]

@emkornfield ninja is installed in ci/conda_env_cpp.yml so isn't this unused?

[emkornfield]

@bkietz one small question about a change to docker file. Otherwise LGTM

[emkornfield]

@bkietz potentially not an expert on docker stuff, so I'd prefer cleanup as a separate PR

[bkietz]

@emkornfield reverted and green

[emkornfield]

+1 LGTM, please file a JIRA for the follow-up work.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.97%. Comparing base (24c42f7) to head (8b356f3).

Files with missing lines	Patch %	Lines
cpp/src/arrow/ipc/writer.cc	0.00%	7 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #4309 +/- ##
==========================================
+ Coverage 88.54% 88.97% +0.42% 
==========================================
Files 796 704 -92 Lines 103206 94725 -8481 Branches 1253 0 -1253 ==========================================
- Hits 91388 84277 -7111 + Misses 11573 10448 -1125 + Partials 245 0 -245 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bkietz]

Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in #4278

[codecov-io]

Codecov Report

Merging #4309 into master will increase coverage by 0.42%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #4309 +/- ##
==========================================
+ Coverage 88.54% 88.97% +0.42% 
==========================================
Files 796 704 -92 Lines 103206 94725 -8481 Branches 1253 0 -1253 ==========================================
- Hits 91388 84277 -7111 + Misses 11573 10448 -1125 + Partials 245 0 -245

Impacted Files	Coverage Δ
cpp/src/arrow/ipc/writer.cc	93.04% <0%> (-1.15%)	⬇️
cpp/src/arrow/vendored/datetime/date.h	26.35% <0%> (-4.28%)	⬇️
cpp/src/plasma/thirdparty/ae/ae.c	70.75% <0%> (-0.95%)	⬇️
cpp/src/arrow/python/arrow_to_pandas.cc	91.55% <0%> (-0.04%)	⬇️
cpp/src/arrow/pretty_print.cc	83.18% <0%> (ø)	⬆️
cpp/src/arrow/vendored/datetime/tz.h	43.47% <0%> (ø)	⬆️
cpp/src/arrow/vendored/datetime/tz_private.h	33.33% <0%> (ø)	⬆️
cpp/src/gandiva/precompiled/epoch_time_point.h	100% <0%> (ø)	⬆️
cpp/src/arrow/pretty_print-test.cc	100% <0%> (ø)	⬆️
cpp/src/arrow/python/python-test.cc	100% <0%> (ø)	⬆️
... and 219 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c42f7...8b356f3. Read the comment docs.

[bkietz]

waiting for #4316 to be merged

[wesm]

Is it expected for the integration tests to pass (there is support in Java for reading these?)?

[bkietz]

It seems like there is support: https://github.com/apache/arrow/blob/master/java/vector/src/test/java/org/apache/arrow/vector/ipc/TestArrowFile.java#L623

I'd need to spend more time figuring out exactly which java code is exercised by integration_test.py

[wesm]

I just poked around the Java codebase. It seems it may work by accident, but it is not tested

[emkornfield]

@bkietz what are the next steps here, do you need help with something on the Java side?

[bkietz]

@emkornfield I have investigated the fixed size list tests. They're spare but present so I think we should merge this and add a JIRA to test fixed size list more thoroughly in Java.

[emkornfield]

@bkietz sounds good, can you rebase?

[bkietz]

@emkornfield rebased and green except for a coredump in test_csv (I don't think that was me)

[emkornfield]

why this change?

[bkietz]

@emkornfield ninja is installed in ci/conda_env_cpp.yml so isn't this unused?

[emkornfield]

@bkietz one small question about a change to docker file. Otherwise LGTM

[emkornfield]

@bkietz potentially not an expert on docker stuff, so I'd prefer cleanup as a separate PR

[bkietz]

@emkornfield reverted and green

[emkornfield]

+1 LGTM, please file a JIRA for the follow-up work.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.97%. Comparing base (24c42f7) to head (8b356f3).

Files with missing lines	Patch %	Lines
cpp/src/arrow/ipc/writer.cc	0.00%	7 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #4309 +/- ##
==========================================
+ Coverage 88.54% 88.97% +0.42% 
==========================================
Files 796 704 -92 Lines 103206 94725 -8481 Branches 1253 0 -1253 ==========================================
- Hits 91388 84277 -7111 + Misses 11573 10448 -1125 + Partials 245 0 -245 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bkietz]

Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in #4278

[codecov-io]

Codecov Report

Merging #4309 into master will increase coverage by 0.42%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #4309 +/- ##
==========================================
+ Coverage 88.54% 88.97% +0.42% 
==========================================
Files 796 704 -92 Lines 103206 94725 -8481 Branches 1253 0 -1253 ==========================================
- Hits 91388 84277 -7111 + Misses 11573 10448 -1125 + Partials 245 0 -245

Impacted Files	Coverage Δ
cpp/src/arrow/ipc/writer.cc	93.04% <0%> (-1.15%)	⬇️
cpp/src/arrow/vendored/datetime/date.h	26.35% <0%> (-4.28%)	⬇️
cpp/src/plasma/thirdparty/ae/ae.c	70.75% <0%> (-0.95%)	⬇️
cpp/src/arrow/python/arrow_to_pandas.cc	91.55% <0%> (-0.04%)	⬇️
cpp/src/arrow/pretty_print.cc	83.18% <0%> (ø)	⬆️
cpp/src/arrow/vendored/datetime/tz.h	43.47% <0%> (ø)	⬆️
cpp/src/arrow/vendored/datetime/tz_private.h	33.33% <0%> (ø)	⬆️
cpp/src/gandiva/precompiled/epoch_time_point.h	100% <0%> (ø)	⬆️
cpp/src/arrow/pretty_print-test.cc	100% <0%> (ø)	⬆️
cpp/src/arrow/python/python-test.cc	100% <0%> (ø)	⬆️
... and 219 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c42f7...8b356f3. Read the comment docs.

[bkietz]

waiting for #4316 to be merged

[wesm]

Is it expected for the integration tests to pass (there is support in Java for reading these?)?

[bkietz]

It seems like there is support: https://github.com/apache/arrow/blob/master/java/vector/src/test/java/org/apache/arrow/vector/ipc/TestArrowFile.java#L623

I'd need to spend more time figuring out exactly which java code is exercised by integration_test.py

[wesm]

I just poked around the Java codebase. It seems it may work by accident, but it is not tested

[emkornfield]

@bkietz what are the next steps here, do you need help with something on the Java side?

[bkietz]

@emkornfield I have investigated the fixed size list tests. They're spare but present so I think we should merge this and add a JIRA to test fixed size list more thoroughly in Java.

[emkornfield]

@bkietz sounds good, can you rebase?

[bkietz]

@emkornfield rebased and green except for a coredump in test_csv (I don't think that was me)

[emkornfield]

why this change?

[bkietz]

@emkornfield ninja is installed in ci/conda_env_cpp.yml so isn't this unused?

[emkornfield]

@bkietz one small question about a change to docker file. Otherwise LGTM

[emkornfield]

@bkietz potentially not an expert on docker stuff, so I'd prefer cleanup as a separate PR

[bkietz]

@emkornfield reverted and green

[emkornfield]

+1 LGTM, please file a JIRA for the follow-up work.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.97%. Comparing base (24c42f7) to head (8b356f3).

Files with missing lines	Patch %	Lines
cpp/src/arrow/ipc/writer.cc	0.00%	7 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #4309 +/- ##
==========================================
+ Coverage 88.54% 88.97% +0.42% 
==========================================
Files 796 704 -92 Lines 103206 94725 -8481 Branches 1253 0 -1253 ==========================================
- Hits 91388 84277 -7111 + Misses 11573 10448 -1125 + Partials 245 0 -245 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bkietz]

Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in #4278

[codecov-io]

Codecov Report

Merging #4309 into master will increase coverage by 0.42%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #4309 +/- ##
==========================================
+ Coverage 88.54% 88.97% +0.42% 
==========================================
Files 796 704 -92 Lines 103206 94725 -8481 Branches 1253 0 -1253 ==========================================
- Hits 91388 84277 -7111 + Misses 11573 10448 -1125 + Partials 245 0 -245

Impacted Files	Coverage Δ
cpp/src/arrow/ipc/writer.cc	93.04% <0%> (-1.15%)	⬇️
cpp/src/arrow/vendored/datetime/date.h	26.35% <0%> (-4.28%)	⬇️
cpp/src/plasma/thirdparty/ae/ae.c	70.75% <0%> (-0.95%)	⬇️
cpp/src/arrow/python/arrow_to_pandas.cc	91.55% <0%> (-0.04%)	⬇️
cpp/src/arrow/pretty_print.cc	83.18% <0%> (ø)	⬆️
cpp/src/arrow/vendored/datetime/tz.h	43.47% <0%> (ø)	⬆️
cpp/src/arrow/vendored/datetime/tz_private.h	33.33% <0%> (ø)	⬆️
cpp/src/gandiva/precompiled/epoch_time_point.h	100% <0%> (ø)	⬆️
cpp/src/arrow/pretty_print-test.cc	100% <0%> (ø)	⬆️
cpp/src/arrow/python/python-test.cc	100% <0%> (ø)	⬆️
... and 219 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c42f7...8b356f3. Read the comment docs.

[bkietz]

waiting for #4316 to be merged

[wesm]

Is it expected for the integration tests to pass (there is support in Java for reading these?)?

[bkietz]

It seems like there is support: https://github.com/apache/arrow/blob/master/java/vector/src/test/java/org/apache/arrow/vector/ipc/TestArrowFile.java#L623

I'd need to spend more time figuring out exactly which java code is exercised by integration_test.py

[wesm]

I just poked around the Java codebase. It seems it may work by accident, but it is not tested

[emkornfield]

@bkietz what are the next steps here, do you need help with something on the Java side?

[bkietz]

@emkornfield I have investigated the fixed size list tests. They're spare but present so I think we should merge this and add a JIRA to test fixed size list more thoroughly in Java.

[emkornfield]

@bkietz sounds good, can you rebase?

[bkietz]

@emkornfield rebased and green except for a coredump in test_csv (I don't think that was me)

[emkornfield]

why this change?

[bkietz]

@emkornfield ninja is installed in ci/conda_env_cpp.yml so isn't this unused?

[emkornfield]

@bkietz one small question about a change to docker file. Otherwise LGTM

[emkornfield]

@bkietz potentially not an expert on docker stuff, so I'd prefer cleanup as a separate PR

[bkietz]

@emkornfield reverted and green

[emkornfield]

+1 LGTM, please file a JIRA for the follow-up work.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.97%. Comparing base (24c42f7) to head (8b356f3).

Files with missing lines	Patch %	Lines
cpp/src/arrow/ipc/writer.cc	0.00%	7 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #4309 +/- ##
==========================================
+ Coverage 88.54% 88.97% +0.42% 
==========================================
Files 796 704 -92 Lines 103206 94725 -8481 Branches 1253 0 -1253 ==========================================
- Hits 91388 84277 -7111 + Misses 11573 10448 -1125 + Partials 245 0 -245 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bkietz]

Adds integration tests for fixed_size_list
Also adds support for fixed_size_list to RecordBatchSerializer, which was omitted in #4278

[codecov-io]

Codecov Report

Merging #4309 into master will increase coverage by 0.42%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #4309 +/- ##
==========================================
+ Coverage 88.54% 88.97% +0.42% 
==========================================
Files 796 704 -92 Lines 103206 94725 -8481 Branches 1253 0 -1253 ==========================================
- Hits 91388 84277 -7111 + Misses 11573 10448 -1125 + Partials 245 0 -245

Impacted Files	Coverage Δ
cpp/src/arrow/ipc/writer.cc	93.04% <0%> (-1.15%)	⬇️
cpp/src/arrow/vendored/datetime/date.h	26.35% <0%> (-4.28%)	⬇️
cpp/src/plasma/thirdparty/ae/ae.c	70.75% <0%> (-0.95%)	⬇️
cpp/src/arrow/python/arrow_to_pandas.cc	91.55% <0%> (-0.04%)	⬇️
cpp/src/arrow/pretty_print.cc	83.18% <0%> (ø)	⬆️
cpp/src/arrow/vendored/datetime/tz.h	43.47% <0%> (ø)	⬆️
cpp/src/arrow/vendored/datetime/tz_private.h	33.33% <0%> (ø)	⬆️
cpp/src/gandiva/precompiled/epoch_time_point.h	100% <0%> (ø)	⬆️
cpp/src/arrow/pretty_print-test.cc	100% <0%> (ø)	⬆️
cpp/src/arrow/python/python-test.cc	100% <0%> (ø)	⬆️
... and 219 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c42f7...8b356f3. Read the comment docs.

[bkietz]

waiting for #4316 to be merged

[wesm]

Is it expected for the integration tests to pass (there is support in Java for reading these?)?

[bkietz]

It seems like there is support: https://github.com/apache/arrow/blob/master/java/vector/src/test/java/org/apache/arrow/vector/ipc/TestArrowFile.java#L623

I'd need to spend more time figuring out exactly which java code is exercised by integration_test.py

[wesm]

I just poked around the Java codebase. It seems it may work by accident, but it is not tested

[emkornfield]

@bkietz what are the next steps here, do you need help with something on the Java side?

[bkietz]

@emkornfield I have investigated the fixed size list tests. They're spare but present so I think we should merge this and add a JIRA to test fixed size list more thoroughly in Java.

[emkornfield]

@bkietz sounds good, can you rebase?

[bkietz]

@emkornfield rebased and green except for a coredump in test_csv (I don't think that was me)

[emkornfield]

why this change?

[bkietz]

@emkornfield ninja is installed in ci/conda_env_cpp.yml so isn't this unused?

[emkornfield]

@bkietz one small question about a change to docker file. Otherwise LGTM

[emkornfield]

@bkietz potentially not an expert on docker stuff, so I'd prefer cleanup as a separate PR

[bkietz]

@emkornfield reverted and green

[emkornfield]

+1 LGTM, please file a JIRA for the follow-up work.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.97%. Comparing base (24c42f7) to head (8b356f3).

Files with missing lines	Patch %	Lines
cpp/src/arrow/ipc/writer.cc	0.00%	7 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #4309 +/- ##
==========================================
+ Coverage 88.54% 88.97% +0.42% 
==========================================
Files 796 704 -92 Lines 103206 94725 -8481 Branches 1253 0 -1253 ==========================================
- Hits 91388 84277 -7111 + Misses 11573 10448 -1125 + Partials 245 0 -245 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.