Uh oh!
There was an error while loading. Please reload this page.
WIP: [R] Verify CRAN release-19.0.1 - #45597
Closed
amoeba wants to merge 10 commits into
Closed
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
amoeba
commented
Feb 20, 2025
MemberAuthor
@github-actions crossbow submit --group r |
Revision: fed7eb7 Submitted crossbow builds: ursacomputing/crossbow @ actions-b7b0e0b19b
|
MemberAuthor
I'll cherry-pick #45524 ( |
…with R lintr (#45524) ### Rationale for this change The linting jobs are failing due to the new version of `lintr` not installing `cyclocomp` anymore. We use `cyclocomp` but this is not part of the default linters of `lintr` anymore. We should install it individually. ### What changes are included in this PR? Install `cyclocomp` as part of setting up the linting environment for R on our linting job. Pin old version of `lintr` for R Windows job as it otherwise fails with a lot of new linter issues. ### Are these changes tested? Yes via CI. ### Are there any user-facing changes? No * GitHub Issue: #45521 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
amoeba
commented
Feb 21, 2025
MemberAuthor
Looks good now, closing and moving forward with CRAN prep. |
### Rationale for this change This fixed a compile error under Windows and MacOS when attempting to package this library as a Conan package: conan-io/conan-center-index#26623 ### What changes are included in this PR? It adds 2 missing headers from the STL, array and vector, which cause resulting compiler errors. ### Are these changes tested? They are tested and passing for the Conan package of these libraries here: conan-io/conan-center-index#26623 ### Are there any user-facing changes? No, only changes within a source file. * GitHub Issue: #45545 Authored-by: Antony Peacock <ant.peacock@gmail.com> Signed-off-by: Bryce Mecum <petridish@gmail.com>
### Rationale for this change Increase the timeout, see if that's the issue on CRAN. ### What changes are included in this PR? Timeout, increased ### Are these changes tested? No ### Are there any user-facing changes? Slightly slower downloads are possible.
…#45606) ### Rationale for this change Fix warnings, pass on CRAN ### What changes are included in this PR? Removing some whitespace ### Are these changes tested? Yes ### Are there any user-facing changes? No, other than being releasable on CRAN * GitHub Issue: #45605 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Bryce Mecum <petridish@gmail.com>
amoeba
commented
Feb 25, 2025
MemberAuthor
@github-actions crossbow submit r-recheck-* |
Revision: c47a022 Submitted crossbow builds: ursacomputing/crossbow @ actions-0096a13a3f
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Do not merge this PR.
This PR is being used to prepare for the CRAN submission for 19.0.1.
See packaging checklist: #45581.