Skip to content

GH-46442: [R] hms::as_hms tests fail on some of our crossbow builds - #46443

Merged
thisisnic merged 4 commits into
apache:mainfrom
thisisnic:gh-46442_hmsfix
May 15, 2025
Merged

GH-46442: [R] hms::as_hms tests fail on some of our crossbow builds#46443
thisisnic merged 4 commits into
apache:mainfrom
thisisnic:gh-46442_hmsfix

Conversation

@thisisnic

@thisisnicthisisnic commented May 14, 2025

Copy link
Copy Markdown
Member

Rationale for this change

New functionality breaks tests with minimal builds

What changes are included in this PR?

Skip tests on those builds

Are these changes tested?

Updates are to tests

Are there any user-facing changes?

No

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #46442has been automatically assigned in GitHub to PR creator.

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-rstudio-r-base-4.1-opensuse155

@github-actions

Copy link
Copy Markdown

Revision: 57053c0

Submitted crossbow builds: ursacomputing/crossbow @ actions-6688d1c6a9

TaskStatus
test-r-rstudio-r-base-4.1-opensuse155Azure

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-rstudio-r-base-4.1-opensuse155

@github-actions

Copy link
Copy Markdown

Revision: 630d86d

Submitted crossbow builds: ursacomputing/crossbow @ actions-b650454563

TaskStatus
test-r-rstudio-r-base-4.1-opensuse155Azure

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-rstudio-r-base-4.1-opensuse155

@github-actions

Copy link
Copy Markdown

Revision: 4dc5da1

Submitted crossbow builds: ursacomputing/crossbow @ actions-5d72b91ecf

TaskStatus
test-r-rstudio-r-base-4.1-opensuse155Azure

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-minimal-build test-r-offline-minimal test-r-rstudio-r-base-4.1-opensuse155 test-r-rstudio-r-base-4.2-focal test-r-versions

@github-actions

Copy link
Copy Markdown

Revision: 4dc5da1

Submitted crossbow builds: ursacomputing/crossbow @ actions-e706ba361a

TaskStatus
test-r-minimal-buildAzure
test-r-offline-minimalAzure
test-r-rstudio-r-base-4.1-opensuse155Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-versionsGitHub Actions

@thisisnic
thisisnic marked this pull request as ready for review May 15, 2025 00:41
@thisisnic
thisisnic requested a review from jonkeane as a code ownerMay 15, 2025 00:41

@jonkeanejonkeane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels May 15, 2025
@thisisnic
thisisnic merged commit 1521148 into apache:mainMay 15, 2025
@thisisnicthisisnic removed the awaiting merge Awaiting merge label May 15, 2025
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1521148.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 14 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@thisisnic@jonkeane