Uh oh!
There was an error while loading. Please reload this page.
GH-40756: [C++] Remove dead Boost urls - #46452
Merged
Merged
Conversation
jonkeane
commented
May 15, 2025
MemberAuthor
jonkeane
commented
May 15, 2025
MemberAuthor
@github-actions crossbow submit -g cpp -g r |
Revision: fa17580 Submitted crossbow builds: ursacomputing/crossbow @ actions-27592e6acc
|
34 tasks
kou
commented
May 16, 2025
Member
There are many failures... but it seems they are not related to this. |
jonkeane
commented
May 16, 2025
MemberAuthor
Thanks! Many of the r failures were resolved in #46443 |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 575cae6. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 14 possible false positives for unstable benchmarks that are known to sometimes produce them. |
amoeba pushed a commit
that referenced
this pull request
May 16, 2025
One of the URLs is dead (https://boostorg.jfrog.io/artifactory/main/release/1.81.0/source/boost_1_81_0.tar.gz) and the sourceforge link is to the non-trimmed version. We are seeing these multiple downloads and fails on CRAN — I believe they get cleaned up so aren't the cause of those runners running out of space (See: https://www.r-project.org/nosvn/R.check/r-release-macos-x86_64/arrow-00install.txt and https://www.r-project.org/nosvn/R.check/r-oldrel-macos-x86_64/arrow-00install.html), but it still isn't great to have it download things we know will fail. ### Rationale for this change Don't download things we know will fail ### What changes are included in this PR? Removed two URLs ### Are these changes tested? Extensively. ### Are there any user-facing changes? No. * GitHub Issue: #40756 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the URLs is dead (https://boostorg.jfrog.io/artifactory/main/release/1.81.0/source/boost_1_81_0.tar.gz) and the sourceforge link is to the non-trimmed version.
We are seeing these multiple downloads and fails on CRAN — I believe they get cleaned up so aren't the cause of those runners running out of space (See: https://www.r-project.org/nosvn/R.check/r-release-macos-x86_64/arrow-00install.txt and https://www.r-project.org/nosvn/R.check/r-oldrel-macos-x86_64/arrow-00install.html), but it still isn't great to have it download things we know will fail.
Rationale for this change
Don't download things we know will fail
What changes are included in this PR?
Removed two URLs
Are these changes tested?
Extensively.
Are there any user-facing changes?
No.