GH-46496: [CI][Dev] Fix shellcheck SC2086 errors in ci/scripts directory

[hiroyuki-sato]

Rationale for this change

We are trying to implement shellcheck on all sh files in #44748.

What changes are included in this PR?

SC2086 check requires quoting like ${url} -> "${url}".

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

• GitHub Issue: [CI][Dev] Fix shellcheck SC2086 errors in ci/scripts directory #46496

[github-actions]

⚠️ GitHub issue #46496has been automatically assigned in GitHub to PR creator.

[hiroyuki-sato]

I modified many files at once. But, all of changes are ${var} -> "${var}". So, I believe review is not so hard.

Please let me know, it would be better to split this into multiple PRs.
(IMO, It is a little tedious to create PR for one by one)

[kou]

Could you remove this file in a separated PR?

We moved the Java implementation to apache/arrow-java.

[hiroyuki-sato]

OK. Should I also remove ci/scripts/rust_build.sh too?

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index fe178e069..3ef23a08e 100644
--- a/.pre-commit-config.yaml+++ b/.pre-commit-config.yaml@@ -196,13 +196,31 @@ repos:
?^ci/scripts/c_glib_build\.sh$|
?^ci/scripts/c_glib_test\.sh$|
?^ci/scripts/conan_setup\.sh$|
+ ?^ci/scripts/csharp_build\.sh$|+ ?^ci/scripts/csharp_pack\.sh$|
?^ci/scripts/download_tz_database\.sh$|
?^ci/scripts/install_azurite\.sh$|
?^ci/scripts/install_ccache\.sh$|
?^ci/scripts/install_ceph\.sh$|
+ ?^ci/scripts/install_chromedriver\.sh$|+ ?^ci/scripts/install_cmake\.sh$|+ ?^ci/scripts/install_emscripten\.sh$|+ ?^ci/scripts/install_iwyu\.sh$|+ ?^ci/scripts/install_ninja\.sh$|+ ?^ci/scripts/install_numpy\.sh$|+ ?^ci/scripts/install_pandas\.sh$|+ ?^ci/scripts/install_python\.sh$|
?^ci/scripts/install_spark\.sh$|
+ ?^ci/scripts/install_vcpkg\.sh$|
?^ci/scripts/integration_dask\.sh$|
+ ?^ci/scripts/java_full_build\.sh$|+ ?^ci/scripts/matlab_build\.sh$|+ ?^ci/scripts/msys2_system_clean\.sh$|
?^ci/scripts/msys2_system_upgrade\.sh$|
+ ?^ci/scripts/python_sdist_build\.sh$|+ ?^ci/scripts/release_test\.sh$|+ ?^ci/scripts/ruby_test\.sh$|+ ?^ci/scripts/rust_build\.sh$|
?^ci/scripts/util_free_space\.sh$|
?^cpp/build-support/build-lz4-lib\.sh$|
?^cpp/build-support/build-zstd-lib\.sh$|

[kou]

It's used here:

arrow/ci/scripts/integration_arrow_build.sh

Line 32 in 7f645d4

${arrow_dir}/ci/scripts/rust_build.sh ${arrow_dir}${build_dir}

[hiroyuki-sato]

Created #46502

[kou]

@github-actions crossbow submit -g python

[kou]

Could you open a new issue for MATLAB CI failures?

[github-actions]

Revision: f1917a8

Submitted crossbow builds: ursacomputing/crossbow @ actions-c037629e6f

Task	Status
example-python-minimal-build-fedora-conda
example-python-minimal-build-ubuntu-venv
test-conda-python-3.10
test-conda-python-3.10-hdfs-2.9.2
test-conda-python-3.10-hdfs-3.2.1
test-conda-python-3.10-pandas-latest-numpy-latest
test-conda-python-3.11
test-conda-python-3.11-dask-latest
test-conda-python-3.11-dask-upstream_devel
test-conda-python-3.11-hypothesis
test-conda-python-3.11-pandas-latest-numpy-1.26
test-conda-python-3.11-pandas-latest-numpy-latest
test-conda-python-3.11-pandas-nightly-numpy-nightly
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly
test-conda-python-3.11-spark-master
test-conda-python-3.12
test-conda-python-3.12-cpython-debug
test-conda-python-3.13
test-conda-python-3.9
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5
test-conda-python-emscripten
test-cuda-python-ubuntu-22.04-cuda-11.7.1
test-debian-12-python-3-amd64
test-debian-12-python-3-i386
test-fedora-39-python-3
test-ubuntu-22.04-python-3
test-ubuntu-22.04-python-313-freethreading
test-ubuntu-24.04-python-3

[hiroyuki-sato]

I created #46498 for MATLAB CI Failure.

[hiroyuki-sato]

It seems that the following error are know issues.

• test-conda-python-3.10-pandas-latest-numpy-latest [CI][Python] Conda Python 3.10 jobs fail with UnicodeDecodeError due to gdb issue #46343
• test-conda-python-3.10 [CI][Python] Conda Python 3.10 jobs fail with UnicodeDecodeError due to gdb issue #46343

Rest of two are the same error.

• example-python-minimal-build-fedora-conda
• example-python-minimal-build-ubuntu-venv

https://github.com/ursacomputing/crossbow/actions/runs/15107317228/job/42458657050#step:3:13178
https://github.com/ursacomputing/crossbow/actions/runs/15107317390/job/42458658267#step:3:15548

E ImportError: Pandas requires version '10.0.1' or newer of 'pyarrow' (version '0.1.dev17552+gf1917a8' currently installed).

[hiroyuki-sato]

@github-actions crossbow submit example-python-minimal-build-fedora-conda

[hiroyuki-sato]

It seems that I don't have permission crossbow. It worked.

[github-actions]

Revision: 709f074

Submitted crossbow builds: ursacomputing/crossbow @ actions-0b8afc1ec8

Task	Status
example-python-minimal-build-fedora-conda

[raulcd]

The failure on the example-python-minimal-* is a known issue if your fork is missing some dev tags, see:

• [Python] Jobs fail if Pyarrow version is not correctly generated due to missing remote dev tags #44803

You can either push the dev tags from the apache/arrow repo to your fork or ignore those failures.

We should fix the issue I've shared as this is recurring for new contributions :)

[hiroyuki-sato]

@raulcd Thanks! I pushed tag to my repository.
#44720 (comment)

[raulcd]

@github-actions crossbow submit example-python-minimal-build-fedora-conda

[github-actions]

Revision: 709f074

Submitted crossbow builds: ursacomputing/crossbow @ actions-33609c0757

Task	Status
example-python-minimal-build-fedora-conda

[hiroyuki-sato]

@kou crossbow failure are known issues. I think crossbow passed. Please take a look when you get a chance.

[kou]

+1

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ddfa762.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.