Uh oh!
There was an error while loading. Please reload this page.
GH-46964: [CI][Packaging][Conan] Ensure using upper case for config suffix - #46967
Merged
Conversation
kou
commented
Jul 2, 2025
MemberAuthor
@github-actions crossbow submit -g conan |
Revision: 80ae88c Submitted crossbow builds: ursacomputing/crossbow @ actions-e5df37694c
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 33c8de7. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Conan uses upper case for config suffix: https://github.com/conan-io/conan/blob/3bc93e28d46f071da45d11f5256c6af52404b756/conan/tools/cmake/cmakedeps/templates/__init__.py#L69
#45306 stopped upcasing configuration name. So
$<CONFIG>may not upper case.What changes are included in this PR?
Ensure using upper case configuration name for Conan bzip2 target.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.