Uh oh!
There was an error while loading. Please reload this page.
GH-45885: [C++] Require C++20 - #48414
Merged
Merged
Conversation
pitrou
commented
Dec 9, 2025
MemberAuthor
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
pitrou
commented
Dec 9, 2025
MemberAuthor
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
pitrou
commented
Dec 9, 2025
MemberAuthor
@github-actions crossbow submit wheelcp313* |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
pitrou
commented
Dec 9, 2025
MemberAuthor
@github-actions crossbow submit -g python |
pitrou
commented
Dec 9, 2025
MemberAuthor
@github-actions crossbow submit -g r |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
5 tasks
pitrou
commented
Dec 15, 2025
MemberAuthor
@github-actions crossbow submit -g c-glib -g ruby -g r |
pitrou
commented
Dec 18, 2025
MemberAuthor
I'm not sure what it's for, but I've re-enabled the |
pitrou
commented
Dec 18, 2025
MemberAuthor
@github-actions crossbow submit test-debian-experimental-cpp-gcc-15 |
Revision: 6fa77b0 Submitted crossbow builds: ursacomputing/crossbow @ actions-93c23edec8
|
pitrou
commented
Dec 18, 2025
MemberAuthor
@github-actions crossbow submit -g cpp -g python |
Revision: 6fa77b0 Submitted crossbow builds: ursacomputing/crossbow @ actions-e5d2f93e4c
|
pitrou
commented
Dec 18, 2025
MemberAuthor
Well, let's merge this now. |
kou
reviewed
Dec 19, 2025
| @@ -1181,7 +1181,7 @@ endif() | |||
| foreach(LIB_TARGET ${ARROW_LIBRARIES}) | |||
| target_compile_definitions(${LIB_TARGET} PRIVATE ARROW_EXPORTING) | |||
| # C++17 is required to compile against Arrow C++ headers and libraries | |||
MemberAuthor
There was a problem hiding this comment.
Oops, sorry, it's intriguing that I overlooked these two occurrences.
| @@ -131,7 +131,7 @@ libmexclass_client_add_proxy_library( | |||
| LINK_LIBRARIES arrow_shared | |||
| ) | |||
| # Use C++17 | |||
kou
commented
Dec 19, 2025
Member
It's for the latest GCC. We should bump this GCC version when new GCC is released. Debian experimental will provide it. For example, GCC 16 isn't released yet but it's already provided: https://packages.debian.org/search?keywords=gcc-16 |
thisisnic pushed a commit
that referenced
this pull request
Dec 19, 2025
### Rationale for this change As a followup to #48414, fix the comments that I had forgotten to update. ### Are these changes tested? No testing required. ### Are there any user-facing changes? No. Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Nic Crane <thisisnic@gmail.com>
jonahkel pushed a commit
to jonahkel/arrow
that referenced
this pull request
Dec 22, 2025
### Rationale for this change As a followup to apache#48414, fix the comments that I had forgotten to update. ### Are these changes tested? No testing required. ### Are there any user-facing changes? No. Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Nic Crane <thisisnic@gmail.com>
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 30809c6. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 474 possible false positives for unstable benchmarks that are known to sometimes produce them. |
raulcd pushed a commit
that referenced
this pull request
Jan 7, 2026
…tup-rhel-rebuilds.sh` for wheel verification (#48748) ### Rationale for this change GH-48414 removed AlmaLinux 8 support from `dev/release/setup-rhel-rebuilds.sh`. But we need to restore it for wheel verification. ### What changes are included in this PR? * Enable `powertools` repository for some development packages * Use Python 3.12 explicitly ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #48736 Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
| # include <opentelemetry/context/propagation/text_map_propagator.h> | ||
| # include <opentelemetry/trace/context.h> | ||
| # include <opentelemetry/trace/propagation/http_trace_context.h> | ||
| # include <opentelemetry/trace/semantic_conventions.h> |
Contributor
There was a problem hiding this comment.
@pitrou, this change looks more or less completely unrelated to the move to C++20? Presumably it's just because you started building against newer otel which doesn't have this header anymore? We're hitting this on all versions before v23 when building against otel 1.25
MemberAuthor
There was a problem hiding this comment.
Yes, you're right, I hit this while working on the PR. But the otel bump might have been tied to some other dependency changes required for the PR as well.
Mottl pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
### Rationale for this change We decided to migrate Arrow C++ to C++20 in this discussion: https://lists.apache.org/thread/48zlj0dn2y0f53y2k37qsr90y781wfnj ### What changes are included in this PR? 1. Build configuration updates (CMake files etc.) to build with C++20 instead of C++17 2. C++-level fixes to ensure compilation succeeds: * Workarounds for deprecation of atomic access on `std::shared_ptr<T>` (the replacement `std::atomic<std::shared_ptr<T>>` is unfortunately not supported in all standard library implementations) * Workaround for [Abseil ABI issues](abseil/abseil-cpp#1624) * Trivial update to `arrow/util/string.h` to call a C++20 API (to validate that C++20 is actually enabled) 3. CI configuration updates to get enough C++20 support on the various platforms: * Bump default clang and LLVM versions to 18 * Use AlmaLinux 10 for release verification (AlmaLinux 8 is still tested on other CI builds) ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes, Arrow C++ will now require a C++20-compliant compiler. * GitHub Issue: apache#45885 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Mottl pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
### Rationale for this change As a followup to apache#48414, fix the comments that I had forgotten to update. ### Are these changes tested? No testing required. ### Are there any user-facing changes? No. Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Nic Crane <thisisnic@gmail.com>
Mottl pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
…ase/setup-rhel-rebuilds.sh` for wheel verification (apache#48748) ### Rationale for this change apacheGH-48414 removed AlmaLinux 8 support from `dev/release/setup-rhel-rebuilds.sh`. But we need to restore it for wheel verification. ### What changes are included in this PR? * Enable `powertools` repository for some development packages * Use Python 3.12 explicitly ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#48736 Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We decided to migrate Arrow C++ to C++20 in this discussion: https://lists.apache.org/thread/48zlj0dn2y0f53y2k37qsr90y781wfnj
What changes are included in this PR?
Build configuration updates (CMake files etc.) to build with C++20 instead of C++17
C++-level fixes to ensure compilation succeeds:
std::shared_ptr<T>(the replacementstd::atomic<std::shared_ptr<T>>is unfortunately not supported in all standard library implementations)arrow/util/string.hto call a C++20 API (to validate that C++20 is actually enabled)CI configuration updates to get enough C++20 support on the various platforms:
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes, Arrow C++ will now require a C++20-compliant compiler.