[EXP] GH-44792: [C++] Require C++20 - #45445

Closed
pitrou wants to merge 2 commits into
apache:mainfrom
pitrou:cxx20-experiment
Closed

[EXP] GH-44792: [C++] Require C++20#45445
pitrou wants to merge 2 commits into
apache:mainfrom
pitrou:cxx20-experiment

Conversation

@pitrou

Copy link
Copy Markdown
Member

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python -g wheel

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g linux -g r

@github-actions

This comment was marked as outdated.

@pitrou

pitrou commented Feb 6, 2025

Copy link
Copy Markdown
MemberAuthor

So, it seems two main issues may be blocking this:

  1. The AWS SDK fails to build ("Could not determine support for atomic operations")
  2. CentOS 8 and Almalinux 8 do not have a C++20 compliant C++ stdlib (by default)

Edit: a couple R builds also seem to have a non-C++20 compliant stdlib.

@kou What is our policy for Almalinux and CentOS support?

@kou

kou commented Feb 7, 2025

Copy link
Copy Markdown
Member

We can use gcc-toolset-{9,10,11,12,13,14} on AlmaLinux 8 and CentOS Stream 8 if we needed. For example, AlmaLinux 9 uses gcc-toolset-12:


@pitrou

Copy link
Copy Markdown
MemberAuthor

I see, thanks. So there are probably no insurmountable issues against switching to C++20. Of course, this will have to be discussed on the ML at some point (and there's no urgency).

@kou

kou commented Feb 7, 2025

Copy link
Copy Markdown
Member

this will have to be discussed on the ML at some point

Right.

FYI: There is a related issue: #44792

@pitroupitrou changed the title EXP: [C++] Require C++20[EXP] GH-44792: [C++] Require C++20Feb 27, 2025
@pitrou
pitrouforce-pushed the cxx20-experiment branch 2 times, most recently from 1244c29 to bc7811aCompareMarch 18, 2025 11:15
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit centos*

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheelcp313*

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g r

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pitrou

pitrou commented Apr 23, 2025

Copy link
Copy Markdown
MemberAuthor

@assignUser See R Crossbow build results just above. Can you check whether the failures are actually related?

Comment threaddev/release/verify-yum.sh Outdated
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Apr 24, 2025
@assignUser

Copy link
Copy Markdown
Member

@pitrou They are not related, they all show the same error that also shows up in the nightly builds:

── Error ('test-s3-minio.R:64:1'): copy files with s3 ──────────────────────────
Error: Key error: Attempted to register factory for scheme 's3' but that scheme is already registered.
Backtrace:
▆
1. └─arrow::copy_files(uri_formatter("hive_dir"), td) at tests/testthat/helper-filesystems.R:173:7
2. └─arrow:::get_path_and_filesystem(from)
3. └─arrow:::get_paths_and_filesystem(x, filesystem)
4. └─base::lapply(x, FileSystem$from_uri)
5. └─arrow (local) FUN(X[[i]], ...)
6. └─arrow:::fs___FileSystemFromUri(uri)

@pitrou

Copy link
Copy Markdown
MemberAuthor

@pitrou They are not related, they all show the same error that also shows up in the nightly builds:

Relatedly, is someone trying to fix them? Is there an issue open?

@pitrou
pitrouforce-pushed the cxx20-experiment branch from 41b3f1d to 16eca75CompareMay 19, 2025 12:54
@github-actionsgithub-actionsBot added awaiting change review Awaiting change review and removed Component: FlightRPC awaiting changes Awaiting changes labels May 19, 2025
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheelcp313*

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-8c72ad3e54

TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-884015d237

TaskStatus
example-cpp-minimal-build-staticGitHub Actions
example-cpp-minimal-build-static-system-dependencyGitHub Actions
example-cpp-tutorialGitHub Actions
example-python-minimal-build-fedora-condaGitHub Actions
example-python-minimal-build-ubuntu-venvGitHub Actions
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-mesonGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightlyGitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightlyGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.12-cpython-debugGitHub Actions
test-conda-python-3.13GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5GitHub Actions
test-conda-python-emscriptenGitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-debian-12-python-3-amd64GitHub Actions
test-debian-12-python-3-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-fedora-39-python-3GitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-bundledGitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-22.04-python-3GitHub Actions
test-ubuntu-22.04-python-313-freethreadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-bundled-offlineGitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-24.04-python-3GitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g linux

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-43a66e208a

TaskStatus
almalinux-8-amd64GitHub Actions
almalinux-8-arm64GitHub Actions
almalinux-9-amd64GitHub Actions
almalinux-9-arm64GitHub Actions
amazon-linux-2023-amd64GitHub Actions
amazon-linux-2023-arm64GitHub Actions
centos-7-amd64GitHub Actions
centos-8-stream-amd64GitHub Actions
centos-8-stream-arm64GitHub Actions
centos-9-stream-amd64GitHub Actions
centos-9-stream-arm64GitHub Actions
debian-bookworm-amd64GitHub Actions
debian-bookworm-arm64GitHub Actions
debian-trixie-amd64GitHub Actions
debian-trixie-arm64GitHub Actions
ubuntu-jammy-amd64GitHub Actions
ubuntu-jammy-arm64GitHub Actions
ubuntu-noble-amd64GitHub Actions
ubuntu-noble-arm64GitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g r

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-3da723357b

TaskStatus
r-binary-packagesGitHub Actions
r-recheck-mostGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-extra-packagesGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-sanitizersGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-m1-sanGitHub Actions
test-r-macos-as-cranGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.2-jammyAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

This PR was getting unwieldy, I opened a new fresh one at #48414

@pitroupitrou closed this Dec 9, 2025
@pitrou
pitrou deleted the cxx20-experiment branch December 9, 2025 09:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou@kou@nealrichardson@assignUser
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

[EXP] GH-44792: [C++] Require C++20 - #45445

Closed
pitrou wants to merge 2 commits into
apache:mainfrom
pitrou:cxx20-experiment
Closed

[EXP] GH-44792: [C++] Require C++20#45445
pitrou wants to merge 2 commits into
apache:mainfrom
pitrou:cxx20-experiment

Conversation

@pitrou

Copy link
Copy Markdown
Member

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python -g wheel

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g linux -g r

@github-actions

This comment was marked as outdated.

@pitrou

pitrou commented Feb 6, 2025

Copy link
Copy Markdown
MemberAuthor

So, it seems two main issues may be blocking this:

  1. The AWS SDK fails to build ("Could not determine support for atomic operations")
  2. CentOS 8 and Almalinux 8 do not have a C++20 compliant C++ stdlib (by default)

Edit: a couple R builds also seem to have a non-C++20 compliant stdlib.

@kou What is our policy for Almalinux and CentOS support?

@kou

kou commented Feb 7, 2025

Copy link
Copy Markdown
Member

We can use gcc-toolset-{9,10,11,12,13,14} on AlmaLinux 8 and CentOS Stream 8 if we needed. For example, AlmaLinux 9 uses gcc-toolset-12:


@pitrou

Copy link
Copy Markdown
MemberAuthor

I see, thanks. So there are probably no insurmountable issues against switching to C++20. Of course, this will have to be discussed on the ML at some point (and there's no urgency).

@kou

kou commented Feb 7, 2025

Copy link
Copy Markdown
Member

this will have to be discussed on the ML at some point

Right.

FYI: There is a related issue: #44792

@pitroupitrou changed the title EXP: [C++] Require C++20[EXP] GH-44792: [C++] Require C++20Feb 27, 2025
@pitrou
pitrouforce-pushed the cxx20-experiment branch 2 times, most recently from 1244c29 to bc7811aCompareMarch 18, 2025 11:15
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit centos*

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheelcp313*

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g r

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pitrou

pitrou commented Apr 23, 2025

Copy link
Copy Markdown
MemberAuthor

@assignUser See R Crossbow build results just above. Can you check whether the failures are actually related?

Comment threaddev/release/verify-yum.sh Outdated
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Apr 24, 2025
@assignUser

Copy link
Copy Markdown
Member

@pitrou They are not related, they all show the same error that also shows up in the nightly builds:

── Error ('test-s3-minio.R:64:1'): copy files with s3 ──────────────────────────
Error: Key error: Attempted to register factory for scheme 's3' but that scheme is already registered.
Backtrace:
▆
1. └─arrow::copy_files(uri_formatter("hive_dir"), td) at tests/testthat/helper-filesystems.R:173:7
2. └─arrow:::get_path_and_filesystem(from)
3. └─arrow:::get_paths_and_filesystem(x, filesystem)
4. └─base::lapply(x, FileSystem$from_uri)
5. └─arrow (local) FUN(X[[i]], ...)
6. └─arrow:::fs___FileSystemFromUri(uri)

@pitrou

Copy link
Copy Markdown
MemberAuthor

@pitrou They are not related, they all show the same error that also shows up in the nightly builds:

Relatedly, is someone trying to fix them? Is there an issue open?

@pitrou
pitrouforce-pushed the cxx20-experiment branch from 41b3f1d to 16eca75CompareMay 19, 2025 12:54
@github-actionsgithub-actionsBot added awaiting change review Awaiting change review and removed Component: FlightRPC awaiting changes Awaiting changes labels May 19, 2025
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheelcp313*

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-8c72ad3e54

TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-884015d237

TaskStatus
example-cpp-minimal-build-staticGitHub Actions
example-cpp-minimal-build-static-system-dependencyGitHub Actions
example-cpp-tutorialGitHub Actions
example-python-minimal-build-fedora-condaGitHub Actions
example-python-minimal-build-ubuntu-venvGitHub Actions
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-mesonGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightlyGitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightlyGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.12-cpython-debugGitHub Actions
test-conda-python-3.13GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5GitHub Actions
test-conda-python-emscriptenGitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-debian-12-python-3-amd64GitHub Actions
test-debian-12-python-3-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-fedora-39-python-3GitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-bundledGitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-22.04-python-3GitHub Actions
test-ubuntu-22.04-python-313-freethreadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-bundled-offlineGitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-24.04-python-3GitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g linux

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-43a66e208a

TaskStatus
almalinux-8-amd64GitHub Actions
almalinux-8-arm64GitHub Actions
almalinux-9-amd64GitHub Actions
almalinux-9-arm64GitHub Actions
amazon-linux-2023-amd64GitHub Actions
amazon-linux-2023-arm64GitHub Actions
centos-7-amd64GitHub Actions
centos-8-stream-amd64GitHub Actions
centos-8-stream-arm64GitHub Actions
centos-9-stream-amd64GitHub Actions
centos-9-stream-arm64GitHub Actions
debian-bookworm-amd64GitHub Actions
debian-bookworm-arm64GitHub Actions
debian-trixie-amd64GitHub Actions
debian-trixie-arm64GitHub Actions
ubuntu-jammy-amd64GitHub Actions
ubuntu-jammy-arm64GitHub Actions
ubuntu-noble-amd64GitHub Actions
ubuntu-noble-arm64GitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g r

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-3da723357b

TaskStatus
r-binary-packagesGitHub Actions
r-recheck-mostGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-extra-packagesGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-sanitizersGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-m1-sanGitHub Actions
test-r-macos-as-cranGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.2-jammyAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

This PR was getting unwieldy, I opened a new fresh one at #48414

@pitroupitrou closed this Dec 9, 2025
@pitrou
pitrou deleted the cxx20-experiment branch December 9, 2025 09:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou@kou@nealrichardson@assignUser
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[EXP] GH-44792: [C++] Require C++20 - #45445

Closed
pitrou wants to merge 2 commits into
apache:mainfrom
pitrou:cxx20-experiment
Closed

[EXP] GH-44792: [C++] Require C++20#45445
pitrou wants to merge 2 commits into
apache:mainfrom
pitrou:cxx20-experiment

Conversation

@pitrou

Copy link
Copy Markdown
Member

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python -g wheel

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g linux -g r

@github-actions

This comment was marked as outdated.

@pitrou

pitrou commented Feb 6, 2025

Copy link
Copy Markdown
MemberAuthor

So, it seems two main issues may be blocking this:

  1. The AWS SDK fails to build ("Could not determine support for atomic operations")
  2. CentOS 8 and Almalinux 8 do not have a C++20 compliant C++ stdlib (by default)

Edit: a couple R builds also seem to have a non-C++20 compliant stdlib.

@kou What is our policy for Almalinux and CentOS support?

@kou

kou commented Feb 7, 2025

Copy link
Copy Markdown
Member

We can use gcc-toolset-{9,10,11,12,13,14} on AlmaLinux 8 and CentOS Stream 8 if we needed. For example, AlmaLinux 9 uses gcc-toolset-12:


@pitrou

Copy link
Copy Markdown
MemberAuthor

I see, thanks. So there are probably no insurmountable issues against switching to C++20. Of course, this will have to be discussed on the ML at some point (and there's no urgency).

@kou

kou commented Feb 7, 2025

Copy link
Copy Markdown
Member

this will have to be discussed on the ML at some point

Right.

FYI: There is a related issue: #44792

@pitroupitrou changed the title EXP: [C++] Require C++20[EXP] GH-44792: [C++] Require C++20Feb 27, 2025
@pitrou
pitrouforce-pushed the cxx20-experiment branch 2 times, most recently from 1244c29 to bc7811aCompareMarch 18, 2025 11:15
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit centos*

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheelcp313*

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g r

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pitrou

pitrou commented Apr 23, 2025

Copy link
Copy Markdown
MemberAuthor

@assignUser See R Crossbow build results just above. Can you check whether the failures are actually related?

Comment threaddev/release/verify-yum.sh Outdated
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Apr 24, 2025
@assignUser

Copy link
Copy Markdown
Member

@pitrou They are not related, they all show the same error that also shows up in the nightly builds:

── Error ('test-s3-minio.R:64:1'): copy files with s3 ──────────────────────────
Error: Key error: Attempted to register factory for scheme 's3' but that scheme is already registered.
Backtrace:
▆
1. └─arrow::copy_files(uri_formatter("hive_dir"), td) at tests/testthat/helper-filesystems.R:173:7
2. └─arrow:::get_path_and_filesystem(from)
3. └─arrow:::get_paths_and_filesystem(x, filesystem)
4. └─base::lapply(x, FileSystem$from_uri)
5. └─arrow (local) FUN(X[[i]], ...)
6. └─arrow:::fs___FileSystemFromUri(uri)

@pitrou

Copy link
Copy Markdown
MemberAuthor

@pitrou They are not related, they all show the same error that also shows up in the nightly builds:

Relatedly, is someone trying to fix them? Is there an issue open?

@pitrou
pitrouforce-pushed the cxx20-experiment branch from 41b3f1d to 16eca75CompareMay 19, 2025 12:54
@github-actionsgithub-actionsBot added awaiting change review Awaiting change review and removed Component: FlightRPC awaiting changes Awaiting changes labels May 19, 2025
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheelcp313*

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-8c72ad3e54

TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-884015d237

TaskStatus
example-cpp-minimal-build-staticGitHub Actions
example-cpp-minimal-build-static-system-dependencyGitHub Actions
example-cpp-tutorialGitHub Actions
example-python-minimal-build-fedora-condaGitHub Actions
example-python-minimal-build-ubuntu-venvGitHub Actions
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-mesonGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightlyGitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightlyGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.12-cpython-debugGitHub Actions
test-conda-python-3.13GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5GitHub Actions
test-conda-python-emscriptenGitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-debian-12-python-3-amd64GitHub Actions
test-debian-12-python-3-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-fedora-39-python-3GitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-bundledGitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-22.04-python-3GitHub Actions
test-ubuntu-22.04-python-313-freethreadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-bundled-offlineGitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-24.04-python-3GitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g linux

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-43a66e208a

TaskStatus
almalinux-8-amd64GitHub Actions
almalinux-8-arm64GitHub Actions
almalinux-9-amd64GitHub Actions
almalinux-9-arm64GitHub Actions
amazon-linux-2023-amd64GitHub Actions
amazon-linux-2023-arm64GitHub Actions
centos-7-amd64GitHub Actions
centos-8-stream-amd64GitHub Actions
centos-8-stream-arm64GitHub Actions
centos-9-stream-amd64GitHub Actions
centos-9-stream-arm64GitHub Actions
debian-bookworm-amd64GitHub Actions
debian-bookworm-arm64GitHub Actions
debian-trixie-amd64GitHub Actions
debian-trixie-arm64GitHub Actions
ubuntu-jammy-amd64GitHub Actions
ubuntu-jammy-arm64GitHub Actions
ubuntu-noble-amd64GitHub Actions
ubuntu-noble-arm64GitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g r

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-3da723357b

TaskStatus
r-binary-packagesGitHub Actions
r-recheck-mostGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-extra-packagesGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-sanitizersGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-m1-sanGitHub Actions
test-r-macos-as-cranGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.2-jammyAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

This PR was getting unwieldy, I opened a new fresh one at #48414

@pitroupitrou closed this Dec 9, 2025
@pitrou
pitrou deleted the cxx20-experiment branch December 9, 2025 09:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou@kou@nealrichardson@assignUser
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[EXP] GH-44792: [C++] Require C++20 - #45445

Closed
pitrou wants to merge 2 commits into
apache:mainfrom
pitrou:cxx20-experiment
Closed

[EXP] GH-44792: [C++] Require C++20#45445
pitrou wants to merge 2 commits into
apache:mainfrom
pitrou:cxx20-experiment

Conversation

@pitrou

Copy link
Copy Markdown
Member

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python -g wheel

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g linux -g r

@github-actions

This comment was marked as outdated.

@pitrou

pitrou commented Feb 6, 2025

Copy link
Copy Markdown
MemberAuthor

So, it seems two main issues may be blocking this:

  1. The AWS SDK fails to build ("Could not determine support for atomic operations")
  2. CentOS 8 and Almalinux 8 do not have a C++20 compliant C++ stdlib (by default)

Edit: a couple R builds also seem to have a non-C++20 compliant stdlib.

@kou What is our policy for Almalinux and CentOS support?

@kou

kou commented Feb 7, 2025

Copy link
Copy Markdown
Member

We can use gcc-toolset-{9,10,11,12,13,14} on AlmaLinux 8 and CentOS Stream 8 if we needed. For example, AlmaLinux 9 uses gcc-toolset-12:


@pitrou

Copy link
Copy Markdown
MemberAuthor

I see, thanks. So there are probably no insurmountable issues against switching to C++20. Of course, this will have to be discussed on the ML at some point (and there's no urgency).

@kou

kou commented Feb 7, 2025

Copy link
Copy Markdown
Member

this will have to be discussed on the ML at some point

Right.

FYI: There is a related issue: #44792

@pitroupitrou changed the title EXP: [C++] Require C++20[EXP] GH-44792: [C++] Require C++20Feb 27, 2025
@pitrou
pitrouforce-pushed the cxx20-experiment branch 2 times, most recently from 1244c29 to bc7811aCompareMarch 18, 2025 11:15
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit centos*

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheelcp313*

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g r

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pitrou

pitrou commented Apr 23, 2025

Copy link
Copy Markdown
MemberAuthor

@assignUser See R Crossbow build results just above. Can you check whether the failures are actually related?

Comment threaddev/release/verify-yum.sh Outdated
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Apr 24, 2025
@assignUser

Copy link
Copy Markdown
Member

@pitrou They are not related, they all show the same error that also shows up in the nightly builds:

── Error ('test-s3-minio.R:64:1'): copy files with s3 ──────────────────────────
Error: Key error: Attempted to register factory for scheme 's3' but that scheme is already registered.
Backtrace:
▆
1. └─arrow::copy_files(uri_formatter("hive_dir"), td) at tests/testthat/helper-filesystems.R:173:7
2. └─arrow:::get_path_and_filesystem(from)
3. └─arrow:::get_paths_and_filesystem(x, filesystem)
4. └─base::lapply(x, FileSystem$from_uri)
5. └─arrow (local) FUN(X[[i]], ...)
6. └─arrow:::fs___FileSystemFromUri(uri)

@pitrou

Copy link
Copy Markdown
MemberAuthor

@pitrou They are not related, they all show the same error that also shows up in the nightly builds:

Relatedly, is someone trying to fix them? Is there an issue open?

@pitrou
pitrouforce-pushed the cxx20-experiment branch from 41b3f1d to 16eca75CompareMay 19, 2025 12:54
@github-actionsgithub-actionsBot added awaiting change review Awaiting change review and removed Component: FlightRPC awaiting changes Awaiting changes labels May 19, 2025
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheelcp313*

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-8c72ad3e54

TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-884015d237

TaskStatus
example-cpp-minimal-build-staticGitHub Actions
example-cpp-minimal-build-static-system-dependencyGitHub Actions
example-cpp-tutorialGitHub Actions
example-python-minimal-build-fedora-condaGitHub Actions
example-python-minimal-build-ubuntu-venvGitHub Actions
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-mesonGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightlyGitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightlyGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.12-cpython-debugGitHub Actions
test-conda-python-3.13GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5GitHub Actions
test-conda-python-emscriptenGitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-debian-12-python-3-amd64GitHub Actions
test-debian-12-python-3-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-fedora-39-python-3GitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-bundledGitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-22.04-python-3GitHub Actions
test-ubuntu-22.04-python-313-freethreadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-bundled-offlineGitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-24.04-python-3GitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g linux

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-43a66e208a

TaskStatus
almalinux-8-amd64GitHub Actions
almalinux-8-arm64GitHub Actions
almalinux-9-amd64GitHub Actions
almalinux-9-arm64GitHub Actions
amazon-linux-2023-amd64GitHub Actions
amazon-linux-2023-arm64GitHub Actions
centos-7-amd64GitHub Actions
centos-8-stream-amd64GitHub Actions
centos-8-stream-arm64GitHub Actions
centos-9-stream-amd64GitHub Actions
centos-9-stream-arm64GitHub Actions
debian-bookworm-amd64GitHub Actions
debian-bookworm-arm64GitHub Actions
debian-trixie-amd64GitHub Actions
debian-trixie-arm64GitHub Actions
ubuntu-jammy-amd64GitHub Actions
ubuntu-jammy-arm64GitHub Actions
ubuntu-noble-amd64GitHub Actions
ubuntu-noble-arm64GitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g r

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-3da723357b

TaskStatus
r-binary-packagesGitHub Actions
r-recheck-mostGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-extra-packagesGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-sanitizersGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-m1-sanGitHub Actions
test-r-macos-as-cranGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.2-jammyAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

This PR was getting unwieldy, I opened a new fresh one at #48414

@pitroupitrou closed this Dec 9, 2025
@pitrou
pitrou deleted the cxx20-experiment branch December 9, 2025 09:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou@kou@nealrichardson@assignUser
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

[EXP] GH-44792: [C++] Require C++20 - #45445

Closed
pitrou wants to merge 2 commits into
apache:mainfrom
pitrou:cxx20-experiment
Closed

[EXP] GH-44792: [C++] Require C++20#45445
pitrou wants to merge 2 commits into
apache:mainfrom
pitrou:cxx20-experiment

Conversation

@pitrou

Copy link
Copy Markdown
Member

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python -g wheel

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g linux -g r

@github-actions

This comment was marked as outdated.

@pitrou

pitrou commented Feb 6, 2025

Copy link
Copy Markdown
MemberAuthor

So, it seems two main issues may be blocking this:

  1. The AWS SDK fails to build ("Could not determine support for atomic operations")
  2. CentOS 8 and Almalinux 8 do not have a C++20 compliant C++ stdlib (by default)

Edit: a couple R builds also seem to have a non-C++20 compliant stdlib.

@kou What is our policy for Almalinux and CentOS support?

@kou

kou commented Feb 7, 2025

Copy link
Copy Markdown
Member

We can use gcc-toolset-{9,10,11,12,13,14} on AlmaLinux 8 and CentOS Stream 8 if we needed. For example, AlmaLinux 9 uses gcc-toolset-12:


@pitrou

Copy link
Copy Markdown
MemberAuthor

I see, thanks. So there are probably no insurmountable issues against switching to C++20. Of course, this will have to be discussed on the ML at some point (and there's no urgency).

@kou

kou commented Feb 7, 2025

Copy link
Copy Markdown
Member

this will have to be discussed on the ML at some point

Right.

FYI: There is a related issue: #44792

@pitroupitrou changed the title EXP: [C++] Require C++20[EXP] GH-44792: [C++] Require C++20Feb 27, 2025
@pitrou
pitrouforce-pushed the cxx20-experiment branch 2 times, most recently from 1244c29 to bc7811aCompareMarch 18, 2025 11:15
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit centos*

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheelcp313*

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g r

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pitrou

pitrou commented Apr 23, 2025

Copy link
Copy Markdown
MemberAuthor

@assignUser See R Crossbow build results just above. Can you check whether the failures are actually related?

Comment threaddev/release/verify-yum.sh Outdated
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Apr 24, 2025
@assignUser

Copy link
Copy Markdown
Member

@pitrou They are not related, they all show the same error that also shows up in the nightly builds:

── Error ('test-s3-minio.R:64:1'): copy files with s3 ──────────────────────────
Error: Key error: Attempted to register factory for scheme 's3' but that scheme is already registered.
Backtrace:
▆
1. └─arrow::copy_files(uri_formatter("hive_dir"), td) at tests/testthat/helper-filesystems.R:173:7
2. └─arrow:::get_path_and_filesystem(from)
3. └─arrow:::get_paths_and_filesystem(x, filesystem)
4. └─base::lapply(x, FileSystem$from_uri)
5. └─arrow (local) FUN(X[[i]], ...)
6. └─arrow:::fs___FileSystemFromUri(uri)

@pitrou

Copy link
Copy Markdown
MemberAuthor

@pitrou They are not related, they all show the same error that also shows up in the nightly builds:

Relatedly, is someone trying to fix them? Is there an issue open?

@pitrou
pitrouforce-pushed the cxx20-experiment branch from 41b3f1d to 16eca75CompareMay 19, 2025 12:54
@github-actionsgithub-actionsBot added awaiting change review Awaiting change review and removed Component: FlightRPC awaiting changes Awaiting changes labels May 19, 2025
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheelcp313*

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-8c72ad3e54

TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-884015d237

TaskStatus
example-cpp-minimal-build-staticGitHub Actions
example-cpp-minimal-build-static-system-dependencyGitHub Actions
example-cpp-tutorialGitHub Actions
example-python-minimal-build-fedora-condaGitHub Actions
example-python-minimal-build-ubuntu-venvGitHub Actions
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-mesonGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightlyGitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightlyGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.12-cpython-debugGitHub Actions
test-conda-python-3.13GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5GitHub Actions
test-conda-python-emscriptenGitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-debian-12-python-3-amd64GitHub Actions
test-debian-12-python-3-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-fedora-39-python-3GitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-bundledGitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-22.04-python-3GitHub Actions
test-ubuntu-22.04-python-313-freethreadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-bundled-offlineGitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-24.04-python-3GitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g linux

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-43a66e208a

TaskStatus
almalinux-8-amd64GitHub Actions
almalinux-8-arm64GitHub Actions
almalinux-9-amd64GitHub Actions
almalinux-9-arm64GitHub Actions
amazon-linux-2023-amd64GitHub Actions
amazon-linux-2023-arm64GitHub Actions
centos-7-amd64GitHub Actions
centos-8-stream-amd64GitHub Actions
centos-8-stream-arm64GitHub Actions
centos-9-stream-amd64GitHub Actions
centos-9-stream-arm64GitHub Actions
debian-bookworm-amd64GitHub Actions
debian-bookworm-arm64GitHub Actions
debian-trixie-amd64GitHub Actions
debian-trixie-arm64GitHub Actions
ubuntu-jammy-amd64GitHub Actions
ubuntu-jammy-arm64GitHub Actions
ubuntu-noble-amd64GitHub Actions
ubuntu-noble-arm64GitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g r

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-3da723357b

TaskStatus
r-binary-packagesGitHub Actions
r-recheck-mostGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-extra-packagesGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-sanitizersGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-m1-sanGitHub Actions
test-r-macos-as-cranGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.2-jammyAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

This PR was getting unwieldy, I opened a new fresh one at #48414

@pitroupitrou closed this Dec 9, 2025
@pitrou
pitrou deleted the cxx20-experiment branch December 9, 2025 09:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou@kou@nealrichardson@assignUser
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[EXP] GH-44792: [C++] Require C++20 - #45445

Closed
pitrou wants to merge 2 commits into
apache:mainfrom
pitrou:cxx20-experiment
Closed

[EXP] GH-44792: [C++] Require C++20#45445
pitrou wants to merge 2 commits into
apache:mainfrom
pitrou:cxx20-experiment

Conversation

@pitrou

Copy link
Copy Markdown
Member

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python -g wheel

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g linux -g r

@github-actions

This comment was marked as outdated.

@pitrou

pitrou commented Feb 6, 2025

Copy link
Copy Markdown
MemberAuthor

So, it seems two main issues may be blocking this:

  1. The AWS SDK fails to build ("Could not determine support for atomic operations")
  2. CentOS 8 and Almalinux 8 do not have a C++20 compliant C++ stdlib (by default)

Edit: a couple R builds also seem to have a non-C++20 compliant stdlib.

@kou What is our policy for Almalinux and CentOS support?

@kou

kou commented Feb 7, 2025

Copy link
Copy Markdown
Member

We can use gcc-toolset-{9,10,11,12,13,14} on AlmaLinux 8 and CentOS Stream 8 if we needed. For example, AlmaLinux 9 uses gcc-toolset-12:


@pitrou

Copy link
Copy Markdown
MemberAuthor

I see, thanks. So there are probably no insurmountable issues against switching to C++20. Of course, this will have to be discussed on the ML at some point (and there's no urgency).

@kou

kou commented Feb 7, 2025

Copy link
Copy Markdown
Member

this will have to be discussed on the ML at some point

Right.

FYI: There is a related issue: #44792

@pitroupitrou changed the title EXP: [C++] Require C++20[EXP] GH-44792: [C++] Require C++20Feb 27, 2025
@pitrou
pitrouforce-pushed the cxx20-experiment branch 2 times, most recently from 1244c29 to bc7811aCompareMarch 18, 2025 11:15
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit centos*

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheelcp313*

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g r

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pitrou

pitrou commented Apr 23, 2025

Copy link
Copy Markdown
MemberAuthor

@assignUser See R Crossbow build results just above. Can you check whether the failures are actually related?

Comment threaddev/release/verify-yum.sh Outdated
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Apr 24, 2025
@assignUser

Copy link
Copy Markdown
Member

@pitrou They are not related, they all show the same error that also shows up in the nightly builds:

── Error ('test-s3-minio.R:64:1'): copy files with s3 ──────────────────────────
Error: Key error: Attempted to register factory for scheme 's3' but that scheme is already registered.
Backtrace:
▆
1. └─arrow::copy_files(uri_formatter("hive_dir"), td) at tests/testthat/helper-filesystems.R:173:7
2. └─arrow:::get_path_and_filesystem(from)
3. └─arrow:::get_paths_and_filesystem(x, filesystem)
4. └─base::lapply(x, FileSystem$from_uri)
5. └─arrow (local) FUN(X[[i]], ...)
6. └─arrow:::fs___FileSystemFromUri(uri)

@pitrou

Copy link
Copy Markdown
MemberAuthor

@pitrou They are not related, they all show the same error that also shows up in the nightly builds:

Relatedly, is someone trying to fix them? Is there an issue open?

@pitrou
pitrouforce-pushed the cxx20-experiment branch from 41b3f1d to 16eca75CompareMay 19, 2025 12:54
@github-actionsgithub-actionsBot added awaiting change review Awaiting change review and removed Component: FlightRPC awaiting changes Awaiting changes labels May 19, 2025
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheelcp313*

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-8c72ad3e54

TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-884015d237

TaskStatus
example-cpp-minimal-build-staticGitHub Actions
example-cpp-minimal-build-static-system-dependencyGitHub Actions
example-cpp-tutorialGitHub Actions
example-python-minimal-build-fedora-condaGitHub Actions
example-python-minimal-build-ubuntu-venvGitHub Actions
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-mesonGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightlyGitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightlyGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.12-cpython-debugGitHub Actions
test-conda-python-3.13GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5GitHub Actions
test-conda-python-emscriptenGitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-debian-12-python-3-amd64GitHub Actions
test-debian-12-python-3-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-fedora-39-python-3GitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-bundledGitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-22.04-python-3GitHub Actions
test-ubuntu-22.04-python-313-freethreadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-bundled-offlineGitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-24.04-python-3GitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g linux

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-43a66e208a

TaskStatus
almalinux-8-amd64GitHub Actions
almalinux-8-arm64GitHub Actions
almalinux-9-amd64GitHub Actions
almalinux-9-arm64GitHub Actions
amazon-linux-2023-amd64GitHub Actions
amazon-linux-2023-arm64GitHub Actions
centos-7-amd64GitHub Actions
centos-8-stream-amd64GitHub Actions
centos-8-stream-arm64GitHub Actions
centos-9-stream-amd64GitHub Actions
centos-9-stream-arm64GitHub Actions
debian-bookworm-amd64GitHub Actions
debian-bookworm-arm64GitHub Actions
debian-trixie-amd64GitHub Actions
debian-trixie-arm64GitHub Actions
ubuntu-jammy-amd64GitHub Actions
ubuntu-jammy-arm64GitHub Actions
ubuntu-noble-amd64GitHub Actions
ubuntu-noble-arm64GitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g r

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-3da723357b

TaskStatus
r-binary-packagesGitHub Actions
r-recheck-mostGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-extra-packagesGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-sanitizersGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-m1-sanGitHub Actions
test-r-macos-as-cranGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.2-jammyAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

This PR was getting unwieldy, I opened a new fresh one at #48414

@pitroupitrou closed this Dec 9, 2025
@pitrou
pitrou deleted the cxx20-experiment branch December 9, 2025 09:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou@kou@nealrichardson@assignUser
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[EXP] GH-44792: [C++] Require C++20 - #45445

Closed
pitrou wants to merge 2 commits into
apache:mainfrom
pitrou:cxx20-experiment
Closed

[EXP] GH-44792: [C++] Require C++20#45445
pitrou wants to merge 2 commits into
apache:mainfrom
pitrou:cxx20-experiment

Conversation

@pitrou

Copy link
Copy Markdown
Member

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python -g wheel

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g linux -g r

@github-actions

This comment was marked as outdated.

@pitrou

pitrou commented Feb 6, 2025

Copy link
Copy Markdown
MemberAuthor

So, it seems two main issues may be blocking this:

  1. The AWS SDK fails to build ("Could not determine support for atomic operations")
  2. CentOS 8 and Almalinux 8 do not have a C++20 compliant C++ stdlib (by default)

Edit: a couple R builds also seem to have a non-C++20 compliant stdlib.

@kou What is our policy for Almalinux and CentOS support?

@kou

kou commented Feb 7, 2025

Copy link
Copy Markdown
Member

We can use gcc-toolset-{9,10,11,12,13,14} on AlmaLinux 8 and CentOS Stream 8 if we needed. For example, AlmaLinux 9 uses gcc-toolset-12:


@pitrou

Copy link
Copy Markdown
MemberAuthor

I see, thanks. So there are probably no insurmountable issues against switching to C++20. Of course, this will have to be discussed on the ML at some point (and there's no urgency).

@kou

kou commented Feb 7, 2025

Copy link
Copy Markdown
Member

this will have to be discussed on the ML at some point

Right.

FYI: There is a related issue: #44792

@pitroupitrou changed the title EXP: [C++] Require C++20[EXP] GH-44792: [C++] Require C++20Feb 27, 2025
@pitrou
pitrouforce-pushed the cxx20-experiment branch 2 times, most recently from 1244c29 to bc7811aCompareMarch 18, 2025 11:15
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit centos*

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheelcp313*

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g r

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pitrou

pitrou commented Apr 23, 2025

Copy link
Copy Markdown
MemberAuthor

@assignUser See R Crossbow build results just above. Can you check whether the failures are actually related?

Comment threaddev/release/verify-yum.sh Outdated
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Apr 24, 2025
@assignUser

Copy link
Copy Markdown
Member

@pitrou They are not related, they all show the same error that also shows up in the nightly builds:

── Error ('test-s3-minio.R:64:1'): copy files with s3 ──────────────────────────
Error: Key error: Attempted to register factory for scheme 's3' but that scheme is already registered.
Backtrace:
▆
1. └─arrow::copy_files(uri_formatter("hive_dir"), td) at tests/testthat/helper-filesystems.R:173:7
2. └─arrow:::get_path_and_filesystem(from)
3. └─arrow:::get_paths_and_filesystem(x, filesystem)
4. └─base::lapply(x, FileSystem$from_uri)
5. └─arrow (local) FUN(X[[i]], ...)
6. └─arrow:::fs___FileSystemFromUri(uri)

@pitrou

Copy link
Copy Markdown
MemberAuthor

@pitrou They are not related, they all show the same error that also shows up in the nightly builds:

Relatedly, is someone trying to fix them? Is there an issue open?

@pitrou
pitrouforce-pushed the cxx20-experiment branch from 41b3f1d to 16eca75CompareMay 19, 2025 12:54
@github-actionsgithub-actionsBot added awaiting change review Awaiting change review and removed Component: FlightRPC awaiting changes Awaiting changes labels May 19, 2025
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheelcp313*

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-8c72ad3e54

TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-884015d237

TaskStatus
example-cpp-minimal-build-staticGitHub Actions
example-cpp-minimal-build-static-system-dependencyGitHub Actions
example-cpp-tutorialGitHub Actions
example-python-minimal-build-fedora-condaGitHub Actions
example-python-minimal-build-ubuntu-venvGitHub Actions
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-mesonGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightlyGitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightlyGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.12-cpython-debugGitHub Actions
test-conda-python-3.13GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5GitHub Actions
test-conda-python-emscriptenGitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-debian-12-python-3-amd64GitHub Actions
test-debian-12-python-3-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-fedora-39-python-3GitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-bundledGitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-22.04-python-3GitHub Actions
test-ubuntu-22.04-python-313-freethreadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-bundled-offlineGitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-24.04-python-3GitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g linux

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-43a66e208a

TaskStatus
almalinux-8-amd64GitHub Actions
almalinux-8-arm64GitHub Actions
almalinux-9-amd64GitHub Actions
almalinux-9-arm64GitHub Actions
amazon-linux-2023-amd64GitHub Actions
amazon-linux-2023-arm64GitHub Actions
centos-7-amd64GitHub Actions
centos-8-stream-amd64GitHub Actions
centos-8-stream-arm64GitHub Actions
centos-9-stream-amd64GitHub Actions
centos-9-stream-arm64GitHub Actions
debian-bookworm-amd64GitHub Actions
debian-bookworm-arm64GitHub Actions
debian-trixie-amd64GitHub Actions
debian-trixie-arm64GitHub Actions
ubuntu-jammy-amd64GitHub Actions
ubuntu-jammy-arm64GitHub Actions
ubuntu-noble-amd64GitHub Actions
ubuntu-noble-arm64GitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g r

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-3da723357b

TaskStatus
r-binary-packagesGitHub Actions
r-recheck-mostGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-extra-packagesGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-sanitizersGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-m1-sanGitHub Actions
test-r-macos-as-cranGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.2-jammyAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

This PR was getting unwieldy, I opened a new fresh one at #48414

@pitroupitrou closed this Dec 9, 2025
@pitrou
pitrou deleted the cxx20-experiment branch December 9, 2025 09:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou@kou@nealrichardson@assignUser
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

[EXP] GH-44792: [C++] Require C++20 - #45445

Closed
pitrou wants to merge 2 commits into
apache:mainfrom
pitrou:cxx20-experiment
Closed

[EXP] GH-44792: [C++] Require C++20#45445
pitrou wants to merge 2 commits into
apache:mainfrom
pitrou:cxx20-experiment

Conversation

@pitrou

Copy link
Copy Markdown
Member

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python -g wheel

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g linux -g r

@github-actions

This comment was marked as outdated.

@pitrou

pitrou commented Feb 6, 2025

Copy link
Copy Markdown
MemberAuthor

So, it seems two main issues may be blocking this:

  1. The AWS SDK fails to build ("Could not determine support for atomic operations")
  2. CentOS 8 and Almalinux 8 do not have a C++20 compliant C++ stdlib (by default)

Edit: a couple R builds also seem to have a non-C++20 compliant stdlib.

@kou What is our policy for Almalinux and CentOS support?

@kou

kou commented Feb 7, 2025

Copy link
Copy Markdown
Member

We can use gcc-toolset-{9,10,11,12,13,14} on AlmaLinux 8 and CentOS Stream 8 if we needed. For example, AlmaLinux 9 uses gcc-toolset-12:


@pitrou

Copy link
Copy Markdown
MemberAuthor

I see, thanks. So there are probably no insurmountable issues against switching to C++20. Of course, this will have to be discussed on the ML at some point (and there's no urgency).

@kou

kou commented Feb 7, 2025

Copy link
Copy Markdown
Member

this will have to be discussed on the ML at some point

Right.

FYI: There is a related issue: #44792

@pitroupitrou changed the title EXP: [C++] Require C++20[EXP] GH-44792: [C++] Require C++20Feb 27, 2025
@pitrou
pitrouforce-pushed the cxx20-experiment branch 2 times, most recently from 1244c29 to bc7811aCompareMarch 18, 2025 11:15
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit centos*

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheelcp313*

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g r

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pitrou

pitrou commented Apr 23, 2025

Copy link
Copy Markdown
MemberAuthor

@assignUser See R Crossbow build results just above. Can you check whether the failures are actually related?

Comment threaddev/release/verify-yum.sh Outdated
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Apr 24, 2025
@assignUser

Copy link
Copy Markdown
Member

@pitrou They are not related, they all show the same error that also shows up in the nightly builds:

── Error ('test-s3-minio.R:64:1'): copy files with s3 ──────────────────────────
Error: Key error: Attempted to register factory for scheme 's3' but that scheme is already registered.
Backtrace:
▆
1. └─arrow::copy_files(uri_formatter("hive_dir"), td) at tests/testthat/helper-filesystems.R:173:7
2. └─arrow:::get_path_and_filesystem(from)
3. └─arrow:::get_paths_and_filesystem(x, filesystem)
4. └─base::lapply(x, FileSystem$from_uri)
5. └─arrow (local) FUN(X[[i]], ...)
6. └─arrow:::fs___FileSystemFromUri(uri)

@pitrou

Copy link
Copy Markdown
MemberAuthor

@pitrou They are not related, they all show the same error that also shows up in the nightly builds:

Relatedly, is someone trying to fix them? Is there an issue open?

@pitrou
pitrouforce-pushed the cxx20-experiment branch from 41b3f1d to 16eca75CompareMay 19, 2025 12:54
@github-actionsgithub-actionsBot added awaiting change review Awaiting change review and removed Component: FlightRPC awaiting changes Awaiting changes labels May 19, 2025
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheelcp313*

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-8c72ad3e54

TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-884015d237

TaskStatus
example-cpp-minimal-build-staticGitHub Actions
example-cpp-minimal-build-static-system-dependencyGitHub Actions
example-cpp-tutorialGitHub Actions
example-python-minimal-build-fedora-condaGitHub Actions
example-python-minimal-build-ubuntu-venvGitHub Actions
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-mesonGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightlyGitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightlyGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.12-cpython-debugGitHub Actions
test-conda-python-3.13GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5GitHub Actions
test-conda-python-emscriptenGitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-debian-12-python-3-amd64GitHub Actions
test-debian-12-python-3-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-fedora-39-python-3GitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-bundledGitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-22.04-python-3GitHub Actions
test-ubuntu-22.04-python-313-freethreadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-bundled-offlineGitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-24.04-python-3GitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g linux

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-43a66e208a

TaskStatus
almalinux-8-amd64GitHub Actions
almalinux-8-arm64GitHub Actions
almalinux-9-amd64GitHub Actions
almalinux-9-arm64GitHub Actions
amazon-linux-2023-amd64GitHub Actions
amazon-linux-2023-arm64GitHub Actions
centos-7-amd64GitHub Actions
centos-8-stream-amd64GitHub Actions
centos-8-stream-arm64GitHub Actions
centos-9-stream-amd64GitHub Actions
centos-9-stream-arm64GitHub Actions
debian-bookworm-amd64GitHub Actions
debian-bookworm-arm64GitHub Actions
debian-trixie-amd64GitHub Actions
debian-trixie-arm64GitHub Actions
ubuntu-jammy-amd64GitHub Actions
ubuntu-jammy-arm64GitHub Actions
ubuntu-noble-amd64GitHub Actions
ubuntu-noble-arm64GitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g r

@github-actions

Copy link
Copy Markdown

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-3da723357b

TaskStatus
r-binary-packagesGitHub Actions
r-recheck-mostGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-extra-packagesGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-sanitizersGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-m1-sanGitHub Actions
test-r-macos-as-cranGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.2-jammyAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

This PR was getting unwieldy, I opened a new fresh one at #48414

@pitroupitrou closed this Dec 9, 2025
@pitrou
pitrou deleted the cxx20-experiment branch December 9, 2025 09:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou@kou@nealrichardson@assignUser