GH-49552: [C++][FlightRPC][ODBC] Enable ODBC test build on Linux by justing-bq · Pull Request #49668 · apache/arrow

justing-bq · 2026-04-06T20:26:50Z

Rationale for this change

The test suite needs to be updated so it will build on Linux in addition to Windows & Mac.
Resolves#49552

What changes are included in this PR?

Miscellaneous changes to get the tests building on Linux.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

GitHub Issue: [C++][FlightRPC][ODBC] Enable ODBC test build on Linux #49552

github-actions · 2026-04-06T20:27:15Z

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

Pull request overview

Enables building the Flight SQL ODBC C++ test suite on Linux by removing the platform gate in CMake and updating tests/helpers to better handle platform differences in SQLWCHAR and wide-string handling.

Changes:

Always add the ODBC tests subdirectory when ARROW_BUILD_TESTS is enabled (including Linux).
Refactor many tests to avoid relying on L""/wcslen assumptions and to use helper macros/utilities for SQLWCHAR.
Adjust CI to exclude running the ODBC test binary on Linux while still building it.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
cpp/src/arrow/flight/sql/odbc/tests/type_info_test.cc	Switches expected column name handling and replaces `NULL` sentinel usage with numeric values.
cpp/src/arrow/flight/sql/odbc/tests/tables_test.cc	Updates `SQLWCHAR` parameter initialization and column-name comparisons for portability.
cpp/src/arrow/flight/sql/odbc/tests/statement_test.cc	Introduces `ASSIGN_SQLWCHAR_ARR_AND_LEN` usage and adjusts string comparisons/conversions.
cpp/src/arrow/flight/sql/odbc/tests/statement_attr_test.cc	Uses the new `SQLWCHAR` assignment helper macro for query strings.
cpp/src/arrow/flight/sql/odbc/tests/odbc_test_suite.h	Adds Linux-specific `SQLWCHAR` assignment macros and declares new conversion helpers.
cpp/src/arrow/flight/sql/odbc/tests/odbc_test_suite.cc	Implements new `SQLWCHAR` length/conversion helpers and tweaks DSN registration call.
cpp/src/arrow/flight/sql/odbc/tests/errors_test.cc	Avoids constructing `std::wstring` directly from `SQLWCHAR*` by converting to UTF-8 first.
cpp/src/arrow/flight/sql/odbc/tests/connection_test.cc	Makes output buffers consistently zero-initialized.
cpp/src/arrow/flight/sql/odbc/tests/connection_info_test.cc	Renames helper and converts many wide-string assertions to use `ConvertToWString`.
cpp/src/arrow/flight/sql/odbc/tests/columns_test.cc	Updates `SQLWCHAR` parameter handling and metadata assertions for Linux builds.
cpp/src/arrow/flight/sql/odbc/CMakeLists.txt	Removes Windows/macOS-only gating so tests are built on Linux too.
ci/scripts/cpp_test.sh	Excludes `arrow-flight-sql-odbc-test` from Linux test execution.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

alinaliBQ

I have 1 comment

alinaliBQ

LGTM

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

justing-bq · 2026-04-24T00:11:29Z

@lidavidm @kou
Please take a look when you have time.

justing-bq · 2026-05-19T22:12:49Z

@lidavidm @kou
Please take a look when you have time.

kou

+1

The ODBC test on Linux is failing. It's out-of-scope of this PR, right?

kou · 2026-05-20T01:33:28Z

 fi
 case "$(uname)" in
 Linux)
+ exclude_tests+=("arrow-flight-sql-odbc-test")


We remove this later, right?

Correct. This gets removed in 9e8272d.

Which PR does include the commit?
GH-49786?

#49786 which will be undrafted as soon as this PR gets merged.

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

justing-bq · 2026-05-20T23:21:09Z

@kou @lidavidm
Comments addressed. Please review.

conbench-apache-arrow · 2026-05-21T09:28:08Z

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 62cdda9.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

conbench-apache-arrow · 2026-05-22T03:58:47Z

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 62cdda9.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

apache#49668) ### Rationale for this change The test suite needs to be updated so it will build on Linux in addition to Windows & Mac. Resolvesapache#49552 ### What changes are included in this PR? Miscellaneous changes to get the tests building on Linux. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#49552 Authored-by: justing-bq <62349012+justing-bq@users.noreply.github.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>

) ### Rationale for this change After getting the tests building on Linux, the next step is to get all the tests passing. Resolves#49785. ### What changes are included in this PR? Miscellaneous fixes. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. Depends on #49668 and #49784 before being ready for review. * GitHub Issue: #49785 Authored-by: justing-bq <62349012+justing-bq@users.noreply.github.com> Signed-off-by: David Li <li.davidm96@gmail.com>

github-actionsBot added Component: C++ Component: FlightRPC CI: Extra: C++ Run extra C++ CI awaiting review Awaiting review labels Apr 6, 2026

justing-bq changed the title ~~[C++][FlightRPC][ODBC] Enable ODBC test build on Linux~~GH-49552: [C++][FlightRPC][ODBC] Enable ODBC test build on LinuxApr 6, 2026

justing-bq force-pushed the gh-49552-linux-test-build branch from 71ade9f to ccf583aCompare April 15, 2026 17:39

justing-bq marked this pull request as ready for review April 15, 2026 17:40

justing-bq requested review from assignUser, jonkeane, kou, lidavidm and raulcd as code owners April 15, 2026 17:40

kou requested review from alinaliBQ and Copilot April 15, 2026 21:27

Copilotstarted reviewing on behalf of kou April 15, 2026 21:28 View session

CopilotAI reviewed Apr 15, 2026
View reviewed changes

alinaliBQ reviewed Apr 15, 2026
View reviewed changes

Comment threadcpp/src/arrow/flight/sql/odbc/tests/odbc_test_suite.cc Outdated

github-actionsBot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Apr 15, 2026

justing-bq mentioned this pull request Apr 17, 2026
GH-49785: [C++][FlightRPC][ODBC] Get ODBC tests passing on Linux #49786
Merged

alinaliBQ approved these changes Apr 20, 2026
View reviewed changes

kou requested a review from Copilot April 20, 2026 20:38

Copilotstarted reviewing on behalf of kou April 20, 2026 20:38 View session

CopilotAI reviewed Apr 20, 2026
View reviewed changes

Comment threadcpp/src/arrow/flight/sql/odbc/tests/odbc_test_suite.h
Comment threadcpp/src/arrow/flight/sql/odbc/tests/odbc_test_suite.cc

justing-bq force-pushed the gh-49552-linux-test-build branch from 27c116c to df15956Compare April 22, 2026 23:19

justing-bq force-pushed the gh-49552-linux-test-build branch from df15956 to 1a69faeCompare April 27, 2026 21:15

justing-bq force-pushed the gh-49552-linux-test-build branch 3 times, most recently from 240837a to e34824aCompare May 5, 2026 21:24

justing-bq force-pushed the gh-49552-linux-test-build branch from e34824a to 6d036ceCompare May 19, 2026 18:46

kou requested a review from Copilot May 20, 2026 01:31

Copilotstarted reviewing on behalf of kou May 20, 2026 01:31 View session

kou approved these changes May 20, 2026
View reviewed changes

github-actionsBot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels May 20, 2026

CopilotAI reviewed May 20, 2026
View reviewed changes

Comment threadci/scripts/cpp_test.sh

justing-bq added 2 commits May 20, 2026 10:18

Enable ODBC test build on Linux
9c88ee5

Address review feedback
682bab2

justing-bq force-pushed the gh-49552-linux-test-build branch from 6d036ce to 682bab2Compare May 20, 2026 17:46

github-actionsBot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels May 21, 2026

kou merged commit 62cdda9 into apache:mainMay 21, 2026
61 of 66 checks passed

kou removed the awaiting changes Awaiting changes label May 21, 2026

kou mentioned this pull request May 21, 2026
[C++][FlightRPC][ODBC] Enable ODBC test build on Linux #49552
Closed

Uh oh!

Conversation

justing-bq commented Apr 6, 2026• edited by github-actions BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actionsBot commented Apr 6, 2026

Uh oh!

github-actionsBot commented Apr 6, 2026

Uh oh!

justing-bq commented Apr 15, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alinaliBQ left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alinaliBQ left a comment

Choose a reason for hiding this comment

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

justing-bq commented Apr 24, 2026

Uh oh!

justing-bq commented May 19, 2026

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

kouMay 20, 2026

Choose a reason for hiding this comment

Uh oh!

justing-bqMay 20, 2026

Choose a reason for hiding this comment

Uh oh!

kouMay 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justing-bqMay 21, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

justing-bq commented May 20, 2026

Uh oh!

Uh oh!

conbench-apache-arrowBot commented May 21, 2026

Uh oh!

conbench-apache-arrowBot commented May 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

justing-bq commented Apr 6, 2026•
edited by github-actions Bot
Loading

kouMay 21, 2026•
edited
Loading