Skip to content

GH-49785: [C++][FlightRPC][ODBC] Get ODBC tests passing on Linux - #49786

Merged
lidavidm merged 1 commit into
apache:mainfrom
Bit-Quill:gh-49785-fix-linux-tests
Jun 12, 2026
Merged

GH-49785: [C++][FlightRPC][ODBC] Get ODBC tests passing on Linux#49786
lidavidm merged 1 commit into
apache:mainfrom
Bit-Quill:gh-49785-fix-linux-tests

Conversation

@justing-bq

@justing-bqjusting-bq commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

After getting the tests building on Linux, the next step is to get all the tests passing.
Resolves#49785.

What changes are included in this PR?

Miscellaneous fixes.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Depends on #49668 and #49784 before being ready for review.

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #49785has been automatically assigned in GitHub to PR creator.

@justing-bq
justing-bqforce-pushed the gh-49785-fix-linux-tests branch 2 times, most recently from e35dfe8 to 9e8272dCompareMay 20, 2026 18:00
@justing-bq
justing-bqforce-pushed the gh-49785-fix-linux-tests branch from 9e8272d to 0ef857dCompareMay 21, 2026 16:54
@justing-bq
justing-bq marked this pull request as ready for review May 21, 2026 17:07
@justing-bq
justing-bqforce-pushed the gh-49785-fix-linux-tests branch from 0ef857d to 3439e98CompareMay 21, 2026 19:01
@justing-bq

Copy link
Copy Markdown
ContributorAuthor

@lidavidm@kou
Please take a look when you have time.

@kou

kou commented May 22, 2026

Copy link
Copy Markdown
Member

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Flight SQL ODBC C++ test suite to pass on Linux by updating platform-specific expectations, selectively disabling known-problematic tests on Linux, and re-enabling the ODBC test target in Linux CI.

Changes:

  • Update multiple ODBC tests to reflect Linux/Unix-ODBC vs Windows vs macOS driver-manager behavior (return codes, SQLSTATEs, and reported info strings).
  • Disable a subset of metadata-related tests on Linux due to an acknowledged BlockingQueue issue (GH-49702).
  • Re-enable arrow-flight-sql-odbc-test execution on Linux in CI.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
FileDescription
cpp/src/arrow/flight/sql/odbc/tests/type_info_test.ccAdjust expected SQLGetTypeInfo results for SQL_TYPE_* across Windows vs non-Windows.
cpp/src/arrow/flight/sql/odbc/tests/tables_test.ccReorder typed tests and disable several table-metadata tests on Linux (GH-49702).
cpp/src/arrow/flight/sql/odbc/tests/statement_test.ccAdjust varbinary byte comparisons and add Linux-specific expectations for some APIs.
cpp/src/arrow/flight/sql/odbc/tests/statement_attr_test.ccLinux-specific SQLSTATE expectation for an unsupported stmt attribute.
cpp/src/arrow/flight/sql/odbc/tests/odbc_test_suite.hAdd kErrorState00000 constant for tests expecting a “success” SQLSTATE.
cpp/src/arrow/flight/sql/odbc/tests/get_functions_test.ccRestrict SQLGetFunctions tests to Windows due to Unix driver-manager limitations.
cpp/src/arrow/flight/sql/odbc/tests/errors_test.ccPlatform-specific expectations for invalid-handle behavior and SQLSTATE differences.
cpp/src/arrow/flight/sql/odbc/tests/connection_info_test.ccDisable one info test on Linux and adjust expected SQL_ODBC_VER values.
cpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.ccAdd pre-connect fixture and adjust platform-specific behavior for several connection attributes.
cpp/src/arrow/flight/sql/odbc/tests/columns_test.ccDisable column-metadata helpers/tests on Linux (GH-49702) and tighten Unicode column checks.
ci/scripts/cpp_test.shStop excluding arrow-flight-sql-odbc-test on Linux.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadcpp/src/arrow/flight/sql/odbc/tests/statement_test.cc Outdated
Comment threadcpp/src/arrow/flight/sql/odbc/tests/statement_test.cc Outdated
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_info_test.cc Outdated
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
@justing-bq

justing-bq commented May 22, 2026

Copy link
Copy Markdown
ContributorAuthor

Is the ODBC Linux job failure tracked? https://github.com/apache/arrow/actions/runs/26246962168/job/77247867378?pr=49786

This failure is due to a problem with arrow-flight-test.
arrow-flight-sql-odbc-test is passing fine.

@github-actionsgithub-actionsBot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels May 22, 2026
@justing-bq
justing-bqforce-pushed the gh-49785-fix-linux-tests branch from eb84cd0 to 549d4c2CompareMay 22, 2026 18:16
@alinaliBQ

Copy link
Copy Markdown
Collaborator

Is the ODBC Linux job failure tracked? https://github.com/apache/arrow/actions/runs/26246962168/job/77247867378?pr=49786

This failure is due to a problem with arrow-flight-test. arrow-flight-sql-odbc-test is passing fine.

Yup, and the failure is tracked in issue #49767. cc @kou

@justing-bq

Copy link
Copy Markdown
ContributorAuthor

@kou@lidavidm
Comments addressed. Please review.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Comment threadcpp/src/arrow/flight/sql/odbc/tests/tables_test.cc
Comment threadcpp/src/arrow/flight/sql/odbc/tests/statement_test.cc Outdated
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
@justing-bq

Copy link
Copy Markdown
ContributorAuthor

@kou@lidavidm
Comments addressed. Please review.

@justing-bq
justing-bqforce-pushed the gh-49785-fix-linux-tests branch from f2b988e to 9251e8cCompareJune 8, 2026 17:22
@justing-bq
justing-bqforce-pushed the gh-49785-fix-linux-tests branch from 9251e8c to 7287c6bCompareJune 11, 2026 17:33

@lidavidmlidavidm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the test failure is in Gandiva and is unrelated.

@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 12, 2026
@lidavidm
lidavidm merged commit 16fe342 into apache:mainJun 12, 2026
61 of 62 checks passed
@lidavidmlidavidm removed the awaiting merge Awaiting merge label Jun 12, 2026
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 16fe342.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C++][FlightRPC][ODBC] Get ODBC tests passing on Linux

5 participants

@justing-bq@kou@alinaliBQ@lidavidm