Skip to content

GH-50022: [Dev] Enable auto GitHub Copilot review - #50023

Merged
raulcd merged 1 commit into
apache:mainfrom
kou:dev-enable-auto-github-copilot-review
May 25, 2026
Merged

GH-50022: [Dev] Enable auto GitHub Copilot review#50023
raulcd merged 1 commit into
apache:mainfrom
kou:dev-enable-auto-github-copilot-review

Conversation

@kou

@koukou commented May 22, 2026•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Rationale for this change

GitHub Copilot may reduce required review resource by committers.

What changes are included in this PR?

Add a configuration to .asf.yaml.

See also: https://github.com/apache/infrastructure-asfyaml#copilot_code_review

Are these changes tested?

No.

Are there any user-facing changes?

No.

@kou
kou requested a review from assignUser as a code ownerMay 22, 2026 22:07
CopilotAI review requested due to automatic review settings May 22, 2026 22:07
@kou
kou requested a review from raulcd as a code ownerMay 22, 2026 22:07
@github-actions

github-actionsBot commented May 22, 2026

Copy link
Copy Markdown

⚠️ GitHub issue #50022has been automatically assigned in GitHub to PR creator.

@github-actionsgithub-actionsBot added the awaiting committer review Awaiting committer review label May 22, 2026
CopilotAI reviewed May 22, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables automated GitHub Copilot code review for this repository via the ASF .asf.yaml GitHub integration configuration, aligning with the ASF asfyaml copilot_code_review feature referenced in GH-50022.

Changes:

  • Add github.copilot_code_review configuration with enabled: true.
  • Enable reviewing draft PRs (review_drafts: true) and reviewing on push (review_on_push: true).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@koukou mentioned this pull request May 22, 2026
Merged
raulcd
raulcd approved these changes May 25, 2026
View reviewed changes

@raulcdraulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding this will review all PRs without asking for it now, right? We can try it and see whether it helps.

@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels May 25, 2026
@kou

kou commented May 25, 2026

Copy link
Copy Markdown
MemberAuthor

Right.

@raulcd
raulcd merged commit 4ea1ad2 into apache:mainMay 25, 2026
10 checks passed
@raulcdraulcd removed the awaiting merge Awaiting merge label May 25, 2026
@raulcdraulcd mentioned this pull request May 25, 2026
Closed
@AlenkaF

AlenkaF commented May 25, 2026

Copy link
Copy Markdown
Member

Some feedback that might be useful:

  • I suggest we share the new auto review setup via Zulip (I bugged @raulcd when a PR of mine got reviewed as I missed this change)
  • I appreciate the gesture to help us with the maintenance burden! I think for lots of PRs that are waiting to get reviewed this is quite helpful.
  • On the other hand this feels too noisy for me. I would suggest turning off the auto AI review on draft PRs. Also, is there a possibility that the AI review is not triggered on every commit? Not sure how that would work, but I tend to split my changes into multiple commits for visibility reasons.
  • Is there any option of making the review less verbose? 😊

I am not against per se, but will need to get used to :)

@conbench-apache-arrow

conbench-apache-arrowBot commented May 25, 2026

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 4ea1ad2.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

@kou
kou deleted the dev-enable-auto-github-copilot-review branch May 25, 2026 20:13
@kou

kou commented May 25, 2026

Copy link
Copy Markdown
MemberAuthor

Sorry for not announcing this configuration widely!

I've started a discussion thread for this on dev@ (not Zulip) for broader visibility: https://lists.apache.org/thread/thq0dz19shxbrjypb81q5ltx8h0w54ob

Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
@kou@Mottl
apacheGH-50022: [Dev] Enable auto GitHub Copilot review (apache#50023)
a5f347a
### Rationale for this change
GitHub Copilot may reduce required review resource by committers.
### What changes are included in this PR?
Add a configuration to `.asf.yaml`.
See also: https://github.com/apache/infrastructure-asfyaml#copilot_code_review
### Are these changes tested?
No.
### Are there any user-facing changes?
No.
* GitHub Issue: apache#50022
Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
This was referenced Jun 6, 2026
Closed
Merged
kou added a commit that referenced this pull request Jun 14, 2026
@kou@raulcd@alamb
GH-50115: [Dev] Adjust GitHub Copilot configuration for preliminary r…
4fce185
…eviews (#50117)
### Rationale for this change
We tried auto GitHub Copilot reviews recently and discussed our experience for them:
https://lists.apache.org/thread/thq0dz19shxbrjypb81q5ltx8h0w54ob
We want to tune auto GitHub Copilot reviews:
* We don't need auto GitHub Copilot reviews for draft PR: https://lists.apache.org/thread/y7yc4yg9n4mdqd1y00w7s498y8m6yold
* GitHub Copilot review is too verbose: #50023 (comment)
* We need to document the expectation for contributors responding to GitHub Copilot reviews: https://lists.apache.org/thread/wvhdqqtq2ndxxjnqwnj39xfcys21tpc4
### What changes are included in this PR?
* Disable auto GitHub Copilot reviews for draft PR
* Add code review instructions for GitHub Copilot
* Base text is generated by Gemini 3 Flash Preview and I adjusted it
### Are these changes tested?
No. We need to merge this to test this.
### Are there any user-facing changes?
No.
* GitHub Issue: #50115
Lead-authored-by: Sutou Kouhei <kou@clear-code.com>
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@raulcdraulcdraulcd approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kou@AlenkaF@raulcd