Uh oh!
There was an error while loading. Please reload this page.
GH-50730: [C++] Do not use throwing <simdjson> api - #50732
Merged
Conversation
pitrou
reviewed
Jul 30, 2026
Uh oh!
There was an error while loading. Please reload this page.
pitrou
reviewed
Jul 30, 2026
pitrou
left a comment
Member
There was a problem hiding this comment.
Just one suggestion. Also, there are some compilation failures that need fixing.
Uh oh!
There was an error while loading. Please reload this page.
pitrou
approved these changes
Jul 30, 2026
pitrou
commented
Jul 30, 2026
Member
The JNI macOS compilation error may be related but this PR still improves on the statu quo, so I'll merge. |
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 86f8d42. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The simdjson API has a throwing and non-throwing subset. #50672 activated a compiler flag that disables the throwing subset of the API, which broke some CI builds.
What changes are included in this PR?
This changes
json_write_internal.ccandfrom_string.ccto use the non-throwing simdjson apiAre these changes tested?
Yes
Are there any user-facing changes?
No
<simdjson>api #50730