GH-50934: [C++][Dev] Fix shellcheck errors in cpp/build-support/run-test.sh by hiroyuki-sato · Pull Request #50935 · apache/arrow

hiroyuki-sato · 2026-08-21T00:58:48Z

Rationale for this change

This is the sub issue #44748.

SC2010: Don't use ls | grep. Use a glob or a for loop with a condition to allow non-alphanumeric filenames.
SC2035: Use ./glob or -- glob so names with dashes won't become options.
SC2046: Quote this to prevent word splitting.
SC2048: Use "$@" (with quotes) to prevent whitespace problems.
SC2086: Double quote to prevent globbing and word splitting.
SC2128: Expanding an array without an index only gives the element in the index 0.
SC2164: Use cd ... || exit in case cd fails.
SC2209: Use var=$(command) to assign output (or quote to assign string).


In cpp/build-support/run-test.sh line 28:
ROOT=$(cd $(dirname $BASH_SOURCE)/..; pwd)
^---------------------------^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
^---------------------^ SC2046 (warning): Quote this to prevent word splitting.
^----------^ SC2128 (warning): Expanding an array without an index only gives the first element.
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
ROOT=$(cd $(dirname "$BASH_SOURCE")/.. || exit; pwd)
In cpp/build-support/run-test.sh line 31:
mkdir -p $TEST_LOGDIR
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mkdir -p "$TEST_LOGDIR"
In cpp/build-support/run-test.sh line 36:
mkdir -p $TEST_DEBUGDIR
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mkdir -p "$TEST_DEBUGDIR"
In cpp/build-support/run-test.sh line 38:
TEST_DIRNAME=$(cd $(dirname $1); pwd)
^--------------^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
^-----------^ SC2046 (warning): Quote this to prevent word splitting.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
TEST_DIRNAME=$(cd $(dirname "$1") || exit; pwd)
In cpp/build-support/run-test.sh line 39:
TEST_FILENAME=$(basename $1)
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
TEST_FILENAME=$(basename "$1")
In cpp/build-support/run-test.sh line 42:
TEST_NAME=$(echo $TEST_FILENAME | sed -E -e 's/\..+$//') # Remove path and extension (if any).
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
TEST_NAME=$(echo "$TEST_FILENAME" | sed -E -e 's/\..+$//') # Remove path and extension (if any).
In cpp/build-support/run-test.sh line 46:
mkdir -p $TEST_WORKDIR
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mkdir -p "$TEST_WORKDIR"
In cpp/build-support/run-test.sh line 47:
pushd $TEST_WORKDIR >/dev/null || exit 1
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
pushd "$TEST_WORKDIR" >/dev/null || exit 1
In cpp/build-support/run-test.sh line 48:
rm -f *
^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.
In cpp/build-support/run-test.sh line 59:
rm -f $LOGFILE $LOGFILE.gz
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -f "$LOGFILE" "$LOGFILE".gz
In cpp/build-support/run-test.sh line 61:
pipe_cmd=cat
^------^ SC2209 (warning): Use var=$(command) to assign output (or quote to assign string).
In cpp/build-support/run-test.sh line 93:
rm -f $XMLFILE
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -f "$XMLFILE"
In cpp/build-support/run-test.sh line 95:
$TEST_EXECUTABLE "$@" > $LOGFILE.raw 2>&1
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
$TEST_EXECUTABLE "$@" > "$LOGFILE".raw 2>&1
In cpp/build-support/run-test.sh line 97:
cat $LOGFILE.raw \
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cat "$LOGFILE".raw \
In cpp/build-support/run-test.sh line 98:
| ${PYTHON:-python} $ROOT/build-support/asan_symbolize.py \
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
| ${PYTHON:-python} "$ROOT"/build-support/asan_symbolize.py \
In cpp/build-support/run-test.sh line 100:
| $pipe_cmd 2>&1 | tee $LOGFILE
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
| $pipe_cmd 2>&1 | tee "$LOGFILE"
In cpp/build-support/run-test.sh line 101:
rm -f $LOGFILE.raw
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -f "$LOGFILE".raw
In cpp/build-support/run-test.sh line 111:
if grep -E -q "ThreadSanitizer|Leak check.*detected leaks" $LOGFILE ; then
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if grep -E -q "ThreadSanitizer|Leak check.*detected leaks" "$LOGFILE" ; then
In cpp/build-support/run-test.sh line 112:
echo ThreadSanitizer or leak check failures in $LOGFILE
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo ThreadSanitizer or leak check failures in "$LOGFILE"
In cpp/build-support/run-test.sh line 114:
rm -f $XMLFILE
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -f "$XMLFILE"
In cpp/build-support/run-test.sh line 137:
FILENAME=$(echo ${FILENAME} | cut -c-15)
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
FILENAME=$(echo "${FILENAME}" | cut -c-15)
In cpp/build-support/run-test.sh line 140:
COREFILES=$(ls /tmp | grep $PATTERN)
^-- SC2010 (warning): Don't use ls | grep. Use a glob or a for loop with a condition to allow non-alphanumeric filenames.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
COREFILES=$(ls /tmp | grep "$PATTERN")
In cpp/build-support/run-test.sh line 150:
gdb -c "${COREPATH}" $TEST_EXECUTABLE -ex "thread apply all bt" -ex "set pagination 0" -batch
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
gdb -c "${COREPATH}" "$TEST_EXECUTABLE" -ex "thread apply all bt" -ex "set pagination 0" -batch
In cpp/build-support/run-test.sh line 163:
if grep -E -q "ERROR: LeakSanitizer: detected memory leaks" $LOGFILE ; then
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if grep -E -q "ERROR: LeakSanitizer: detected memory leaks" "$LOGFILE" ; then
In cpp/build-support/run-test.sh line 171:
$XMLFILE
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
"$XMLFILE"
In cpp/build-support/run-test.sh line 172:
mv $XMLFILE.bak $XMLFILE
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mv "$XMLFILE".bak "$XMLFILE"
In cpp/build-support/run-test.sh line 178:
$TEST_EXECUTABLE "$@" 2>&1 | $pipe_cmd > $LOGFILE
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
$TEST_EXECUTABLE "$@" 2>&1 | $pipe_cmd > "$LOGFILE"
In cpp/build-support/run-test.sh line 182:
if [ $RUN_TYPE = "test" ]; then
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$RUN_TYPE" = "test" ]; then
In cpp/build-support/run-test.sh line 188:
if [ $ATTEMPT_NUMBER -lt $TEST_EXECUTION_ATTEMPTS ]; then
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$ATTEMPT_NUMBER" -lt $TEST_EXECUTION_ATTEMPTS ]; then
In cpp/build-support/run-test.sh line 195:
TEST_TMPDIR_BEFORE=$(find $TEST_TMPDIR -maxdepth 1 -type d | sort)
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
TEST_TMPDIR_BEFORE=$(find "$TEST_TMPDIR" -maxdepth 1 -type d | sort)
In cpp/build-support/run-test.sh line 198:
if [ $ATTEMPT_NUMBER -lt $TEST_EXECUTION_ATTEMPTS ]; then
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$ATTEMPT_NUMBER" -lt $TEST_EXECUTION_ATTEMPTS ]; then
In cpp/build-support/run-test.sh line 200:
TEST_TMPDIR_AFTER=$(find $TEST_TMPDIR -maxdepth 1 -type d | sort)
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
TEST_TMPDIR_AFTER=$(find "$TEST_TMPDIR" -maxdepth 1 -type d | sort)
In cpp/build-support/run-test.sh line 218:
if [ $RUN_TYPE = "test" ]; then
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$RUN_TYPE" = "test" ]; then
In cpp/build-support/run-test.sh line 219:
run_test $*
^-- SC2048 (warning): Use "$@" (with quotes) to prevent whitespace problems.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
run_test "$*"
In cpp/build-support/run-test.sh line 221:
run_other $*
^-- SC2048 (warning): Use "$@" (with quotes) to prevent whitespace problems.
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
run_other "$*"
In cpp/build-support/run-test.sh line 226:
echo Test failed attempt number $ATTEMPT_NUMBER
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo Test failed attempt number "$ATTEMPT_NUMBER"
In cpp/build-support/run-test.sh line 231:
if [ $RUN_TYPE = "test" ]; then
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$RUN_TYPE" = "test" ]; then
In cpp/build-support/run-test.sh line 237:
popd
^--^ SC2164 (warning): Use 'popd ... || exit' or 'popd ... || return' in case popd fails.
Did you mean:
popd || exit
In cpp/build-support/run-test.sh line 238:
rm -Rf $TEST_WORKDIR
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -Rf "$TEST_WORKDIR"
In cpp/build-support/run-test.sh line 240:
exit $STATUS
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
exit "$STATUS"
For more information:
https://www.shellcheck.net/wiki/SC2010 -- Don't use ls | grep. Use a glob o...
https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
https://www.shellcheck.net/wiki/SC2048 -- Use "$@" (with quotes) to prevent...

What changes are included in this PR?

SC2010: Replace ls | grep with find
SC2035: Prefix globs with ./ to prevent filenames from being treated as options
SC2046: Quote command substitutions to prevent word splitting
SC2048: Use "$@" to preserve arguments containing whitespace
SC2086: Quote variables to prevent word splitting and globbing
SC2128: Specify the array index explicitly
SC2164: Handle cd failures explicitly
SC2209: Use command substitution when assigning command output

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

GitHub Issue: [C++] Fix shellcheck errors in cpp/build-support/run-test.sh #50934

github-actions · 2026-08-21T00:59:19Z

⚠️ GitHub issue #50934has been automatically assigned in GitHub to PR creator.

hiroyuki-sato · 2026-08-23T08:31:22Z

rebased for re-run CI job

hiroyuki-sato · 2026-08-23T15:25:40Z

@kou I don't think the two CI failures are related to this PR. What do you think?

tadeja · 2026-08-23T22:37:37Z

Failing C++ / AMD64 Conda C++ AVX2 is the new issue #50930
(Re-ran ARM64 macOS 14 C++ and that one is passing now.)

hiroyuki-sato · 2026-08-24T00:16:07Z

@kou Thank you for re-run job. Please take a look this PR when you get a chance.
@tadeja Thank you for your comment.

hiroyuki-sato · 2026-08-25T12:18:15Z

@kou Please take a look when you get a chance.

failing C++ / AMD64 Conda C++ AVX2 is the new issue [C++][CI] S3 tests fail with "Attempt to initialize S3 after it has been finalized" #50930
failing Dev / Lint C++, Python, R, Docker, RAT is the GH-50985: [CI][Dev][Python] Update cython-lint and pin Cython to 3.2.9 #50986

hiroyuki-sato · 2026-08-26T00:37:26Z

Rebased to test the changes from #50986.

hiroyuki-sato · 2026-08-26T04:47:19Z

C++ / AMD64 Windows MinGW CLANG64 C++ failed

99/99 Test #78: arrow-flight-test ............................***Timeout 300.02 sec

hiroyuki-sato · 2026-08-26T06:32:16Z

@kou After re-run job, C++ / AMD64 Windows MinGW CLANG64 C++ passed. Please take a look when you get a chance

This reverts commit 45bba12.

This reverts commit 4ed6bae.

hiroyuki-sato · 2026-08-30T12:22:48Z

just re-run CI, and rebase to the latest main (no code change)

kou

+1

github-actionsBot added Component: C++ awaiting review Awaiting review labels Aug 21, 2026

hiroyuki-sato mentioned this pull request Aug 22, 2026
GH-50934: [C++] Fix shellcheck errors in cpp/build-support/run-test.sh #50950
Closed

hiroyuki-sato marked this pull request as ready for review August 22, 2026 07:22

hiroyuki-sato requested a review from raulcd as a code owner August 22, 2026 07:22

hiroyuki-sato force-pushed the topic/shellcheck-cpp-run-test branch from da4e451 to 7b9e1a6Compare August 23, 2026 08:30

kou changed the title ~~GH-50934: Fix shellcheck errors in cpp/build-support/run-test.sh~~GH-50934: [C++][Dev] Fix shellcheck errors in cpp/build-support/run-test.shAug 24, 2026

kou reviewed Aug 24, 2026
View reviewed changes

Comment threadcpp/build-support/run-test.sh Outdated

github-actionsBot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting review Awaiting review awaiting changes Awaiting changes labels Aug 24, 2026

hiroyuki-sato marked this pull request as draft August 24, 2026 05:31

hiroyuki-sato force-pushed the topic/shellcheck-cpp-run-test branch from bc92179 to 45bba12Compare August 24, 2026 10:57

github-actionsBot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting change review Awaiting change review awaiting changes Awaiting changes labels Aug 24, 2026

hiroyuki-sato force-pushed the topic/shellcheck-cpp-run-test branch from 92c8419 to 7844c5eCompare August 25, 2026 10:52

hiroyuki-sato marked this pull request as ready for review August 25, 2026 12:16

hiroyuki-sato force-pushed the topic/shellcheck-cpp-run-test branch from 7844c5e to 3982f35Compare August 26, 2026 00:33

kou reviewed Aug 26, 2026
View reviewed changes

Comment threadcpp/build-support/run-test.sh Outdated

github-actionsBot removed the awaiting change review Awaiting change review label Aug 26, 2026

github-actionsBot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Aug 26, 2026

hiroyuki-sato added 10 commits August 30, 2026 21:21

apacheGH-50934: Fix shellcheck errors in cpp/build-support/run-test.sh
c8c2174

Revert .pre-commit-config.yaml
3a141e6

Fix wrong remove variable
5785140

Quote variable expansions
5810c64

Use set -euo pipmail
255ea5f

Use set -e
91a4f60

Revert "Use set -e"
2e34c5d
This reverts commit 45bba12.

Revert "Use set -euo pipmail"
5703e76
This reverts commit 4ed6bae.

Re-enable set -e
e262e41

Use "$@" instead of "$*"
90d6e03

hiroyuki-sato force-pushed the topic/shellcheck-cpp-run-test branch from e06250d to 90d6e03Compare August 30, 2026 12:22

kou approved these changes Aug 31, 2026
View reviewed changes

kou merged commit e9ec94b into apache:mainAug 31, 2026
54 of 56 checks passed

kou removed the awaiting change review Awaiting change review label Aug 31, 2026

kou mentioned this pull request Aug 31, 2026
[C++] Fix shellcheck errors in cpp/build-support/run-test.sh #50934
Closed

github-actionsBot added the awaiting merge Awaiting merge label Aug 31, 2026

hiroyuki-sato deleted the topic/shellcheck-cpp-run-test branch August 31, 2026 01:01

pitrou mentioned this pull request Aug 31, 2026
[C++] Sporadic test errors in parallel mode #51095
Closed

Navigation Menu

Uh oh!

GH-50934: [C++][Dev] Fix shellcheck errors in cpp/build-support/run-test.sh - #50935

GH-50934: [C++][Dev] Fix shellcheck errors in cpp/build-support/run-test.sh#50935
kou merged 10 commits into
apache:mainfrom
hiroyuki-sato:topic/shellcheck-cpp-run-test

hiroyuki-sato commented Aug 21, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Aug 21, 2026

Uh oh!

hiroyuki-sato commented Aug 23, 2026

Uh oh!

hiroyuki-sato commented Aug 23, 2026

Uh oh!

tadeja commented Aug 23, 2026

Uh oh!

hiroyuki-sato commented Aug 24, 2026

Uh oh!

Uh oh!

hiroyuki-sato commented Aug 25, 2026

Uh oh!

hiroyuki-sato commented Aug 26, 2026

Uh oh!

Uh oh!

hiroyuki-sato commented Aug 26, 2026

Uh oh!

hiroyuki-sato commented Aug 26, 2026

Uh oh!

hiroyuki-sato commented Aug 30, 2026

Uh oh!

kou left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

hiroyuki-sato commented Aug 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actionsBot commented Aug 21, 2026

Uh oh!

hiroyuki-sato commented Aug 23, 2026

Uh oh!

hiroyuki-sato commented Aug 23, 2026

Uh oh!

tadeja commented Aug 23, 2026

Uh oh!

hiroyuki-sato commented Aug 24, 2026

Uh oh!

Uh oh!

hiroyuki-sato commented Aug 25, 2026

Uh oh!

hiroyuki-sato commented Aug 26, 2026

Uh oh!

Uh oh!

hiroyuki-sato commented Aug 26, 2026

Uh oh!

hiroyuki-sato commented Aug 26, 2026

Uh oh!

hiroyuki-sato commented Aug 30, 2026

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hiroyuki-sato commented Aug 21, 2026•
edited
Loading