ARROW-1008: [C++] Add abstract stream writer and reader C++ APIs. Give clearer names to IPC reader/writer classes by wesm · Pull Request #679 · apache/arrow

wesm · 2017-05-12T20:15:39Z

The main motivation for this patch was to make StreamReader and StreamWriter abstract, so that other implementations can be created. I would also like to add the option for asynchronous reading and writing.

I also added a CMake option ARROW_NO_DEPRECATED_API for more graceful name deprecations.

@kou do you think these names for the IPC classes are more clear?

kou · 2017-05-13T01:14:40Z

Basically, I like this change! I have some concerns.

Concern 1: Use of "batch", "stream" and "random access" words.

"batch" is used for the following things:

"record batch": e.g.: BatchStreamReader
"batch file format": e.g.: BatchFileWriter
- It's also called as "random access file format": e.g.: https://github.com/apache/arrow/pull/679/files#diff-a9e81066a3b1057b1e0e874c541f8bb8R85

"stream" is used for the following things:

"zero or more record batches": e.g.: BatchStreamReader and "stream of record batches": https://github.com/apache/arrow/pull/679/files#diff-a9e81066a3b1057b1e0e874c541f8bb8R47
"input stream": e.g.: InputStreamReader
("stream file format")

It may be better that we use one word for one mean.

Concern 2: Consistency.

BatchStreamReader shows "what" is read.

InputStreamReader and BatchFileReader show "where" from read.

I tried considering names but I don't get good names yet... Sorry...

Broken idea:

BatchStreamReader -> RecordBatchReader (or RecordBatchesReader?)
- "record batch" is used only for record batch.
- "stream" isn't used for "zero or more X"
InputStreamReader -> RecordBatchStreamReader
- Umm... "stream" is used for "stream file format" but it's not clear...
BatchFileReader -> RecordBatchXXXReader (RecordBatchSetReader ?)
- Umm... I wanted to use a word from "random access format" or "batch format" but ...

…tream reader and writer classes for better clarity

Change-Id: I38b1e570c69af59aac917e96845b7add947d7196

… APIs Change-Id: I92cc2d5de55f625dee543bd7dc223225fd8f7977

Change-Id: I2b375c917e6004c3ffebf3657491d4756f792951

wesm · 2017-05-13T20:42:14Z

I renamed some things:

RecordBatchReader and RecordBatchWriter for the abstract base classes
RecordBatchStreamReader/RecordBatchStreamWriter for the synchronous streaming format classes
RecordBatchFileReader/RecordBatchFileWriter for the synchronous file format classes

I removed the "random access" language since we use "Streaming format" and "File format" in the Arrow format documentation.

Let me know if this sounds good for now

Change-Id: I0c06793275de0bf96be5602e5c99ae9cf7ad2b14

kou · 2017-05-14T12:10:26Z

This sounds good!

wesm · 2017-05-14T12:55:09Z

+1

@kou

…e clearer names to IPC reader/writer classes The main motivation for this patch was to make `StreamReader` and `StreamWriter` abstract, so that other implementations can be created. I would also like to add the option for asynchronous reading and writing. I also added a CMake option `ARROW_NO_DEPRECATED_API` for more graceful name deprecations. @kou do you think these names for the IPC classes are more clear? Author: Wes McKinney <wes.mckinney@twosigma.com> Closesapache#679 from wesm/ARROW-1008 and squashes the following commits: d7b7c9c [Wes McKinney] Add missing dtors for pimpl pattern a797ee3 [Wes McKinney] Fix glib 04fa285 [Wes McKinney] Feedback on ipc reader/writer names. Add open_stream/open_file Python APIs 22346d4 [Wes McKinney] Fix unit tests 10837a6 [Wes McKinney] Add abstract stream writer and reader C++ APIs. Rename record batch stream reader and writer classes for better clarity

…#679) Bumps [com.github.luben:zstd-jni](https://github.com/luben/zstd-jni) from 1.5.7-1 to 1.5.7-2. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/luben/zstd-jni/commit/88892eb44549a214ba4c23459618b9d5d647a44c"><code>88892eb</code></a> v1.5.7-2</li> <li><a href="https://github.com/luben/zstd-jni/commit/7b52f9b6d3912ddb59ce3ffb7e26e635bcfa71db"><code>7b52f9b</code></a> indentation</li> <li><a href="https://github.com/luben/zstd-jni/commit/cdd20becaad29372922b33c2762183bdf4726598"><code>cdd20be</code></a> Fix lock acquisition</li> <li><a href="https://github.com/luben/zstd-jni/commit/15e5eee8b871add5a50a0c53ae5167668455170f"><code>15e5eee</code></a> Support decompression from byte array to ByteBuffer and vice-versa</li> <li>See full diff in <a href="https://github.com/luben/zstd-jni/compare/v1.5.7-1...v1.5.7-2">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.github.luben:zstd-jni&package-manager=maven&previous-version=1.5.7-1&new-version=1.5.7-2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JB Onofré <jb.onofre@dremio.com>

wesm · 2017-05-12T20:15:39Z

The main motivation for this patch was to make StreamReader and StreamWriter abstract, so that other implementations can be created. I would also like to add the option for asynchronous reading and writing.

I also added a CMake option ARROW_NO_DEPRECATED_API for more graceful name deprecations.

@kou do you think these names for the IPC classes are more clear?

kou · 2017-05-13T01:14:40Z

Basically, I like this change! I have some concerns.

Concern 1: Use of "batch", "stream" and "random access" words.

"batch" is used for the following things:

"record batch": e.g.: BatchStreamReader
"batch file format": e.g.: BatchFileWriter
- It's also called as "random access file format": e.g.: https://github.com/apache/arrow/pull/679/files#diff-a9e81066a3b1057b1e0e874c541f8bb8R85

"stream" is used for the following things:

"zero or more record batches": e.g.: BatchStreamReader and "stream of record batches": https://github.com/apache/arrow/pull/679/files#diff-a9e81066a3b1057b1e0e874c541f8bb8R47
"input stream": e.g.: InputStreamReader
("stream file format")

It may be better that we use one word for one mean.

Concern 2: Consistency.

BatchStreamReader shows "what" is read.

InputStreamReader and BatchFileReader show "where" from read.

I tried considering names but I don't get good names yet... Sorry...

Broken idea:

BatchStreamReader -> RecordBatchReader (or RecordBatchesReader?)
- "record batch" is used only for record batch.
- "stream" isn't used for "zero or more X"
InputStreamReader -> RecordBatchStreamReader
- Umm... "stream" is used for "stream file format" but it's not clear...
BatchFileReader -> RecordBatchXXXReader (RecordBatchSetReader ?)
- Umm... I wanted to use a word from "random access format" or "batch format" but ...

…tream reader and writer classes for better clarity

Change-Id: I38b1e570c69af59aac917e96845b7add947d7196

… APIs Change-Id: I92cc2d5de55f625dee543bd7dc223225fd8f7977

Change-Id: I2b375c917e6004c3ffebf3657491d4756f792951

wesm · 2017-05-13T20:42:14Z

I renamed some things:

RecordBatchReader and RecordBatchWriter for the abstract base classes
RecordBatchStreamReader/RecordBatchStreamWriter for the synchronous streaming format classes
RecordBatchFileReader/RecordBatchFileWriter for the synchronous file format classes

I removed the "random access" language since we use "Streaming format" and "File format" in the Arrow format documentation.

Let me know if this sounds good for now

Change-Id: I0c06793275de0bf96be5602e5c99ae9cf7ad2b14

kou · 2017-05-14T12:10:26Z

This sounds good!

wesm · 2017-05-14T12:55:09Z

+1

@kou

…e clearer names to IPC reader/writer classes The main motivation for this patch was to make `StreamReader` and `StreamWriter` abstract, so that other implementations can be created. I would also like to add the option for asynchronous reading and writing. I also added a CMake option `ARROW_NO_DEPRECATED_API` for more graceful name deprecations. @kou do you think these names for the IPC classes are more clear? Author: Wes McKinney <wes.mckinney@twosigma.com> Closesapache#679 from wesm/ARROW-1008 and squashes the following commits: d7b7c9c [Wes McKinney] Add missing dtors for pimpl pattern a797ee3 [Wes McKinney] Fix glib 04fa285 [Wes McKinney] Feedback on ipc reader/writer names. Add open_stream/open_file Python APIs 22346d4 [Wes McKinney] Fix unit tests 10837a6 [Wes McKinney] Add abstract stream writer and reader C++ APIs. Rename record batch stream reader and writer classes for better clarity

…#679) Bumps [com.github.luben:zstd-jni](https://github.com/luben/zstd-jni) from 1.5.7-1 to 1.5.7-2. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/luben/zstd-jni/commit/88892eb44549a214ba4c23459618b9d5d647a44c"><code>88892eb</code></a> v1.5.7-2</li> <li><a href="https://github.com/luben/zstd-jni/commit/7b52f9b6d3912ddb59ce3ffb7e26e635bcfa71db"><code>7b52f9b</code></a> indentation</li> <li><a href="https://github.com/luben/zstd-jni/commit/cdd20becaad29372922b33c2762183bdf4726598"><code>cdd20be</code></a> Fix lock acquisition</li> <li><a href="https://github.com/luben/zstd-jni/commit/15e5eee8b871add5a50a0c53ae5167668455170f"><code>15e5eee</code></a> Support decompression from byte array to ByteBuffer and vice-versa</li> <li>See full diff in <a href="https://github.com/luben/zstd-jni/compare/v1.5.7-1...v1.5.7-2">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.github.luben:zstd-jni&package-manager=maven&previous-version=1.5.7-1&new-version=1.5.7-2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JB Onofré <jb.onofre@dremio.com>

wesm · 2017-05-12T20:15:39Z

The main motivation for this patch was to make StreamReader and StreamWriter abstract, so that other implementations can be created. I would also like to add the option for asynchronous reading and writing.

I also added a CMake option ARROW_NO_DEPRECATED_API for more graceful name deprecations.

@kou do you think these names for the IPC classes are more clear?

kou · 2017-05-13T01:14:40Z

Basically, I like this change! I have some concerns.

Concern 1: Use of "batch", "stream" and "random access" words.

"batch" is used for the following things:

"record batch": e.g.: BatchStreamReader
"batch file format": e.g.: BatchFileWriter
- It's also called as "random access file format": e.g.: https://github.com/apache/arrow/pull/679/files#diff-a9e81066a3b1057b1e0e874c541f8bb8R85

"stream" is used for the following things:

"zero or more record batches": e.g.: BatchStreamReader and "stream of record batches": https://github.com/apache/arrow/pull/679/files#diff-a9e81066a3b1057b1e0e874c541f8bb8R47
"input stream": e.g.: InputStreamReader
("stream file format")

It may be better that we use one word for one mean.

Concern 2: Consistency.

BatchStreamReader shows "what" is read.

InputStreamReader and BatchFileReader show "where" from read.

I tried considering names but I don't get good names yet... Sorry...

Broken idea:

BatchStreamReader -> RecordBatchReader (or RecordBatchesReader?)
- "record batch" is used only for record batch.
- "stream" isn't used for "zero or more X"
InputStreamReader -> RecordBatchStreamReader
- Umm... "stream" is used for "stream file format" but it's not clear...
BatchFileReader -> RecordBatchXXXReader (RecordBatchSetReader ?)
- Umm... I wanted to use a word from "random access format" or "batch format" but ...

…tream reader and writer classes for better clarity

Change-Id: I38b1e570c69af59aac917e96845b7add947d7196

… APIs Change-Id: I92cc2d5de55f625dee543bd7dc223225fd8f7977

Change-Id: I2b375c917e6004c3ffebf3657491d4756f792951

wesm · 2017-05-13T20:42:14Z

I renamed some things:

RecordBatchReader and RecordBatchWriter for the abstract base classes
RecordBatchStreamReader/RecordBatchStreamWriter for the synchronous streaming format classes
RecordBatchFileReader/RecordBatchFileWriter for the synchronous file format classes

I removed the "random access" language since we use "Streaming format" and "File format" in the Arrow format documentation.

Let me know if this sounds good for now

Change-Id: I0c06793275de0bf96be5602e5c99ae9cf7ad2b14

kou · 2017-05-14T12:10:26Z

This sounds good!

wesm · 2017-05-14T12:55:09Z

+1

@kou

…e clearer names to IPC reader/writer classes The main motivation for this patch was to make `StreamReader` and `StreamWriter` abstract, so that other implementations can be created. I would also like to add the option for asynchronous reading and writing. I also added a CMake option `ARROW_NO_DEPRECATED_API` for more graceful name deprecations. @kou do you think these names for the IPC classes are more clear? Author: Wes McKinney <wes.mckinney@twosigma.com> Closesapache#679 from wesm/ARROW-1008 and squashes the following commits: d7b7c9c [Wes McKinney] Add missing dtors for pimpl pattern a797ee3 [Wes McKinney] Fix glib 04fa285 [Wes McKinney] Feedback on ipc reader/writer names. Add open_stream/open_file Python APIs 22346d4 [Wes McKinney] Fix unit tests 10837a6 [Wes McKinney] Add abstract stream writer and reader C++ APIs. Rename record batch stream reader and writer classes for better clarity

…#679) Bumps [com.github.luben:zstd-jni](https://github.com/luben/zstd-jni) from 1.5.7-1 to 1.5.7-2. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/luben/zstd-jni/commit/88892eb44549a214ba4c23459618b9d5d647a44c"><code>88892eb</code></a> v1.5.7-2</li> <li><a href="https://github.com/luben/zstd-jni/commit/7b52f9b6d3912ddb59ce3ffb7e26e635bcfa71db"><code>7b52f9b</code></a> indentation</li> <li><a href="https://github.com/luben/zstd-jni/commit/cdd20becaad29372922b33c2762183bdf4726598"><code>cdd20be</code></a> Fix lock acquisition</li> <li><a href="https://github.com/luben/zstd-jni/commit/15e5eee8b871add5a50a0c53ae5167668455170f"><code>15e5eee</code></a> Support decompression from byte array to ByteBuffer and vice-versa</li> <li>See full diff in <a href="https://github.com/luben/zstd-jni/compare/v1.5.7-1...v1.5.7-2">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.github.luben:zstd-jni&package-manager=maven&previous-version=1.5.7-1&new-version=1.5.7-2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JB Onofré <jb.onofre@dremio.com>

wesm · 2017-05-12T20:15:39Z

The main motivation for this patch was to make StreamReader and StreamWriter abstract, so that other implementations can be created. I would also like to add the option for asynchronous reading and writing.

I also added a CMake option ARROW_NO_DEPRECATED_API for more graceful name deprecations.

@kou do you think these names for the IPC classes are more clear?

kou · 2017-05-13T01:14:40Z

Basically, I like this change! I have some concerns.

Concern 1: Use of "batch", "stream" and "random access" words.

"batch" is used for the following things:

"record batch": e.g.: BatchStreamReader
"batch file format": e.g.: BatchFileWriter
- It's also called as "random access file format": e.g.: https://github.com/apache/arrow/pull/679/files#diff-a9e81066a3b1057b1e0e874c541f8bb8R85

"stream" is used for the following things:

"zero or more record batches": e.g.: BatchStreamReader and "stream of record batches": https://github.com/apache/arrow/pull/679/files#diff-a9e81066a3b1057b1e0e874c541f8bb8R47
"input stream": e.g.: InputStreamReader
("stream file format")

It may be better that we use one word for one mean.

Concern 2: Consistency.

BatchStreamReader shows "what" is read.

InputStreamReader and BatchFileReader show "where" from read.

I tried considering names but I don't get good names yet... Sorry...

Broken idea:

BatchStreamReader -> RecordBatchReader (or RecordBatchesReader?)
- "record batch" is used only for record batch.
- "stream" isn't used for "zero or more X"
InputStreamReader -> RecordBatchStreamReader
- Umm... "stream" is used for "stream file format" but it's not clear...
BatchFileReader -> RecordBatchXXXReader (RecordBatchSetReader ?)
- Umm... I wanted to use a word from "random access format" or "batch format" but ...

…tream reader and writer classes for better clarity

Change-Id: I38b1e570c69af59aac917e96845b7add947d7196

… APIs Change-Id: I92cc2d5de55f625dee543bd7dc223225fd8f7977

Change-Id: I2b375c917e6004c3ffebf3657491d4756f792951

wesm · 2017-05-13T20:42:14Z

I renamed some things:

RecordBatchReader and RecordBatchWriter for the abstract base classes
RecordBatchStreamReader/RecordBatchStreamWriter for the synchronous streaming format classes
RecordBatchFileReader/RecordBatchFileWriter for the synchronous file format classes

I removed the "random access" language since we use "Streaming format" and "File format" in the Arrow format documentation.

Let me know if this sounds good for now

Change-Id: I0c06793275de0bf96be5602e5c99ae9cf7ad2b14

kou · 2017-05-14T12:10:26Z

This sounds good!

wesm · 2017-05-14T12:55:09Z

+1

@kou

…e clearer names to IPC reader/writer classes The main motivation for this patch was to make `StreamReader` and `StreamWriter` abstract, so that other implementations can be created. I would also like to add the option for asynchronous reading and writing. I also added a CMake option `ARROW_NO_DEPRECATED_API` for more graceful name deprecations. @kou do you think these names for the IPC classes are more clear? Author: Wes McKinney <wes.mckinney@twosigma.com> Closesapache#679 from wesm/ARROW-1008 and squashes the following commits: d7b7c9c [Wes McKinney] Add missing dtors for pimpl pattern a797ee3 [Wes McKinney] Fix glib 04fa285 [Wes McKinney] Feedback on ipc reader/writer names. Add open_stream/open_file Python APIs 22346d4 [Wes McKinney] Fix unit tests 10837a6 [Wes McKinney] Add abstract stream writer and reader C++ APIs. Rename record batch stream reader and writer classes for better clarity

…#679) Bumps [com.github.luben:zstd-jni](https://github.com/luben/zstd-jni) from 1.5.7-1 to 1.5.7-2. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/luben/zstd-jni/commit/88892eb44549a214ba4c23459618b9d5d647a44c"><code>88892eb</code></a> v1.5.7-2</li> <li><a href="https://github.com/luben/zstd-jni/commit/7b52f9b6d3912ddb59ce3ffb7e26e635bcfa71db"><code>7b52f9b</code></a> indentation</li> <li><a href="https://github.com/luben/zstd-jni/commit/cdd20becaad29372922b33c2762183bdf4726598"><code>cdd20be</code></a> Fix lock acquisition</li> <li><a href="https://github.com/luben/zstd-jni/commit/15e5eee8b871add5a50a0c53ae5167668455170f"><code>15e5eee</code></a> Support decompression from byte array to ByteBuffer and vice-versa</li> <li>See full diff in <a href="https://github.com/luben/zstd-jni/compare/v1.5.7-1...v1.5.7-2">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.github.luben:zstd-jni&package-manager=maven&previous-version=1.5.7-1&new-version=1.5.7-2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JB Onofré <jb.onofre@dremio.com>

wesm · 2017-05-12T20:15:39Z

The main motivation for this patch was to make StreamReader and StreamWriter abstract, so that other implementations can be created. I would also like to add the option for asynchronous reading and writing.

I also added a CMake option ARROW_NO_DEPRECATED_API for more graceful name deprecations.

@kou do you think these names for the IPC classes are more clear?

kou · 2017-05-13T01:14:40Z

Basically, I like this change! I have some concerns.

Concern 1: Use of "batch", "stream" and "random access" words.

"batch" is used for the following things:

"record batch": e.g.: BatchStreamReader
"batch file format": e.g.: BatchFileWriter
- It's also called as "random access file format": e.g.: https://github.com/apache/arrow/pull/679/files#diff-a9e81066a3b1057b1e0e874c541f8bb8R85

"stream" is used for the following things:

"zero or more record batches": e.g.: BatchStreamReader and "stream of record batches": https://github.com/apache/arrow/pull/679/files#diff-a9e81066a3b1057b1e0e874c541f8bb8R47
"input stream": e.g.: InputStreamReader
("stream file format")

It may be better that we use one word for one mean.

Concern 2: Consistency.

BatchStreamReader shows "what" is read.

InputStreamReader and BatchFileReader show "where" from read.

I tried considering names but I don't get good names yet... Sorry...

Broken idea:

BatchStreamReader -> RecordBatchReader (or RecordBatchesReader?)
- "record batch" is used only for record batch.
- "stream" isn't used for "zero or more X"
InputStreamReader -> RecordBatchStreamReader
- Umm... "stream" is used for "stream file format" but it's not clear...
BatchFileReader -> RecordBatchXXXReader (RecordBatchSetReader ?)
- Umm... I wanted to use a word from "random access format" or "batch format" but ...

…tream reader and writer classes for better clarity

Change-Id: I38b1e570c69af59aac917e96845b7add947d7196

… APIs Change-Id: I92cc2d5de55f625dee543bd7dc223225fd8f7977

Change-Id: I2b375c917e6004c3ffebf3657491d4756f792951

wesm · 2017-05-13T20:42:14Z

I renamed some things:

RecordBatchReader and RecordBatchWriter for the abstract base classes
RecordBatchStreamReader/RecordBatchStreamWriter for the synchronous streaming format classes
RecordBatchFileReader/RecordBatchFileWriter for the synchronous file format classes

I removed the "random access" language since we use "Streaming format" and "File format" in the Arrow format documentation.

Let me know if this sounds good for now

Change-Id: I0c06793275de0bf96be5602e5c99ae9cf7ad2b14

kou · 2017-05-14T12:10:26Z

This sounds good!

wesm · 2017-05-14T12:55:09Z

+1

@kou

…e clearer names to IPC reader/writer classes The main motivation for this patch was to make `StreamReader` and `StreamWriter` abstract, so that other implementations can be created. I would also like to add the option for asynchronous reading and writing. I also added a CMake option `ARROW_NO_DEPRECATED_API` for more graceful name deprecations. @kou do you think these names for the IPC classes are more clear? Author: Wes McKinney <wes.mckinney@twosigma.com> Closesapache#679 from wesm/ARROW-1008 and squashes the following commits: d7b7c9c [Wes McKinney] Add missing dtors for pimpl pattern a797ee3 [Wes McKinney] Fix glib 04fa285 [Wes McKinney] Feedback on ipc reader/writer names. Add open_stream/open_file Python APIs 22346d4 [Wes McKinney] Fix unit tests 10837a6 [Wes McKinney] Add abstract stream writer and reader C++ APIs. Rename record batch stream reader and writer classes for better clarity

…#679) Bumps [com.github.luben:zstd-jni](https://github.com/luben/zstd-jni) from 1.5.7-1 to 1.5.7-2. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/luben/zstd-jni/commit/88892eb44549a214ba4c23459618b9d5d647a44c"><code>88892eb</code></a> v1.5.7-2</li> <li><a href="https://github.com/luben/zstd-jni/commit/7b52f9b6d3912ddb59ce3ffb7e26e635bcfa71db"><code>7b52f9b</code></a> indentation</li> <li><a href="https://github.com/luben/zstd-jni/commit/cdd20becaad29372922b33c2762183bdf4726598"><code>cdd20be</code></a> Fix lock acquisition</li> <li><a href="https://github.com/luben/zstd-jni/commit/15e5eee8b871add5a50a0c53ae5167668455170f"><code>15e5eee</code></a> Support decompression from byte array to ByteBuffer and vice-versa</li> <li>See full diff in <a href="https://github.com/luben/zstd-jni/compare/v1.5.7-1...v1.5.7-2">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.github.luben:zstd-jni&package-manager=maven&previous-version=1.5.7-1&new-version=1.5.7-2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JB Onofré <jb.onofre@dremio.com>

wesm · 2017-05-12T20:15:39Z

The main motivation for this patch was to make StreamReader and StreamWriter abstract, so that other implementations can be created. I would also like to add the option for asynchronous reading and writing.

I also added a CMake option ARROW_NO_DEPRECATED_API for more graceful name deprecations.

@kou do you think these names for the IPC classes are more clear?

kou · 2017-05-13T01:14:40Z

Basically, I like this change! I have some concerns.

Concern 1: Use of "batch", "stream" and "random access" words.

"batch" is used for the following things:

"record batch": e.g.: BatchStreamReader
"batch file format": e.g.: BatchFileWriter
- It's also called as "random access file format": e.g.: https://github.com/apache/arrow/pull/679/files#diff-a9e81066a3b1057b1e0e874c541f8bb8R85

"stream" is used for the following things:

"zero or more record batches": e.g.: BatchStreamReader and "stream of record batches": https://github.com/apache/arrow/pull/679/files#diff-a9e81066a3b1057b1e0e874c541f8bb8R47
"input stream": e.g.: InputStreamReader
("stream file format")

It may be better that we use one word for one mean.

Concern 2: Consistency.

BatchStreamReader shows "what" is read.

InputStreamReader and BatchFileReader show "where" from read.

I tried considering names but I don't get good names yet... Sorry...

Broken idea:

BatchStreamReader -> RecordBatchReader (or RecordBatchesReader?)
- "record batch" is used only for record batch.
- "stream" isn't used for "zero or more X"
InputStreamReader -> RecordBatchStreamReader
- Umm... "stream" is used for "stream file format" but it's not clear...
BatchFileReader -> RecordBatchXXXReader (RecordBatchSetReader ?)
- Umm... I wanted to use a word from "random access format" or "batch format" but ...

…tream reader and writer classes for better clarity

Change-Id: I38b1e570c69af59aac917e96845b7add947d7196

… APIs Change-Id: I92cc2d5de55f625dee543bd7dc223225fd8f7977

Change-Id: I2b375c917e6004c3ffebf3657491d4756f792951

wesm · 2017-05-13T20:42:14Z

I renamed some things:

RecordBatchReader and RecordBatchWriter for the abstract base classes
RecordBatchStreamReader/RecordBatchStreamWriter for the synchronous streaming format classes
RecordBatchFileReader/RecordBatchFileWriter for the synchronous file format classes

I removed the "random access" language since we use "Streaming format" and "File format" in the Arrow format documentation.

Let me know if this sounds good for now

Change-Id: I0c06793275de0bf96be5602e5c99ae9cf7ad2b14

kou · 2017-05-14T12:10:26Z

This sounds good!

wesm · 2017-05-14T12:55:09Z

+1

@kou

…e clearer names to IPC reader/writer classes The main motivation for this patch was to make `StreamReader` and `StreamWriter` abstract, so that other implementations can be created. I would also like to add the option for asynchronous reading and writing. I also added a CMake option `ARROW_NO_DEPRECATED_API` for more graceful name deprecations. @kou do you think these names for the IPC classes are more clear? Author: Wes McKinney <wes.mckinney@twosigma.com> Closesapache#679 from wesm/ARROW-1008 and squashes the following commits: d7b7c9c [Wes McKinney] Add missing dtors for pimpl pattern a797ee3 [Wes McKinney] Fix glib 04fa285 [Wes McKinney] Feedback on ipc reader/writer names. Add open_stream/open_file Python APIs 22346d4 [Wes McKinney] Fix unit tests 10837a6 [Wes McKinney] Add abstract stream writer and reader C++ APIs. Rename record batch stream reader and writer classes for better clarity

…#679) Bumps [com.github.luben:zstd-jni](https://github.com/luben/zstd-jni) from 1.5.7-1 to 1.5.7-2. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/luben/zstd-jni/commit/88892eb44549a214ba4c23459618b9d5d647a44c"><code>88892eb</code></a> v1.5.7-2</li> <li><a href="https://github.com/luben/zstd-jni/commit/7b52f9b6d3912ddb59ce3ffb7e26e635bcfa71db"><code>7b52f9b</code></a> indentation</li> <li><a href="https://github.com/luben/zstd-jni/commit/cdd20becaad29372922b33c2762183bdf4726598"><code>cdd20be</code></a> Fix lock acquisition</li> <li><a href="https://github.com/luben/zstd-jni/commit/15e5eee8b871add5a50a0c53ae5167668455170f"><code>15e5eee</code></a> Support decompression from byte array to ByteBuffer and vice-versa</li> <li>See full diff in <a href="https://github.com/luben/zstd-jni/compare/v1.5.7-1...v1.5.7-2">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.github.luben:zstd-jni&package-manager=maven&previous-version=1.5.7-1&new-version=1.5.7-2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JB Onofré <jb.onofre@dremio.com>

wesm · 2017-05-12T20:15:39Z

The main motivation for this patch was to make StreamReader and StreamWriter abstract, so that other implementations can be created. I would also like to add the option for asynchronous reading and writing.

I also added a CMake option ARROW_NO_DEPRECATED_API for more graceful name deprecations.

@kou do you think these names for the IPC classes are more clear?

kou · 2017-05-13T01:14:40Z

Basically, I like this change! I have some concerns.

Concern 1: Use of "batch", "stream" and "random access" words.

"batch" is used for the following things:

"record batch": e.g.: BatchStreamReader
"batch file format": e.g.: BatchFileWriter
- It's also called as "random access file format": e.g.: https://github.com/apache/arrow/pull/679/files#diff-a9e81066a3b1057b1e0e874c541f8bb8R85

"stream" is used for the following things:

"zero or more record batches": e.g.: BatchStreamReader and "stream of record batches": https://github.com/apache/arrow/pull/679/files#diff-a9e81066a3b1057b1e0e874c541f8bb8R47
"input stream": e.g.: InputStreamReader
("stream file format")

It may be better that we use one word for one mean.

Concern 2: Consistency.

BatchStreamReader shows "what" is read.

InputStreamReader and BatchFileReader show "where" from read.

I tried considering names but I don't get good names yet... Sorry...

Broken idea:

BatchStreamReader -> RecordBatchReader (or RecordBatchesReader?)
- "record batch" is used only for record batch.
- "stream" isn't used for "zero or more X"
InputStreamReader -> RecordBatchStreamReader
- Umm... "stream" is used for "stream file format" but it's not clear...
BatchFileReader -> RecordBatchXXXReader (RecordBatchSetReader ?)
- Umm... I wanted to use a word from "random access format" or "batch format" but ...

…tream reader and writer classes for better clarity

Change-Id: I38b1e570c69af59aac917e96845b7add947d7196

… APIs Change-Id: I92cc2d5de55f625dee543bd7dc223225fd8f7977

Change-Id: I2b375c917e6004c3ffebf3657491d4756f792951

wesm · 2017-05-13T20:42:14Z

I renamed some things:

RecordBatchReader and RecordBatchWriter for the abstract base classes
RecordBatchStreamReader/RecordBatchStreamWriter for the synchronous streaming format classes
RecordBatchFileReader/RecordBatchFileWriter for the synchronous file format classes

I removed the "random access" language since we use "Streaming format" and "File format" in the Arrow format documentation.

Let me know if this sounds good for now

Change-Id: I0c06793275de0bf96be5602e5c99ae9cf7ad2b14

kou · 2017-05-14T12:10:26Z

This sounds good!

wesm · 2017-05-14T12:55:09Z

+1

@kou

…e clearer names to IPC reader/writer classes The main motivation for this patch was to make `StreamReader` and `StreamWriter` abstract, so that other implementations can be created. I would also like to add the option for asynchronous reading and writing. I also added a CMake option `ARROW_NO_DEPRECATED_API` for more graceful name deprecations. @kou do you think these names for the IPC classes are more clear? Author: Wes McKinney <wes.mckinney@twosigma.com> Closesapache#679 from wesm/ARROW-1008 and squashes the following commits: d7b7c9c [Wes McKinney] Add missing dtors for pimpl pattern a797ee3 [Wes McKinney] Fix glib 04fa285 [Wes McKinney] Feedback on ipc reader/writer names. Add open_stream/open_file Python APIs 22346d4 [Wes McKinney] Fix unit tests 10837a6 [Wes McKinney] Add abstract stream writer and reader C++ APIs. Rename record batch stream reader and writer classes for better clarity

…#679) Bumps [com.github.luben:zstd-jni](https://github.com/luben/zstd-jni) from 1.5.7-1 to 1.5.7-2. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/luben/zstd-jni/commit/88892eb44549a214ba4c23459618b9d5d647a44c"><code>88892eb</code></a> v1.5.7-2</li> <li><a href="https://github.com/luben/zstd-jni/commit/7b52f9b6d3912ddb59ce3ffb7e26e635bcfa71db"><code>7b52f9b</code></a> indentation</li> <li><a href="https://github.com/luben/zstd-jni/commit/cdd20becaad29372922b33c2762183bdf4726598"><code>cdd20be</code></a> Fix lock acquisition</li> <li><a href="https://github.com/luben/zstd-jni/commit/15e5eee8b871add5a50a0c53ae5167668455170f"><code>15e5eee</code></a> Support decompression from byte array to ByteBuffer and vice-versa</li> <li>See full diff in <a href="https://github.com/luben/zstd-jni/compare/v1.5.7-1...v1.5.7-2">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.github.luben:zstd-jni&package-manager=maven&previous-version=1.5.7-1&new-version=1.5.7-2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JB Onofré <jb.onofre@dremio.com>

wesm · 2017-05-12T20:15:39Z

The main motivation for this patch was to make StreamReader and StreamWriter abstract, so that other implementations can be created. I would also like to add the option for asynchronous reading and writing.

I also added a CMake option ARROW_NO_DEPRECATED_API for more graceful name deprecations.

@kou do you think these names for the IPC classes are more clear?

kou · 2017-05-13T01:14:40Z

Basically, I like this change! I have some concerns.

Concern 1: Use of "batch", "stream" and "random access" words.

"batch" is used for the following things:

"record batch": e.g.: BatchStreamReader
"batch file format": e.g.: BatchFileWriter
- It's also called as "random access file format": e.g.: https://github.com/apache/arrow/pull/679/files#diff-a9e81066a3b1057b1e0e874c541f8bb8R85

"stream" is used for the following things:

"zero or more record batches": e.g.: BatchStreamReader and "stream of record batches": https://github.com/apache/arrow/pull/679/files#diff-a9e81066a3b1057b1e0e874c541f8bb8R47
"input stream": e.g.: InputStreamReader
("stream file format")

It may be better that we use one word for one mean.

Concern 2: Consistency.

BatchStreamReader shows "what" is read.

InputStreamReader and BatchFileReader show "where" from read.

I tried considering names but I don't get good names yet... Sorry...

Broken idea:

BatchStreamReader -> RecordBatchReader (or RecordBatchesReader?)
- "record batch" is used only for record batch.
- "stream" isn't used for "zero or more X"
InputStreamReader -> RecordBatchStreamReader
- Umm... "stream" is used for "stream file format" but it's not clear...
BatchFileReader -> RecordBatchXXXReader (RecordBatchSetReader ?)
- Umm... I wanted to use a word from "random access format" or "batch format" but ...

…tream reader and writer classes for better clarity

Change-Id: I38b1e570c69af59aac917e96845b7add947d7196

… APIs Change-Id: I92cc2d5de55f625dee543bd7dc223225fd8f7977

Change-Id: I2b375c917e6004c3ffebf3657491d4756f792951

wesm · 2017-05-13T20:42:14Z

I renamed some things:

RecordBatchReader and RecordBatchWriter for the abstract base classes
RecordBatchStreamReader/RecordBatchStreamWriter for the synchronous streaming format classes
RecordBatchFileReader/RecordBatchFileWriter for the synchronous file format classes

I removed the "random access" language since we use "Streaming format" and "File format" in the Arrow format documentation.

Let me know if this sounds good for now

Change-Id: I0c06793275de0bf96be5602e5c99ae9cf7ad2b14

kou · 2017-05-14T12:10:26Z

This sounds good!

wesm · 2017-05-14T12:55:09Z

+1

@kou

…e clearer names to IPC reader/writer classes The main motivation for this patch was to make `StreamReader` and `StreamWriter` abstract, so that other implementations can be created. I would also like to add the option for asynchronous reading and writing. I also added a CMake option `ARROW_NO_DEPRECATED_API` for more graceful name deprecations. @kou do you think these names for the IPC classes are more clear? Author: Wes McKinney <wes.mckinney@twosigma.com> Closesapache#679 from wesm/ARROW-1008 and squashes the following commits: d7b7c9c [Wes McKinney] Add missing dtors for pimpl pattern a797ee3 [Wes McKinney] Fix glib 04fa285 [Wes McKinney] Feedback on ipc reader/writer names. Add open_stream/open_file Python APIs 22346d4 [Wes McKinney] Fix unit tests 10837a6 [Wes McKinney] Add abstract stream writer and reader C++ APIs. Rename record batch stream reader and writer classes for better clarity

…#679) Bumps [com.github.luben:zstd-jni](https://github.com/luben/zstd-jni) from 1.5.7-1 to 1.5.7-2. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/luben/zstd-jni/commit/88892eb44549a214ba4c23459618b9d5d647a44c"><code>88892eb</code></a> v1.5.7-2</li> <li><a href="https://github.com/luben/zstd-jni/commit/7b52f9b6d3912ddb59ce3ffb7e26e635bcfa71db"><code>7b52f9b</code></a> indentation</li> <li><a href="https://github.com/luben/zstd-jni/commit/cdd20becaad29372922b33c2762183bdf4726598"><code>cdd20be</code></a> Fix lock acquisition</li> <li><a href="https://github.com/luben/zstd-jni/commit/15e5eee8b871add5a50a0c53ae5167668455170f"><code>15e5eee</code></a> Support decompression from byte array to ByteBuffer and vice-versa</li> <li>See full diff in <a href="https://github.com/luben/zstd-jni/compare/v1.5.7-1...v1.5.7-2">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.github.luben:zstd-jni&package-manager=maven&previous-version=1.5.7-1&new-version=1.5.7-2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JB Onofré <jb.onofre@dremio.com>

wesm mentioned this pull request May 12, 2017
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method #680
Closed

wesm added 3 commits May 13, 2017 15:59

Add abstract stream writer and reader C++ APIs. Rename record batch s…
10837a6
…tream reader and writer classes for better clarity

Fix unit tests
22346d4
Change-Id: I38b1e570c69af59aac917e96845b7add947d7196

Feedback on ipc reader/writer names. Add open_stream/open_file Python…
04fa285
… APIs Change-Id: I92cc2d5de55f625dee543bd7dc223225fd8f7977

wesm force-pushed the ARROW-1008 branch from 01c7801 to 04fa285Compare May 13, 2017 20:34

Fix glib
a797ee3
Change-Id: I2b375c917e6004c3ffebf3657491d4756f792951

Add missing dtors for pimpl pattern
d7b7c9c
Change-Id: I0c06793275de0bf96be5602e5c99ae9cf7ad2b14

asfgit closed this in 5739e04May 14, 2017

wesm deleted the ARROW-1008 branch May 14, 2017 12:55

wesm mentioned this pull request May 14, 2017
ARROW-881: [Python] Reconstruct Pandas DataFrame indexes using metadata #612
Closed

wesm mentioned this pull request May 12, 2017
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method #680
Closed

wesm added 3 commits May 13, 2017 15:59

Add abstract stream writer and reader C++ APIs. Rename record batch s…
10837a6
…tream reader and writer classes for better clarity

Fix unit tests
22346d4
Change-Id: I38b1e570c69af59aac917e96845b7add947d7196

Feedback on ipc reader/writer names. Add open_stream/open_file Python…
04fa285
… APIs Change-Id: I92cc2d5de55f625dee543bd7dc223225fd8f7977

wesm force-pushed the ARROW-1008 branch from 01c7801 to 04fa285Compare May 13, 2017 20:34

Fix glib
a797ee3
Change-Id: I2b375c917e6004c3ffebf3657491d4756f792951

Add missing dtors for pimpl pattern
d7b7c9c
Change-Id: I0c06793275de0bf96be5602e5c99ae9cf7ad2b14

asfgit closed this in 5739e04May 14, 2017

wesm deleted the ARROW-1008 branch May 14, 2017 12:55

wesm mentioned this pull request May 14, 2017
ARROW-881: [Python] Reconstruct Pandas DataFrame indexes using metadata #612
Closed

wesm mentioned this pull request May 12, 2017
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method #680
Closed

wesm added 3 commits May 13, 2017 15:59

Add abstract stream writer and reader C++ APIs. Rename record batch s…
10837a6
…tream reader and writer classes for better clarity

Fix unit tests
22346d4
Change-Id: I38b1e570c69af59aac917e96845b7add947d7196

Feedback on ipc reader/writer names. Add open_stream/open_file Python…
04fa285
… APIs Change-Id: I92cc2d5de55f625dee543bd7dc223225fd8f7977

wesm force-pushed the ARROW-1008 branch from 01c7801 to 04fa285Compare May 13, 2017 20:34

Fix glib
a797ee3
Change-Id: I2b375c917e6004c3ffebf3657491d4756f792951

Add missing dtors for pimpl pattern
d7b7c9c
Change-Id: I0c06793275de0bf96be5602e5c99ae9cf7ad2b14

asfgit closed this in 5739e04May 14, 2017

wesm deleted the ARROW-1008 branch May 14, 2017 12:55

wesm mentioned this pull request May 14, 2017
ARROW-881: [Python] Reconstruct Pandas DataFrame indexes using metadata #612
Closed

wesm mentioned this pull request May 12, 2017
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method #680
Closed

wesm added 3 commits May 13, 2017 15:59

Add abstract stream writer and reader C++ APIs. Rename record batch s…
10837a6
…tream reader and writer classes for better clarity

Fix unit tests
22346d4
Change-Id: I38b1e570c69af59aac917e96845b7add947d7196

Feedback on ipc reader/writer names. Add open_stream/open_file Python…
04fa285
… APIs Change-Id: I92cc2d5de55f625dee543bd7dc223225fd8f7977

wesm force-pushed the ARROW-1008 branch from 01c7801 to 04fa285Compare May 13, 2017 20:34

Fix glib
a797ee3
Change-Id: I2b375c917e6004c3ffebf3657491d4756f792951

Add missing dtors for pimpl pattern
d7b7c9c
Change-Id: I0c06793275de0bf96be5602e5c99ae9cf7ad2b14

asfgit closed this in 5739e04May 14, 2017

wesm deleted the ARROW-1008 branch May 14, 2017 12:55

wesm mentioned this pull request May 14, 2017
ARROW-881: [Python] Reconstruct Pandas DataFrame indexes using metadata #612
Closed

wesm mentioned this pull request May 12, 2017
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method #680
Closed

wesm added 3 commits May 13, 2017 15:59

Add abstract stream writer and reader C++ APIs. Rename record batch s…
10837a6
…tream reader and writer classes for better clarity

Fix unit tests
22346d4
Change-Id: I38b1e570c69af59aac917e96845b7add947d7196

Feedback on ipc reader/writer names. Add open_stream/open_file Python…
04fa285
… APIs Change-Id: I92cc2d5de55f625dee543bd7dc223225fd8f7977

wesm force-pushed the ARROW-1008 branch from 01c7801 to 04fa285Compare May 13, 2017 20:34

Fix glib
a797ee3
Change-Id: I2b375c917e6004c3ffebf3657491d4756f792951

Add missing dtors for pimpl pattern
d7b7c9c
Change-Id: I0c06793275de0bf96be5602e5c99ae9cf7ad2b14

asfgit closed this in 5739e04May 14, 2017

wesm deleted the ARROW-1008 branch May 14, 2017 12:55

wesm mentioned this pull request May 14, 2017
ARROW-881: [Python] Reconstruct Pandas DataFrame indexes using metadata #612
Closed

wesm mentioned this pull request May 12, 2017
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method #680
Closed

wesm added 3 commits May 13, 2017 15:59

Add abstract stream writer and reader C++ APIs. Rename record batch s…
10837a6
…tream reader and writer classes for better clarity

Fix unit tests
22346d4
Change-Id: I38b1e570c69af59aac917e96845b7add947d7196

Feedback on ipc reader/writer names. Add open_stream/open_file Python…
04fa285
… APIs Change-Id: I92cc2d5de55f625dee543bd7dc223225fd8f7977

wesm force-pushed the ARROW-1008 branch from 01c7801 to 04fa285Compare May 13, 2017 20:34

Fix glib
a797ee3
Change-Id: I2b375c917e6004c3ffebf3657491d4756f792951

Add missing dtors for pimpl pattern
d7b7c9c
Change-Id: I0c06793275de0bf96be5602e5c99ae9cf7ad2b14

asfgit closed this in 5739e04May 14, 2017

wesm deleted the ARROW-1008 branch May 14, 2017 12:55

wesm mentioned this pull request May 14, 2017
ARROW-881: [Python] Reconstruct Pandas DataFrame indexes using metadata #612
Closed

wesm mentioned this pull request May 12, 2017
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method #680
Closed

wesm added 3 commits May 13, 2017 15:59

Add abstract stream writer and reader C++ APIs. Rename record batch s…
10837a6
…tream reader and writer classes for better clarity

Fix unit tests
22346d4
Change-Id: I38b1e570c69af59aac917e96845b7add947d7196

Feedback on ipc reader/writer names. Add open_stream/open_file Python…
04fa285
… APIs Change-Id: I92cc2d5de55f625dee543bd7dc223225fd8f7977

wesm force-pushed the ARROW-1008 branch from 01c7801 to 04fa285Compare May 13, 2017 20:34

Fix glib
a797ee3
Change-Id: I2b375c917e6004c3ffebf3657491d4756f792951

Add missing dtors for pimpl pattern
d7b7c9c
Change-Id: I0c06793275de0bf96be5602e5c99ae9cf7ad2b14

asfgit closed this in 5739e04May 14, 2017

wesm deleted the ARROW-1008 branch May 14, 2017 12:55

wesm mentioned this pull request May 14, 2017
ARROW-881: [Python] Reconstruct Pandas DataFrame indexes using metadata #612
Closed

wesm mentioned this pull request May 12, 2017
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method #680
Closed

wesm added 3 commits May 13, 2017 15:59

Add abstract stream writer and reader C++ APIs. Rename record batch s…
10837a6
…tream reader and writer classes for better clarity

Fix unit tests
22346d4
Change-Id: I38b1e570c69af59aac917e96845b7add947d7196

Feedback on ipc reader/writer names. Add open_stream/open_file Python…
04fa285
… APIs Change-Id: I92cc2d5de55f625dee543bd7dc223225fd8f7977

wesm force-pushed the ARROW-1008 branch from 01c7801 to 04fa285Compare May 13, 2017 20:34

Fix glib
a797ee3
Change-Id: I2b375c917e6004c3ffebf3657491d4756f792951

Add missing dtors for pimpl pattern
d7b7c9c
Change-Id: I0c06793275de0bf96be5602e5c99ae9cf7ad2b14

asfgit closed this in 5739e04May 14, 2017

wesm deleted the ARROW-1008 branch May 14, 2017 12:55

wesm mentioned this pull request May 14, 2017
ARROW-881: [Python] Reconstruct Pandas DataFrame indexes using metadata #612
Closed

Uh oh!

Conversation

wesm commented May 12, 2017

Uh oh!

kou commented May 13, 2017

Uh oh!

wesm commented May 13, 2017

Uh oh!

kou commented May 14, 2017

Uh oh!

wesm commented May 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

wesm commented May 12, 2017

Uh oh!

kou commented May 13, 2017

Uh oh!

wesm commented May 13, 2017

Uh oh!

kou commented May 14, 2017

Uh oh!

wesm commented May 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

wesm commented May 12, 2017

Uh oh!

kou commented May 13, 2017

Uh oh!

wesm commented May 13, 2017

Uh oh!

kou commented May 14, 2017

Uh oh!

wesm commented May 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

wesm commented May 12, 2017

Uh oh!

kou commented May 13, 2017

Uh oh!

wesm commented May 13, 2017

Uh oh!

kou commented May 14, 2017

Uh oh!

wesm commented May 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants