ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method - #680

Closed
wesm wants to merge 5 commits into
apache:masterfrom
wesm:ARROW-819
Closed

ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method#680
wesm wants to merge 5 commits into
apache:masterfrom
wesm:ARROW-819

Conversation

@wesm

@wesmwesm commented May 12, 2017•
edited
Loading

Copy link
Copy Markdown
Member

I have been looking at LXML's approach to creating both a public Cython API and C++ API

https://github.com/lxml/lxml

While this may seem like a somewhat radical reorganization of the code, putting all of the main symbols in a single Cython extension makes generating a C++ API for them significantly simpler. By using .pxi files we can break the codebase into as small pieces as we like (as long as there are no circular dependencies). As a convenient side effect, the build times are shorter.

wesm added 4 commits May 12, 2017 17:26
@wesm
Reorganize Cython code in the style of lxml so make declaring a publi…
d4a8391
…c C API easier
Change-Id: I3879a8f0546c88959f4468f69f41044455c7978a
@wesm
Rename things a bit
ff1b5e5
Change-Id: Ifc6b97f7bae539c7c072e6c4ddbba8b8dbd06bc5
@wesm
Fix test suite. Move _config into lib
b39d19c
Change-Id: I8eb4db35868420d374e03ebb9305e2884b3cac44
@wesm
Expose pyarrow C API in arrow/python/pyarrow.h
cff757d
Change-Id: I21e6a311273cda7eb793f8430581ba06b2393913
@wesm

wesm commented May 12, 2017

Copy link
Copy Markdown
MemberAuthor

OK, now we have

$ nm -g debug/libarrow_python.so | c++filt | grep import
000000000010e802 T arrow::py::import_pyarrow()
$ nm -g debug/libarrow_python.so | c++filt | grep wrap
000000000010e885 T arrow::py::wrap_array(std::shared_ptr<arrow::Array> const&)
000000000010e849 T arrow::py::wrap_field(std::shared_ptr<arrow::Field> const&)
000000000010e8df T arrow::py::wrap_table(std::shared_ptr<arrow::Table> const&)
000000000010e80d T arrow::py::wrap_buffer(std::shared_ptr<arrow::Buffer> const&)
000000000010e8c1 T arrow::py::wrap_column(std::shared_ptr<arrow::Column> const&)
000000000010e867 T arrow::py::wrap_schema(std::shared_ptr<arrow::Schema> const&)
000000000010e8a3 T arrow::py::wrap_tensor(std::shared_ptr<arrow::Tensor> const&)
000000000010e82b T arrow::py::wrap_data_type(std::shared_ptr<arrow::DataType> const&)
000000000010e8fd T arrow::py::wrap_record_batch(std::shared_ptr<arrow::RecordBatch> const&)

I haven't tried using these in a C extension yet (open to ideas how to test this), but I think this works!

@wesmwesm changed the title WIP ARROW-819: Work toward public Cython and C API in the style of lxmlARROW-819: Public Cython and C API in the style of lxml, arrow::py::import_pyarrow methodMay 12, 2017
@wesm

wesm commented May 12, 2017

Copy link
Copy Markdown
MemberAuthor

This conflicts with #679; I can rebase this after that is merged.

xhochy
xhochy approved these changes May 13, 2017
View reviewed changes

@xhochyxhochy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , amazing work! This is probably the last piece I needed for the turbodbc work to continue.

Comment threadcpp/src/arrow/python/pyarrow.cc
return ::import_pyarrow__lib();
}

PyObject* wrap_buffer(const std::shared_ptr<Buffer>& buffer) {

@xhochyxhochyMay 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You won't be able to call these from C without wrapping them into extern "C" { .. }" due to the name mangling. Also I would be astonished if plain C code could instantiate std::shared_ptr`.

@wesmwesmMay 13, 2017

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR title and comments to indicate this is a C++ API and not a C API (because the arguments are STL types)

@wesmwesm changed the title ARROW-819: Public Cython and C API in the style of lxml, arrow::py::import_pyarrow methodARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow methodMay 13, 2017
@wesm
Fix up optional extensions
9e6ee24
Change-Id: Icad57e6d5e9ee5302e8623664c3c58ac363bdd69
@wesm

wesm commented May 13, 2017

Copy link
Copy Markdown
MemberAuthor

I will merge this as soon as I get a green build, then rebase #679 since there may be some more discussion about names for the IPC reader/writer classes

@wesm
wesm deleted the ARROW-819 branch May 13, 2017 19:55
jeffknupp pushed a commit to jeffknupp/arrow that referenced this pull request Jun 3, 2017
@wesm@jeffknupp
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py:…
0d2cb4f
…:import_pyarrow method
I have been looking at LXML's approach to creating both a public Cython API and C++ API
https://github.com/lxml/lxml
While this may seem like a somewhat radical reorganization of the code, putting all of the main symbols in a single Cython extension makes generating a C++ API for them significantly simpler. By using `.pxi` files we can break the codebase into as small pieces as we like (as long as there are no circular dependencies). As a convenient side effect, the build times are shorter.
Author: Wes McKinney <wes.mckinney@twosigma.com>
Closesapache#680 from wesm/ARROW-819 and squashes the following commits:
9e6ee24 [Wes McKinney] Fix up optional extensions
cff757d [Wes McKinney] Expose pyarrow C API in arrow/python/pyarrow.h
b39d19c [Wes McKinney] Fix test suite. Move _config into lib
ff1b5e5 [Wes McKinney] Rename things a bit
d4a8391 [Wes McKinney] Reorganize Cython code in the style of lxml so make declaring a public C API easier
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
@dependabot
MINOR: Bump dep.junit.jupiter.version from 5.12.0 to 5.12.1 (apache#680)
88eb0a3
Bumps `dep.junit.jupiter.version` from 5.12.0 to 5.12.1.
Updates `org.junit.jupiter:junit-jupiter-engine` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-engine's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Updates `org.junit.jupiter:junit-jupiter-api` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-api's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Updates `org.junit.jupiter:junit-jupiter-params` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-params's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhochyxhochyxhochy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wesm@xhochy
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method - #680
Closed
wesm wants to merge 5 commits into
apache:masterfrom 
wesm:ARROW-819
Closed
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method#680
wesm wants to merge 5 commits into
apache:masterfrom 
wesm:ARROW-819
Conversation
@wesm
@wesmwesm
commented
May 12, 2017•

edited

Loading

Copy link


Copy Markdown

Member
I have been looking at LXML's approach to creating both a public Cython API and C++ API
https://github.com/lxml/lxml
While this may seem like a somewhat radical reorganization of the code, putting all of the main symbols in a single Cython extension makes generating a C++ API for them significantly simpler. By using .pxi files we can break the codebase into as small pieces as we like (as long as there are no circular dependencies). As a convenient side effect, the build times are shorter.
wesm
added 4 commits
May 12, 2017 17:26
@wesm
Reorganize Cython code in the style of lxml so make declaring a publi…
d4a8391
…c C API easier
Change-Id: I3879a8f0546c88959f4468f69f41044455c7978a
@wesm
Rename things a bit
ff1b5e5
Change-Id: Ifc6b97f7bae539c7c072e6c4ddbba8b8dbd06bc5
@wesm
Fix test suite. Move _config into lib
b39d19c
Change-Id: I8eb4db35868420d374e03ebb9305e2884b3cac44
@wesm
Expose pyarrow C API in arrow/python/pyarrow.h
cff757d
Change-Id: I21e6a311273cda7eb793f8430581ba06b2393913
@wesm
wesm
commented
May 12, 2017

Copy link


Copy Markdown

MemberAuthor
OK, now we have
$ nm -g debug/libarrow_python.so | c++filt | grep import
000000000010e802 T arrow::py::import_pyarrow()
$ nm -g debug/libarrow_python.so | c++filt | grep wrap
000000000010e885 T arrow::py::wrap_array(std::shared_ptr<arrow::Array> const&)
000000000010e849 T arrow::py::wrap_field(std::shared_ptr<arrow::Field> const&)
000000000010e8df T arrow::py::wrap_table(std::shared_ptr<arrow::Table> const&)
000000000010e80d T arrow::py::wrap_buffer(std::shared_ptr<arrow::Buffer> const&)
000000000010e8c1 T arrow::py::wrap_column(std::shared_ptr<arrow::Column> const&)
000000000010e867 T arrow::py::wrap_schema(std::shared_ptr<arrow::Schema> const&)
000000000010e8a3 T arrow::py::wrap_tensor(std::shared_ptr<arrow::Tensor> const&)
000000000010e82b T arrow::py::wrap_data_type(std::shared_ptr<arrow::DataType> const&)
000000000010e8fd T arrow::py::wrap_record_batch(std::shared_ptr<arrow::RecordBatch> const&)
I haven't tried using these in a C extension yet (open to ideas how to test this), but I think this works!
@wesmwesm
changed the title
WIP ARROW-819: Work toward public Cython and C API in the style of lxmlARROW-819: Public Cython and C API in the style of lxml, arrow::py::import_pyarrow methodMay 12, 2017
@wesm
wesm
commented
May 12, 2017

Copy link


Copy Markdown

MemberAuthor
This conflicts with #679; I can rebase this after that is merged.
xhochy
xhochy
approved these changes
May 13, 2017
View reviewed changes
@xhochyxhochy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , amazing work! This is probably the last piece I needed for the turbodbc work to continue.
Comment threadcpp/src/arrow/python/pyarrow.cc
 return ::import_pyarrow__lib();
}

PyObject* wrap_buffer(const std::shared_ptr<Buffer>& buffer) {
@xhochyxhochyMay 13, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You won't be able to call these from C without wrapping them into extern "C" { .. }" due to the name mangling. Also I would be astonished if plain C code could instantiate std::shared_ptr`.
@wesmwesmMay 13, 2017

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR title and comments to indicate this is a C++ API and not a C API (because the arguments are STL types)
@wesmwesm
changed the title
ARROW-819: Public Cython and C API in the style of lxml, arrow::py::import_pyarrow methodARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow methodMay 13, 2017
@wesm
Fix up optional extensions
9e6ee24
Change-Id: Icad57e6d5e9ee5302e8623664c3c58ac363bdd69
@wesm
wesm
commented
May 13, 2017

Copy link


Copy Markdown

MemberAuthor
I will merge this as soon as I get a green build, then rebase #679 since there may be some more discussion about names for the IPC reader/writer classes
@wesm
wesm
deleted the

ARROW-819

branch
May 13, 2017 19:55
jeffknupp pushed a commit
to jeffknupp/arrow
that referenced
this pull request
Jun 3, 2017
@wesm@jeffknupp
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py:…
0d2cb4f
…:import_pyarrow method
I have been looking at LXML's approach to creating both a public Cython API and C++ API
https://github.com/lxml/lxml
While this may seem like a somewhat radical reorganization of the code, putting all of the main symbols in a single Cython extension makes generating a C++ API for them significantly simpler. By using `.pxi` files we can break the codebase into as small pieces as we like (as long as there are no circular dependencies). As a convenient side effect, the build times are shorter.
Author: Wes McKinney <wes.mckinney@twosigma.com>
Closesapache#680 from wesm/ARROW-819 and squashes the following commits:
9e6ee24 [Wes McKinney] Fix up optional extensions
cff757d [Wes McKinney] Expose pyarrow C API in arrow/python/pyarrow.h
b39d19c [Wes McKinney] Fix test suite. Move _config into lib
ff1b5e5 [Wes McKinney] Rename things a bit
d4a8391 [Wes McKinney] Reorganize Cython code in the style of lxml so make declaring a public C API easier
pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@dependabot
MINOR: Bump dep.junit.jupiter.version from 5.12.0 to 5.12.1 (apache#680)
88eb0a3
Bumps `dep.junit.jupiter.version` from 5.12.0 to 5.12.1.
Updates `org.junit.jupiter:junit-jupiter-engine` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-engine's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Updates `org.junit.jupiter:junit-jupiter-api` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-api's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Updates `org.junit.jupiter:junit-jupiter-params` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-params's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@xhochyxhochyxhochy approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wesm@xhochy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method - #680
Closed
wesm wants to merge 5 commits into
apache:masterfrom 
wesm:ARROW-819
Closed
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method#680
wesm wants to merge 5 commits into
apache:masterfrom 
wesm:ARROW-819
Conversation
@wesm
@wesmwesm
commented
May 12, 2017•

edited

Loading

Copy link


Copy Markdown

Member
I have been looking at LXML's approach to creating both a public Cython API and C++ API
https://github.com/lxml/lxml
While this may seem like a somewhat radical reorganization of the code, putting all of the main symbols in a single Cython extension makes generating a C++ API for them significantly simpler. By using .pxi files we can break the codebase into as small pieces as we like (as long as there are no circular dependencies). As a convenient side effect, the build times are shorter.
wesm
added 4 commits
May 12, 2017 17:26
@wesm
Reorganize Cython code in the style of lxml so make declaring a publi…
d4a8391
…c C API easier
Change-Id: I3879a8f0546c88959f4468f69f41044455c7978a
@wesm
Rename things a bit
ff1b5e5
Change-Id: Ifc6b97f7bae539c7c072e6c4ddbba8b8dbd06bc5
@wesm
Fix test suite. Move _config into lib
b39d19c
Change-Id: I8eb4db35868420d374e03ebb9305e2884b3cac44
@wesm
Expose pyarrow C API in arrow/python/pyarrow.h
cff757d
Change-Id: I21e6a311273cda7eb793f8430581ba06b2393913
@wesm
wesm
commented
May 12, 2017

Copy link


Copy Markdown

MemberAuthor
OK, now we have
$ nm -g debug/libarrow_python.so | c++filt | grep import
000000000010e802 T arrow::py::import_pyarrow()
$ nm -g debug/libarrow_python.so | c++filt | grep wrap
000000000010e885 T arrow::py::wrap_array(std::shared_ptr<arrow::Array> const&)
000000000010e849 T arrow::py::wrap_field(std::shared_ptr<arrow::Field> const&)
000000000010e8df T arrow::py::wrap_table(std::shared_ptr<arrow::Table> const&)
000000000010e80d T arrow::py::wrap_buffer(std::shared_ptr<arrow::Buffer> const&)
000000000010e8c1 T arrow::py::wrap_column(std::shared_ptr<arrow::Column> const&)
000000000010e867 T arrow::py::wrap_schema(std::shared_ptr<arrow::Schema> const&)
000000000010e8a3 T arrow::py::wrap_tensor(std::shared_ptr<arrow::Tensor> const&)
000000000010e82b T arrow::py::wrap_data_type(std::shared_ptr<arrow::DataType> const&)
000000000010e8fd T arrow::py::wrap_record_batch(std::shared_ptr<arrow::RecordBatch> const&)
I haven't tried using these in a C extension yet (open to ideas how to test this), but I think this works!
@wesmwesm
changed the title
WIP ARROW-819: Work toward public Cython and C API in the style of lxmlARROW-819: Public Cython and C API in the style of lxml, arrow::py::import_pyarrow methodMay 12, 2017
@wesm
wesm
commented
May 12, 2017

Copy link


Copy Markdown

MemberAuthor
This conflicts with #679; I can rebase this after that is merged.
xhochy
xhochy
approved these changes
May 13, 2017
View reviewed changes
@xhochyxhochy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , amazing work! This is probably the last piece I needed for the turbodbc work to continue.
Comment threadcpp/src/arrow/python/pyarrow.cc
 return ::import_pyarrow__lib();
}

PyObject* wrap_buffer(const std::shared_ptr<Buffer>& buffer) {
@xhochyxhochyMay 13, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You won't be able to call these from C without wrapping them into extern "C" { .. }" due to the name mangling. Also I would be astonished if plain C code could instantiate std::shared_ptr`.
@wesmwesmMay 13, 2017

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR title and comments to indicate this is a C++ API and not a C API (because the arguments are STL types)
@wesmwesm
changed the title
ARROW-819: Public Cython and C API in the style of lxml, arrow::py::import_pyarrow methodARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow methodMay 13, 2017
@wesm
Fix up optional extensions
9e6ee24
Change-Id: Icad57e6d5e9ee5302e8623664c3c58ac363bdd69
@wesm
wesm
commented
May 13, 2017

Copy link


Copy Markdown

MemberAuthor
I will merge this as soon as I get a green build, then rebase #679 since there may be some more discussion about names for the IPC reader/writer classes
@wesm
wesm
deleted the

ARROW-819

branch
May 13, 2017 19:55
jeffknupp pushed a commit
to jeffknupp/arrow
that referenced
this pull request
Jun 3, 2017
@wesm@jeffknupp
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py:…
0d2cb4f
…:import_pyarrow method
I have been looking at LXML's approach to creating both a public Cython API and C++ API
https://github.com/lxml/lxml
While this may seem like a somewhat radical reorganization of the code, putting all of the main symbols in a single Cython extension makes generating a C++ API for them significantly simpler. By using `.pxi` files we can break the codebase into as small pieces as we like (as long as there are no circular dependencies). As a convenient side effect, the build times are shorter.
Author: Wes McKinney <wes.mckinney@twosigma.com>
Closesapache#680 from wesm/ARROW-819 and squashes the following commits:
9e6ee24 [Wes McKinney] Fix up optional extensions
cff757d [Wes McKinney] Expose pyarrow C API in arrow/python/pyarrow.h
b39d19c [Wes McKinney] Fix test suite. Move _config into lib
ff1b5e5 [Wes McKinney] Rename things a bit
d4a8391 [Wes McKinney] Reorganize Cython code in the style of lxml so make declaring a public C API easier
pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@dependabot
MINOR: Bump dep.junit.jupiter.version from 5.12.0 to 5.12.1 (apache#680)
88eb0a3
Bumps `dep.junit.jupiter.version` from 5.12.0 to 5.12.1.
Updates `org.junit.jupiter:junit-jupiter-engine` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-engine's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Updates `org.junit.jupiter:junit-jupiter-api` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-api's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Updates `org.junit.jupiter:junit-jupiter-params` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-params's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@xhochyxhochyxhochy approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wesm@xhochy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method - #680
Closed
wesm wants to merge 5 commits into
apache:masterfrom 
wesm:ARROW-819
Closed
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method#680
wesm wants to merge 5 commits into
apache:masterfrom 
wesm:ARROW-819
Conversation
@wesm
@wesmwesm
commented
May 12, 2017•

edited

Loading

Copy link


Copy Markdown

Member
I have been looking at LXML's approach to creating both a public Cython API and C++ API
https://github.com/lxml/lxml
While this may seem like a somewhat radical reorganization of the code, putting all of the main symbols in a single Cython extension makes generating a C++ API for them significantly simpler. By using .pxi files we can break the codebase into as small pieces as we like (as long as there are no circular dependencies). As a convenient side effect, the build times are shorter.
wesm
added 4 commits
May 12, 2017 17:26
@wesm
Reorganize Cython code in the style of lxml so make declaring a publi…
d4a8391
…c C API easier
Change-Id: I3879a8f0546c88959f4468f69f41044455c7978a
@wesm
Rename things a bit
ff1b5e5
Change-Id: Ifc6b97f7bae539c7c072e6c4ddbba8b8dbd06bc5
@wesm
Fix test suite. Move _config into lib
b39d19c
Change-Id: I8eb4db35868420d374e03ebb9305e2884b3cac44
@wesm
Expose pyarrow C API in arrow/python/pyarrow.h
cff757d
Change-Id: I21e6a311273cda7eb793f8430581ba06b2393913
@wesm
wesm
commented
May 12, 2017

Copy link


Copy Markdown

MemberAuthor
OK, now we have
$ nm -g debug/libarrow_python.so | c++filt | grep import
000000000010e802 T arrow::py::import_pyarrow()
$ nm -g debug/libarrow_python.so | c++filt | grep wrap
000000000010e885 T arrow::py::wrap_array(std::shared_ptr<arrow::Array> const&)
000000000010e849 T arrow::py::wrap_field(std::shared_ptr<arrow::Field> const&)
000000000010e8df T arrow::py::wrap_table(std::shared_ptr<arrow::Table> const&)
000000000010e80d T arrow::py::wrap_buffer(std::shared_ptr<arrow::Buffer> const&)
000000000010e8c1 T arrow::py::wrap_column(std::shared_ptr<arrow::Column> const&)
000000000010e867 T arrow::py::wrap_schema(std::shared_ptr<arrow::Schema> const&)
000000000010e8a3 T arrow::py::wrap_tensor(std::shared_ptr<arrow::Tensor> const&)
000000000010e82b T arrow::py::wrap_data_type(std::shared_ptr<arrow::DataType> const&)
000000000010e8fd T arrow::py::wrap_record_batch(std::shared_ptr<arrow::RecordBatch> const&)
I haven't tried using these in a C extension yet (open to ideas how to test this), but I think this works!
@wesmwesm
changed the title
WIP ARROW-819: Work toward public Cython and C API in the style of lxmlARROW-819: Public Cython and C API in the style of lxml, arrow::py::import_pyarrow methodMay 12, 2017
@wesm
wesm
commented
May 12, 2017

Copy link


Copy Markdown

MemberAuthor
This conflicts with #679; I can rebase this after that is merged.
xhochy
xhochy
approved these changes
May 13, 2017
View reviewed changes
@xhochyxhochy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , amazing work! This is probably the last piece I needed for the turbodbc work to continue.
Comment threadcpp/src/arrow/python/pyarrow.cc
 return ::import_pyarrow__lib();
}

PyObject* wrap_buffer(const std::shared_ptr<Buffer>& buffer) {
@xhochyxhochyMay 13, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You won't be able to call these from C without wrapping them into extern "C" { .. }" due to the name mangling. Also I would be astonished if plain C code could instantiate std::shared_ptr`.
@wesmwesmMay 13, 2017

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR title and comments to indicate this is a C++ API and not a C API (because the arguments are STL types)
@wesmwesm
changed the title
ARROW-819: Public Cython and C API in the style of lxml, arrow::py::import_pyarrow methodARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow methodMay 13, 2017
@wesm
Fix up optional extensions
9e6ee24
Change-Id: Icad57e6d5e9ee5302e8623664c3c58ac363bdd69
@wesm
wesm
commented
May 13, 2017

Copy link


Copy Markdown

MemberAuthor
I will merge this as soon as I get a green build, then rebase #679 since there may be some more discussion about names for the IPC reader/writer classes
@wesm
wesm
deleted the

ARROW-819

branch
May 13, 2017 19:55
jeffknupp pushed a commit
to jeffknupp/arrow
that referenced
this pull request
Jun 3, 2017
@wesm@jeffknupp
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py:…
0d2cb4f
…:import_pyarrow method
I have been looking at LXML's approach to creating both a public Cython API and C++ API
https://github.com/lxml/lxml
While this may seem like a somewhat radical reorganization of the code, putting all of the main symbols in a single Cython extension makes generating a C++ API for them significantly simpler. By using `.pxi` files we can break the codebase into as small pieces as we like (as long as there are no circular dependencies). As a convenient side effect, the build times are shorter.
Author: Wes McKinney <wes.mckinney@twosigma.com>
Closesapache#680 from wesm/ARROW-819 and squashes the following commits:
9e6ee24 [Wes McKinney] Fix up optional extensions
cff757d [Wes McKinney] Expose pyarrow C API in arrow/python/pyarrow.h
b39d19c [Wes McKinney] Fix test suite. Move _config into lib
ff1b5e5 [Wes McKinney] Rename things a bit
d4a8391 [Wes McKinney] Reorganize Cython code in the style of lxml so make declaring a public C API easier
pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@dependabot
MINOR: Bump dep.junit.jupiter.version from 5.12.0 to 5.12.1 (apache#680)
88eb0a3
Bumps `dep.junit.jupiter.version` from 5.12.0 to 5.12.1.
Updates `org.junit.jupiter:junit-jupiter-engine` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-engine's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Updates `org.junit.jupiter:junit-jupiter-api` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-api's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Updates `org.junit.jupiter:junit-jupiter-params` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-params's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@xhochyxhochyxhochy approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wesm@xhochy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method - #680
Closed
wesm wants to merge 5 commits into
apache:masterfrom 
wesm:ARROW-819
Closed
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method#680
wesm wants to merge 5 commits into
apache:masterfrom 
wesm:ARROW-819
Conversation
@wesm
@wesmwesm
commented
May 12, 2017•

edited

Loading

Copy link


Copy Markdown

Member
I have been looking at LXML's approach to creating both a public Cython API and C++ API
https://github.com/lxml/lxml
While this may seem like a somewhat radical reorganization of the code, putting all of the main symbols in a single Cython extension makes generating a C++ API for them significantly simpler. By using .pxi files we can break the codebase into as small pieces as we like (as long as there are no circular dependencies). As a convenient side effect, the build times are shorter.
wesm
added 4 commits
May 12, 2017 17:26
@wesm
Reorganize Cython code in the style of lxml so make declaring a publi…
d4a8391
…c C API easier
Change-Id: I3879a8f0546c88959f4468f69f41044455c7978a
@wesm
Rename things a bit
ff1b5e5
Change-Id: Ifc6b97f7bae539c7c072e6c4ddbba8b8dbd06bc5
@wesm
Fix test suite. Move _config into lib
b39d19c
Change-Id: I8eb4db35868420d374e03ebb9305e2884b3cac44
@wesm
Expose pyarrow C API in arrow/python/pyarrow.h
cff757d
Change-Id: I21e6a311273cda7eb793f8430581ba06b2393913
@wesm
wesm
commented
May 12, 2017

Copy link


Copy Markdown

MemberAuthor
OK, now we have
$ nm -g debug/libarrow_python.so | c++filt | grep import
000000000010e802 T arrow::py::import_pyarrow()
$ nm -g debug/libarrow_python.so | c++filt | grep wrap
000000000010e885 T arrow::py::wrap_array(std::shared_ptr<arrow::Array> const&)
000000000010e849 T arrow::py::wrap_field(std::shared_ptr<arrow::Field> const&)
000000000010e8df T arrow::py::wrap_table(std::shared_ptr<arrow::Table> const&)
000000000010e80d T arrow::py::wrap_buffer(std::shared_ptr<arrow::Buffer> const&)
000000000010e8c1 T arrow::py::wrap_column(std::shared_ptr<arrow::Column> const&)
000000000010e867 T arrow::py::wrap_schema(std::shared_ptr<arrow::Schema> const&)
000000000010e8a3 T arrow::py::wrap_tensor(std::shared_ptr<arrow::Tensor> const&)
000000000010e82b T arrow::py::wrap_data_type(std::shared_ptr<arrow::DataType> const&)
000000000010e8fd T arrow::py::wrap_record_batch(std::shared_ptr<arrow::RecordBatch> const&)
I haven't tried using these in a C extension yet (open to ideas how to test this), but I think this works!
@wesmwesm
changed the title
WIP ARROW-819: Work toward public Cython and C API in the style of lxmlARROW-819: Public Cython and C API in the style of lxml, arrow::py::import_pyarrow methodMay 12, 2017
@wesm
wesm
commented
May 12, 2017

Copy link


Copy Markdown

MemberAuthor
This conflicts with #679; I can rebase this after that is merged.
xhochy
xhochy
approved these changes
May 13, 2017
View reviewed changes
@xhochyxhochy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , amazing work! This is probably the last piece I needed for the turbodbc work to continue.
Comment threadcpp/src/arrow/python/pyarrow.cc
 return ::import_pyarrow__lib();
}

PyObject* wrap_buffer(const std::shared_ptr<Buffer>& buffer) {
@xhochyxhochyMay 13, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You won't be able to call these from C without wrapping them into extern "C" { .. }" due to the name mangling. Also I would be astonished if plain C code could instantiate std::shared_ptr`.
@wesmwesmMay 13, 2017

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR title and comments to indicate this is a C++ API and not a C API (because the arguments are STL types)
@wesmwesm
changed the title
ARROW-819: Public Cython and C API in the style of lxml, arrow::py::import_pyarrow methodARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow methodMay 13, 2017
@wesm
Fix up optional extensions
9e6ee24
Change-Id: Icad57e6d5e9ee5302e8623664c3c58ac363bdd69
@wesm
wesm
commented
May 13, 2017

Copy link


Copy Markdown

MemberAuthor
I will merge this as soon as I get a green build, then rebase #679 since there may be some more discussion about names for the IPC reader/writer classes
@wesm
wesm
deleted the

ARROW-819

branch
May 13, 2017 19:55
jeffknupp pushed a commit
to jeffknupp/arrow
that referenced
this pull request
Jun 3, 2017
@wesm@jeffknupp
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py:…
0d2cb4f
…:import_pyarrow method
I have been looking at LXML's approach to creating both a public Cython API and C++ API
https://github.com/lxml/lxml
While this may seem like a somewhat radical reorganization of the code, putting all of the main symbols in a single Cython extension makes generating a C++ API for them significantly simpler. By using `.pxi` files we can break the codebase into as small pieces as we like (as long as there are no circular dependencies). As a convenient side effect, the build times are shorter.
Author: Wes McKinney <wes.mckinney@twosigma.com>
Closesapache#680 from wesm/ARROW-819 and squashes the following commits:
9e6ee24 [Wes McKinney] Fix up optional extensions
cff757d [Wes McKinney] Expose pyarrow C API in arrow/python/pyarrow.h
b39d19c [Wes McKinney] Fix test suite. Move _config into lib
ff1b5e5 [Wes McKinney] Rename things a bit
d4a8391 [Wes McKinney] Reorganize Cython code in the style of lxml so make declaring a public C API easier
pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@dependabot
MINOR: Bump dep.junit.jupiter.version from 5.12.0 to 5.12.1 (apache#680)
88eb0a3
Bumps `dep.junit.jupiter.version` from 5.12.0 to 5.12.1.
Updates `org.junit.jupiter:junit-jupiter-engine` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-engine's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Updates `org.junit.jupiter:junit-jupiter-api` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-api's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Updates `org.junit.jupiter:junit-jupiter-params` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-params's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@xhochyxhochyxhochy approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wesm@xhochy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method - #680
Closed
wesm wants to merge 5 commits into
apache:masterfrom 
wesm:ARROW-819
Closed
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method#680
wesm wants to merge 5 commits into
apache:masterfrom 
wesm:ARROW-819
Conversation
@wesm
@wesmwesm
commented
May 12, 2017•

edited

Loading

Copy link


Copy Markdown

Member
I have been looking at LXML's approach to creating both a public Cython API and C++ API
https://github.com/lxml/lxml
While this may seem like a somewhat radical reorganization of the code, putting all of the main symbols in a single Cython extension makes generating a C++ API for them significantly simpler. By using .pxi files we can break the codebase into as small pieces as we like (as long as there are no circular dependencies). As a convenient side effect, the build times are shorter.
wesm
added 4 commits
May 12, 2017 17:26
@wesm
Reorganize Cython code in the style of lxml so make declaring a publi…
d4a8391
…c C API easier
Change-Id: I3879a8f0546c88959f4468f69f41044455c7978a
@wesm
Rename things a bit
ff1b5e5
Change-Id: Ifc6b97f7bae539c7c072e6c4ddbba8b8dbd06bc5
@wesm
Fix test suite. Move _config into lib
b39d19c
Change-Id: I8eb4db35868420d374e03ebb9305e2884b3cac44
@wesm
Expose pyarrow C API in arrow/python/pyarrow.h
cff757d
Change-Id: I21e6a311273cda7eb793f8430581ba06b2393913
@wesm
wesm
commented
May 12, 2017

Copy link


Copy Markdown

MemberAuthor
OK, now we have
$ nm -g debug/libarrow_python.so | c++filt | grep import
000000000010e802 T arrow::py::import_pyarrow()
$ nm -g debug/libarrow_python.so | c++filt | grep wrap
000000000010e885 T arrow::py::wrap_array(std::shared_ptr<arrow::Array> const&)
000000000010e849 T arrow::py::wrap_field(std::shared_ptr<arrow::Field> const&)
000000000010e8df T arrow::py::wrap_table(std::shared_ptr<arrow::Table> const&)
000000000010e80d T arrow::py::wrap_buffer(std::shared_ptr<arrow::Buffer> const&)
000000000010e8c1 T arrow::py::wrap_column(std::shared_ptr<arrow::Column> const&)
000000000010e867 T arrow::py::wrap_schema(std::shared_ptr<arrow::Schema> const&)
000000000010e8a3 T arrow::py::wrap_tensor(std::shared_ptr<arrow::Tensor> const&)
000000000010e82b T arrow::py::wrap_data_type(std::shared_ptr<arrow::DataType> const&)
000000000010e8fd T arrow::py::wrap_record_batch(std::shared_ptr<arrow::RecordBatch> const&)
I haven't tried using these in a C extension yet (open to ideas how to test this), but I think this works!
@wesmwesm
changed the title
WIP ARROW-819: Work toward public Cython and C API in the style of lxmlARROW-819: Public Cython and C API in the style of lxml, arrow::py::import_pyarrow methodMay 12, 2017
@wesm
wesm
commented
May 12, 2017

Copy link


Copy Markdown

MemberAuthor
This conflicts with #679; I can rebase this after that is merged.
xhochy
xhochy
approved these changes
May 13, 2017
View reviewed changes
@xhochyxhochy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , amazing work! This is probably the last piece I needed for the turbodbc work to continue.
Comment threadcpp/src/arrow/python/pyarrow.cc
 return ::import_pyarrow__lib();
}

PyObject* wrap_buffer(const std::shared_ptr<Buffer>& buffer) {
@xhochyxhochyMay 13, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You won't be able to call these from C without wrapping them into extern "C" { .. }" due to the name mangling. Also I would be astonished if plain C code could instantiate std::shared_ptr`.
@wesmwesmMay 13, 2017

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR title and comments to indicate this is a C++ API and not a C API (because the arguments are STL types)
@wesmwesm
changed the title
ARROW-819: Public Cython and C API in the style of lxml, arrow::py::import_pyarrow methodARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow methodMay 13, 2017
@wesm
Fix up optional extensions
9e6ee24
Change-Id: Icad57e6d5e9ee5302e8623664c3c58ac363bdd69
@wesm
wesm
commented
May 13, 2017

Copy link


Copy Markdown

MemberAuthor
I will merge this as soon as I get a green build, then rebase #679 since there may be some more discussion about names for the IPC reader/writer classes
@wesm
wesm
deleted the

ARROW-819

branch
May 13, 2017 19:55
jeffknupp pushed a commit
to jeffknupp/arrow
that referenced
this pull request
Jun 3, 2017
@wesm@jeffknupp
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py:…
0d2cb4f
…:import_pyarrow method
I have been looking at LXML's approach to creating both a public Cython API and C++ API
https://github.com/lxml/lxml
While this may seem like a somewhat radical reorganization of the code, putting all of the main symbols in a single Cython extension makes generating a C++ API for them significantly simpler. By using `.pxi` files we can break the codebase into as small pieces as we like (as long as there are no circular dependencies). As a convenient side effect, the build times are shorter.
Author: Wes McKinney <wes.mckinney@twosigma.com>
Closesapache#680 from wesm/ARROW-819 and squashes the following commits:
9e6ee24 [Wes McKinney] Fix up optional extensions
cff757d [Wes McKinney] Expose pyarrow C API in arrow/python/pyarrow.h
b39d19c [Wes McKinney] Fix test suite. Move _config into lib
ff1b5e5 [Wes McKinney] Rename things a bit
d4a8391 [Wes McKinney] Reorganize Cython code in the style of lxml so make declaring a public C API easier
pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@dependabot
MINOR: Bump dep.junit.jupiter.version from 5.12.0 to 5.12.1 (apache#680)
88eb0a3
Bumps `dep.junit.jupiter.version` from 5.12.0 to 5.12.1.
Updates `org.junit.jupiter:junit-jupiter-engine` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-engine's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Updates `org.junit.jupiter:junit-jupiter-api` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-api's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Updates `org.junit.jupiter:junit-jupiter-params` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-params's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@xhochyxhochyxhochy approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wesm@xhochy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method - #680
Closed
wesm wants to merge 5 commits into
apache:masterfrom 
wesm:ARROW-819
Closed
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method#680
wesm wants to merge 5 commits into
apache:masterfrom 
wesm:ARROW-819
Conversation
@wesm
@wesmwesm
commented
May 12, 2017•

edited

Loading

Copy link


Copy Markdown

Member
I have been looking at LXML's approach to creating both a public Cython API and C++ API
https://github.com/lxml/lxml
While this may seem like a somewhat radical reorganization of the code, putting all of the main symbols in a single Cython extension makes generating a C++ API for them significantly simpler. By using .pxi files we can break the codebase into as small pieces as we like (as long as there are no circular dependencies). As a convenient side effect, the build times are shorter.
wesm
added 4 commits
May 12, 2017 17:26
@wesm
Reorganize Cython code in the style of lxml so make declaring a publi…
d4a8391
…c C API easier
Change-Id: I3879a8f0546c88959f4468f69f41044455c7978a
@wesm
Rename things a bit
ff1b5e5
Change-Id: Ifc6b97f7bae539c7c072e6c4ddbba8b8dbd06bc5
@wesm
Fix test suite. Move _config into lib
b39d19c
Change-Id: I8eb4db35868420d374e03ebb9305e2884b3cac44
@wesm
Expose pyarrow C API in arrow/python/pyarrow.h
cff757d
Change-Id: I21e6a311273cda7eb793f8430581ba06b2393913
@wesm
wesm
commented
May 12, 2017

Copy link


Copy Markdown

MemberAuthor
OK, now we have
$ nm -g debug/libarrow_python.so | c++filt | grep import
000000000010e802 T arrow::py::import_pyarrow()
$ nm -g debug/libarrow_python.so | c++filt | grep wrap
000000000010e885 T arrow::py::wrap_array(std::shared_ptr<arrow::Array> const&)
000000000010e849 T arrow::py::wrap_field(std::shared_ptr<arrow::Field> const&)
000000000010e8df T arrow::py::wrap_table(std::shared_ptr<arrow::Table> const&)
000000000010e80d T arrow::py::wrap_buffer(std::shared_ptr<arrow::Buffer> const&)
000000000010e8c1 T arrow::py::wrap_column(std::shared_ptr<arrow::Column> const&)
000000000010e867 T arrow::py::wrap_schema(std::shared_ptr<arrow::Schema> const&)
000000000010e8a3 T arrow::py::wrap_tensor(std::shared_ptr<arrow::Tensor> const&)
000000000010e82b T arrow::py::wrap_data_type(std::shared_ptr<arrow::DataType> const&)
000000000010e8fd T arrow::py::wrap_record_batch(std::shared_ptr<arrow::RecordBatch> const&)
I haven't tried using these in a C extension yet (open to ideas how to test this), but I think this works!
@wesmwesm
changed the title
WIP ARROW-819: Work toward public Cython and C API in the style of lxmlARROW-819: Public Cython and C API in the style of lxml, arrow::py::import_pyarrow methodMay 12, 2017
@wesm
wesm
commented
May 12, 2017

Copy link


Copy Markdown

MemberAuthor
This conflicts with #679; I can rebase this after that is merged.
xhochy
xhochy
approved these changes
May 13, 2017
View reviewed changes
@xhochyxhochy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , amazing work! This is probably the last piece I needed for the turbodbc work to continue.
Comment threadcpp/src/arrow/python/pyarrow.cc
 return ::import_pyarrow__lib();
}

PyObject* wrap_buffer(const std::shared_ptr<Buffer>& buffer) {
@xhochyxhochyMay 13, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You won't be able to call these from C without wrapping them into extern "C" { .. }" due to the name mangling. Also I would be astonished if plain C code could instantiate std::shared_ptr`.
@wesmwesmMay 13, 2017

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR title and comments to indicate this is a C++ API and not a C API (because the arguments are STL types)
@wesmwesm
changed the title
ARROW-819: Public Cython and C API in the style of lxml, arrow::py::import_pyarrow methodARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow methodMay 13, 2017
@wesm
Fix up optional extensions
9e6ee24
Change-Id: Icad57e6d5e9ee5302e8623664c3c58ac363bdd69
@wesm
wesm
commented
May 13, 2017

Copy link


Copy Markdown

MemberAuthor
I will merge this as soon as I get a green build, then rebase #679 since there may be some more discussion about names for the IPC reader/writer classes
@wesm
wesm
deleted the

ARROW-819

branch
May 13, 2017 19:55
jeffknupp pushed a commit
to jeffknupp/arrow
that referenced
this pull request
Jun 3, 2017
@wesm@jeffknupp
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py:…
0d2cb4f
…:import_pyarrow method
I have been looking at LXML's approach to creating both a public Cython API and C++ API
https://github.com/lxml/lxml
While this may seem like a somewhat radical reorganization of the code, putting all of the main symbols in a single Cython extension makes generating a C++ API for them significantly simpler. By using `.pxi` files we can break the codebase into as small pieces as we like (as long as there are no circular dependencies). As a convenient side effect, the build times are shorter.
Author: Wes McKinney <wes.mckinney@twosigma.com>
Closesapache#680 from wesm/ARROW-819 and squashes the following commits:
9e6ee24 [Wes McKinney] Fix up optional extensions
cff757d [Wes McKinney] Expose pyarrow C API in arrow/python/pyarrow.h
b39d19c [Wes McKinney] Fix test suite. Move _config into lib
ff1b5e5 [Wes McKinney] Rename things a bit
d4a8391 [Wes McKinney] Reorganize Cython code in the style of lxml so make declaring a public C API easier
pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@dependabot
MINOR: Bump dep.junit.jupiter.version from 5.12.0 to 5.12.1 (apache#680)
88eb0a3
Bumps `dep.junit.jupiter.version` from 5.12.0 to 5.12.1.
Updates `org.junit.jupiter:junit-jupiter-engine` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-engine's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Updates `org.junit.jupiter:junit-jupiter-api` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-api's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Updates `org.junit.jupiter:junit-jupiter-params` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-params's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@xhochyxhochyxhochy approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wesm@xhochy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method - #680
Closed
wesm wants to merge 5 commits into
apache:masterfrom 
wesm:ARROW-819
Closed
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow method#680
wesm wants to merge 5 commits into
apache:masterfrom 
wesm:ARROW-819
Conversation
@wesm
@wesmwesm
commented
May 12, 2017•

edited

Loading

Copy link


Copy Markdown

Member
I have been looking at LXML's approach to creating both a public Cython API and C++ API
https://github.com/lxml/lxml
While this may seem like a somewhat radical reorganization of the code, putting all of the main symbols in a single Cython extension makes generating a C++ API for them significantly simpler. By using .pxi files we can break the codebase into as small pieces as we like (as long as there are no circular dependencies). As a convenient side effect, the build times are shorter.
wesm
added 4 commits
May 12, 2017 17:26
@wesm
Reorganize Cython code in the style of lxml so make declaring a publi…
d4a8391
…c C API easier
Change-Id: I3879a8f0546c88959f4468f69f41044455c7978a
@wesm
Rename things a bit
ff1b5e5
Change-Id: Ifc6b97f7bae539c7c072e6c4ddbba8b8dbd06bc5
@wesm
Fix test suite. Move _config into lib
b39d19c
Change-Id: I8eb4db35868420d374e03ebb9305e2884b3cac44
@wesm
Expose pyarrow C API in arrow/python/pyarrow.h
cff757d
Change-Id: I21e6a311273cda7eb793f8430581ba06b2393913
@wesm
wesm
commented
May 12, 2017

Copy link


Copy Markdown

MemberAuthor
OK, now we have
$ nm -g debug/libarrow_python.so | c++filt | grep import
000000000010e802 T arrow::py::import_pyarrow()
$ nm -g debug/libarrow_python.so | c++filt | grep wrap
000000000010e885 T arrow::py::wrap_array(std::shared_ptr<arrow::Array> const&)
000000000010e849 T arrow::py::wrap_field(std::shared_ptr<arrow::Field> const&)
000000000010e8df T arrow::py::wrap_table(std::shared_ptr<arrow::Table> const&)
000000000010e80d T arrow::py::wrap_buffer(std::shared_ptr<arrow::Buffer> const&)
000000000010e8c1 T arrow::py::wrap_column(std::shared_ptr<arrow::Column> const&)
000000000010e867 T arrow::py::wrap_schema(std::shared_ptr<arrow::Schema> const&)
000000000010e8a3 T arrow::py::wrap_tensor(std::shared_ptr<arrow::Tensor> const&)
000000000010e82b T arrow::py::wrap_data_type(std::shared_ptr<arrow::DataType> const&)
000000000010e8fd T arrow::py::wrap_record_batch(std::shared_ptr<arrow::RecordBatch> const&)
I haven't tried using these in a C extension yet (open to ideas how to test this), but I think this works!
@wesmwesm
changed the title
WIP ARROW-819: Work toward public Cython and C API in the style of lxmlARROW-819: Public Cython and C API in the style of lxml, arrow::py::import_pyarrow methodMay 12, 2017
@wesm
wesm
commented
May 12, 2017

Copy link


Copy Markdown

MemberAuthor
This conflicts with #679; I can rebase this after that is merged.
xhochy
xhochy
approved these changes
May 13, 2017
View reviewed changes
@xhochyxhochy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , amazing work! This is probably the last piece I needed for the turbodbc work to continue.
Comment threadcpp/src/arrow/python/pyarrow.cc
 return ::import_pyarrow__lib();
}

PyObject* wrap_buffer(const std::shared_ptr<Buffer>& buffer) {
@xhochyxhochyMay 13, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You won't be able to call these from C without wrapping them into extern "C" { .. }" due to the name mangling. Also I would be astonished if plain C code could instantiate std::shared_ptr`.
@wesmwesmMay 13, 2017

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR title and comments to indicate this is a C++ API and not a C API (because the arguments are STL types)
@wesmwesm
changed the title
ARROW-819: Public Cython and C API in the style of lxml, arrow::py::import_pyarrow methodARROW-819: Public Cython and C++ API in the style of lxml, arrow::py::import_pyarrow methodMay 13, 2017
@wesm
Fix up optional extensions
9e6ee24
Change-Id: Icad57e6d5e9ee5302e8623664c3c58ac363bdd69
@wesm
wesm
commented
May 13, 2017

Copy link


Copy Markdown

MemberAuthor
I will merge this as soon as I get a green build, then rebase #679 since there may be some more discussion about names for the IPC reader/writer classes
@wesm
wesm
deleted the

ARROW-819

branch
May 13, 2017 19:55
jeffknupp pushed a commit
to jeffknupp/arrow
that referenced
this pull request
Jun 3, 2017
@wesm@jeffknupp
ARROW-819: Public Cython and C++ API in the style of lxml, arrow::py:…
0d2cb4f
…:import_pyarrow method
I have been looking at LXML's approach to creating both a public Cython API and C++ API
https://github.com/lxml/lxml
While this may seem like a somewhat radical reorganization of the code, putting all of the main symbols in a single Cython extension makes generating a C++ API for them significantly simpler. By using `.pxi` files we can break the codebase into as small pieces as we like (as long as there are no circular dependencies). As a convenient side effect, the build times are shorter.
Author: Wes McKinney <wes.mckinney@twosigma.com>
Closesapache#680 from wesm/ARROW-819 and squashes the following commits:
9e6ee24 [Wes McKinney] Fix up optional extensions
cff757d [Wes McKinney] Expose pyarrow C API in arrow/python/pyarrow.h
b39d19c [Wes McKinney] Fix test suite. Move _config into lib
ff1b5e5 [Wes McKinney] Rename things a bit
d4a8391 [Wes McKinney] Reorganize Cython code in the style of lxml so make declaring a public C API easier
pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@dependabot
MINOR: Bump dep.junit.jupiter.version from 5.12.0 to 5.12.1 (apache#680)
88eb0a3
Bumps `dep.junit.jupiter.version` from 5.12.0 to 5.12.1.
Updates `org.junit.jupiter:junit-jupiter-engine` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-engine's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Updates `org.junit.jupiter:junit-jupiter-api` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-api's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Updates `org.junit.jupiter:junit-jupiter-params` from 5.12.0 to 5.12.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/junit-team/junit5/releases">org.junit.jupiter:junit-jupiter-params's
releases</a>.</em></p>
<blockquote>
<p>JUnit 5.12.1 = Platform 1.12.1 + Jupiter 5.12.1 + Vintage 5.12.1</p>
<p>See <a
href="https://junit.org/junit5/docs/5.12.1/release-notes/">Release
Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/junit-team/junit5/commit/ba9c9ae111f5f06645ebcda2bb831c8e093cc002"><code>ba9c9ae</code></a>
Release 5.12.1</li>
<li><a
href="https://github.com/junit-team/junit5/commit/e28ad4a89047da0aca6aca32b0e45ac8309954e1"><code>e28ad4a</code></a>
Finalize 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1044e2c63c435f735ab78dbbca09e78b13fb5f80"><code>1044e2c</code></a>
Move entry to 5.12.1 release notes</li>
<li><a
href="https://github.com/junit-team/junit5/commit/bea821d69ae8848aa21f7ee10692c6185abfc9ac"><code>bea821d</code></a>
Fix Javadoc formatting</li>
<li><a
href="https://github.com/junit-team/junit5/commit/1a1a67daee1507ae85a25ec0f57bce98d6824b39"><code>1a1a67d</code></a>
Set stable module name for the standalone JAR file</li>
<li><a
href="https://github.com/junit-team/junit5/commit/062d3fa175d94010c24054fb44b2566955ba95ae"><code>062d3fa</code></a>
Remove internal packages from API reports</li>
<li><a
href="https://github.com/junit-team/junit5/commit/74521ab55ca19269e4cf628ed738d0382a1699c9"><code>74521ab</code></a>
Introduce <code>ExtensionContext.getEnclosingTestClasses()</code></li>
<li><a
href="https://github.com/junit-team/junit5/commit/1e135b9d37a88bc0319b98ddcfc050fc0cf89a98"><code>1e135b9</code></a>
Create initial 5.12.1 release notes from template</li>
<li><a
href="https://github.com/junit-team/junit5/commit/d540e4ff3aeb13a3b3167515efa6ed1ec00b0773"><code>d540e4f</code></a>
Link to correct method</li>
<li><a
href="https://github.com/junit-team/junit5/commit/31d60b7751e415853b582a275fe626b0358ab939"><code>31d60b7</code></a>
Split API reports by module and package</li>
<li>Additional commits viewable in <a
href="https://github.com/junit-team/junit5/compare/r5.12.0...r5.12.1">compare
view</a></li>
</ul>
</details>
<br />
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@xhochyxhochyxhochy approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wesm@xhochy