Skip to content

ARROW-10861: [Python] Update minimal NumPy version to 1.16.6 - #8878

Closed
xhochy wants to merge 2 commits into
apache:masterfrom
xhochy:ARROW-10861
Closed

ARROW-10861: [Python] Update minimal NumPy version to 1.16.6#8878
xhochy wants to merge 2 commits into
apache:masterfrom
xhochy:ARROW-10861

Conversation

@xhochy

@xhochyxhochy commented Dec 9, 2020

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actionsBot commented Dec 9, 2020

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-10861

@kou

kou commented Dec 9, 2020

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g wheel

@github-actions

github-actionsBot commented Dec 9, 2020

Copy link
Copy Markdown

Revision: ab43613e8c91eb50998ac42a8fa356d76f98e3b1

Submitted crossbow builds: ursa-labs/crossbow @ actions-756

TaskStatus
wheel-manylinux1-cp36mAzure
wheel-manylinux1-cp37mAzure
wheel-manylinux1-cp38Azure
wheel-manylinux2010-cp36mAzure
wheel-manylinux2010-cp37mAzure
wheel-manylinux2010-cp38Azure
wheel-manylinux2014-cp36mAzure
wheel-manylinux2014-cp37mAzure
wheel-manylinux2014-cp38Azure
wheel-osx-high-sierra-cp36mTravisCI
wheel-osx-high-sierra-cp37mTravisCI
wheel-osx-high-sierra-cp38TravisCI
wheel-osx-mavericks-cp36mTravisCI
wheel-osx-mavericks-cp37mTravisCI
wheel-osx-mavericks-cp38TravisCI
wheel-win-cp36mGithub Actions
wheel-win-cp37mGithub Actions
wheel-win-cp38Github Actions

@kou

kou commented Dec 9, 2020

Copy link
Copy Markdown
Member

It seems that we can't use numpy>=1.16.6 with vs2015_runtime<14.16.

@xhochy

xhochy commented Dec 10, 2020

Copy link
Copy Markdown
MemberAuthor

Windows Wheels in general are currently broken. I have a WIP PR in #8881 to have everything build from BUNDLED instead of using conda-forge packages.

jorisvandenbossche
jorisvandenbossche reviewed Dec 10, 2020
View reviewed changes
Comment threadpython/pyproject.toml Outdated
@terencehonlesterencehonles mentioned this pull request Dec 11, 2020
Closed
@github-actionsgithub-actionsBot added the needs-rebase A PR that needs to be rebased by the author label Dec 13, 2020
@xhochyxhochy mentioned this pull request Dec 14, 2020
Closed
@pitrou

pitrou commented Dec 14, 2020

Copy link
Copy Markdown
Member

I have no problem with this PR, but it needs rebasing and fixing conflicts.

@jorisvandenbossche

jorisvandenbossche commented Jan 11, 2021

Copy link
Copy Markdown
Member

@xhochy do we still want to do this for pyarrow 3.0 ?

@xhochy

xhochy commented Jan 11, 2021

Copy link
Copy Markdown
MemberAuthor

Oh yes, definitely!

xhochyand others added 2 commits January 12, 2021 10:38
@xhochy
ARROW-10861: [Python] Update minimal NumPy version to 1.16.6
6c21f0e
@xhochy@jorisvandenbossche
Update python/pyproject.toml
4fe319c
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@xhochy

xhochy commented Jan 12, 2021

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g wheel

@github-actions

github-actionsBot commented Jan 12, 2021

Copy link
Copy Markdown

Revision: 4fe319c

Submitted crossbow builds: ursa-labs/crossbow @ actions-875

TaskStatus
wheel-manylinux1-cp36mAzure
wheel-manylinux1-cp37mAzure
wheel-manylinux1-cp38Azure
wheel-manylinux1-cp39Azure
wheel-manylinux2010-cp36mAzure
wheel-manylinux2010-cp37mAzure
wheel-manylinux2010-cp38Azure
wheel-manylinux2010-cp39Azure
wheel-manylinux2014-cp36mAzure
wheel-manylinux2014-cp37mAzure
wheel-manylinux2014-cp38Azure
wheel-manylinux2014-cp39Azure
wheel-osx-high-sierra-cp36mGithub Actions
wheel-osx-high-sierra-cp37mGithub Actions
wheel-osx-high-sierra-cp38Github Actions
wheel-osx-high-sierra-cp39Github Actions
wheel-osx-mavericks-cp36mGithub Actions
wheel-osx-mavericks-cp37mGithub Actions
wheel-osx-mavericks-cp38Github Actions
wheel-osx-mavericks-cp39Github Actions
wheel-win-cp36mGithub Actions
wheel-win-cp37mGithub Actions
wheel-win-cp38Github Actions

kszucs
kszucs reviewed Jan 12, 2021
View reviewed changes
Comment threadpython/requirements-wheel-test.txt
numpy==1.16.0; python_version == "3.7"
numpy==1.17.3; python_version == "3.8"
numpy==1.19.3; python_version >= "3.9"
numpy==1.19.4

@kszucskszucsJan 12, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xhochy shouldn't we test with 1.16.6 for python < 3.9 instead?

@xhochyxhochyJan 12, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should test with the numpy release we have built with and a much newer one to detect issues. Currently we only test with one and there I would prefer to test with a newer release as this has a higher chance to fail on the C-API level like we have seen with the 1.20 release candidate.

@kszucskszucsJan 12, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sounds good to me.

kszucs
kszucs approved these changes Jan 12, 2021
View reviewed changes

@kszucskszucs left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging on green, and will handle the failing builds in #9096

@kszucs

kszucs commented Jan 12, 2021

Copy link
Copy Markdown
Member

The travis builds are still pending but it shouldn't affect them, so merging.

@xhochy
xhochy deleted the ARROW-10861 branch January 12, 2021 14:14
@asfimportasfimport mentioned this pull request Mar 10, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisvandenbosschejorisvandenbosschejorisvandenbossche left review comments
@kszucskszucskszucs approved these changes

Assignees

No one assigned

Labels

Component: Pythonneeds-rebaseA PR that needs to be rebased by the author

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xhochy@kou@pitrou@jorisvandenbossche@kszucs