Skip to content

ARROW-10861: [Python] Update minimal NumPy version to 1.16.6#8878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xhochy wants to merge 2 commits into from
Closed

ARROW-10861: [Python] Update minimal NumPy version to 1.16.6 #8878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c21f0e
ARROW-10861: [Python] Update minimal NumPy version to 1.16.6
xhochy Dec 9, 2020
4fe319c
Update python/pyproject.toml
xhochy Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/conda_env_python.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ cython
cloudpickle
fsspec
hypothesis
numpy>=1.14
numpy>=1.16.6
pytest
pytest-faulthandler
pytest-lazy-fixture
Expand Down
6 changes: 2 additions & 4 deletions python/pyproject.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,10 +18,8 @@
[build-system]
requires = [
"cython >= 0.29",
"numpy==1.14.5; python_version<'3.7'",
"numpy==1.16.0; python_version=='3.7'",
"numpy==1.17.3; python_version=='3.8'",
"numpy==1.19.3; python_version>='3.9'",
"numpy==1.16.6; python_version<'3.9'",
"numpy==1.19.4; python_version>='3.9'",
"setuptools",
"setuptools_scm",
"wheel"
Expand Down
2 changes: 1 addition & 1 deletion python/requirements-build.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
cython>=0.29
numpy>=1.14
numpy>=1.16.6
setuptools>=38.6.0
setuptools_scm
6 changes: 2 additions & 4 deletions python/requirements-wheel-build.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
cython>=0.29.11
numpy==1.14.5; python_version < "3.7"
numpy==1.16.0; python_version == "3.7"
numpy==1.17.3; python_version == "3.8"
numpy==1.19.3; python_version >= "3.9"
numpy==1.16.6; python_version < "3.9"
numpy==1.19.4; python_version >= "3.9"
setuptools_scm
wheel
5 changes: 1 addition & 4 deletions python/requirements-wheel-test.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
cffi
cython
hypothesis
numpy==1.14.5; python_version < "3.7"
numpy==1.16.0; python_version == "3.7"
numpy==1.17.3; python_version == "3.8"
numpy==1.19.3; python_version >= "3.9"
numpy==1.19.4

@kszucskszucsJan 12, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xhochy shouldn't we test with 1.16.6 for python < 3.9 instead?

@xhochyxhochyJan 12, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should test with the numpy release we have built with and a much newer one to detect issues. Currently we only test with one and there I would prefer to test with a newer release as this has a higher chance to fail on the C-API level like we have seen with the 1.20 release candidate.

@kszucskszucsJan 12, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sounds good to me.

pandas<1.1.0; python_version < "3.8"
pandas; python_version >= "3.8"
pickle5; python_version == "3.6" or python_version == "3.7"
Expand Down
2 changes: 1 addition & 1 deletion python/setup.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -572,7 +572,7 @@ def has_ext_modules(foo):


install_requires = (
'numpy >= 1.14',
'numpy >= 1.16.6',
)


Expand Down