Skip to content

ARROW-11054: [Rust] [DataFusion] Move to sqlparser 0.7.0 - #9037

Closed
ovr wants to merge 2 commits into
apache:masterfrom
ovr:sqlparser-0.7
Closed

ARROW-11054: [Rust] [DataFusion] Move to sqlparser 0.7.0#9037
ovr wants to merge 2 commits into
apache:masterfrom
ovr:sqlparser-0.7

Conversation

@ovr

@ovrovr commented Dec 28, 2020

Copy link
Copy Markdown
Contributor

Hello!

Thanks

@github-actions

github-actionsBot commented Dec 28, 2020

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-11054

andygrove
andygrove approved these changes Dec 28, 2020
View reviewed changes

@andygroveandygrove left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ovr

@ovr

ovr commented Dec 28, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@andygrove I am still working on it, planning to finish today/tomorrow. I will mark this PR to ready for review after it.

@ovr
ovr marked this pull request as ready for review December 29, 2020 00:01
@ovr

ovr commented Dec 29, 2020

Copy link
Copy Markdown
ContributorAuthor

I finished, CI passed, I think PR is now ready for review.

Thanks

cC @andygrove

Dandandan
Dandandan approved these changes Dec 29, 2020
View reviewed changes

@DandandanDandandan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😎 looks great @ovr !

@alamb

alamb commented Dec 31, 2020

Copy link
Copy Markdown
Contributor

The full set of Rust CI tests did not run on this PR :(

Can you please rebase this PR against apache/master to pick up the changes in #9056 so that they do?

I apologize for the inconvenience.

alamb
alamb approved these changes Dec 31, 2020
View reviewed changes

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks @ovr

@codecov-io

codecov-io commented Dec 31, 2020

Copy link
Copy Markdown

Codecov Report

Merging #9037 (81141a8) into master (cf0ef79) will decrease coverage by 0.02%.
The diff coverage is 55.55%.

Impacted file tree graph

@@ Coverage Diff @@## master #9037 +/- ##
==========================================
- Coverage 82.64% 82.61% -0.03% 
==========================================
Files 202 202 Lines 50044 50052 +8 ==========================================
- Hits 41358 41351 -7 - Misses 8686 8701 +15
Impacted FilesCoverage Δ
rust/datafusion/src/sql/parser.rs82.35% <36.36%> (-4.53%)⬇️
rust/datafusion/src/sql/planner.rs83.97% <64.00%> (-0.84%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf0ef79...81141a8. Read the comment docs.

@alambalamb closed this in dd5fe70Dec 31, 2020
@alamb

alamb commented Dec 31, 2020

Copy link
Copy Markdown
Contributor

Thanks again @ovr

@ovr
ovr deleted the sqlparser-0.7 branch January 9, 2021 10:01
@asfimportasfimport mentioned this pull request Dec 31, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DandandanDandandanDandandan approved these changes
@alambalambalamb approved these changes
@andygroveandygroveandygrove approved these changes

Assignees

No one assigned

Labels

Component: Rust - DataFusionComponent: Rust

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ovr@alamb@codecov-io@Dandandan@andygrove