Uh oh!
There was an error while loading. Please reload this page.
ARROW-11327: [Rust][DataFusion] Add DictionarySupport to create_batch_empty - #9276
Closed
alamb wants to merge 1 commit into
Closed
ARROW-11327: [Rust][DataFusion] Add DictionarySupport to create_batch_empty#9276alamb wants to merge 1 commit into
alamb wants to merge 1 commit into
Conversation
alamb
commented
Jan 20, 2021
ContributorAuthor
There was a problem hiding this comment.
this code is just hoisted into its own function so it can be called recursively
alamb
marked this pull request as ready for review
January 20, 2021 14:47
Codecov Report
@@ Coverage Diff @@## master #9276 +/- ##
==========================================
+ Coverage 81.64% 81.66% +0.01%
==========================================
Files 215 215 Lines 52489 52512 +23 ==========================================
+ Hits 42857 42884 +27 + Misses 9632 9628 -4
Continue to review full report at Codecov.
|
jorgecarleitao
commented
Jan 21, 2021
Member
fyi, with #9281 , (imo) this is solved more broadly. |
alamb
commented
Jan 21, 2021
ContributorAuthor
I agree that #9281 looks much better. Thanks @jorgecarleitao I might port the tests from this PR subsently, but for now i don't think it is doing anything valuable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
create_batch_emptyfunction is used for creating output during aggregation. As part of my plan for better dictionary support it also needs to support DictionaryArray as well.