Uh oh!
There was an error while loading. Please reload this page.
ARROW-11333: [Rust] Generalized creation of empty arrays. - #9281
Closed
jorgecarleitao wants to merge 1 commit into
Closed
ARROW-11333: [Rust] Generalized creation of empty arrays.#9281jorgecarleitao wants to merge 1 commit into
jorgecarleitao wants to merge 1 commit into
Conversation
jorgecarleitao
commented
Jan 21, 2021
MemberAuthor
@ovr, this is what I was trying to express in your PR: we can use |
alamb
approved these changes
Jan 21, 2021
alamb
left a comment
Contributor
There was a problem hiding this comment.
This looks really awesome @jorgecarleitao -- more features and less code. That is a pretty solid win in my opinion
Thank you!
jorgecarleitao
marked this pull request as ready for review
January 21, 2021 18:09
kszucs pushed a commit
that referenced
this pull request
Jan 25, 2021
This PR exposes two new functions: * `new_empty_array`, that creates a new empty `ArrayRef` (i.e. dynamically typed) of any (primitive or nested) type except `Union` * `RecordBatch::new_empty` that creates an empty `RecordBatch`, thereby migrating code from `DataFusion`. Since we were using a similar code in `array/transform/mod.rs` and `array_list`, this PR ends up removing some code. Closes#9281 from jorgecarleitao/improve_empty Authored-by: Jorge C. Leitao <jorgecarleitao@gmail.com> Signed-off-by: Neville Dipale <nevilledips@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes two new functions:
new_empty_array, that creates a new emptyArrayRef(i.e. dynamically typed) of any (primitive or nested) type exceptUnionRecordBatch::new_emptythat creates an emptyRecordBatch, thereby migrating code fromDataFusion.Since we were using a similar code in
array/transform/mod.rsandarray_list, this PR ends up removing some code.