Uh oh!
There was an error while loading. Please reload this page.
ARROW-11369: [DataFusion] Split physical_plan/expressions.rs - #9312
ARROW-11369: [DataFusion] Split physical_plan/expressions.rs#9312jorgecarleitao wants to merge 16 commits into
Conversation
Codecov Report
@@ Coverage Diff @@## master #9312 +/- ##
=======================================
Coverage 81.88% 81.89% =======================================
Files 215 230 +15 Lines 52988 53004 +16 =======================================
+ Hits 43391 43407 +16
Misses 9597 9597
Continue to review full report at Codecov.
|
jorgecarleitao
commented
Jan 25, 2021
The clippy error is unrelated. |
alamb
left a comment
There was a problem hiding this comment.
Thanks @jorgecarleitao -- this is great. ❤️
I went through the PR commit by commit spot checked things -- everything looked good to me though clearly I did not go through all the changes in detail.
FYI @seddonm1 in case this conflicts with work you are working on
alamb
commented
Jan 25, 2021
Clippy error is addressed here: #9314 |
seddonm1
commented
Jan 25, 2021
Thanks @alamb and @jorgecarleitao . Good idea. I'll rebase and apply these changes. I think the next work will be to address the signatures so I'll be starting work again tomorrow. |
andygrove
left a comment
There was a problem hiding this comment.
Thanks a lot for doing this @jorgecarleitao
alamb
commented
Jan 30, 2021
🎉 |
This PR splits the +4k LOC
expressions.rsmodule in modules, one per expression, thereby making it easier to navigate and work with.No backward incompatible changes are expected from this.
Each commit is an independent expression / logical change.